| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-01 | |||
| 10:09:40 | tobias-urdin | also super interested in your ideas on how to solve the bug for this patch https://review.opendev.org/c/openstack/nova/+/875859 that we got hit by some days ago | |
| 10:31:09 | sean-k-mooney[m] | bauzas: can we get https://review.opendev.org/c/openstack/nova/+/896100 in to unblock the uc bump | |
| 10:32:32 | bauzas | sean-k-mooney: I don't have context but I can take a look | |
| 11:22:12 | opendevreview | Merged openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 11:22:25 | opendevreview | Merged openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 11:25:43 | ratailor__ | Hi cores, can I get reviews on https://review.opendev.org/q/topic:%22list-requested-az%22 | |
| 11:30:33 | ratailor__ | elodilles, gibi sean-k-mooney[m] dansmith please review ^^ | |
| 11:47:55 | gibi | ratailor__: bauzas: I -1 on the AZ series, the mock in the functional tests feels like a paperover of a bug | |
| 11:48:41 | stephenfin | bauzas: Can we please just merge https://review.opendev.org/c/openstack/nova/+/896100 and move on | |
| 11:55:17 | opendevreview | Amit Uniyal proposed openstack/nova master: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905134 | |
| 12:02:20 | sean-k-mooney | bauzas: tl;dr castalan added 2 new required abstract methods to a basecalse we inherit form | |
| 12:02:33 | sean-k-mooney | bauzas: that got reverted on stable last cycle | |
| 12:02:57 | sean-k-mooney | bauzas: but the castalan version that was intened for stabel only got pulled into master by mistake | |
| 12:03:21 | sean-k-mooney | so we were not seing this for the last cycle | |
| 12:03:49 | sean-k-mooney | bauzas: we should have had this code chagne since bobcat | |
| 12:05:37 | sean-k-mooney | bauzas: i dont really think its reasoable to punt the new castalane version for two cycles in a row just because we didnt accept a patch that addes to uncalled functions that raise not implemetned | |
| 12:06:28 | sean-k-mooney | bauzas: there was a way for castalan to not make this a breaking api change | |
| 12:07:04 | sean-k-mooney | but im not sure how fair it is to say to them rework this now and do another release unless we are going to write that patch for them | |
| 12:07:58 | sean-k-mooney | bauzas: im not particaly happy either but apparenty the non-client release deadline is the deadlien for the code to be merged not the deadline for the requirement repo to be bumped | |
| 12:08:31 | sean-k-mooney | hence reluctant +2 from me | |
| 12:34:53 | opendevreview | Merged openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 12:40:08 | gibi | bauzas: would it make sense to fix the AZ series now, (I can try), or the bug I found means we punt it form the release? | |
| 12:59:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix for showing AZ without reqspec https://review.opendev.org/c/openstack/nova/+/910728 | |
| 13:10:02 | sean-k-mooney | gibi: technially code feeze was yesterday, but we could accpet it today if we wanted too | |
| 13:10:29 | sean-k-mooney | i would not extend to monday however without going though the excption process | |
| 13:11:22 | sean-k-mooney | gibi: what is the behvior with your fix | |
| 13:11:35 | sean-k-mooney | gibi: i would expect the pinned az to be None | |
| 13:11:52 | sean-k-mooney | if its not in the request spec so in json that would be null not '' | |
| 13:12:57 | sean-k-mooney | gibi: could you add an api sample test to show the end result? | |
| 13:13:36 | sean-k-mooney | we coudl go with empty string i guess instead of null | |
| 13:31:00 | stblatzheim | sean-k-mooney: Fix was merged. Any change i can backport this till stable/zed or at least stable/2023.1 ? | |
| 13:31:14 | stblatzheim | sean-k-mooney: Fix was merged. Any chance i can backport this till stable/zed or at least stable/2023.1 ? | |
| 13:32:17 | sean-k-mooney | yes it shoudl be backportable we have to go newest to oldest but i dont see why it could not go back to zed | |
| 13:32:45 | sean-k-mooney | are you familar with how to cerrypick it | |
| 13:33:10 | sean-k-mooney | i doubt it will have merge confict so fi the patch is merged you can do it via the gerrit ui | |
| 13:33:24 | sean-k-mooney | if its not merged the gerrit ui wont add the cherry-picked form line | |
| 13:34:42 | stblatzheim | I'll give it a try :) It's already merged. | |
| 13:35:03 | sean-k-mooney | that was more a meta comment for the older branches | |
| 13:35:17 | sean-k-mooney | you have ot go n to n-1 then n-1 to n-2 | |
| 13:35:21 | opendevreview | Steven Blatzheim proposed openstack/nova stable/2023.2: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910616 | |
| 13:35:24 | sean-k-mooney | not n to n-2 | |
| 13:35:45 | sean-k-mooney | so the simpelstet way to do that is jsut wait for ^ to merge | |
| 13:35:50 | sean-k-mooney | before creating the next one | |
| 13:36:25 | stblatzheim | Ok, so i'll wait for 2023.2 and when it's merged i'll start 2023.1 and after this merge zed | |
| 13:36:41 | sean-k-mooney | cool | |
| 13:37:24 | stblatzheim | thanks for your help with the whole fix | |
| 13:38:19 | sean-k-mooney | no worries, i have +2'd the first backport feel free to ping me if you need reviews on the others | |
| 13:44:04 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing requested az in output https://review.opendev.org/c/openstack/nova/+/904568 | |
| 13:58:47 | elodilles | bauzas: when you are around, can you take a second look on this? https://review.opendev.org/c/openstack/nova/+/896100 | |
| 14:11:39 | opendevreview | Amit Uniyal proposed openstack/nova master: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905134 | |
| 15:11:41 | bauzas | gibi: sean-k-mooney: sorry I was doing something else and before I wasn't in front of my screen when you pinged me | |
| 15:11:53 | bauzas | gibi: sean-k-mooney: so I can take a second look on the AZ API | |
| 15:12:32 | bauzas | elodilles: sean-k-mooney: castellan stuff sent to the gate | |
| 15:17:44 | sean-k-mooney | bauzas: i have been dipping in an dout of the az patch | |
| 15:18:01 | sean-k-mooney | i honestly dont have the context fo that loaded enough to review properly | |
| 15:18:36 | sean-k-mooney | gibi seems to have a better grasp of that | |
| 15:19:19 | sean-k-mooney | gibi pushed a followup patch but rajesh then incoperated some of that into there own patch, perhaps they didnt see gibis patch | |
| 15:19:29 | sean-k-mooney | so i dont really know if the comments have been adressed | |
| 15:21:56 | bauzas | I'll take a look before I stop for the weekend | |
| 15:22:07 | gibi | sean-k-mooney: bauzas: there are two comments left open there form me | |
| 15:22:27 | gibi | I can fix them if we still want to land it | |
| 15:22:46 | gibi | but i have limited time left for today | |
| 15:24:04 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing requested az in output https://review.opendev.org/c/openstack/nova/+/904568 | |
| 15:24:48 | sean-k-mooney | ratailor_: are you actully around ^ | |
| 15:24:58 | ratailor_ | sean-k-mooney, yes | |
| 15:25:21 | sean-k-mooney | ok it woudl be good to check in with bauzas / gibi to make sure everthing that needs to be adress is | |
| 15:25:36 | ratailor_ | sean-k-mooney, sure. Thanks! | |
| 15:25:47 | ratailor_ | just now updated the patch, let's see how it goes. | |
| 15:26:10 | sean-k-mooney | ack i expect most of use will disapare for the weekend in the next 30 mins or so | |
| 15:26:33 | ratailor_ | sean-k-mooney, aha.. then what are the options to get it merged ? | |
| 15:26:46 | gibi | ratailor_: could you drop the changes from https://review.opendev.org/c/openstack/nova/+/904568/16/nova/tests/unit/policies/test_servers.py | |
| 15:26:50 | gibi | they are not needed | |
| 15:27:00 | gibi | then I will be +2 | |
| 15:27:08 | sean-k-mooney | apprently ^ | |
| 15:27:29 | ratailor_ | gibi, sure, i will remove remaining changes there. | |
| 15:28:57 | gibi | cool | |
| 15:28:58 | opendevreview | Amit Uniyal proposed openstack/nova master: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905134 | |
| 15:35:37 | ratailor_ | gibi, how to resolve this https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d83/904568/16/check/openstack-tox-pep8/d83f39e/job-output.txt | |
| 15:35:45 | ratailor_ | nova/api/openstack/compute/views/servers.py:223:5: C901 'ViewBuilder.show' is too complex (41) | |
| 15:36:15 | ratailor_ | gibi, I think, its failing because we have too many ifs | |
| 15:39:17 | ratailor_ | we want to get req_spec during server show call when provided_az is None, but during server list, it will be passed from list_view method, so it might be some-string or '' | |
| 15:42:07 | opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | |
| 15:43:01 | dansmith | sean-k-mooney: was it you that had or was using some log aggregator thing that would collapse logs from multiple services into one? | |
| 15:46:00 | sean-k-mooney | gibi: has one tool for that bu ti also use lnav locally to do something like that | |
| 15:46:56 | dansmith | just thinking that for debugging gate fails, it might be a lot easier if we had a unified journal-style log with all the services from that host so we could open and search for a traceback, error, or instance uuid | |
| 15:47:36 | bauzas | dansmith: I generally use journalctl -f -u devstack@n-* for my controller | |
| 15:47:45 | sean-k-mooney | i think we have a full copy of the journal oputput | |
| 15:47:47 | dansmith | bauzas: right, I mean for gate fails | |
| 15:48:05 | bauzas | ah, aggregating the logfiles | |
| 15:48:56 | dansmith | sean-k-mooney: right but it's not viewable in the browser is it? | |
| 15:49:00 | sean-k-mooney | im on a call but ill see if i can get a link | |
| 15:49:52 | gibi | ratailor_: just pull out the logic to a separate function to reduce complexity | |
| 15:50:07 | ratailor_ | gibi, ack. Thanks! | |
| 15:50:41 | ratailor_ | gibi, inner function ? | |
| 15:51:12 | bauzas | sean-k-mooney: dansmith: yeah we do have the journal https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f81/904568/14/check/tempest-integrated-compute/f81f16a/controller/logs/devstack.journal.README.txt | |
| 15:51:35 | dansmith | yeah, I know, but it's not browseable | |
| 15:51:35 | bauzas | but you need to download the file | |
| 15:51:41 | bauzas | yup | |
| 15:51:55 | dansmith | but yeah, I guess we don't need log merge if we generated the combined log from that | |
| 15:52:15 | dansmith | okay so maybe I should just script doing that from a log url and look at it not in the browser | |