| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-28 | |||
| 15:36:29 | dansmith | sean-k-mooney: the key we're using to access a given disk is known really only to libvirt and qemu on the host, right? It's really qemu's integrated rbd client that's doing the luks on top, AFAK | |
| 15:36:56 | dansmith | so what I don't understand is how something that does *not* know about those things do image operations like flatten when it doesn't know those details | |
| 15:37:30 | dansmith | like, let's say we have an unencrypted base image, encrypted root disk on top. we haven't read or written block 10, | |
| 15:38:01 | dansmith | we call librbd to flatten the image (detach from parent), we have to copy any un-CoW'd blocks into the detached disk to make it whole | |
| 15:38:20 | dansmith | but we don't have the key, or even know that there's an encryption scheme going on in the child disk | |
| 15:50:27 | dansmith | melwitt: ^ when you're around | |
| 15:59:54 | mnaser | https://review.opendev.org/c/openstack/nova/+/909098 + https://review.opendev.org/c/openstack/nova/+/909541 is finally passing thanks | |
| 16:20:33 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 16:24:29 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 16:33:28 | opendevreview | Merged openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| #openstack-nova - 2024-02-29 | |||
| 06:58:41 | opendevreview | Merged openstack/nova master: Modify the mdevs in the migrate XML https://review.opendev.org/c/openstack/nova/+/904258 | |
| 07:36:21 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 07:36:21 | opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 07:36:22 | opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | |
| 07:36:22 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | |
| 07:36:23 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | |
| 07:36:23 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 07:36:24 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 07:36:25 | opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | |
| 07:36:25 | opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |
| 07:36:27 | opendevreview | melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595 | |
| 07:36:27 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 07:36:29 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 07:36:29 | opendevreview | melanie witt proposed openstack/nova master: Report ephemeral disk encryption in the metadata API https://review.opendev.org/c/openstack/nova/+/909945 | |
| 07:36:31 | opendevreview | melanie witt proposed openstack/nova master: Deprecate legacy ephemeral storage encryption using dm-crypt https://review.opendev.org/c/openstack/nova/+/909947 | |
| 07:36:31 | opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | |
| 07:36:33 | opendevreview | melanie witt proposed openstack/nova master: testing: Add ephemeral encryption support to fixtures https://review.opendev.org/c/openstack/nova/+/910571 | |
| 11:32:08 | stblatzheim | sean-k-mooney: Thanks for the review. Just a quick question as it's my first work on openstack: Which id do i need to append to the release-note file under /releasenotes/notes? Atm i have a file called bug-2055245-fix-nova-metadata-api.yaml . | |
| 11:33:50 | stephenfin | Uggla: Have you link to the discussion where we decided not to bump the object version for a new field enum? That's pretty unusual unless we're not transmitting over the wire (in which case why _not_ bump) https://review.opendev.org/c/openstack/nova/+/908864 | |
| 11:33:54 | stephenfin | cc sean-k-mooney ^ | |
| 11:34:25 | sean-k-mooney | so you can generate a templesate doing "tox -e venv reno new bug-2055245-fix-nova-metadata-api" | |
| 11:34:43 | sean-k-mooney | stblatzheim: well you can generate a file form the template i should say | |
| 11:35:03 | sean-k-mooney | then you can take the content you have and put it in that file under the fixes section | |
| 11:35:09 | sean-k-mooney | just remove all the other sections | |
| 11:35:43 | sean-k-mooney | stephenfin: we normally do bump them | |
| 11:36:00 | sean-k-mooney | and you need compat code to remove the new values when backleveling | |
| 11:36:03 | stephenfin | yeah that's my thinking. It's pretty unusual not to | |
| 11:36:25 | stephenfin | as I said in the review, if there's a good reason not then it should be noted in the commit message | |
| 11:36:27 | sean-k-mooney | if we look at the video model | |
| 11:36:37 | sean-k-mooney | that is proably the closest example to the compat code | |
| 11:37:26 | sean-k-mooney | https://github.com/openstack/nova/commit/35a591d33d8b1a6c30bf40ddc48a07715fd87339 | |
| 11:37:30 | sean-k-mooney | Uggla: ^ | |
| 11:38:39 | sean-k-mooney | adding new enum fields to the VideoModel enum required an object bump for the image metadata object and backleveling code | |
| 11:38:45 | sean-k-mooney | so you woudl need that for attaching too | |
| 11:42:54 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 11:43:27 | stblatzheim | sean-k-mooney: Thank you, I just uploaded the release file | |
| 11:43:27 | sean-k-mooney | stblatzheim: did you forget a git add ^ | |
| 11:44:00 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 11:44:16 | sean-k-mooney | :) | |
| 11:44:18 | stblatzheim | Sorry, my fault :D | |
| 11:45:42 | sean-k-mooney | stephenfin: while your here ^ nice quick review for you if you have time | |
| 11:54:10 | sean-k-mooney | bauzas: are you around | |
| 11:54:41 | bauzas | yup | |
| 11:54:56 | sean-k-mooney | can we chat about the ironic shards work | |
| 11:55:18 | sean-k-mooney | basically im wondering are you ok to proceed with it | |
| 11:56:04 | sean-k-mooney | also the mdev presitance https://review.opendev.org/c/openstack/nova/+/910041 im not sure i have time to review that today | |
| 11:56:11 | opendevreview | Merged openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 11:56:40 | sean-k-mooney | so i assume the mdev persistnace will go to D since mel has a -w on it | |
| 11:57:25 | bauzas | sure | |
| 12:05:37 | stephenfin | sean-k-mooney: your opinion is requested on https://review.opendev.org/c/openstack/nova/+/833090/43/nova/compute/api.py | |
| 12:06:22 | sean-k-mooney | bauzas: is that sure your goign t | |
| 12:06:40 | sean-k-mooney | to review them or... | |
| 12:08:19 | bauzas | ok, I need to go to lunch but I'll look at it | |
| 12:09:04 | sean-k-mooney | stephenfin: ya i chatted to gibi about it a little. he pointed out that the attachment is actully done in the api | |
| 12:09:47 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 12:09:53 | sean-k-mooney | stephenfin: he was ok with using attachment to future proof the name | |
| 12:10:12 | sean-k-mooney | but right now its acutly doing the manilla export | |
| 12:13:22 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 12:20:33 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further clarifications to the SG doc https://review.opendev.org/c/openstack/nova/+/903675 | |
| 12:21:19 | stephenfin | melwitt: Respun that small SG docs patch again ^ Sorry for the delay: I missed your response. Would appreciate a (re-)review when you can 🙏 | |
| 12:24:09 | sean-k-mooney | stephenfin: i am +2 on it i think the changes are a nice improvement | |
| 12:24:19 | stephenfin | ty | |
| 12:24:23 | sean-k-mooney | espically the metadata one | |
| 12:25:13 | sean-k-mooney | i actully think that might depend on the driver tha tis used on teh neutron side | |
| 12:25:18 | sean-k-mooney | but its good to have a note | |
| 12:25:42 | sean-k-mooney | neutorn has some default ruels that are alwasy applike like allowing arp and dhcp i belive | |
| 12:26:10 | sean-k-mooney | but i also think ml2/ovs and ml2/ovn differ on what is always allwoed | |
| 12:30:41 | sean-k-mooney | stephenfin: this is what i was thinking of https://github.com/openstack/neutron/blob/12ed429e7b41c7f1ce0901fdc4215216a80b9374/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py#L68-L69 | |
| 12:31:03 | sean-k-mooney | so if the subnet has dhcp it opens dhcp automatically | |
| 12:31:27 | sean-k-mooney | but it doe s not do that for metadata | |
| 12:32:11 | sean-k-mooney | whihc is why we need the note you added for metadata but not for dhcp | |
| 12:33:50 | stblatzheim | In ovn context there needs to be a SG for DHCP and metadata if i remember well. We scame across this behavior when we built a new cloud with ovn. | |
| 12:36:20 | stblatzheim | I think there was also a difference between geneve networks and native_vlan networks. | |
| 13:32:20 | Uggla | sean-k-mooney, stephenfin ok I'have seen your comments. I'll update the version. | |
| 13:33:29 | Uggla | sean-k-mooney, stephenfin, thx for explanation | |
| 13:57:37 | opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | |
| 14:10:15 | opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | |
| 14:20:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: SEV: Add TODO note about iommu setting done in recent QEMU https://review.opendev.org/c/openstack/nova/+/909635 | |
| 14:27:09 | opendevreview | Merged openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | |
| 14:27:16 | opendevreview | Merged openstack/nova master: Separate OSError with ValueError https://review.opendev.org/c/openstack/nova/+/908825 | |
| 15:54:10 | opendevreview | Merged openstack/nova master: HyperV: Remove extra specs of HyperV driver https://review.opendev.org/c/openstack/nova/+/906992 | |
| 16:14:40 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 16:16:19 | opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 16:16:19 | opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | |
| 16:16:20 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | |
| 16:16:20 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | |
| 16:16:21 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 16:16:21 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 16:16:22 | opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | |
| 16:16:22 | opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |