| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-23 | |||
| 16:17:25 | sean-k-mooney | hum although im not sure that is corect since wallay and victoria should be unmainted then too | |
| 16:17:34 | sean-k-mooney | and xena | |
| 16:17:54 | sean-k-mooney | elodilles: ^ we should look into what up there | |
| 16:18:09 | sean-k-mooney | https://opendev.org/openstack/nova/branches | |
| 16:18:42 | sean-k-mooney | i forget what we had agreed but i taught we agreed not to skip any releases | |
| 16:18:57 | sean-k-mooney | so if yoga is moved to unamined i woudl expect all older branch to be as well | |
| 16:29:31 | elodilles | sean-k-mooney: we started the transition with yoga, as that had a 'deadline' some months ago... now we'll continue with the rest (xena, wallaby and victoria), actually, i just said on the Release meeting that i'm planning to propose the transition patches on Monday (despite the busy Caracal-3 milestone busy time... :S) | |
| 16:30:20 | sean-k-mooney | elodilles: oh ok | |
| 16:30:25 | sean-k-mooney | so they are just in flight | |
| 16:30:27 | sean-k-mooney | cool | |
| 16:31:45 | elodilles | yepp-yepp | |
| 16:31:49 | elodilles | that's the plan | |
| 16:52:10 | artom | Bleargh, the CPU power management stuff is not testable for multiple compute hosts in functional tests | |
| 16:52:39 | artom | All the work is being done by module-level functions, no way to mock/patch different instances on the two compute services/libvirt drivers | |
| 16:52:50 | artom | IOW, live migration reproducer tests are impossible | |
| 16:53:55 | artom | And I feel like if I make the CPU API a class and stick in an attribute of the driver, it won't fly, because it's a change that would only exist to allow tests | |
| 16:54:26 | sean-k-mooney | artom: we could test it with multiple compute nodes in the functional tests | |
| 16:54:37 | sean-k-mooney | but we are missing test infra to do that | |
| 16:54:59 | artom | sean-k-mooney, I don't see a way to the assert the online/offline CPUs on each host | |
| 16:55:33 | artom | Because the libvirt driver imports cpu/api.py as a global libvirt_cpu, and calls that | |
| 17:03:12 | artom | Actually, what I'd really need is to somehow stub in different "instances" of the Core class for each libvirt driver | |
| 17:04:36 | artom | More like, a different SysFS fixture for each... | |
| 17:17:49 | sean-k-mooney | artom: we made live migration work in teh functrional tests with sriov | |
| 17:18:01 | sean-k-mooney | we can make it work for power management | |
| 17:18:08 | sean-k-mooney | if we put in the effort | |
| 17:18:32 | artom | Right, I'm just not sure it's possible without changing the actual Nova code | |
| 17:21:18 | sean-k-mooney | anywya im ment to be off today so im going to leave the office again | |
| 17:22:11 | artom | Yeah, I was going to say, make sure you compensate for working today by not working Monday or something :) | |
| 17:47:05 | elodilles | sean-k-mooney LarsErikP : i've cherry picked the patch to unmaintained/yoga: https://review.opendev.org/c/openstack/nova/+/910010 | |
| 17:47:59 | elodilles | gate is happy with it, though there are no devstack based jobs among the zuul jobs at all, so that should be added to the branch first | |
| 18:14:54 | opendevreview | Artom Lifshitz proposed openstack/nova master: Power on cores for isolated emulator threads https://review.opendev.org/c/openstack/nova/+/909795 | |
| 18:14:55 | opendevreview | Artom Lifshitz proposed openstack/nova master: POC: power up dedicated cores during pre_live_migration https://review.opendev.org/c/openstack/nova/+/909806 | |
| 18:14:55 | opendevreview | Artom Lifshitz proposed openstack/nova master: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/910020 | |
| 18:14:56 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/910021 | |
| 18:14:56 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Reproducer tests for live migration with power management https://review.opendev.org/c/openstack/nova/+/910022 | |
| 19:48:28 | u00599 | sean-k-mooney: but infact ovn has just it's proxy and network_data.json is provided by nova-api or am i wrong? Infact the ovn has it's router and dhcp port in common and is owned by network:distributed. Wouldn't it be feasible to add another check for this owner when no dhcp-agent is found? | |
| 22:55:52 | opendevreview | Jay Faulkner proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | |
| 22:55:53 | opendevreview | Jay Faulkner proposed openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | |
| 22:55:53 | opendevreview | Jay Faulkner proposed openstack/nova master: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/903917 | |
| 23:23:39 | opendevreview | Jay Faulkner proposed openstack/nova master: Make compute node rebalance safer https://review.opendev.org/c/openstack/nova/+/903917 | |
| #openstack-nova - 2024-02-24 | |||
| 02:02:12 | opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | |
| 02:41:55 | opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | |
| #openstack-nova - 2024-02-25 | |||
| 05:49:16 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing requested az in output https://review.opendev.org/c/openstack/nova/+/904568 | |
| 21:25:43 | opendevreview | Jay Faulkner proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | |
| 21:25:44 | opendevreview | Jay Faulkner proposed openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | |
| 21:25:44 | opendevreview | Jay Faulkner proposed openstack/nova master: Make compute node rebalance safer https://review.opendev.org/c/openstack/nova/+/903917 | |
| #openstack-nova - 2024-02-26 | |||
| 03:56:49 | opendevreview | Nobuhiro MIKI proposed openstack/nova master: libvirt: Support maxphysaddr. https://review.opendev.org/c/openstack/nova/+/907516 | |
| 07:37:59 | LarsErikP | elodilles: aha! We are working on upgrading from yoga anyway, so I guess we will be good ;) | |
| 07:42:07 | LarsErikP | sean-k-mooney: thanks for the explanation =) We definitly has count_usage_from_placement | |
| 07:42:29 | LarsErikP | jamespage: woho \o/ we will help verify the nova-package at <3 | |
| 07:42:34 | LarsErikP | at least* | |
| 07:59:30 | opendevreview | Rajesh Tailor proposed openstack/nova master: trivial doc fix https://review.opendev.org/c/openstack/nova/+/901237 | |
| 08:33:31 | opendevreview | Merged openstack/nova master: trivial doc fix https://review.opendev.org/c/openstack/nova/+/901237 | |
| 09:14:33 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 11:04:01 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix device type when booting from ISO image https://review.opendev.org/c/openstack/nova/+/909611 | |
| 13:25:10 | sean-k-mooney | bauzas: rajesh has respon https://review.opendev.org/c/openstack/nova/+/904568 can you re review and if your happy with it ill try and review it later | |
| 13:25:25 | bauzas | ack | |
| 13:26:23 | sean-k-mooney | amit adresses my issues with https://review.opendev.org/c/openstack/nova/+/901824 too so that just needs a second core to review | |
| 13:26:32 | sean-k-mooney | i updated the etherpad with that info | |
| 13:27:31 | sean-k-mooney | im hesitent to merge anytrhing that conflcits with the encyption series but those should hopefully be small | |
| 14:34:10 | bauzas | sean-k-mooney: I'll review amit's rfe shortly but I started reviewing mel's patches and I struggle understanding what she did tbh | |
| 14:34:31 | bauzas | I don't feel confident about providing +2s for things so tangled | |
| 14:34:40 | bauzas | and that I'm not an expert | |
| 14:35:19 | bauzas | so I can try to give it a shot but it will be more based on your own expertise and mel's evidences of that it works | |
| 16:55:57 | dansmith | melwitt: sean-k-mooney: where's the job add/change for this in the stack? | |
| 16:56:19 | dansmith | (for ephemeral encryption) | |
| 16:57:10 | melwitt | dansmith: this is what I've been using https://review.opendev.org/c/openstack/nova/+/862416 it changes the default flavors for tempest to ones that request encryption and then runs all of normal tempest with that | |
| 16:57:24 | dansmith | melwitt: thanks | |
| 16:58:02 | dansmith | melwitt: so are we going to change over one/more jobs to use these? | |
| 16:59:20 | dansmith | melwitt: and the failed run on that needs a recheck I assume | |
| 16:59:55 | melwitt | dansmith: yeah I'm not sure what consensus would want to do here. sean-k-mooney and I chatted about the possibility of adding "smoke" style tests in tempest to do a very basic thing. another option is using something like what's in the DNM and run it periodic because of how heavy they are | |
| 17:00:34 | dansmith | or potentially add a compute feature flag to tempest to just run a few tests with flavors asking for it? | |
| 17:01:21 | melwitt | dansmith: yeah, that's an unrelated fail that needs a recheck. I'll do that | |
| 17:01:34 | melwitt | dansmith: yeah that would be another option | |
| 17:17:08 | melwitt | I had the recheck in a draft comment and hadn't posted it 😣 | |
| 17:23:36 | sean-k-mooney | dansmith: ya so i would liek to add a couple of simple test behind a compute_feature flag in tempest | |
| 17:24:09 | sean-k-mooney | dansmith: melwitt has the every weithg job that turns this on in the flavor for all the tempest vms | |
| 17:24:22 | sean-k-mooney | which we could do in a perodic but not every patch due to the time it takes | |
| 17:24:31 | dansmith | the what? | |
| 17:24:51 | sean-k-mooney | heavy weight | |
| 17:25:05 | sean-k-mooney | the dnm test just changes the tempest flvoars to make all vms use encyption | |
| 17:25:20 | sean-k-mooney | but since the flavor has ephmeral root and swap | |
| 17:25:26 | sean-k-mooney | it slows down the job | |
| 17:26:05 | sean-k-mooney | if we dont already have a job with barbican i would ike to have at least one so we can test cinder volume encyption and vtpm in that job too | |
| 17:26:21 | sean-k-mooney | i have not checked if we have any job today with barbican in our gate | |
| 17:29:23 | melwitt | I think we don't, so that's kind of the main thing is how do we want to add barbican | |
| 17:30:45 | melwitt | add it to an existing job like nova-next and then set a feature flag to run limited encryption tests? | |
| 17:30:59 | dansmith | yeah, something | |
| 17:31:09 | dansmith | or maybe nova-lvm since it's kinda relatedish? | |
| 17:31:36 | sean-k-mooney | not really since this feature wont support lvm | |
| 17:31:40 | sean-k-mooney | at least not in this release | |
| 17:31:56 | dansmith | meaning we can't do this underneath an lvm-backed nova? | |
| 17:32:15 | dansmith | I meant it's related to a more complex ephemeral disk layout | |
| 17:32:20 | sean-k-mooney | correct the serise is currently for qcow, raw and rbd | |
| 17:32:33 | sean-k-mooney | lvm could be supproted but not in the current serise | |
| 17:32:47 | dansmith | and we fail in that scenario how? | |
| 17:32:59 | sean-k-mooney | it does not report the triat saying we supprot this | |
| 17:33:21 | sean-k-mooney | so an lvm cloud will have no valid host or select a non lvm node if they eexist and supprot it | |
| 17:33:34 | dansmith | okay so if you have all LVM-backed nodes and you ask for this, nothing will be bootable | |
| 17:33:44 | sean-k-mooney | there is a per image backend SUPPORTS_LUKS flag | |