| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-16 | |||
| 16:41:43 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 16:41:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 16:41:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 16:42:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop logic for compute service version < 33 https://review.opendev.org/c/openstack/nova/+/909218 | |
| 16:48:27 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 16:58:49 | artom | That +/- line count is mighty alluring, but I do understand the robustness concern. | |
| 17:00:42 | dansmith | artom: we could drop a lot of checks and meet that requirement :) | |
| 17:00:59 | dansmith | artom: we're also talking about downstream effects of one of these checks specifically right now... | |
| 17:01:32 | artom | dansmith, yeah, I think you and I are on the same page about this | |
| 17:01:59 | artom | I understand the sentiment, but am concerned about the side effects | |
| 17:08:43 | tkajinam | we may keep some of these, but some checks even call neutron to get port details for no use | |
| 17:09:33 | dansmith | tkajinam: that's fine, those are expensive.. separating those from the service version checks would be much better IMHO | |
| 17:10:00 | tkajinam | If we prefer not removing these then I'm fine. then I'll remove all TODO comments because these shouldn't be done | |
| 17:11:44 | artom | I mean I think there's a balance that something like Victoria is _probably_ fine | |
| 17:12:07 | artom | But the more recent we go, the more it's a case of "well, it _might_ be happening somewhere" | |
| 17:12:53 | tkajinam | I have a few topis I need to bring to PTG so will add this topic there, too, to discuss the strategy. | |
| 17:13:16 | tkajinam | yeah. I understand that point and that's why I'm making per-release change instead of removing these by a single shot | |
| 17:14:00 | artom | Though most of our customer are still running a train-based release, so perhaps even Victoria should be off limits | |
| 17:14:18 | artom | I think the upstream operator survey mostly aligns with that, too | |
| 17:14:58 | dansmith | yeah, and people are also still skipping lots of releases on each upgrade, which makes keeping the older checks in the newer code more relevant than they may seem | |
| 17:16:38 | tkajinam | I agree with that stetement though I'm not too sure skipping releases during upgrade immediately means mixing versions with huge gap really during operation | |
| 17:17:12 | tkajinam | anyway I think we can discuss details during PTG. I'm almost done about the series of patches so these may show the amount of codes we may drop if we do cleanup completely. | |
| 17:17:56 | dansmith | tkajinam: it does if you miss some computes during the upgrade, which we hear about regularly | |
| 17:18:11 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: libvirt: Stop unconditionally enabling evmcs https://review.opendev.org/c/openstack/nova/+/909228 | |
| 17:19:00 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/909229 | |
| 17:21:02 | tkajinam | yeah but even in that case I'm unsure why they can't complete upgrade before getting it back to the cluster. | |
| 17:21:19 | tkajinam | ... with keeping all my experience tripleo thrown away | |
| 17:30:13 | dansmith | they can, of course, but the point of these checks is so that nova notices these sorts of things | |
| 17:34:24 | tkajinam | nova already has version check and reject starting services in case services with too old versions exist. That'd be the first guard. operators can disable the check but they should aware of the risk of doing it, unless they expect nova should take care of any versions, or we should remove that check if that does not meet the real requirement. | |
| 17:34:50 | tkajinam | (I don't intend to get conclusion here. just dumping some of my thoughts which I may bring during PTG. | |
| 17:35:33 | tkajinam | s/unless they expect/without expecting that/ | |
| 17:37:17 | dansmith | are you talking about the check that a service doesn't regress the current minimum? that only helps if you restart the old services, which doesn't happen by definition if your upgrade tool skips them | |
| 17:37:52 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 17:41:34 | tkajinam | I was talking about the service version check at startup (based on https://github.com/openstack/nova/blob/master/nova/objects/service.py#L256 ). I agree it may not work for case where old services may be kept running during upgrade | |
| 17:42:02 | tkajinam | though it blocks the case that a user attempts to get old node joining back to the cluster. | |
| 17:46:45 | dansmith | Yep, that's the thing we had to add the knob to disable because it gets in the way of large upgrades, so it's not uncommon to see that turned off :) | |
| 17:47:03 | dansmith | we added it as a hard fail and immediately had to backport the knob because it was too strict for lots of real-world situations | |
| 18:33:12 | opendevreview | Merged openstack/nova master: docs: Further tweaks to the CPU models document https://review.opendev.org/c/openstack/nova/+/784066 | |
| 18:33:25 | opendevreview | Merged openstack/nova stable/2023.2: libvirt: Stop unconditionally enabling evmcs https://review.opendev.org/c/openstack/nova/+/909082 | |
| 18:33:42 | opendevreview | Merged openstack/nova stable/2023.2: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/909086 | |
| 18:33:57 | opendevreview | Merged openstack/nova master: Drop unnecessary mocking of get_minimum_version_all_cells https://review.opendev.org/c/openstack/nova/+/909219 | |
| 19:25:16 | opendevreview | Mohammed Naser proposed openstack/nova stable/2023.1: libvirt: Stop unconditionally enabling evmcs https://review.opendev.org/c/openstack/nova/+/909228 | |
| 19:25:24 | opendevreview | Mohammed Naser proposed openstack/nova stable/2023.1: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/909229 | |
| 20:57:20 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if original image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| #openstack-nova - 2024-02-17 | |||
| 04:49:29 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if original image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| 19:07:01 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 19:07:02 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 19:07:03 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 19:07:03 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 19:07:04 | opendevreview | melanie witt proposed openstack/nova master: libvirt: make |
|
| 19:07:04 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 19:07:05 | opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 19:07:06 | opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | |
| 19:07:07 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | |
| 19:07:08 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | |
| 19:07:09 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 19:07:09 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 19:07:10 | opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | |
| 19:07:10 | opendevreview | melanie witt proposed openstack/nova master: WIP Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |
| 19:07:12 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 19:07:12 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 22:15:37 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 22:15:38 | opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | |
| 22:15:38 | opendevreview | melanie witt proposed openstack/nova master: WIP Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |
| 22:15:39 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 22:15:39 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| #openstack-nova - 2024-02-18 | |||
| 10:10:56 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 10:10:56 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 17:28:20 | opendevreview | Takashi Kajinami proposed openstack/os-resource-classes master: Bupm hacking https://review.opendev.org/c/openstack/os-resource-classes/+/909332 | |
| 17:29:10 | opendevreview | Takashi Kajinami proposed openstack/os-traits master: Bupm hacking https://review.opendev.org/c/openstack/os-traits/+/909333 | |
| 17:59:36 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Remove unused netaddr https://review.opendev.org/c/openstack/os-vif/+/909340 | |
| 17:59:37 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Move oslo.concurrency to test dependencies https://review.opendev.org/c/openstack/os-vif/+/909341 | |
| 18:01:23 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Move test dependencies https://review.opendev.org/c/openstack/os-vif/+/909341 | |
| 18:06:57 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Fix missing or unnecessary dependencies https://review.opendev.org/c/openstack/os-vif/+/909341 | |
| 18:08:26 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Fix missing or unnecessary dependencies https://review.opendev.org/c/openstack/os-vif/+/909341 | |
| #openstack-nova - 2024-02-19 | |||
| 01:40:00 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Fix missing or unnecessary dependencies https://review.opendev.org/c/openstack/os-vif/+/909341 | |
| 01:41:21 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Fix missing or unnecessary dependencies https://review.opendev.org/c/openstack/os-vif/+/909341 | |
| 09:28:21 | opendevreview | Merged openstack/nova master: HyperV: Remove RDP console connection information API https://review.opendev.org/c/openstack/nova/+/906991 | |
| 11:03:01 | opendevreview | Merged openstack/nova-specs master: Create specs directory for 2024.2 Dalmatian https://review.opendev.org/c/openstack/nova-specs/+/906073 | |
| 13:18:28 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add openapi spec https://review.opendev.org/c/openstack/nova-specs/+/909448 | |
| 13:23:27 | opendevreview | Takashi Kajinami proposed openstack/nova-specs master: libvirt: Stateless firmware support https://review.opendev.org/c/openstack/nova-specs/+/908297 | |
| 13:24:08 | opendevreview | Takashi Kajinami proposed openstack/nova-specs master: libvirt: AMD SEV-ES support https://review.opendev.org/c/openstack/nova-specs/+/907702 | |
| 14:37:50 | bauzas | dansmith: sean-k-mooney: when you have a minute, I'd like to discuss about the mdev live-mig series https://review.opendev.org/c/openstack/nova/+/904209/16 | |
| 14:38:18 | bauzas | (about the periodic call) | |
| 14:41:04 | sean-k-mooney | sure | |
| 14:41:32 | sean-k-mooney | we will be hitting meetings shortly but im free for a while | |
| 14:42:11 | bauzas | awaiting dan when he can | |
| 14:42:29 | bauzas | my concern is about the API we could use for calling the drivcer | |
| 14:43:07 | dansmith | bauzas: I'm just getting started in my morning so I'm doing lots of stuff, sorry | |
| 14:43:16 | bauzas | no worries then | |
| 14:43:36 | bauzas | I'll try to provide a WIP then | |
| 14:44:33 | sean-k-mooney | bauzas: just do this in update_aviable_resouces | |
| 14:45:02 | sean-k-mooney | thats already being called and its very closely related | |
| 14:45:14 | bauzas | sean-k-mooney: sure, but given we don't call the driver by it, I need to create a new driver method :( | |
| 14:45:21 | sean-k-mooney | we do | |
| 14:45:30 | sean-k-mooney | update_avlaiable_resouces calls the driver | |
| 14:45:41 | sean-k-mooney | thats why im suggesting it | |
| 14:46:08 | bauzas | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9582 | |
| 14:47:24 | sean-k-mooney | i belive that is called form https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L10587 | |
| 14:48:23 | sean-k-mooney | yep here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L911 | |