| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-15 | |||
| 11:55:26 | sean-k-mooney | and can you backport the other one too | |
| 11:57:13 | opendevreview | Takashi Kajinami proposed openstack/os-traits master: Add traits for TPM models https://review.opendev.org/c/openstack/os-traits/+/909107 | |
| 11:57:46 | artom | sean-k-mooney, it didn't merge yet | |
| 11:57:59 | artom | But maybe we don't care, because it has +A | |
| 12:00:00 | sean-k-mooney | yes i know. we do care for the cherry picked form line i just ment when its ready can you do it and ping me | |
| 12:00:19 | sean-k-mooney | if you want to prepare them local youc an but hopefuly it will merge later today | |
| 12:45:30 | elodilles | sean-k-mooney[m]: i'm not super confident about that backport, so left a question in my comment there | |
| 12:46:03 | sean-k-mooney | elodilles: ack, right now you cant boot windows vms on amd host becuase of a reguression intoduced by enableing that feature | |
| 12:46:16 | sean-k-mooney | so we really need to undo that | |
| 12:46:30 | sean-k-mooney | live migration is also broken for a simialr reason | |
| 12:46:56 | elodilles | sean-k-mooney: ACK i understand that, but what about with intel hosts? we might remove a feature that is already used by some operators? | |
| 12:48:00 | sean-k-mooney | yep that hsoudl only reduce performace in some edge cases where the enlightnemtn was used | |
| 12:48:25 | elodilles | and yepp, probably to fix this to work both AMD and Intel hosts has higher prio, i'm just asking whether this is the right way | |
| 12:48:35 | sean-k-mooney | to be clear i would have consider this a criticla bug requireing a new RC if we had found it before the release | |
| 12:49:07 | sean-k-mooney | elodilles: so to reenable this for intel hosts we will need a trait and a new falvor/image property | |
| 12:50:13 | sean-k-mooney | because it depend on the hardware vendor of the underlying host | |
| 12:50:24 | sean-k-mooney | we cant just enable this via the exissting OS_TYPE=windows | |
| 12:50:43 | sean-k-mooney | it will need to be requested explictly to safely enable and supprot live migration as we will have to schdule on it | |
| 12:51:40 | elodilles | ACK, then i also tend to agree on backporting this. but to be on the safe side, i let other stable cores to also share their opinions on the patch o:) | |
| 12:51:48 | sean-k-mooney | elodilles: what will happen with the backport is existing vms will keep the enlightnement until they are hard rebooted, cold migrated, shelved or rebuilt | |
| 12:55:43 | elodilles | is this already a bug since 2023.1 Antelope? :-o | |
| 12:56:02 | sean-k-mooney | yep... | |
| 12:56:15 | sean-k-mooney | i was kind of shocked it took so long for it to be reported | |
| 12:57:39 | sean-k-mooney | well i gues it didnt take that long to be reported but it did take a long time to get this fixed | |
| 12:58:19 | sean-k-mooney | i moved it to high the second i realsised the impact and confirmed the limitation | |
| 12:58:59 | elodilles | i guess not many operators have windows guests on AMD hosts :-o | |
| 12:59:17 | sean-k-mooney | the workaround is just dont set OS_TYPE=windows on the image | |
| 12:59:24 | sean-k-mooney | but that disables all the enlightenment | |
| 12:59:31 | sean-k-mooney | and that reduces performance a lot | |
| 12:59:54 | sean-k-mooney | having them eaislly doubles the guest performacne and more in some workloads | |
| 13:00:08 | sean-k-mooney | not that one specificaly jsut in general | |
| 13:00:26 | sean-k-mooney | so truning off all the windows enlightenments is really not a compeling choice | |
| 13:04:24 | sean-k-mooney | elodilles: https://bugs.launchpad.net/nova/+bug/2046549 is more shocking to me | |
| 13:05:05 | sean-k-mooney | elodilles: i would have expected operators to be screaming at use for breakign live migration with windows guests | |
| 13:05:32 | elodilles | :-o | |
| 13:06:01 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/904183 is the fix but that is still in ci | |
| 13:08:53 | elodilles | so that will be also backported together with the above fix i guess then | |
| 13:09:04 | sean-k-mooney | that would be the intent yes | |
| 13:09:09 | sean-k-mooney | they can be backported seperatly | |
| 13:09:34 | sean-k-mooney | but both are a high prioryt i think to backprot | |
| 13:10:09 | sean-k-mooney | i think that will be compelling ot operators to have espeiclly those who have not upgraded to antelope yet | |
| 13:16:03 | elodilles | yepp, probably the thing is that 'those' operators have noy yet upgraded (not even to 2023.1 Antelope :S) | |
| 13:21:29 | opendevreview | Merged openstack/nova master: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/904183 | |
| 14:00:50 | sean-k-mooney | artom: ^ fyi that merged on master so you can start the backport of that too now | |
| 14:20:11 | opendevreview | Mohammed Naser proposed openstack/nova stable/2023.2: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/909086 | |
| 14:31:06 | sean-k-mooney | JayF: for that its worth we have mypy in some files in nova | |
| 14:31:38 | sean-k-mooney | JayF: so its not all or nothing it can be added gradully | |
| 14:32:14 | JayF | I know, and I think it would be cool, but that email the point was more.. do something rather than telling other people to do something 😀 | |
| 14:32:15 | sean-k-mooney | when startging new files like for the healthcheck stuff i have inteionally starte with mypy enabeld | |
| 14:32:25 | sean-k-mooney | yep | |
| 14:32:43 | sean-k-mooney | i am kind of trying to stay out of that thread | |
| 14:32:57 | sean-k-mooney | partly because i have been burnt on tryign to do simiear things and i just dont have time right now | |
| 14:33:44 | sean-k-mooney | i.e. i would like to moderenize some things and pay down tech debt | |
| 14:34:08 | sean-k-mooney | like i really want to see the SQLA2.0 stuff done in manilla so we can move to it | |
| 14:34:28 | sean-k-mooney | or get the wsgi/pyproject.yaml stuff doen | |
| 14:34:34 | sean-k-mooney | just time... | |
| 14:35:16 | sean-k-mooney | JayF: thanks for responding :) | |
| 14:36:53 | JayF | I have a friend who works on a major python library who always says (joking) that they're about 100 developers working on infrastructure across all technology. | |
| 14:37:28 | JayF | Finding the quote from that paper about OSS contribution that said 97% of value was created by 5% of people... It's weird to see the gist of your validated by research | |
| 14:37:42 | JayF | **your joke | |
| 14:38:06 | sean-k-mooney | the best jokes are based in reality... | |
| 14:40:31 | sean-k-mooney | i was chatting to one of the developer workign on stading up the infra for centos 10 stream yeasterday and they actully suggested that instead of using centos stream a a rhel next proxy we should be using https://docs.fedoraproject.org/en-US/eln/ | |
| 14:41:05 | sean-k-mooney | apprenetly fedora eln is what facebook and amazone use to build adn test there rhel deritivtes | |
| 14:42:39 | sean-k-mooney | if we were usign fedroa eln + rocky/almalinux we would ahve better proxies for btoh rhel next and rhel current | |
| 14:42:48 | sean-k-mooney | then useing stream gives us today | |
| 15:35:11 | opendevreview | Doug Szumski proposed openstack/nova master: Revert "[libvirt] Live migration fails when config_drive_format=iso9660" https://review.opendev.org/c/openstack/nova/+/909122 | |
| 15:45:00 | opendevreview | Doug Szumski proposed openstack/nova master: Revert "[libvirt] Live migration fails when config_drive_format=iso9660" https://review.opendev.org/c/openstack/nova/+/909122 | |
| 15:56:19 | dougszu | As promised sean-k-mooney ^. It's entirely clear to me yet. Will keep digging. | |
| 15:56:23 | dougszu | *not | |
| 17:15:10 | dansmith | bauzas: I thought you said you were going to remove the dict and use the guest XMLs to determine persistence in this: https://review.opendev.org/c/openstack/nova/+/904209 | |
| 17:15:22 | dansmith | did I misunderstand or are we still waiting for that revision/ | |
| 17:26:00 | mnaser | I'd appreciate reviews on https://review.opendev.org/c/openstack/nova/+/909082 + https://review.opendev.org/c/openstack/nova/+/909086 -- we'll need to cherry-pick it a bit further down so b enice to merge those in | |
| 18:00:54 | bauzas | dansmith : I'm not super opinionated about that, I eventually thought that it wouldn't be a problem if we reserve the mdevs with the dict | |
| 18:01:25 | dansmith | using the xmls seems better to me, but I know it's more work | |
| 18:01:35 | dansmith | I'm mostly asking because I was expecting to see that change and haven't | |
| 18:01:53 | bauzas | Well, we already look at the XMLs | |
| 18:02:12 | bauzas | So it should be automatically find the paused guests | |
| 18:02:28 | bauzas | So the dict shouldn't be needed | |
| 18:03:22 | bauzas | but again, in case libvirt would change it, I'm not sure it would continue to work | |
| 18:03:34 | bauzas | I can test it if you want | |
| 18:04:05 | dansmith | I think it would be better to not have a thing that can get out of sync, so if it's reasonable to PoC it, I think that's worth it | |
| 18:18:07 | sean-k-mooney | mnaser: i tought you might be interested in those | |
| 18:18:07 | sean-k-mooney | dansmith: bauzas so im very hesitent to addign even more reliance on the xmls | |
| 18:18:07 | sean-k-mooney | i have said this in the past that i woudl not have merged the orginal vgpu code that used the xmls to track what mdevs where in use | |
| 18:18:07 | sean-k-mooney | with that said i get dans concern about it getting out of sync | |
| 18:20:31 | sean-k-mooney | bauzas: the dict is needed because the pasued guest does not exist in pre-live-migrate | |
| 18:20:42 | sean-k-mooney | its only created by libvirt when we start the migration | |
| 18:21:08 | sean-k-mooney | so if we dont have the dict pre precreate the domain in pre live migrate on the dest we woudl have a rcace | |
| 18:21:39 | sean-k-mooney | so to remove the dict you need to add creating a domin | |
| 18:21:48 | sean-k-mooney | you shoudl not create a paused doamin however | |
| 18:22:08 | sean-k-mooney | jsut define it and create the approate cleanup codded for revert | |
| 18:22:49 | sean-k-mooney | just beause i strongly dislike what we do with the xml does not mean im -2 on replacing the dict with pre defineing a domian to reserve the mdev | |
| 18:22:57 | bauzas | sean-k-mooney: the target is automatically created by libvirt | |
| 18:23:09 | bauzas | and then paused | |
| 18:23:13 | sean-k-mooney | yes but only wehn we call migrate2URL | |
| 18:23:15 | bauzas | don't ask me how | |
| 18:23:23 | bauzas | sean-k-mooney: yup frow what I saw | |
| 18:23:26 | sean-k-mooney | it wont exist in pre-live migrate | |
| 18:23:30 | bauzas | indeed | |
| 18:23:34 | sean-k-mooney | so you cant jsut remove the dict | |