Earlier  
Posted Nick Remark
#openstack-nova - 2024-02-13
17:03:41 gmann dansmith: sean-k-mooney and rest of the patch in remove hyperv series
17:04:55 sean-k-mooney fwiesel: glance_store.default_store = file so ya thats odd it should be pulling the image form the rest api then
17:04:56 dansmith gmann: sorry I didn't realize I hadn't circled back on that one after you fixed the qemu thing
17:04:59 sean-k-mooney gmann: sure
17:05:14 gmann thanks
17:05:31 fwiesel sean-k-mooney: Yes, it is pulling it via the rest api from a local file. And the fun part is, cinder does the same and it works.
17:05:54 dansmith sean-k-mooney: maybe read my comment here: https://review.opendev.org/c/openstack/nova/+/906636/3/nova/tests/unit/objects/test_objects.py#b1105
17:06:40 sean-k-mooney dansmith: ya i saw that. i was personally fine with leave everythign after the virt driver remove for a later release
17:07:04 sean-k-mooney dansmith: so with https://review.opendev.org/c/openstack/nova/+/894466/3 merged we have removed the mvp
17:07:37 dansmith yeah
17:07:46 sean-k-mooney so if you want to keep HyperVLiveMigrateData that ok
17:07:56 dansmith although I'd say the doc patch should be considered mandatory
17:08:03 sean-k-mooney we can do the RDP console changes if we want even with out the object change
17:08:18 sean-k-mooney oh yes but that has +2w no?
17:08:39 sean-k-mooney ya it has so that just need to make it way through ci
17:08:49 dansmith sean-k-mooney: it does now, I'm just saying if you're talking about mvp, we should include not having docs about drivers that aren't in tree :)
17:09:10 sean-k-mooney :) yes your right
17:11:12 gmann but if we keep field and remove HyperVLiveMigrateData maybe that is fine?
17:11:38 gmann dansmith: forgot to reply there but I checked and that is what we did for xenapi driver removal
17:12:52 sean-k-mooney gmann: having the opbject has little to no maintance overhead
17:13:18 dansmith gmann: the xenbus object is still there.. what object are you talking about?
17:13:42 dansmith maybe the xen live migratedata?
17:14:47 gmann yeah live migration one was removed
17:14:48 gmann https://review.opendev.org/c/openstack/nova/+/749307
17:14:54 gmann this is what I checked
17:15:26 dansmith ack, I didn't review that :P
17:16:06 gmann k, we can keep that with a note to remove in later cycle after 1 or 2.
17:16:52 dansmith we can remove the xenbus module when we do :)
17:38:31 opendevreview Merged openstack/nova master: Remove HyperV: cleanup doc/code ref https://review.opendev.org/c/openstack/nova/+/906629
17:58:10 sean-k-mooney dansmith: by the way if you have time to start revieing melwitt serise i think most of the patches are in good shape
17:58:30 sean-k-mooney https://review.opendev.org/q/topic:%22specs/yoga/approved/ephemeral-encryption-libvirt%22+status:open+project:openstack/nova
17:58:56 dansmith yeah it's kinda half on my list, but I'm not sure I'll really be able to dive into it in detail
18:13:05 melwitt sean-k-mooney: ack, thanks for testing that
18:44:02 bauzas sean-k-mooney, dansmith : ok, I'm eventually done with testing my series, I'll provide the asciinema gif tomorrow
18:44:23 dansmith bauzas: updates needed to the set or good as is?
18:52:04 sean-k-mooney i started looking at the serise a littel to day but likely wont have time to review it till tomorrow
18:52:24 sean-k-mooney going though the vgpu serise is on my todo list for tomorrow before i loop back to melainies series
19:05:52 bauzas dansmith: nope, no need to change, we just need to set a large number for downtime but you will see it tomorrow ;-)
19:06:02 dansmith cool
19:06:57 bauzas the reason that qemu doesn't know about the right GPU memory, it just thinks that it needs to migrate 4GB
19:07:28 dansmith ack
19:27:49 opendevreview Ghanshyam proposed openstack/nova master: HyperV: Add todo to remove HyperVLiveMigrateData object https://review.opendev.org/c/openstack/nova/+/906636
19:28:09 opendevreview Ghanshyam proposed openstack/nova master: HyperV: Remove RDP console connection information API https://review.opendev.org/c/openstack/nova/+/906991
19:28:16 opendevreview Ghanshyam proposed openstack/nova master: HyperV: Remove RDP console API https://review.opendev.org/c/openstack/nova/+/906809
19:28:22 opendevreview Ghanshyam proposed openstack/nova master: HyperV: Remove extra specs of HyperV driver https://review.opendev.org/c/openstack/nova/+/906992
19:28:56 gmann dansmith: sean-k-mooney ^^ keeping hyperv object and rebased API change, please check
19:29:06 dansmith gmann: already done
19:29:18 gmann thanks, so fast :)
19:29:36 sean-k-mooney im just leaveing but ill do that then drop for today
19:30:27 gmann sean-k-mooney: thanks, and sorry for making it late for you
19:30:49 sean-k-mooney its normally not laste but i got up very early today
19:30:58 sean-k-mooney so no worries
19:37:41 sean-k-mooney gmann: ok im +2 on all of those they look ok assuming they also pass ci
19:47:13 opendevreview Merged openstack/nova stable/2023.1: tests: Use GreenThreadPoolExecutor.shutdown(wait=True) https://review.opendev.org/c/openstack/nova/+/908806
20:13:55 spatel I am getting strange nova-novncproxy error and not sure what is wrong. Everything was working but after restart nova-novncproxy it started throwing error - https://paste.opendev.org/show/baZjIpTcibpksgajegav/
20:25:15 opendevreview Ghanshyam proposed openstack/nova master: HyperV: Remove RDP console API https://review.opendev.org/c/openstack/nova/+/906809
20:25:24 opendevreview Ghanshyam proposed openstack/nova master: HyperV: Remove extra specs of HyperV driver https://review.opendev.org/c/openstack/nova/+/906992
23:04:51 gmann dansmith: ^^ updated it to keep RPC method
23:33:42 dansmith gmann: ack thanks
#openstack-nova - 2024-02-14
02:58:35 opendevreview Takashi Kajinami proposed openstack/os-traits master: Add a new trait for AMD SEV-ES https://review.opendev.org/c/openstack/os-traits/+/908966
02:59:55 opendevreview Takashi Kajinami proposed openstack/os-traits master: Add a new trait for AMD SEV-ES https://review.opendev.org/c/openstack/os-traits/+/908966
03:00:10 opendevreview Takashi Kajinami proposed openstack/os-traits master: Add a new trait for AMD SEV-ES https://review.opendev.org/c/openstack/os-traits/+/908966
03:02:34 opendevreview Takashi Kajinami proposed openstack/os-resource-classes master: Add MEM_ENCRYPTED_CONTEXT_V2 resource class https://review.opendev.org/c/openstack/os-resource-classes/+/908967
03:49:54 opendevreview Takashi Kajinami proposed openstack/os-resource-classes master: Add MEM_ENCRYPTED_CONTEXT_V2 resource class https://review.opendev.org/c/openstack/os-resource-classes/+/908967
05:36:21 opendevreview Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824
07:23:03 opendevreview Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824
07:37:41 opendevreview ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864
07:37:41 opendevreview ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194
07:37:42 opendevreview ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090
07:37:42 opendevreview ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075
07:37:43 opendevreview ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472
07:37:43 opendevreview ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500
07:37:44 opendevreview ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823
07:37:45 opendevreview ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824
07:37:45 opendevreview ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284
07:37:47 opendevreview ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285
07:37:47 opendevreview ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286
07:37:49 opendevreview ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287
07:37:49 opendevreview ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288
07:37:51 opendevreview ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862
07:37:51 opendevreview ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751
07:37:53 opendevreview ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340
07:37:53 opendevreview ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752
07:37:55 opendevreview ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830
07:37:55 opendevreview ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499
07:37:57 opendevreview ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753
07:37:57 opendevreview ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501
07:37:59 opendevreview ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028
07:37:59 opendevreview ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029
07:38:01 opendevreview ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282
07:38:01 opendevreview ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283
07:38:03 opendevreview ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086
07:38:03 opendevreview ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087
07:38:05 opendevreview ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642
08:04:34 opendevreview melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312
08:04:35 opendevreview melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754
08:04:35 opendevreview melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755
08:04:36 opendevreview melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934
08:04:36 opendevreview melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935
08:04:37 opendevreview melanie witt proposed openstack/nova master: libvirt: make a sub element of https://review.opendev.org/c/openstack/nova/+/905515

Earlier   Later