| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-01-22 | |||
| 12:58:39 | tkajinam | ah, ok. so this is not the first time we hit this | |
| 12:59:15 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 12:59:15 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck tracker to nova context https://review.opendev.org/c/openstack/nova/+/829468 | |
| 12:59:16 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 12:59:16 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 13:00:18 | tkajinam | frickler, I tested that requirement change and confirmed doc build now succeeds | |
| 13:00:20 | tkajinam | just fyi | |
| 13:00:45 | tkajinam | (I was concerned about potential conflicts with the other bumps but seems a simple and single downgrade works. nice | |
| 13:02:11 | frickler | tkajinam: yes, once I saw your comment I remembered that we had that thing before. thx for confirming it works, already approved 906262 | |
| 13:02:27 | tkajinam | frickler, thank you, too | |
| 13:49:40 | frickler | nova ppl please also check https://bugs.launchpad.net/ironic/+bug/2026345 related to the above | |
| 13:55:02 | bauzas | frickler: lookign | |
| 13:55:54 | bauzas | frickler: fwiw, now I've upgraded to F39 which defaults to py312, I need to target my docs and relnotes tox runs by capping them with py39 or py310 | |
| 13:56:04 | bauzas | and I saw some problem with Pillow due to some dependency | |
| 13:59:45 | frickler | sounds like we should add some py312 testing into requirements and elsewhere soon. I'm just not sure yet which distro to use for that. maybe I should start looking at some noble stuff, that would likely make sense for devstack, too | |
| 14:12:07 | bauzas | frickler: lemme know when we need to merge the new reqs patch in Nova (but I think we don't need it ) | |
| 14:13:14 | bauzas | yeah, Pillow is neither in reqs.txt or in test-reqs.txt | |
| 14:13:42 | opendevreview | Marius Leustean proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/c/openstack/nova/+/699176 | |
| 14:34:12 | bauzas | sean-k-mooney: fwiw, I reworded entirely the doc patch for the multi-vgpu-per_instance bugfix https://review.opendev.org/c/openstack/nova/+/906151/2 | |
| 14:34:34 | frickler | bauzas: that's not the point, stopping to use blockdiag seems to be what is needed | |
| 14:35:07 | bauzas | sean-k-mooney: long story short, I just say that SRIOV GPUs are fine, but you would need to do something else for non-SRIOV GPUs | |
| 14:35:43 | bauzas | frickler: well, if blockdiag is unmaintained, we may need to do this indeed | |
| 14:36:07 | bauzas | frickler: but nothing magically happens even if we wish it, we need some people to do the dirty work :) | |
| 14:36:41 | bauzas | so I can try to file a bug report but no promises we could change that shortly | |
| 14:37:29 | bauzas | (ideally, if many projects share the same usage of blockdiag, I'd certainly be happy if the TC could take a stance on that situation like they did with eventlet) | |
| 14:37:49 | bauzas | gmann: JayF: just sayin' ^ | |
| 14:44:00 | tkajinam | https://bugs.launchpad.net/ironic/+bug/2026345 | |
| 14:44:15 | tkajinam | bauzas, there is already a bug for it so you can use it | |
| 14:45:04 | bauzas | tkajinam: well, that one is for the pillow error | |
| 14:45:23 | bauzas | I'd like to track ourselves the fact that we're incented to move from blockdiag | |
| 14:45:43 | tkajinam | ok | |
| 14:46:39 | bauzas | there was a thread https://lists.openstack.org/pipermail/openstack-discuss/2023-July/034561.html | |
| 14:46:48 | bauzas | tkajinam: frickler: ^ | |
| 14:47:51 | tkajinam | afaik designate already replaced blockdiag by graphviz. however graphviz does not cover all of the use cases needed by ironic and now they are looking into plantuml. | |
| 14:48:00 | tkajinam | yeah I wasn't aware of that thread. thanks for sharing it. | |
| 14:49:19 | bauzas | well, we need to evaluate the required changes, but sean-k-mooney's suggestion to statically create the SVGs sounds to me the shortest and easiest path | |
| 14:51:28 | bauzas | hum, interesting | |
| 14:52:44 | bauzas | https://github.com/search?q=repo%3Aopenstack%2Fnova+blockdiag&type=code | |
| 14:52:54 | bauzas | the only place where we pull blockdiag is from conf | |
| 14:53:15 | bauzas | I'm not a doc expert, maybe stephenfin may help :) | |
| 14:54:02 | bauzas | stephenfin: tl;dr: blockdiag seems unmaintained and is broken due to a new Pillow release, do you know what's left in nova because we can remove it from sphinx's conf ? | |
| 14:54:08 | bauzas | before* | |
| 14:55:42 | JayF | We use it in ironic still. We've got folks working on replacements, but it's just on a long list of things with a short people to do them. | |
| 14:56:07 | JayF | Our weekly meeting is in 5 minutes I can see if anyone is actively committed to completing our retirement of blockdiag with any kind of timeline | |
| 14:58:21 | bauzas | JayF: nova's approach was to statically create the SVGs | |
| 14:58:44 | bauzas | JayF: apparently now we no longer *need* blockdiag | |
| 14:58:59 | bauzas | oh waiy | |
| 14:59:12 | bauzas | we need to statically create for seqdiag | |
| 14:59:39 | bauzas | https://github.com/search?q=repo%3Aopenstack%2Fnova+seqdiag&type=code | |
| 14:59:55 | bauzas | I can take that action | |
| 15:15:20 | bauzas | JayF: that may help you guys https://bugs.launchpad.net/tacker/+bug/2026345/comments/11 | |
| 15:15:42 | JayF | Ah, that's a good idea actually | |
| 15:15:47 | JayF | Hadn't even considered that | |
| 15:15:53 | JayF | Thanks! | |
| 16:04:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: GMR: Explicitly disable signal handleris in wsgi app https://review.opendev.org/c/openstack/nova/+/906279 | |
| 16:05:34 | opendevreview | Takashi Kajinami proposed openstack/nova master: GMR: Omit signal handleris in wsgi app https://review.opendev.org/c/openstack/nova/+/906279 | |
| 16:06:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: GMR: Omit signal handleris in wsgi app https://review.opendev.org/c/openstack/nova/+/906279 | |
| 17:10:18 | opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| 17:15:52 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 17:15:53 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 17:15:53 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 17:15:54 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 17:15:54 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 17:15:55 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 17:15:55 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 17:15:56 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 17:15:57 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 17:15:57 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 17:15:59 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 17:15:59 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 17:16:01 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 17:16:01 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 17:16:03 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 17:16:03 | opendevreview | ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340 | |
| 17:16:05 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | |
| 17:16:05 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 17:16:07 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499 | |
| 17:16:07 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 17:16:09 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 17:16:09 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 17:16:11 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 17:16:11 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 17:16:13 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 17:16:13 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 17:16:15 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 17:16:15 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 17:28:48 | opendevreview | Sylvain Bauza proposed openstack/nova master: doc: drop blockdiag usage https://review.opendev.org/c/openstack/nova/+/906309 | |
| 17:30:21 | bauzas | sean-k-mooney: gibi: let's drop blockdiag for now ^ | |
| 17:30:36 | bauzas | stephenfin: you may also be interested in https://review.opendev.org/c/openstack/nova/+/906309 | |
| #openstack-nova - 2024-01-23 | |||
| 01:11:18 | opendevreview | Takashi Kajinami proposed openstack/nova master: GMR: Omit signal handleris in wsgi app https://review.opendev.org/c/openstack/nova/+/906279 | |
| 06:28:50 | opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| 09:56:51 | bauzas | sean-k-mooney: gibi: stephenfin: could you please look at https://review.opendev.org/c/openstack/nova/+/906309 for removing our usage of blockdiag ? | |
| 10:58:55 | sean-k-mooney | we already did this for nova-specs so i dont see a reason not to do it for nova propper as well | |
| 10:59:49 | sean-k-mooney | there is one downside with using the image:: macro | |
| 11:00:05 | sean-k-mooney | whic is tha tthe svg wont be rendered in teh browser as a svg | |
| 11:00:13 | sean-k-mooney | it will use the html image tag | |
| 11:00:29 | sean-k-mooney | so extentions like dark reader wont be able ot recoler them properly | |
| 11:01:07 | sean-k-mooney | thats a minor annoyance that iu can live with but it is an accsiblity change | |
| 11:53:56 | opendevreview | Merged openstack/nova master: doc: drop blockdiag usage https://review.opendev.org/c/openstack/nova/+/906309 | |
| 12:14:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: [libvirt]log XML if nova fails to parse it https://review.opendev.org/c/openstack/nova/+/906364 | |