| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-12-28 | |||
| 18:59:46 | JayF | I'm mildly tempted to do a similar POC with black/ruff/autopep8 or a similar tool | |
| 19:01:31 | sean-k-mooney[m] | we use autopep8 | |
| 19:01:55 | sean-k-mooney[m] | we talked about black but so far its a hard no form some so not pushing that at the moment | |
| 19:02:26 | sean-k-mooney[m] | we are currently trying to move as much of this to precommit wih optional tox targets for those that dont wnt to use precommit | |
| 19:02:54 | sean-k-mooney[m] | ruff is very interesting although i dont know if its packaged widely | |
| 19:03:35 | sean-k-mooney[m] | usign pre-commit to run flake8 has similar effect in that it only checks the files you changed | |
| 19:03:56 | sean-k-mooney[m] | so it gives a nice speedup althogh im sure its still slower the ruff | |
| 19:04:26 | sean-k-mooney[m] | the main problem with ruff would be hacking i.e. hacking checks would still need to be run elsewhere or ported | |
| 19:06:02 | JayF | the only reason I'm considering autopep8 at all is Nova's use of it | |
| 19:06:20 | JayF | yep, that's basically the #1 primary reason why ruff makes me :( | |
| 19:07:33 | JayF | ruff has some neat features around autoupgrading and dropping old python compat code | |
| 19:08:06 | JayF | I think it could have some real utility in OpenStack if we could bridge that gap, but I do think it's a bit early in the lifecycle compared to most tools we'd pick up | |
| 19:10:37 | sean-k-mooney[m] | JayF: i proposed using pyupgrade for that for nova | |
| 19:10:55 | sean-k-mooney[m] | but people were kind of uncomfortable with that being used automtically | |
| 19:11:00 | sean-k-mooney[m] | so i abandoned the serise | |
| 19:11:38 | JayF | pyupgrade is nasty for a handful of reasons | |
| 19:11:43 | JayF | ruff is better designed but just younger | |
| 19:11:52 | JayF | pyupgrade only running on a per-file basis is really strange | |
| 19:12:32 | JayF | let me put it this way: pyupgrade is written in an extremely opinionated way, and CI-style tooling like that with strong opinions I find offputting, as opposed to things with knobs you can turn to make them work in different ways/environments/runners/etc | |
| 19:12:38 | sean-k-mooney[m] | pyupgarde is using the python ast and validating that the upgraded line has the same behavior | |
| 19:12:42 | JayF | you're already on pre-commit, so that probably was easily glossed over :) | |
| 19:13:27 | sean-k-mooney[m] | welll the way we have been trating this is if the linters would change the code then you reject the patch in ci | |
| 19:13:41 | sean-k-mooney[m] | and provide a way to run that same check locally before its submitted | |
| 19:13:46 | JayF | sean-k-mooney[m]: yeah, my complaints are mostly about the interface/style than they are about the technical aspects of it. It's a useful tool; but I'd never trust it in a CI environment or anywhere that a human would not review it afterwards | |
| 19:13:48 | sean-k-mooney[m] | with pre-commit or tox or both | |
| 19:14:22 | sean-k-mooney[m] | ya same we generally have a policy of nothing other than a huma should modify the code | |
| 19:14:51 | sean-k-mooney[m] | i.e. it not modifed after its reviewed before its submited | |
| 19:16:06 | sean-k-mooney[m] | anyway hopefully the ironic comunitiy will find codespell useful too | |
| 19:18:04 | sean-k-mooney[m] | JayF: on a different note, while im off im catching up on some python confernce videos ectra. i have been thinking about replaceing eventlet and lookign at https://anyio.readthedocs.io/en/stable/ as a possible lib to use if we are to prot off of eventlet | |
| 19:18:42 | JayF | I'm going to be completely honest and transparent with you: I'm maybe one of the worst folks to have this conversation with. | |
| 19:19:12 | JayF | I don't have a good mind for this style of programming or a lot of background on it, it's part of why I pulled in the big brains with that knowledge from GR-OSS to help with that stuff | |
| 19:19:52 | JayF | but I will say please lets pick the most vanilla basic implementation that 90% of everyone else is using, asyncio, trio, something like that, not another weirdo thing that someone will have to rescue next decade LOL | |
| 19:19:55 | sean-k-mooney[m] | well the thing is i dont really want most people to start writing low level asyncio or threaded code | |
| 19:20:31 | sean-k-mooney[m] | right so anyio provides trios api over trio or vanila ayncio | |
| 19:21:38 | sean-k-mooney[m] | trio and asyncio are not directly comtible. anyio give you taskgroups and cancelation_scopes(timeouts) form trio but on plain asyncio | |
| 19:21:55 | sean-k-mooney[m] | its also supports py38+ | |
| 19:22:14 | sean-k-mooney[m] | so while 3.11 has taskgroups anyio gives them to you on 3.8 | |
| 19:24:23 | sean-k-mooney[m] | anyway im going to go cooks something and chill for the evening o/ | |
| 19:25:31 | JayF | o/ have a good one | |
| #openstack-nova - 2023-12-29 | |||
| 01:40:47 | opendevreview | songjie proposed openstack/nova master: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/904183 | |
| 02:19:18 | opendevreview | sean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 02:21:53 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 03:19:08 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 03:22:10 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 03:26:11 | opendevreview | sean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 03:26:11 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 03:26:12 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 03:29:17 | opendevreview | sean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 03:29:18 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 03:29:18 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 03:30:55 | opendevreview | sean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 03:30:55 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 03:30:56 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 03:51:05 | opendevreview | sean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 03:51:05 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 03:51:06 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 10:07:45 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 15:25:58 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| 16:09:21 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| #openstack-nova - 2023-12-30 | |||
| 02:39:22 | opendevreview | sean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 02:39:23 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 02:39:23 | opendevreview | sean mooney proposed openstack/nova master: [WIP] remmove eventlet form nova api wsgi https://review.opendev.org/c/openstack/nova/+/904425 | |
| #openstack-nova - 2024-01-02 | |||
| 07:08:03 | opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| #openstack-nova - 2024-01-03 | |||
| 13:26:12 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing requested az in output https://review.opendev.org/c/openstack/nova/+/904568 | |
| 23:13:19 | opendevreview | melanie witt proposed openstack/nova master: Enable use of native threads in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | |
| #openstack-nova - 2024-01-04 | |||
| 01:45:19 | opendevreview | melanie witt proposed openstack/nova master: Enable use of native threads in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | |
| 03:15:02 | opendevreview | Ghanshyam proposed openstack/osc-placement master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/osc-placement/+/904612 | |
| 03:15:49 | opendevreview | Ghanshyam proposed openstack/os-vif master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/os-vif/+/904613 | |
| 03:27:06 | opendevreview | Ghanshyam proposed openstack/os-resource-classes master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/os-resource-classes/+/904614 | |
| 03:27:12 | opendevreview | Ghanshyam proposed openstack/os-traits master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/os-traits/+/904615 | |
| 03:27:29 | opendevreview | Ghanshyam proposed openstack/nova master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/nova/+/904616 | |
| 03:27:34 | opendevreview | Ghanshyam proposed openstack/python-novaclient master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/python-novaclient/+/904617 | |
| 03:27:40 | opendevreview | Ghanshyam proposed openstack/placement master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/placement/+/904618 | |
| 09:06:31 | songwenping__ | hi, team. my env run 'tox -e pep8' error with the error: 'An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')', any body can help? thanks. | |
| 09:11:11 | frickler | songwenping__: can you show some more context for that error? please use paste.opendev.org and show the resulting URL | |
| 09:12:23 | songwenping__ | yeah, i have pasted all info. | |
| 09:16:32 | frickler | pretty sure that single line isn't the complete output from running tox? | |
| 09:19:42 | songwenping__ | sorry, pasting to paste.opendev.org is error with 'Could not submit your paste because your paste contains spam'. | |
| 09:21:11 | songwenping__ | i am sending email now. | |
| 09:38:29 | frickler | songwenping__: that context really isn't too helpful, I agree. I also think introducing this opacity caused by the pre-commit wrapper wasn't a good decision by nova devs. can you check what happens when you run "/usr/bin/git fetch origin --tags" manually? | |
| 09:39:52 | songwenping__ | frickler: nothing return | |
| 09:53:46 | frickler | then I guess someone needs to find out how to turn on debugging for pre-commit, I'm out for that, sorry | |
| 09:55:23 | songwenping__ | thanks for help. | |
| #openstack-nova - 2024-01-05 | |||
| 07:09:03 | opendevreview | melanie witt proposed openstack/nova master: Reject (resize|rebuild) API requests with conflicting encryption https://review.opendev.org/c/openstack/nova/+/904240 | |
| 08:44:25 | opendevreview | Amit Uniyal proposed openstack/nova master: Fixes bug 2048184 https://review.opendev.org/c/openstack/nova/+/904817 | |
| 09:48:14 | opendevreview | Amit Uniyal proposed openstack/nova master: Fixes bug 2048184 https://review.opendev.org/c/openstack/nova/+/904817 | |
| 09:49:03 | opendevreview | songjie proposed openstack/nova master: Add id and name key when getting image_meta from volume https://review.opendev.org/c/openstack/nova/+/904197 | |
| 12:46:28 | opendevreview | songjie proposed openstack/nova master: Add id and name key when getting image_meta from volume https://review.opendev.org/c/openstack/nova/+/904197 | |
| 14:50:57 | opendevreview | Dan Smith proposed openstack/nova master: Support glance's new location API https://review.opendev.org/c/openstack/nova/+/891036 | |
| 14:50:58 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test glance new location api https://review.opendev.org/c/openstack/nova/+/891207 | |
| 16:38:58 | opendevreview | Gorka Eguileor proposed openstack/nova master: Fix guard for NVMeOF volumes https://review.opendev.org/c/openstack/nova/+/895192 | |
| #openstack-nova - 2024-01-06 | |||
| 05:12:10 | opendevreview | melanie witt proposed openstack/nova master: Enable use of native threads in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | |
| #openstack-nova - 2024-01-07 | |||
| 09:41:41 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 09:41:41 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 09:41:42 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 09:41:42 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 09:41:43 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 09:41:43 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 09:41:44 | opendevreview | melanie witt proposed openstack/nova master: Reject (resize|rebuild) API requests with conflicting encryption https://review.opendev.org/c/openstack/nova/+/904240 | |
| 09:41:44 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |