| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-12-19 | |||
| 17:21:51 | damiandabrowski | ahh my bad, thanks! | |
| 17:21:52 | damiandabrowski | https://paste.openstack.org/raw/bUwKEZg6FsylqJj4mDBi/ | |
| 17:21:57 | damiandabrowski | "availability_zone": null | |
| 17:22:11 | bauzas | strange | |
| 17:22:31 | bauzas | if you had cross_az_attach=False, then the reqspec should have been modified | |
| 17:22:40 | bauzas | by pinning to the volume AZ | |
| 17:22:57 | bauzas | sean-k-mooney: noted, will change too | |
| 17:24:35 | bauzas | damiandabrowski: sean-k-mooney: the path that's checking whether we should pin to an AZ for a volume https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L1268 | |
| 17:24:45 | JayF | bauzas: others; feedback from dtantsur in #openstack-ironic leads me to revise the ironic guest metadata spec to remove flavor since flavor name is volatile and can change while the instance is provisioned; in general can you consider us sending *less* fields to Ironic than listed in that spec an implementation detail? | |
| 17:25:05 | bauzas | JayF: yup, no worries | |
| 17:25:13 | sean-k-mooney | JayF: that why i was saying we should use the falvor uuid | |
| 17:25:13 | bauzas | we said all that meat is specless | |
| 17:25:25 | JayF | ack | |
| 17:25:35 | JayF | sean-k-mooney: that's not in the libvirt one today, fwiw | |
| 17:25:35 | bauzas | this is an implementation detail that will reviewed at time | |
| 17:25:52 | sean-k-mooney | JayF: yep i know thats an oversight i wanted to fix | |
| 17:26:07 | sean-k-mooney | we have access to it we are just not storing it right now | |
| 17:26:28 | sean-k-mooney | JayF: flavors are imuntable (extra_spec are not) | |
| 17:26:28 | JayF | ++ sounds good, we can easily do that with the centralization of that code | |
| 17:27:10 | sean-k-mooney | you can recarete a flavor with the same name as previously deleted one but you cant specify a uuid | |
| 17:28:20 | sean-k-mooney | JayF: with regards to updating the bluepint lets add a doc in the refernce/continbutor section | |
| 17:28:22 | dtantsur | JayF: I assume the flavor uuid only fixes a half of the problem: the flavor can deleted or (?changed?) | |
| 17:28:24 | sean-k-mooney | to detail how this works | |
| 17:28:50 | sean-k-mooney | dtantsur: it can be but that does not make the info useless | |
| 17:29:10 | dtantsur | sean-k-mooney: but isn't it the reason why nova provides neither name nor uuid in the newer API versions? | |
| 17:29:15 | JayF | sean-k-mooney: I don't know what that means? | |
| 17:29:42 | sean-k-mooney | JayF: while the flavor exist the uuid is useful for operator s to correalte nodes | |
| 17:30:27 | dtantsur | yeah, I don't see flavor UUID in https://docs.openstack.org/api-ref/compute/#show-server-details | |
| 17:30:29 | JayF | sean-k-mooney: the "doc in reference/contributor section" bit is what I don't understand | |
| 17:30:41 | sean-k-mooney | dtantsur: we provide flavor.original_name i server show | |
| 17:30:52 | JayF | If the flavor uuid/name isn't in Nova's API, it's not super useful in Ironic's API tbh | |
| 17:31:15 | JayF | and given there's a price to putting keys in that json field, if it's not cross-referenceable, I'd rather not send it | |
| 17:31:18 | damiandabrowski | bauzas: thanks, then something is off...I'll try to gather more details | |
| 17:31:24 | sean-k-mooney | JayF: it is in the api up to version 2.46 | |
| 17:31:39 | dtantsur | when you say flavor UUID, you mean its numerical ID? | |
| 17:31:46 | dtantsur | "The ID of the flavor. While people often make this look like an int, this is really a string."? | |
| 17:32:07 | sean-k-mooney | JayF: in 2.47 we addded flavor.original_name and remove flavor.name and flavor.id because they can be deleted but we cache a copy of hte flavor in the isntance_extra table when its created | |
| 17:32:32 | JayF | sean-k-mooney: so it sounds like that is probably information better left for the operator to lookup in nova api | |
| 17:32:46 | sean-k-mooney | dtantsur: flavor.id is a string filed that can be an int or any other sting. we generate a uuid if you dont provide one | |
| 17:33:18 | dtantsur | I"m curious, why don't you publish id yourself then? | |
| 17:33:26 | dtantsur | it's weird to add something to ironic that nova decided to remove | |
| 17:33:29 | opendevreview | Merged openstack/nova stable/zed: Translate VF network capabilities to port binding https://review.opendev.org/c/openstack/nova/+/899229 | |
| 17:33:33 | sean-k-mooney | we did and im not sure why we did keep it | |
| 17:33:44 | sean-k-mooney | but you can still get it usign the old microverion | |
| 17:33:58 | sean-k-mooney | im not sure why we dont have flavor.original_id | |
| 17:34:13 | dtantsur | yeah, this ^^^ | |
| 17:34:23 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | |
| 17:34:41 | bauzas | sean-k-mooney: gibi: updated based on sean-k-mooney's nice improvments | |
| 17:34:49 | JayF | Either way, it's clear the arrows of the "latest" version of the API is that this information is best looked up and kept in nova, if it's not a first class API object in Nova that's guaranteed to be there and/or Ironic is not going to cache the flavor like nova does | |
| 17:35:07 | JayF | this was going to be an easy win; it's not; so punt it and keep the metadata that is the easy wins IMO | |
| 17:35:29 | JayF | our API already has enough places with weird corners, this sounds like an easy place to avoid making another one | |
| 17:35:30 | sean-k-mooney | so looks like it was changed in pike https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id43 so there should be a spec | |
| 17:36:54 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html#proposed-change it jsut says it could be stale but i kind of think that was a mistake | |
| 17:37:22 | sean-k-mooney | JayF: ack i tought the falvor was the main motavator for this | |
| 17:37:34 | dtantsur | hold on. if a user can specify the uuid, cannot they specify a uuid of an already deleted flavor? | |
| 17:38:02 | JayF | sean-k-mooney: user_id/project_id is the primary motivator, to enable that next-step feature outlined in the blueprint (automatic_lessee) | |
| 17:38:27 | sean-k-mooney | first flavor are admin only. and yes looking at the api they can recreate a flavor wit hteh same id and name | |
| 17:38:46 | sean-k-mooney | JayF: oh ok | |
| 17:38:59 | sean-k-mooney | then sure feel free to exclude flavor or any other filed not useful to you | |
| 17:40:10 | sean-k-mooney | JayF: back to my docs comment we ahve refnece docs that detail some of the internal works of nova https://github.com/openstack/nova/tree/d28a55959e50b472e181809b919e11a896f989e3/doc/source/reference | |
| 17:40:16 | opendevreview | Merged openstack/nova stable/wallaby: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874069 | |
| 17:40:34 | JayF | sean-k-mooney: so you're saying "Ironic <> Nova API interactions" would be a good document for there, potentially | |
| 17:40:41 | JayF | sean-k-mooney: including a section on metadata passed over | |
| 17:40:47 | sean-k-mooney | JayF: they refence section is inteded for developers so i was suggesting adding a instance metadata doc ther that just says this si what ironic uses | |
| 17:41:00 | JayF | sean-k-mooney: even if that's not what you're saying, it's what I'm saying now, because it's a good idea and might make the ironic driver generally less scary | |
| 17:41:20 | sean-k-mooney | yep | |
| 17:41:49 | sean-k-mooney | so im fine fi the details change as part of the impleation as long as we documetn /test the expecte behavior so we know why | |
| 17:41:58 | sean-k-mooney | normally i woudl refer to the spec for those detail of intent | |
| 17:55:59 | opendevreview | Merged openstack/nova stable/2023.1: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/903840 | |
| 18:39:54 | sean-k-mooney | bauzas: +2 on https://review.opendev.org/c/openstack/nova-specs/+/900636 gibi if you agree can you +2w | |
| 22:57:07 | opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 22:57:07 | opendevreview | Jay Faulkner proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | |
| 22:57:08 | opendevreview | Jay Faulkner proposed openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | |
| 22:57:08 | opendevreview | Jay Faulkner proposed openstack/nova master: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/903917 | |
| #openstack-nova - 2023-12-20 | |||
| 00:54:10 | opendevreview | Merged openstack/nova-specs master: Enforce console session timeout https://review.opendev.org/c/openstack/nova-specs/+/898553 | |
| 01:45:25 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 01:45:25 | opendevreview | melanie witt proposed openstack/nova master: WIP Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 01:45:26 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 01:45:26 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 01:45:27 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 01:51:48 | sean-k-mooney[m] | melwitt: im going to sleep now but can you do a full rebase of the ephmeral encyption serise so we can start reviewing and merging the firest couple of patches? i would suggest putting them on top of stephenfin ‘s mypy patch to avoid the merge conflict | |
| 01:52:27 | melwitt | sean-k-mooney[m]: ok, sure | |
| 01:52:35 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/884312 need a recheck anyway so might as well just do a rebase of the serise and get fresh results for the seriese | |
| 01:53:12 | melwitt | ++ | |
| 03:42:12 | opendevreview | Artom Lifshitz proposed openstack/nova master: weights debug log: stop using tuples as dict keys https://review.opendev.org/c/openstack/nova/+/904060 | |
| 03:47:47 | opendevreview | Merged openstack/nova master: Remove deprecated [api] use_forwarded_for https://review.opendev.org/c/openstack/nova/+/903339 | |
| 03:47:59 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/903427 | |
| 03:50:38 | opendevreview | Merged openstack/nova master: Reproducer test of bug #1999674 https://review.opendev.org/c/openstack/nova/+/867807 | |
| 05:29:08 | opendevreview | Merged openstack/nova master: docs: fix 404 for ironic docs https://review.opendev.org/c/openstack/nova/+/887643 | |
| 05:43:13 | opendevreview | Merged openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088 | |
| 06:23:03 | opendevreview | Artom Lifshitz proposed openstack/nova master: weights debug log: stop using tuples as dict keys https://review.opendev.org/c/openstack/nova/+/904060 | |
| 07:41:33 | opendevreview | liwenjian proposed openstack/nova stable/2023.2: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904017 | |
| 07:42:08 | opendevreview | liwenjian proposed openstack/nova stable/2023.1: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904018 | |
| 07:44:26 | opendevreview | liwenjian proposed openstack/nova stable/zed: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904019 | |
| 07:44:47 | opendevreview | liwenjian proposed openstack/nova stable/yoga: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904020 | |
| 07:45:09 | opendevreview | liwenjian proposed openstack/nova stable/xena: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904081 | |
| 07:45:36 | opendevreview | liwenjian proposed openstack/nova stable/wallaby: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904082 | |
| 07:46:25 | opendevreview | liwenjian proposed openstack/nova stable/victoria: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904083 | |
| 07:49:44 | opendevreview | liwenjian proposed openstack/nova stable/victoria: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904083 | |
| 07:57:05 | opendevreview | liwenjian proposed openstack/nova stable/ussuri: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904084 | |