| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-12-14 | |||
| 15:09:35 | gibi | so that again resource tracker territory. But I got it that it is too big of a move | |
| 15:10:08 | gibi | so I drop my question about persistence | |
| 15:10:15 | gibi | an in memory dict is OK to me | |
| 15:11:33 | bauzas | fair enough | |
| 15:11:47 | JayF | Thanks gibi \o/ was quite a gift to wake up to the rest of that chain being not only approved but through the gate! | |
| 15:12:07 | bauzas | gibi: so we only have one open question about the conductor conf option | |
| 15:12:22 | bauzas | gibi: see my comment about it and all the alternatives | |
| 15:13:05 | gibi | JayF: it is almost Christmas anyhow :) | |
| 15:13:14 | gibi | bauzas: I'm on it | |
| 15:13:19 | bauzas | thanks | |
| 15:13:27 | JayF | Let me rebase my ironic<>nova driver bugfix and I'll add something else to my list ;) | |
| 15:13:35 | gibi | :) | |
| 15:25:40 | gibi | > We could avoid the pre-flight check that adds a conductor option and just | |
| 15:25:43 | gibi | assume to test the libvirt versions and the types during the pre-livemigration | |
| 15:25:46 | gibi | conductor checks that claim the resources. | |
| 15:26:08 | gibi | bauzas: does it mean we can do all our checks in pre-livemigration without the extra conductor option? | |
| 15:26:46 | gibi | if so then I vote for not having a conductor option and the the pre-livemigration do the checking | |
| 15:27:00 | gibi | pre-livemigration is there for many other checks like cpu compatibility | |
| 15:28:14 | gibi | bauzas: ^^ | |
| 15:39:58 | opendevreview | ribaudr proposed openstack/nova master: Reproducers for bug 1869804 https://review.opendev.org/c/openstack/nova/+/877772 | |
| 15:39:59 | opendevreview | ribaudr proposed openstack/nova master: Fix [backport]: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/877773 | |
| 15:39:59 | opendevreview | ribaudr proposed openstack/nova master: Fix: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/903706 | |
| 15:43:16 | bauzas | gibi: cool with me so | |
| 15:43:50 | bauzas | I'll doublecheck with the code if that would work, since we'll go to the target first | |
| 15:58:07 | gibi | bauzas: ack | |
| 15:58:29 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: scheduler: AggregateMultitenancyIsolation to support unlimited tenant https://review.opendev.org/c/openstack/nova/+/896512 | |
| 16:49:53 | opendevreview | Merged openstack/nova stable/2023.1: [pwmgmt]ignore missin governor when cpu_state used https://review.opendev.org/c/openstack/nova/+/903553 | |
| 16:50:00 | opendevreview | Merged openstack/nova master: Remove outdated comment about allocation ratios https://review.opendev.org/c/openstack/nova/+/900242 | |
| 16:55:49 | opendevreview | Pierre Riteau proposed openstack/nova stable/2023.2: Remove outdated comment about allocation ratios https://review.opendev.org/c/openstack/nova/+/903684 | |
| 17:29:19 | bauzas | gibi: doh, we missed the target for releasing your bugfix shortly by 1 hour | |
| 17:36:07 | gibi | bauzas: now worries | |
| 17:36:34 | gibi | bauzas: that is not a blocker until we start testing with cpu_dedicated_set | |
| 20:56:51 | opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| #openstack-nova - 2023-12-15 | |||
| 03:20:03 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/903427 | |
| 10:41:00 | opendevreview | Stephen Finucane proposed openstack/nova master: tox: Use pre-commit for pep8 target https://review.opendev.org/c/openstack/nova/+/896227 | |
| 10:41:01 | opendevreview | Stephen Finucane proposed openstack/nova master: pre-commit: Add mypy https://review.opendev.org/c/openstack/nova/+/896228 | |
| 10:41:01 | opendevreview | Stephen Finucane proposed openstack/nova master: pre-commit: Bump linter versions https://review.opendev.org/c/openstack/nova/+/903749 | |
| 11:51:05 | opendevreview | Merged openstack/nova stable/2023.2: Remove outdated comment about allocation ratios https://review.opendev.org/c/openstack/nova/+/903684 | |
| 12:00:07 | opendevreview | Pierre Riteau proposed openstack/nova stable/2023.1: Remove outdated comment about allocation ratios https://review.opendev.org/c/openstack/nova/+/903695 | |
| 12:35:47 | opendevreview | sean mooney proposed openstack/nova master: [codespell] fix final typos and enable ci https://review.opendev.org/c/openstack/nova/+/897214 | |
| 12:35:47 | opendevreview | sean mooney proposed openstack/nova master: [codespell] ignore codespell in git blame https://review.opendev.org/c/openstack/nova/+/897215 | |
| 12:50:59 | opendevreview | sean mooney proposed openstack/nova master: fix sphinx-lint errors in docs and add ci https://review.opendev.org/c/openstack/nova/+/897089 | |
| 12:51:00 | opendevreview | sean mooney proposed openstack/nova master: ignore sphinx-lint series in git blame https://review.opendev.org/c/openstack/nova/+/897218 | |
| 13:34:50 | zigo | stephenfin: Is there a 2/2 patch for this one ? https://review.opendev.org/c/openstack/heat/+/896025 | |
| 13:44:06 | stephenfin | Tes. It's listed on the Relation chain pane on the right | |
| 13:44:09 | stephenfin | *Yes | |
| 14:06:36 | zigo | Ah, right ... | |
| 16:34:33 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | |
| 16:43:03 | kashyap | bauzas: Hi, unrelated: I think this can be a specless-bp, agree? - https://blueprints.launchpad.net/nova/+spec/allow-disabling-ephemeral-disk-formatting | |
| 16:46:22 | kashyap | It came out of a discussion w/ Sean. No need to respond right away; can talk on Mon. | |
| 16:49:34 | bauzas | kashyap: you left but lemme log this : we can discuss this on a next nova meeting, like Tuesday | |
| #openstack-nova - 2023-12-16 | |||
| 03:08:57 | opendevreview | melanie witt proposed openstack/nova master: WIP Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 03:08:58 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 03:08:58 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 03:08:59 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 03:23:18 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 03:41:58 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 13:08:43 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova-specs master: [spec] Add Cross-AZ scheduling blueprint https://review.opendev.org/c/openstack/nova-specs/+/900296 | |
| 17:54:53 | opendevreview | Artom Lifshitz proposed openstack/nova master: Call Neutron immediately upon _post_live_migration() start https://review.opendev.org/c/openstack/nova/+/883682 | |
| 17:54:54 | opendevreview | Artom Lifshitz proposed openstack/nova master: Parallelize calls to Neutron and Cinder in post_live_migration https://review.opendev.org/c/openstack/nova/+/883678 | |
| 17:54:54 | opendevreview | Artom Lifshitz proposed openstack/nova master: Allow best effort sending of notifications https://review.opendev.org/c/openstack/nova/+/903807 | |
| #openstack-nova - 2023-12-17 | |||
| 02:05:08 | opendevreview | Artom Lifshitz proposed openstack/nova master: Call Neutron immediately upon _post_live_migration() start https://review.opendev.org/c/openstack/nova/+/883682 | |
| 02:05:09 | opendevreview | Artom Lifshitz proposed openstack/nova master: Allow best effort sending of notifications https://review.opendev.org/c/openstack/nova/+/903807 | |
| 02:05:09 | opendevreview | Artom Lifshitz proposed openstack/nova master: Parallelize calls to Neutron and Cinder in post_live_migration https://review.opendev.org/c/openstack/nova/+/883678 | |
| 13:37:23 | opendevreview | Artom Lifshitz proposed openstack/nova master: Allow best effort sending of notifications https://review.opendev.org/c/openstack/nova/+/903807 | |
| 13:37:23 | opendevreview | Artom Lifshitz proposed openstack/nova master: Parallelize calls to Neutron and Cinder in post_live_migration https://review.opendev.org/c/openstack/nova/+/883678 | |
| #openstack-nova - 2023-12-18 | |||
| 08:37:33 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | |
| 12:38:57 | opendevreview | sean mooney proposed openstack/nova master: add initial healthcheck support https://review.opendev.org/c/openstack/nova/+/825015 | |
| 13:24:55 | opendevreview | sean mooney proposed openstack/nova master: add initial healthcheck support https://review.opendev.org/c/openstack/nova/+/825015 | |
| 13:24:55 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 13:24:56 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck tracker to nova context https://review.opendev.org/c/openstack/nova/+/829468 | |
| 13:39:50 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 13:39:51 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 14:02:44 | bauzas | sean-k-mooney: gibi: fwiw, I'm about to start writing the series for the mdev live-migration RFE | |
| 14:04:55 | gibi | bauzas: good luck! | |
| 14:11:17 | opendevreview | Artom Lifshitz proposed openstack/nova master: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/444517 | |
| 14:38:35 | artom | melwitt, sean-k-mooney, gibi, btw, I updated https://review.opendev.org/c/openstack/nova/+/883682/ to hopefully reflect what was agreed on in the review comments | |
| 14:38:48 | artom | So now there's the notifications best effort patch on top: https://review.opendev.org/c/openstack/nova/+/903807/3 | |
| 15:07:29 | gibi | artom: thanks. Both looks good to me | |
| 15:08:28 | sean-k-mooney | artom: ack ill look at it shortly | |
| 15:09:30 | artom | Thank _you_! | |
| 16:29:02 | gibi | sean-k-mooney: if you have a moment later, then I verified https://review.opendev.org/c/openstack/nova/+/444517 and it solves the live-migration of paused instance when post-copy is configured in nova.conf. | |
| 16:29:13 | gibi | artom: ^^ \o/ | |
| 16:33:14 | kashyap | gibi: Also the "double live migration of a paused instance" thing - did you see that bz too? | |
| 16:33:30 | kashyap | Although, why would one want to run a double LM, though | |
| 16:34:11 | artom | gibi, ~~o~~ | |
| 16:34:19 | kashyap | "If a VM is in paused, and it live-migrated twice, it is lost" | |
| 16:34:21 | kashyap | https://bugs.launchpad.net/nova/+bug/1947725 | |
| 16:34:31 | kashyap | "Lost"? | |
| 16:35:04 | artom | Here instance instance, here boy! | |
| 16:46:47 | gibi | kashyap: I can try | |
| 16:55:33 | gibi | kashyap: nope, that but is still reproducible https://paste.opendev.org/show/bswQVIMJddVkrUtC1Pk0/ | |
| 16:56:55 | gibi | kashyap: but it make sens as the related qemu bug is also open https://gitlab.com/qemu-project/qemu/-/issues/686 | |
| 16:58:49 | kashyap | gibi: Ohh, I missed the attached QEMU bug | |
| 17:06:17 | artom | sean-k-mooney, so, tracing our snapshot upload call, we actually call it with a file handler for image_file/data | |
| 17:07:00 | artom | https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L3182 | |
| 17:07:09 | artom | https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L3176 | |
| 17:09:00 | artom | The thing is, on the sender side (Nova) passing a file handler to Python requests results in a streaming upload: https://docs.python-requests.org/en/latest/user/advanced.html#streaming-uploads | |
| 17:09:33 | artom | For chunks we have to use a generator or iterator: https://docs.python-requests.org/en/latest/user/advanced.html#chunk-encoded-requests | |
| 17:10:44 | sean-k-mooney | ack so we likely need a [glance]uplod_type=streaming|chunked config option | |