| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-11-15 | |||
| 15:06:44 | bauzas | honestly, I'm fine with using 'assert', we already have a few calls for it in Nova IIRC | |
| 15:07:31 | opendevreview | Dan Smith proposed openstack/nova master: Support setting alias on libvirt disks https://review.opendev.org/c/openstack/nova/+/892800 | |
| 15:07:32 | opendevreview | Dan Smith proposed openstack/nova master: Set libvirt device alias for volumes https://review.opendev.org/c/openstack/nova/+/892801 | |
| 15:07:32 | opendevreview | Dan Smith proposed openstack/nova master: Detach disks using alias when possible https://review.opendev.org/c/openstack/nova/+/893068 | |
| 15:07:32 | dansmith | me too | |
| 15:08:04 | dansmith | it's more that it might be used to parse any alias, and thus be surprising, but the intent was (of course) to only use it to extract the identifier out of the user-specified format | |
| 15:08:18 | dansmith | but when I start using that we can see what makes the most sense | |
| 15:13:21 | dansmith | sean-k-mooney: on the volume id thing, I think that what I was seeing was actually our retries after we detach a volume, we go back and look it up to make sure it's gone, | |
| 15:13:28 | bauzas | anyway, /me just looks at your new revision | |
| 15:13:37 | dansmith | and we'll always fall back to the "old way" because we don't find it via alias (because it's gone) | |
| 15:14:00 | sean-k-mooney | dansmith: ack gone form the trainistae domain right | |
| 15:14:08 | dansmith | so I changed how we do that log to only log if we found it via the old way but not the new way, so we'll see how that looks | |
| 15:14:10 | dansmith | sean-k-mooney: well, both | |
| 15:14:17 | sean-k-mooney | or or just gone because it was detached in between | |
| 15:14:37 | dansmith | gone because we do get_disk(); detach(); get_disk() | |
| 15:14:49 | sean-k-mooney | ah ya ok | |
| 15:14:55 | dansmith | the latter will always fail to find via alias (because it's gone) and try the fallback | |
| 15:15:06 | sean-k-mooney | yep that makes sense | |
| 15:17:04 | sean-k-mooney | dansmith: on the assert thing do we want to put that back in the gate and revisit when you use it later or were you going to respin that anyway | |
| 15:18:40 | bauzas | yeah, in the spec we said we would try to use the alias but we could still support the the previous behaviour | |
| 15:19:03 | bauzas | so, everything looks good to me here | |
| 15:19:08 | bauzas | but I could be wrong | |
| 15:20:51 | sean-k-mooney | i think dansmith just wanted to understand why they were seeing the log message when they were not expecting too and now with the new version wants to minimise the false positives | |
| 15:26:35 | dansmith | the assert is in code that isn't even used, so it's really irrelevant | |
| 15:26:55 | dansmith | I'd rather just merge it as-is and if we start using it on one way or the other we can add the assert back or not | |
| 15:26:59 | dansmith | unrelated to the log message | |
| 15:27:19 | dansmith | sean-k-mooney: and I already respun to do that | |
| 15:27:52 | sean-k-mooney | ack | |
| 15:32:21 | bauzas | sean-k-mooney: good call on the libvirt api not supporting to query per alias | |
| 15:32:28 | bauzas | that's sad at least | |
| 15:32:50 | bauzas | but I wonder, maybe we have a get device per alias | |
| 15:33:01 | sean-k-mooney | we as in nova | |
| 15:33:04 | sean-k-mooney | i dont think so | |
| 15:33:33 | sean-k-mooney | but we can always ask the virt folks if this exists elsewhere in the python lib | |
| 15:33:45 | bauzas | but I don't see anything in https://libvirt.org/html/libvirt-libvirt-nodedev.html | |
| 15:34:03 | bauzas | we have a cap flag but not an alias one | |
| 15:35:18 | bauzas | https://libvirt.org/html/libvirt-libvirt-nodedev.html#virConnectListAllNodeDevices doesn't know a single bit about aliases | |
| 15:41:18 | bauzas | actually, I'm wrong, nodedev is only for host devices, here we're talking of guest devices hence the domain API | |
| 15:52:16 | opendevreview | Merged openstack/nova stable/2023.2: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/900309 | |
| 15:53:04 | bauzas | one down, two to go | |
| 17:27:55 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 17:36:33 | bauzas | stephenfin: or other lords of mypy: could someone tell me how to tell f..k to mypy here https://review.opendev.org/c/openstack/nova/+/899625/4/nova/virt/libvirt/driver.py#7975 ? | |
| 17:36:50 | bauzas | mypy isn't able to infer that the variable will never be None in that case | |
| 17:38:03 | JayF | Does it need to be a Tuple[str, Optional[Any]]? | |
| 17:39:02 | melwitt | bauzas: I think it's just that you need to use a % there instead of a comma? | |
| 17:39:05 | JayF | Any implies none per https://mypy.readthedocs.io/en/stable/kinds_of_types.html#the-any-type | |
| 17:39:20 | bauzas | melwitt: not in LOG() | |
| 17:39:58 | melwitt | but you're assembling the message separately before calling LOG.blah(..., ..., ...) | |
| 17:40:11 | bauzas | JayF: I guess I'll need to annotate the first call | |
| 17:40:36 | JayF | I think melwitt is right | |
| 17:40:37 | melwitt | you could do LOG.warning("mdev type default already set to %s", self.pgpu_type_default) | |
| 17:40:41 | dansmith | sean-k-mooney: yep, that was the problem with the falling-back log message, so that top patch should be good :) | |
| 17:40:55 | bauzas | I can try | |
| 17:40:56 | melwitt | but if you're making the string beforehand the comma won't work. LOG is the thing that handles the comma | |
| 17:41:23 | stephenfin | yeah, what melwitt said. That would have introduced a bug | |
| 17:42:10 | bauzas | ok | |
| 17:42:25 | bauzas | respinning pep8 locally to see whether that fixes my problem | |
| 17:43:43 | bauzas | uh, actually that's a separate tox target | |
| 17:46:29 | stephenfin | iirc we run all linters as part of the pep8 env. mordred had an idea of renaming pep8 to linters across projects years ago but backed off the idea | |
| 17:46:37 | stephenfin | too much work, too little ROI | |
| 17:46:52 | JayF | Ah, so that's why it's inconsistent everywhere now :-| | |
| 17:47:02 | stephenfin | afraid so | |
| 17:47:47 | stephenfin | bauzas: btw, https://review.opendev.org/c/openstack/nova/+/899979 is waiting for your doc eyes when you get a chance. There are references to AZs in there that melwitt thought you might have opinions on | |
| 17:49:01 | bauzas | stephenfin: ack, a bit overloaded as of now, but I'll look at it tomorrow morning | |
| 17:49:10 | stephenfin | nw, thanks (y) | |
| 18:12:21 | admin1 | > i accidentally mapped an IP to a wrong node .. i deleted it from inventory and compute service .. and gave the correct node to the IP .. but when i provision it, it still comes up wiht the old hostname .. which nova/placement table holds this record so that i can map the uuid to the correct hostname | |
| 19:27:33 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 19:58:16 | mgariepy | hmm any pointer on : Migration pre-check error: Unacceptable CPU info: CPU doesn't have compatibility ? | |
| 19:58:29 | mgariepy | same server model cpu memory and all | |
| 19:58:40 | mgariepy | with 2023.1 release. | |
| 20:10:50 | opendevreview | Merged openstack/nova stable/2023.2: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/900338 | |
| 20:17:07 | mgariepy | hmm like this one : https://bugs.launchpad.net/nova/+bug/2039803 | |
| 20:38:45 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 21:26:30 | opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| #openstack-nova - 2023-11-16 | |||
| 01:01:34 | songwenping | hi, team. nova-conductor services block at starting after the control nodes' network reset(stop and start for 5min), what's the reason and any guys got this? | |
| 08:31:14 | gibi | mgariepy: you might hit by https://bugs.launchpad.net/nova/+bug/2039803 | |
| 09:43:38 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/900306 | |
| 09:43:39 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/900336 | |
| 09:43:40 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: Adding server actions tests to grenade-multinode https://review.opendev.org/c/openstack/nova/+/900337 | |
| 09:53:33 | bauzas | elodilles: thanks for taking care of the RPC backports | |
| 10:18:14 | elodilles | np :) | |
| 10:19:10 | bauzas | elodilles: as a reminder, we'll need to modify the main change when backporting to Zed since one of the two modifications are related to a new RPC version that was added in Antelope | |
| 10:19:58 | elodilles | bauzas: i had only a quick look at the zed version, but yes, i saw that there should be a conflict | |
| 10:20:44 | elodilles | though as i saw probably it's trivial to resolve (famous last words? :)) | |
| 10:35:36 | bauzas | elodilles: probably, I can take a look when I have time | |
| 11:23:40 | opendevreview | Mark Goddard proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 11:23:40 | opendevreview | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 12:03:04 | dvo-plv | sean-k-mooney, I write to you regarding your comment https://review.opendev.org/c/openstack/nova/+/876075/27/nova/api/validation/extra_specs/hw.py#540 | |
| 12:03:27 | dvo-plv | I found this doc https://review.opendev.org/c/openstack/glance/+/882133/3/doc/source/admin/useful-image-properties.rst | |
| 12:04:10 | dvo-plv | but i can not find glance metadada and flavor extra spec which I have to extend | |
| 12:04:17 | sean-k-mooney | ah right you have done this already | |
| 12:04:38 | sean-k-mooney | dvo-plv: you have already done it in https://review.opendev.org/c/openstack/glance/+/882133/3/etc/metadefs/compute-libvirt.json | |
| 12:04:48 | sean-k-mooney | that patch has everything you need to do in glance | |
| 12:05:23 | sean-k-mooney | dvo-plv: all that is missing is the nova doc update to document the extra spec | |
| 12:05:32 | dvo-plv | okay, I will test gibi's comments and update nova patch | |
| 12:05:42 | sean-k-mooney | that is done in the user/flavor.rst doc | |
| 12:06:07 | dvo-plv | soory, i did not get | |
| 12:06:52 | sean-k-mooney | your current nova patch does not update doc/source/user/flavor.rst | |
| 12:07:11 | sean-k-mooney | * doc/source/user/flavors.rst | |
| 12:07:35 | sean-k-mooney | we list all the extra specs there https://github.com/openstack/nova/blob/master/doc/source/user/flavors.rst#extra-specs | |