| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-11-13 | |||
| 14:26:48 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | |
| 14:32:02 | sean-k-mooney | zigo: wrong channel | |
| 14:32:29 | zigo | ok :) | |
| 14:32:35 | sean-k-mooney | im not sure about hte while true: | |
| 14:32:43 | zigo | I am. | |
| 14:32:51 | sean-k-mooney | that might never exit | |
| 14:32:53 | zigo | There's a break ... | |
| 14:33:02 | sean-k-mooney | there is only if you get an indexError | |
| 14:33:16 | zigo | Which is going to happen when all connections have been closed. | |
| 14:33:31 | sean-k-mooney | no | |
| 14:33:39 | zigo | queue.pop() will return nothing... | |
| 14:33:49 | zigo | I mean, will do an IndexError no? | |
| 14:33:50 | sean-k-mooney | it returns None by default no? | |
| 14:34:02 | sean-k-mooney | which will cause an AtributeError when we defernce the connection | |
| 14:34:05 | zigo | tkajinam wrote it, he may tell. | |
| 14:34:26 | zigo | At first, I wrote: | |
| 14:34:26 | zigo | while ( conn = self.queue.pop().connection ) != None: | |
| 14:35:05 | sean-k-mooney | https://docs.python.org/3/library/collections.html#collections.deque.pop | |
| 14:35:22 | sean-k-mooney | ok pop does raise indexerror if its empty | |
| 14:35:50 | sean-k-mooney | i was expeciting it to reutrn a default like get on a dict | |
| 14:37:05 | sean-k-mooney | zigo: i still dont partically like useign excptions as contolflow but i see why this is working | |
| 14:38:02 | zigo | I was surprised at first too. Probably this only deserves some added code comments ... | |
| 14:38:16 | sean-k-mooney | zigo: i still feel like it might be better to have a timeout but i see why you want it to wait | |
| 14:38:32 | zigo | A timeout ?!? | |
| 14:38:39 | zigo | You mean wait until the CLOSE_WAIT times out ? | |
| 14:38:57 | zigo | That is a crazy idea. One of our server doesn't even have source port available because of this. | |
| 14:39:08 | zigo | Also, we reach the memcached max open sockets very fast. | |
| 14:39:12 | sean-k-mooney | no | |
| 14:39:26 | sean-k-mooney | i mean perhasp we shoudl not try to clsoe the connections indefintly | |
| 14:40:02 | zigo | If we don't, then there's some remaining sockets in CLOSE_WAIT state. | |
| 14:40:03 | tkajinam | the logic loops over all connections in the queue but it does not retry for a single one | |
| 14:40:16 | sean-k-mooney | oh your right | |
| 14:40:19 | tkajinam | in case a connection closure fails then it leaves that one and process the next | |
| 14:40:24 | sean-k-mooney | if we cant close it its already poped | |
| 14:40:31 | tkajinam | yeah | |
| 14:40:32 | sean-k-mooney | so we will at most try each connection once | |
| 14:40:36 | sean-k-mooney | ok yep | |
| 14:40:45 | sean-k-mooney | so ya i agree the patch is correct then | |
| 14:41:29 | zigo | tkajinam: Are you ok if I add some more comments in your patch? | |
| 14:41:56 | tkajinam | you can though we have number of similar implementations in the other places in that single file | |
| 14:42:15 | tkajinam | anyway this is not the right channel and we can continue it in #openstack-oslo | |
| 14:42:55 | sean-k-mooney | i +1'd it for what its worth | |
| 14:43:07 | sean-k-mooney | and i +2'd the voting job changes | |
| 14:43:20 | tkajinam | sean-k-mooney, thanks ! | |
| 14:48:30 | sean-k-mooney | while true: and excptions as contol flow are redflags for me | |
| 14:48:54 | sean-k-mooney | zigo: so if i see either i try to take a closer look and ensure the will exit in all cases | |
| 14:49:18 | sean-k-mooney | unless there i s a comment explinaing ny this shoudl run forever or simialr | |
| 14:49:43 | zigo | Agreed, it's not very natural. | |
| 14:50:06 | zigo | Though there's a lot of valid cases in this world. | |
| 14:50:29 | zigo | Example: the wait for event loop in every single X-Window app ... :) | |
| 14:54:07 | sean-k-mooney | i alwasy implemnt those in terms of a var that is set to true but can be set to false by the app | |
| 14:54:09 | sean-k-mooney | but yes | |
| 15:06:10 | tkajinam | zigo, as I said earlier the same snippet is used multiple times in the same file. If you add a comment then it should be added to the all places. If you fix it then you should fix all. | |
| 15:06:56 | dvo-plv | hello, hello | |
| 15:07:23 | dvo-plv | I wouldl ike to suggest this spec for review https://review.opendev.org/c/openstack/nova-specs/+/895924 | |
| 15:07:29 | dvo-plv | If you will have a time | |
| 15:07:30 | tkajinam | zigo, hmm. ignore it. it might be the only place where that hack is used for loop | |
| 17:15:21 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further tweaks to the CPU models document https://review.opendev.org/c/openstack/nova/+/784066 | |
| 17:22:43 | opendevreview | Robert Franzke proposed openstack/nova stable/zed: fix: server rebuild not working during zed upgrade https://review.opendev.org/c/openstack/nova/+/900811 | |
| 18:49:43 | opendevreview | Elod Illes proposed openstack/nova stable/2023.2: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/900338 | |
| 18:49:44 | opendevreview | Elod Illes proposed openstack/nova stable/2023.2: Adding server actions tests to grenade-multinode https://review.opendev.org/c/openstack/nova/+/900339 | |
| 19:23:36 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/900821 | |
| 19:25:15 | opendevreview | melanie witt proposed openstack/nova stable/xena: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/900822 | |
| 19:30:05 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/900821 | |
| 23:05:32 | opendevreview | melanie witt proposed openstack/nova stable/xena: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/900822 | |
| 23:25:29 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 23:26:46 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/900832 | |
| 23:34:00 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| #openstack-nova - 2023-11-14 | |||
| 01:13:26 | opendevreview | melanie witt proposed openstack/nova stable/zed: Fix exception catch when volume mount fails https://review.opendev.org/c/openstack/nova/+/900835 | |
| 01:14:13 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Fix exception catch when volume mount fails https://review.opendev.org/c/openstack/nova/+/900836 | |
| 01:14:58 | opendevreview | melanie witt proposed openstack/nova stable/xena: Fix exception catch when volume mount fails https://review.opendev.org/c/openstack/nova/+/900837 | |
| 01:15:44 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Fix exception catch when volume mount fails https://review.opendev.org/c/openstack/nova/+/900838 | |
| 01:37:54 | opendevreview | melanie witt proposed openstack/nova stable/2023.2: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900840 | |
| 01:38:34 | opendevreview | melanie witt proposed openstack/nova stable/2023.1: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900841 | |
| 01:39:30 | opendevreview | melanie witt proposed openstack/nova stable/zed: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900842 | |
| 01:40:04 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900843 | |
| 01:40:30 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900843 | |
| 01:40:56 | opendevreview | melanie witt proposed openstack/nova stable/xena: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900844 | |
| 01:41:37 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Improve logging at '_numa_cells_support_network_metadata' https://review.opendev.org/c/openstack/nova/+/900845 | |
| 05:41:55 | hamidlotfi_ | Good morning. | |
| 05:43:25 | hamidlotfi_ | I want to remove a controller node from the OpenStack cluster, how do that? | |
| 05:44:15 | hamidlotfi_ | What are the steps to do it? I didn't see anything in the documents. | |
| 05:47:12 | hamidlotfi_ | I am using the zed/26.1 version. | |
| 06:25:23 | hamidlotfi_ | @noonedeadpunk @jrosser | |
| 06:39:23 | art | Good morning | |
| 06:43:29 | hamidlotfi_ | Sorry, I posted this message here by mistake. | |
| 09:27:09 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Enforce console session timeout https://review.opendev.org/c/openstack/nova-specs/+/898553 | |
| 15:13:12 | bauzas | reminder: nova meeting in 47 mins here | |
| 15:43:11 | opendevreview | Dan Smith proposed openstack/nova master: Support setting alias on libvirt disks https://review.opendev.org/c/openstack/nova/+/892800 | |
| 15:43:11 | opendevreview | Dan Smith proposed openstack/nova master: Set libvirt device alias for volumes https://review.opendev.org/c/openstack/nova/+/892801 | |
| 15:43:12 | opendevreview | Dan Smith proposed openstack/nova master: Detach disks using alias when possible https://review.opendev.org/c/openstack/nova/+/893068 | |
| 16:00:26 | bauzas | #startmeeting nova | |
| 16:00:26 | opendevmeet | Meeting started Tue Nov 14 16:00:26 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:26 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:26 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:39 | elodilles | o/ | |
| 16:00:42 | bauzas | I was about to write 'startmeeting nvidia' | |
| 16:00:48 | elodilles | :S | |
| 16:00:52 | bauzas | ETOOMANYTHINGS | |
| 16:00:53 | dvo-plv | o/ | |