| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-10-10 | |||
| 17:57:50 | sean-k-mooney | so nova has two modes of opertation | |
| 17:57:58 | sean-k-mooney | you can either precreate the mdevs and it will use them | |
| 17:58:06 | sean-k-mooney | or it will create tehm if you dont | |
| 17:58:38 | sean-k-mooney | but ya from a qemu/libvirt point of view i think that means its workign | |
| 17:58:51 | dansmith | sweert | |
| 18:03:43 | sean-k-mooney | oh right it was out of tree.. | |
| 18:07:05 | sean-k-mooney | for what its worht this is how you boot a vm in nova with hardware offloaded networkign using mdev before that is merged in qemu/libvirt/the kernel https://github.com/openstack/nova/commit/13de00c20477189201f102499cc6451f47765c5c | |
| 18:10:43 | sean-k-mooney | that is not relevent beyond the fact i was checkign how we configured the mdevs and vf via the devstack plugin | |
| 18:10:45 | sean-k-mooney | https://github.com/intel-orchestration-software/networking-vhost-vfio/blob/master/devstack/libs/vhost-vfio#L367-L393 | |
| 18:11:12 | sean-k-mooney | so we just allocated the vf on the defice and created the mdevs dymically in nova | |
| 18:11:33 | sean-k-mooney | so not really relevent in this case since there are no vfs to allcoate | |
| 18:22:15 | tobias-urdin | any good idea's on how one should handle cputune.shares issues on stable releases? https://bugs.launchpad.net/nova/+bug/1978489 – last comment in https://gitlab.com/libvirt/libvirt/-/issues/161 aged well "...I think this problematic change is only now starting to hit people" oh yes it will :) | |
| 18:22:15 | tobias-urdin | any good idea's on how one should handle cputune.shares issues on stable releases? https://bugs.launchpad.net/nova/+bug/1978489 – last comment in https://gitlab.com/libvirt/libvirt/-/issues/161 aged well "...I think this problematic change is only now starting to hit people" oh yes it will :) | |
| 18:45:25 | sean-k-mooney | we partly fixed this | |
| 18:45:38 | sean-k-mooney | we stopped generating implcit cpu shares in zed i belvie | |
| 18:45:50 | sean-k-mooney | and we basically say dont use the explit ones | |
| 18:46:00 | sean-k-mooney | we have not removed/depreated the feature entirly | |
| 18:46:14 | sean-k-mooney | simply because we have never done that before | |
| 18:46:41 | sean-k-mooney | but perfonslly i would fix it by deprecateing them on master for caracal and delete the feature in D | |
| 18:46:52 | sean-k-mooney | tobias-urdin: proably not waht you want to hear so the more helpful answer is | |
| 18:47:42 | sean-k-mooney | you need to reize today before you upgrade | |
| 18:47:56 | sean-k-mooney | we could also add a nova manage command liek https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L3211 | |
| 18:48:09 | sean-k-mooney | to allow updating the embded flavor extra specs | |
| 18:48:20 | sean-k-mooney | that not negerally safe but in this case it is | |
| 19:05:39 | tobias-urdin | thanks, yeah it was an interesting read for sure and something i completely missed last year | |
| 19:06:28 | tobias-urdin | imo the approach taken in libvirt is pretty bad, im kinda sad it wasn't better handled at all in https://gitlab.com/libvirt/libvirt/-/issues/161 either | |
| 19:07:25 | tobias-urdin | fortunately is that we dont set it as extra specs but we do however have large instances that will be impacted just based on the cpu.shares value being greater than the limit there | |
| 19:07:53 | tobias-urdin | so for us on yoga i guess i'll just have to carry that patch until i'm on zed, shouldn't be that long | |
| 19:11:53 | tobias-urdin | im just a little bit scared about the impact for large instances removing that entirely but i guess i dont have a choice, i felt like scaling the value for cgroupv2 in cputune.shares and introducing a new cputune.weight was more elegant, anyway | |
| #openstack-nova - 2023-10-11 | |||
| 10:49:08 | whoami-rajat | bauzas, hey, i was planning to keep a cross project meeting with nova regarding the topic https://etherpad.opendev.org/p/caracal-ptg-cinder-planning#L50 | |
| 10:50:01 | whoami-rajat | bauzas, let me know when would be a good time for the same | |
| 11:37:51 | sean-k-mooney | elodilles: can i add https://review.opendev.org/c/openstack/nova/+/865334 and the following 5 patches to your review radar. tthey have all merged on xena so the wallaby backports are all that is left to close out those backport series | |
| 11:54:28 | elodilles | sean-k-mooney: ACK, will review them shortly | |
| 11:55:26 | bauzas | whoami-rajat: hey, sorry quite busy today, sorry for the late reply | |
| 11:55:35 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/865571 | |
| 11:55:41 | bauzas | whoami-rajat: I'm open to any dates, you're the first to ask :) | |
| 11:56:27 | bauzas | I'd prefer if we could stick with a common timeslot for both nova and cinder, but we can book another room if needed | |
| 11:57:05 | whoami-rajat | bauzas, great, sure, how about wednesday 1600 utc? | |
| 11:57:19 | bauzas | cool with me | |
| 11:58:36 | whoami-rajat | thanks, let me know if there are any topics from nova side for cross project and i will add it to our etherpad | |
| 11:58:40 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/865571 | |
| 11:59:17 | bauzas | whoami-rajat: cool, I'll mark it also in our etherpad | |
| 11:59:28 | bauzas | whoami-rajat: I'll leave you host the session :) | |
| 11:59:39 | bauzas | your etherpad, your room :D | |
| 11:59:57 | whoami-rajat | bauzas, sounds good to me! | |
| 12:01:01 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/865572 | |
| 12:01:02 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | |
| 12:01:03 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | |
| 12:01:38 | sean-k-mooney | elodilles: there was a pep8 issue in one of the patches in the middle so i just fixed that and cherrypicked the follow on patches ^ | |
| 12:01:52 | sean-k-mooney | so we will need to wait for ci in anycase so no rush | |
| 12:02:38 | sean-k-mooney | the first 2 should be fine the 3rd patch and an extra new line | |
| 12:10:01 | elodilles | sean-k-mooney: OK, i'll add it then to my TODO :) it's a big nice pack of backports as i see, fixing multiple bugs if i'm not mistaken :) | |
| 12:12:50 | sean-k-mooney | yep they have been sitting for a while so the new ci runs probaly dont hurt | |
| 12:13:13 | sean-k-mooney | they are all related to device passthough so vdpa+sriov+vgpu | |
| 12:16:40 | elodilles | sean-k-mooney: ACK, i had a commit message nit for the 2nd patch until zuul is back with the results for the rests | |
| 12:31:55 | sean-k-mooney | elodilles: if you like i can adress that and just rebase all the rest on the tip of stable | |
| 12:32:13 | sean-k-mooney | i intentonlly did not chagne the orgianl base so there are a littel behind | |
| 12:32:30 | sean-k-mooney | they should not have merge conflict but it never hurts to actully have them rebased | |
| 12:35:38 | elodilles | sean-k-mooney: ACK, then please do o:) | |
| 13:03:16 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/865334 | |
| 13:03:17 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/865336 | |
| 13:03:18 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/865571 | |
| 13:03:19 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/865572 | |
| 13:03:20 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | |
| 13:03:21 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | |
| 13:03:39 | sean-k-mooney | ok commit message updateand and trivial rebase to the tip of stable | |
| 13:04:02 | sean-k-mooney | as i said no rush they have just been sitting ther a while | |
| 13:08:56 | elodilles | sean-k-mooney: thanks! added them to my TODO! | |
| 13:21:26 | sean-k-mooney | dansmith: im +2w on https://review.opendev.org/q/topic:extra-rename-check | |
| 13:21:57 | sean-k-mooney | all nice enhancements | |
| 13:31:17 | bauzas | shit, forgot to do my round of reviews | |
| 13:38:45 | dansmith | sean-k-mooney: thanks | |
| 14:04:50 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Update disk.info in finish_migration https://review.opendev.org/c/openstack/nova/+/897842 | |
| 14:48:05 | opendevreview | Dan Smith proposed openstack/nova master: Compile mdev samples for nova-next https://review.opendev.org/c/openstack/nova/+/897708 | |
| 15:41:33 | opendevreview | Dan Smith proposed openstack/nova master: Compile mdev samples for nova-next https://review.opendev.org/c/openstack/nova/+/897708 | |
| 15:48:03 | opendevreview | Merged openstack/nova master: Sanity check that new hosts have no instances https://review.opendev.org/c/openstack/nova/+/897076 | |
| 17:12:58 | opendevreview | Dan Smith proposed openstack/nova master: Compile mdev samples for nova-next https://review.opendev.org/c/openstack/nova/+/897708 | |
| #openstack-nova - 2023-10-12 | |||
| 03:35:28 | opendevreview | sean mooney proposed openstack/nova master: refactor numa claims https://review.opendev.org/c/openstack/nova/+/898056 | |
| 03:37:40 | opendevreview | sean mooney proposed openstack/nova master: refactor numa claims https://review.opendev.org/c/openstack/nova/+/898056 | |
| 04:29:02 | opendevreview | sean mooney proposed openstack/nova master: imporve nova object logging https://review.opendev.org/c/openstack/nova/+/898057 | |
| 09:08:20 | tobias-urdin | sean-k-mooney: when you have some seconds, based on https://review.opendev.org/c/openstack/nova/+/824048 and the issue from libvirt down expressed in https://gitlab.com/libvirt/libvirt/-/issues/161 I assume it would be thrown upon implementing the workaround in the nova layer by checking for cgroupsv1/cgroupsv2 and reintroducing the default | |
| 09:08:20 | tobias-urdin | cputune.shares value based on that (lets ignore the live migration part of it now and just focus on "having the correct value" based on the crazy decision made in libvirt).. any thoughts on that? | |
| 09:40:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: add mtty support for vgpus https://review.opendev.org/c/openstack/nova/+/898100 | |
| 12:46:31 | bauzas | dansmith: I know that's too early for you but my devstack fails on your mtty patch https://paste.opendev.org/show/bwpHZPMuePifFk0JWi7v/ (just reply when you want) | |
| 12:46:38 | bauzas | sean-k-mooney: ^ | |
| 12:47:53 | bauzas | actually the whole stack is here https://paste.opendev.org/show/bLirDAMuGmxhLLod0S9p/ | |
| 12:49:19 | bauzas | stack@sbauza-dev2:~/devstack$ cat /etc/lsb-release | |
| 12:49:19 | bauzas | DISTRIB_ID=Ubuntu | |
| 12:49:19 | bauzas | DISTRIB_RELEASE=22.04 | |
| 12:49:19 | bauzas | DISTRIB_CODENAME=jammy | |
| 12:49:20 | bauzas | DISTRIB_DESCRIPTION="Ubuntu 22.04.1 LTS" | |
| 12:49:35 | bauzas | stack@sbauza-dev2:~/devstack$ uname -r | |
| 12:49:35 | bauzas | 5.15.0-1037-kvm | |
| 13:19:21 | frickler | bauzas: is there some linux-modules-extra pkg for that kernel? | |
| 13:22:22 | dansmith | bauzas: looks like maybe it has module symbols from a different kernel | |
| 13:22:37 | dansmith | since it failed to create /opt/stack/kernel .. did you run it once, upgrade kernel, run again? | |
| 13:36:29 | bauzas | dansmith: it didn't failed to create kernel | |
| 13:36:37 | bauzas | (sorry was on a meeting) | |
| 13:36:39 | dansmith | didn't fail? | |
| 13:36:52 | dansmith | ++/opt/stack/nova/devstack/lib/mdev_samples:compile_mdev_samples:19 mkdir /opt/stack/kernel | |