| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-09-26 | |||
| 16:22:46 | bauzas | sorry, I missed to review a couple of them | |
| 16:22:55 | bauzas | my karma went down I assume | |
| 16:23:27 | elodilles | you can review patches there later ;) | |
| 16:23:33 | elodilles | #info all stable gates should be OK, though not much activity on stable branches these days | |
| 16:23:46 | elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:24:07 | elodilles | in case anyone finds any gate issue ^^^ | |
| 16:24:26 | bauzas | thanks | |
| 16:24:29 | elodilles | np | |
| 16:24:41 | bauzas | #topic Open discussion | |
| 16:24:57 | bauzas | nothing written, anything anyone in mind ? | |
| 16:25:41 | bauzas | well, if so, let's conclude our meeting | |
| 16:25:45 | bauzas | thanks all | |
| 16:25:49 | bauzas | #endmeeting | |
| 16:25:49 | opendevmeet | Meeting ended Tue Sep 26 16:25:49 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:25:49 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-09-26-16.00.html | |
| 16:25:49 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-09-26-16.00.txt | |
| 16:25:49 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-09-26-16.00.log.html | |
| 16:25:52 | elodilles | o/ | |
| 16:26:26 | auniyal | dansmith, can you please review these https://review.opendev.org/c/openstack/nova/+/893587/2 | |
| 16:27:02 | gibi | bauzas: thank you | |
| 16:27:35 | bauzas | np, always | |
| 16:28:08 | dansmith | auniyal: just all test refactors for the sake of it? | |
| 16:28:29 | auniyal | yes | |
| 16:28:54 | auniyal | its divided in 3 though, | |
| 16:30:04 | dansmith | probably not necessary to ping for that kind of thing.. just add me as a reviewer and I'll try to look sometime, but not today | |
| 16:30:25 | auniyal | ack, | |
| 16:45:29 | bauzas | saying out loud, we may want to tell operators which specs we implemented this cycle https://review.opendev.org/c/openstack/nova-specs/+/895815 | |
| 16:45:51 | bauzas | collecting +2s :) | |
| 17:05:13 | gmann | bauzas: 1 comment about ironic-shards BP, rest all lgtm | |
| 17:06:03 | bauzas | well, I tagged it 'Implemented' in Launchpad | |
| 17:06:09 | bauzas | it's half-implemented :) | |
| 17:06:17 | bauzas | since we left the deprecation | |
| 17:06:21 | gmann | yeah, I got confused with revert and LP status | |
| 17:09:34 | gmann | bauzas: I mean if all things mentioned in the spec are not implemented then we should not mark as Implemented or we update the spec in case of half implementation - https://review.opendev.org/c/openstack/nova-specs/+/862833 | |
| 17:10:08 | gmann | I remember we have updated the specs in such cases to match the spec documentation and actual implemetation | |
| 20:16:13 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Remove Hyper-V driver https://review.opendev.org/c/openstack/nova-specs/+/896592 | |
| #openstack-nova - 2023-09-27 | |||
| 01:57:38 | opendevreview | Natz cheng proposed openstack/os-vif master: cleanup py27 support https://review.opendev.org/c/openstack/os-vif/+/896598 | |
| 07:08:59 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: scheduler: AggregateMultitenancyIsolation to support unlimited tenant https://review.opendev.org/c/openstack/nova/+/896512 | |
| 08:47:22 | dvo-plv | Hello, All | |
| 08:48:00 | dvo-plv | Maybe you will have a chance to take a look on the reproposed spec file ? https://review.opendev.org/c/openstack/nova-specs/+/895924 | |
| 08:48:32 | dvo-plv | and check dependent patch for it https://review.opendev.org/c/openstack/nova/+/876075 | |
| 09:28:30 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: scheduler: AggregateMultitenancyIsolation to support unlimited tenant https://review.opendev.org/c/openstack/nova/+/896512 | |
| 10:09:33 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds device tagging functional tests https://review.opendev.org/c/openstack/nova/+/895162 | |
| 10:20:40 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds device tagging functional tests https://review.opendev.org/c/openstack/nova/+/895162 | |
| 11:02:38 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds device tagging functional tests https://review.opendev.org/c/openstack/nova/+/895162 | |
| 11:02:38 | opendevreview | Amit Uniyal proposed openstack/nova master: Device tags: don't pass pf_interface=True to get_mac_by_pci_address https://review.opendev.org/c/openstack/nova/+/670593 | |
| 11:02:39 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: Device tagging: expose target PCI address, not source https://review.opendev.org/c/openstack/nova/+/672127 | |
| 12:32:26 | stephenfin | bauzas: Can you look at https://review.opendev.org/c/openstack/placement/+/886229 and https://review.opendev.org/c/openstack/placement/+/888281 when you get a chance? (SQLAlchemy 2.x stuff) | |
| 12:32:44 | bauzas | stephenfin: yeah I'll try | |
| 12:37:10 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Workaround SQLAlchemy 2.x bug https://review.opendev.org/c/openstack/placement/+/888281 | |
| 12:37:11 | opendevreview | Stephen Finucane proposed openstack/placement master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/placement/+/886229 | |
| 12:37:11 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Wrap raw SQL query in sqlalchemy.text https://review.opendev.org/c/openstack/placement/+/896650 | |
| 12:58:50 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix the libvirt.images_type value in KVM docs https://review.opendev.org/c/openstack/nova/+/896651 | |
| 13:00:01 | bauzas | stephenfin: ack, thanks for the quick respins, will check | |
| 14:33:44 | sahid | o/ I have proposed a change for the filter AggregateMultiTenancyFilter, I have reused what we do in placement | |
| 14:33:50 | sahid | https://review.opendev.org/c/openstack/nova/+/896512 | |
| 14:34:15 | sahid | can you just tell whether that looks to be in the right direction for you guys? | |
| 14:35:08 | bauzas | I'll try | |
| 14:36:48 | sahid | thank you | |
| 14:53:23 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: explain why ironic-shards was reverted in the spec https://review.opendev.org/c/openstack/nova-specs/+/896679 | |
| 14:58:05 | opendevreview | Stephen Finucane proposed openstack/placement master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/placement/+/886229 | |
| 14:59:45 | opendevreview | Dan Smith proposed openstack/nova-specs master: Add libvirt-dev-alias spec https://review.opendev.org/c/openstack/nova-specs/+/892806 | |
| 15:01:54 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Wrap raw SQL query in sqlalchemy.text https://review.opendev.org/c/openstack/placement/+/896650 | |
| 15:01:59 | opendevreview | Stephen Finucane proposed openstack/placement master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/placement/+/886229 | |
| 18:51:35 | mnaser | https://bugs.launchpad.net/nova/+bug/2037585 -- does deleting neutron ports in a specific order sound like a reasonable fix here? | |
| 18:51:46 | mnaser | if so i can push that proposal | |
| 19:30:59 | greatgatsby | Hi. I was asking before about our compute aggregates become out of sync with the resource provider aggregates. We had it happen again last night, and I've found a PUT /resource_providers/<uuid>/aggregates in the logs at the time we detected them out of sync. What service or state might trigger this update on its own? I've been grepping through logs most of the day, but still haven't found what | |
| 19:30:59 | greatgatsby | triggers this to happen. | |
| 19:31:12 | greatgatsby | thanks *a lot* for any help | |
| 19:31:52 | JayF | greatgatsby: just curious, are the resources in question Ironic nodes? | |
| 19:33:35 | greatgatsby | thanks for the reply. No ironic, we pxe boot and use ansible for config | |
| 19:33:59 | JayF | ack; sorry I won't be much help then as that's my specialty; good luck! | |
| 19:34:10 | greatgatsby | thanks :-) | |
| 19:34:58 | dansmith | greatgatsby: nova-api will do that in response to creating or deleting aggregates on the nova side | |
| 19:35:06 | dansmith | nothing else should be doing that, AFAIK | |
| 19:35:20 | dansmith | can you trace the origin with a req-id or source ip? | |
| 19:36:32 | greatgatsby | source ip in one case came from the controller that lost the resource provider aggs. The nova aggs have never changed (or at least, we haven't changed them, and they stay consistent) | |
| 19:36:59 | greatgatsby | so, for example, compute 1 will still have the correct linux agg on the nova side, but it disappears on the resource provider side | |
| 19:37:06 | greatgatsby | this happened late last night | |
| 19:38:55 | greatgatsby | in one PUT message I see "nova-compute keystoneauth1/4.5.0 python-requests...." | |
| 19:41:12 | dansmith | "from the controller that lost the aggregates" doesn't mean anything to me | |
| 19:41:19 | dansmith | do you mean from a compute node? | |
| 19:41:41 | greatgatsby | oops, sorry, yes, the compute | |
| 19:42:01 | dansmith | there is some aggregate-manipulation that happens in the provider tree stuff now that I'm not familiar enough to speak about without some study | |
| 19:42:08 | dansmith | so must be something related to that I guess | |
| 19:42:27 | dansmith | best option would be to chat with gibi in his morning (central EU) | |
| 19:43:40 | dansmith | is the uuid in the PUT /resource_providers/uuid/aggregate the uuid of that same compute node? | |
| 19:43:50 | greatgatsby | yes, exactly | |
| 19:44:19 | greatgatsby | it's the only PUT to the resources providers and only to that specific node | |
| 19:45:28 | dansmith | I really didn't think that any of the computes would be adjusting their own aggregate membership, so that seems weird to me | |
| 19:45:40 | dansmith | is there something in the compute log that matches that timestamp? | |
| 19:47:51 | greatgatsby | there probably is, but I haven't found it. I've been grepping through logs all day. I just check the nova_api aggregates table in the database, the creation time is still months old, so they didn't get recreated. Updated is NULL though. | |
| #openstack-nova - 2023-09-28 | |||
| 07:45:32 | gibi | greatgatsby, dansmith: based on my serach the only code that writes aggregates to placement is the report client's set_aggregates_for_provider() https://github.com/openstack/nova/blob/87d4807848bb9546c1fca972da2eb2eda13eb08d/nova/scheduler/client/report.py#L1122 | |
| 07:46:02 | gibi | we call that during nova aggregate manipulation but you said that is not happening | |
| 07:46:22 | gibi | so I ignore those places now | |
| 07:47:03 | gibi | we call that from update_from_provider_tree() as well that is the codepath dansmith refers to above | |
| 07:49:25 | gibi | that will basically flush the nova-compute's internal caches (the provider tree) back to placement | |
| 07:50:12 | gibi | so we need to track down what updates aggregates in that cache | |
| 07:52:29 | sahid | o/ | |
| 07:53:04 | sahid | any issue with our ci, it looks like zull did not pass completely for https://review.opendev.org/c/openstack/nova/+/896512 | |