Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-07-14
11:37:40 noonedeadpunk I don't see how it can be related to the patch itself though...
14:48:44 opendevreview Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339
15:25:41 auniyal hi dansmith, regarding context is not targeted and context cell uuid is None; as we need admin context if cell_uuid is presentI think we should raise AdminRequired exception
15:26:00 auniyal is it okay ? or only Exception ?
15:33:06 dansmith auniyal: admin has nothing to do with being targeted or not, so I'm not sure what you mean.. this is always using an empty admin context, no?
16:17:01 auniyal context.target_cell(context.get_admin_context(), im.cell_mapping)
16:17:57 auniyal dansmith^^, we use admin context for same
16:40:29 dansmith auniyal: right.. I'm still not sure what you're asking
16:42:26 auniyal I need to raise an Exception of context.cell_uuid is not correct, as this context is made by admin context; I think possible case would be caller did not create it using admin context
16:43:01 auniyal so its appropriate to raise AdminRequired exception
16:46:52 dansmith auniyal: no, I do not think that's reasonable
16:47:04 auniyal ack
16:47:32 auniyal so then Exception('targetcell is not correct') ?
16:48:07 dansmith admin is not even required (for the locking) and you don't need to get *another* context in there like you're doing, right? Use the targeted context that you're being passed
16:48:31 dansmith auniyal: just do 'assert cctxt.cell_uuid is not None' and that's it
16:48:40 dansmith it'll raise AssertionError if that fails
16:49:12 auniyal okay, thanks dansmith
16:58:14 opendevreview Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446
17:09:40 sean-k-mooney dansmith: im going to call it a day but im +2w on all but the second last patch. you can see the comment inlien but i think it would be good to add a release not to that and think about docs or a nova-staus check for unmapped instnaces
17:09:54 dansmith yep was just replying
17:10:41 dansmith sean-k-mooney: thanks for all that and I'll hit the reno and status check next week
17:14:53 sean-k-mooney if your going to do that as a fllow up ill upgrade to +2 and we can see about landing the core part today/monday
17:21:13 dansmith up to you, it's already missing a +2 from bauzas so ...
17:21:30 dansmith I'm fine with leaving it, it's a lot closer than it was yesterday thanks to you, so I'm satisfied :)
18:45:34 opendevreview Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339
22:18:27 opendevreview melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509
22:41:40 opendevreview Merged openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904
#openstack-nova - 2023-07-17
01:26:56 opendevreview efineshi proposed openstack/nova master: Not destroy the vm as it migrate back before evacuate clean https://review.opendev.org/c/openstack/nova/+/887564
06:27:55 opendevreview suzhengwei proposed openstack/nova-specs master: spec: evacuate api return migration https://review.opendev.org/c/openstack/nova-specs/+/888101
11:20:40 opendevreview sean mooney proposed openstack/nova master: Remove deprecated AZ filter. https://review.opendev.org/c/openstack/nova/+/886779
11:22:33 opendevreview sean mooney proposed openstack/nova master: Remove deprecated AZ filter. https://review.opendev.org/c/openstack/nova/+/886779
11:22:55 sean-k-mooney stephenfin: thanks for the review nits adressed and rebased :)
11:23:42 sean-k-mooney dansmith: gmann if ye are devstack cores can ye look at https://review.opendev.org/c/openstack/devstack/+/886972 to unblock ^
11:45:18 opendevreview Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648
11:45:19 opendevreview Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446
11:50:11 auniyal Hi sean-k-mooney
11:50:17 auniyal regarding AZ filter removal from devstack
11:50:25 auniyal after devstack deployment tempest tests runs right ? so we need to remove AZ test from tempest as well?
11:50:34 sean-k-mooney no
11:50:42 auniyal oh okay, thanks
11:50:43 sean-k-mooney i replied to your comment
11:50:51 sean-k-mooney we are not removing the az support
11:50:57 sean-k-mooney we have 2 implematnions
11:51:03 sean-k-mooney we are just remvoing the older one
11:51:09 sean-k-mooney the same functionality exits
11:51:24 sean-k-mooney so there is no visable change form tempest
11:51:32 auniyal ack
12:14:59 opendevreview Elod Illes proposed openstack/nova stable/victoria: [stable-only] Cap virtualenv/setuptools https://review.opendev.org/c/openstack/nova/+/888681
13:18:05 opendevreview Elod Illes proposed openstack/nova stable/victoria: [stable-only] Cap virtualenv/setuptools https://review.opendev.org/c/openstack/nova/+/888681
14:37:41 opendevreview Merged openstack/nova master: db: Avoid relying on autobegin https://review.opendev.org/c/openstack/nova/+/880668
15:06:53 opendevreview Kashyap Chamarthy proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Bobcat" https://review.opendev.org/c/openstack/nova/+/887255
15:16:08 kashyap gibi: Hey, later when you get a min, with the latest revision of the above, this UT is still failing for me: test_compare_cpu_aarch64_skip_comparison
15:16:29 kashyap (Since you have the env locally, I'd appreciate a second look. Don't worry if you're short on time; I'll take a deeper look tomm)
15:43:34 gibi kashyap: please ping me tomorrow
15:43:47 kashyap Sure, thx!
15:59:02 melwitt sean-k-mooney: I dunno if you remember this but awhile back someone reported a bug downstream where they got a "QueuePool limit of size 5 overflow 50 reached, connection timed out, timeout 30.00" database error after calling the os-extra_specs API repeatedly over time. I think I figured out what was causing it and proposed a patch here https://review.opendev.org/c/openstack/nova/+/888513 I didn't include test coverage bc I'm not sure
15:59:02 melwitt how to test that ... feel free to suggest if you know a way
16:03:32 sean-k-mooney i vaguly recall that but not the details
16:16:04 gmann sean-k-mooney: just saw your message and devstack change is merged already. ping me anything else pending on devstack side
16:34:19 sean-k-mooney gmann: cool i think if that is merge to stop addign it by default we can proceed on the nova side
16:48:50 dansmith melwitt: I've been seeing an increase in frequency of that mkfs timeout thing lately...
16:49:48 melwitt dansmith: me too. I feel like I see it hit most changes. do you always see it in test_stamp_pattern or any other test? I tried a tempest change to add "no discard" to the command and it didn't help
16:50:31 dansmith melwitt: yep that's the one I just saw fail, not sure if the others are the same or not
16:50:46 dansmith this one I did see IO errors in the console log though,
16:50:55 dansmith so perhaps it's something more going on than just the discard thing
16:51:07 dansmith [ 289.096098] Buffer I/O error on dev vdb, logical block 6, lost async page write
16:51:14 melwitt dansmith: this was the change I tried https://review.opendev.org/c/openstack/tempest/+/886991 I have never seen it hit any other test. and I don't see what is unique about this test to be the only one exhibiting this?
16:51:25 dansmith ack
16:52:51 melwitt there's definitely something else going on than discard imho but I hadn't noticed the IO errors
16:53:58 melwitt the test isn't trying to do anything weird, I'm stumped as to why it's only test_stamp_pattern
16:54:13 dansmith yeah
16:55:52 dansmith Jul 17 16:01:08 np0034696204 kernel: iSCSI Login timeout on Network Portal 10.209.97.252:3260
16:57:03 dansmith several iscsi errors there in the log
16:57:58 dansmith do you have another example log to look at? this one was nova-multi-cell and it was on the compute worker node in the syslog around the time of the failure
16:59:52 gmann sean-k-mooney: lgtm, one question regarding copy/mentioning the upgrade notes to next SLURP release https://review.opendev.org/c/openstack/nova/+/886779/4/releasenotes/notes/az-filter-removal-587f7337040b6216.yaml#2
17:00:24 gmann I am not sure we have figured that out in TC but in case we need to tag/make a note somehere to remember it for C release
17:13:01 gmann sean-k-mooney: I am +1 and can convert to +2 as ^^ should not be blocker for it. just bringing it here and in TC also to finalize the guidelines. added this in next TC meeting agenda
17:14:04 melwitt dansmith: maybe this one https://zuul.opendev.org/t/openstack/build/f8734471732246aaab8a8c41e3761af3/logs
17:15:17 melwitt and I had opened this bug about it and put an opensearch query in the first comment https://bugs.launchpad.net/tempest/+bug/2024859
17:20:13 dansmith melwitt: yeah that one has the login timeout message in the controller's syslog
17:20:18 gmann sean-k-mooney: can you check this again as you were +2 already. I asked ykarel to change the exception type to raise (after checking meeting discussion I am ok now to raise exception instead of warning) https://review.opendev.org/c/openstack/nova/+/868419
17:20:20 dansmith so that could be the common link
17:31:26 sean-k-mooney gmann: it depend if we raise and excption we woudl ant it to stop the agent form startign right
17:31:49 sean-k-mooney i think that is ok for invalid config i.e. enabling this if the min version is not met
17:38:40 opendevreview Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284
17:48:11 auniyal hi elodilles
17:48:11 auniyal here https://review.opendev.org/c/openstack/nova/+/882914
17:48:11 auniyal you meant until "enable validations in nova-lvm" get merged in zed right ?
17:48:11 auniyal this: https://review.opendev.org/q/Ia198f712e2ad277743aed08e27e480208f463ac7
17:51:50 auniyal dansmith , melwitt can these get merged https://review.opendev.org/q/Ia198f712e2ad277743aed08e27e480208f463ac7 ?
17:54:14 melwitt auniyal: yeah I can review
19:35:35 opendevreview Merged openstack/nova stable/wallaby: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/888333
19:37:33 elodilles auniyal: yes, those are the gate fixing patches
19:50:11 auniyal thanks melwitt, ack elodilles
19:50:47 auniyal stable/2023.1 will be merged in some time, can you please merge this as well - https://review.opendev.org/c/openstack/nova/+/888230
19:57:08 auniyal melwitt, regarding your comment https://review.opendev.org/c/openstack/nova/+/873648/comment/e8d05cbb_aa954e91/ in "Added context manager for instance lock" as per lyarwood Note we need to create new context to unlock the instance.
19:59:06 melwitt auniyal: yeah, we'll do that one next
19:59:52 melwitt auniyal: oh, hm. sorry I didn't notice that comment, on the surface, I'm not sure why we would need or want a new request-id for the unlock
20:00:07 melwitt so let me think on that for a bit
20:00:23 auniyal ack, thanks, will fix rest meanwhile

Earlier   Later