| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-06-27 | |||
| 16:48:05 | sean-k-mooney | it does not | |
| 16:48:11 | sean-k-mooney | i provided 2 suggestsions | |
| 16:48:22 | sean-k-mooney | return max_instace- current | |
| 16:48:32 | bauzas | sean-k-mooney: okay, so you would be okay if _weigh_object() would just do -1 * host_state.num_instances ? | |
| 16:48:32 | sean-k-mooney | or return current * -1.0 | |
| 16:48:42 | sean-k-mooney | yep | |
| 16:48:50 | sean-k-mooney | tottaly fine with that | |
| 16:48:52 | gibi | The -1.0 one works for me. I would not complicate it with the max-instance | |
| 16:49:23 | bauzas | sean-k-mooney: as I said in https://review.opendev.org/c/openstack/nova/+/886232/comment/565abda0_70ab7fde/ we already have negative values for spreading | |
| 16:49:29 | bauzas | https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.io_ops_weight_multiplier | |
| 16:49:43 | sean-k-mooney | yep i pointed that out to you in the review | |
| 16:50:02 | sean-k-mooney | and noted that its unforturneate because its teh opisctie behavior of the cpu ram and disk weighers | |
| 16:50:17 | sean-k-mooney | and i didnt want to proliferate that by adding more useage | |
| 16:50:33 | sean-k-mooney | but as i also said its just a prefrence if other dont mind then fine | |
| 16:50:37 | bauzas | okay, if really you want it to be positive, then I'll just multiply by -1.0 | |
| 16:51:01 | bauzas | but I'm not sure it's really a problem to have a negative value for spreadinh | |
| 16:51:23 | bauzas | anyway, looks to me an implementation nit | |
| 16:51:24 | sean-k-mooney | it just makes it harder to reason about | |
| 16:51:35 | sean-k-mooney | if it would not break peopel i would change the io_ops_weigher | |
| 16:51:39 | bauzas | do people agree on having https://blueprints.launchpad.net/nova/+spec/num-instances-weigher to be specless ? | |
| 16:51:40 | sean-k-mooney | but its really not worth it | |
| 16:51:41 | dansmith | I wasn't aware we had any sort of weigher convention where one value means pack or spread | |
| 16:51:47 | dansmith | bauzas: yes, specless | |
| 16:51:55 | sean-k-mooney | ya specless is good with me | |
| 16:52:00 | bauzas | cool, then we'll revisit this conversation in gerrit | |
| 16:52:09 | sean-k-mooney | ack | |
| 16:52:09 | dansmith | I've heard you say that, but I've never heard that before | |
| 16:52:10 | bauzas | anyone fancy to review the code itself | |
| 16:52:18 | dansmith | I guess I'll have to go look at the existing weighers and see | |
| 16:52:23 | bauzas | dansmith: I can't remember it too | |
| 16:52:42 | bauzas | in general our weighers have different default values | |
| 16:52:45 | gibi | +1 on specless | |
| 16:52:59 | bauzas | like https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.build_failure_weight_multiplier | |
| 16:53:03 | dansmith | bauzas: yeah I thought they were all pretty much individually contextual | |
| 16:53:09 | bauzas | which defaults to 1000000.0 | |
| 16:53:10 | sean-k-mooney | in generall they all spread by default and positive measn spread. those are the two ruels of tumb i learend early on | |
| 16:53:21 | bauzas | anyway | |
| 16:53:28 | sean-k-mooney | if we broke that at some poin thats unfortunet btu its what we are stuck with | |
| 16:53:39 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/num-instances-weigher is approved as a specless bp | |
| 16:53:47 | gibi | \o/ | |
| 16:53:55 | bauzas | I guess we can continue this in gerrit :!) | |
| 16:53:57 | bauzas | :) | |
| 16:54:34 | bauzas | okay, so I don't see any other item | |
| 16:54:42 | bauzas | anyone wanting to discuss on something ? | |
| 16:55:41 | bauzas | thanks :) | |
| 16:55:50 | Uggla_ | :) | |
| 16:56:01 | bauzas | I guess I'll need to stop sooner than later | |
| 16:56:06 | bauzas | anyway | |
| 16:56:09 | bauzas | thanks all | |
| 16:56:11 | bauzas | #endmeeting | |
| 16:56:11 | opendevmeet | Meeting ended Tue Jun 27 16:56:11 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:56:11 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-06-27-16.01.html | |
| 16:56:11 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-06-27-16.01.txt | |
| 16:56:11 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-06-27-16.01.log.html | |
| 16:57:10 | bauzas | three machines and two screens running in a 9m2 room doesn't help with the temperature FWIW :) | |
| 17:30:14 | gmann | bauzas: sean-k-mooney elodilles gibi: about EM, TC will be discussing about EM as concept and how to solve the issue of maintenance expectation. Oldest/er EM branch(es) moving to EOL as per normal process/some blocker or project decision is all good to go. | |
| 17:35:24 | elodilles | gmann: ack, thanks for the info! | |
| 17:35:59 | dansmith | ++ | |
| 17:37:14 | gibi | gmann: thanks | |
| 17:42:17 | NobodyCam | Good morning Nova folks, Would anyone happen to know if there is a list of status messages emitted by Nova??? I am look to see if there are events for rescue | |
| 17:45:12 | NobodyCam | I found them "rescue.start" & "rescue.end" | |
| 17:48:02 | dansmith | NobodyCam: this might help: https://github.com/openstack/nova/tree/master/doc/notification_samples | |
| 17:49:42 | NobodyCam | Thank you dan. that is very helpful! | |
| 17:49:53 | NobodyCam | s/d/D/ | |
| 18:39:13 | opendevreview | Amit Uniyal proposed openstack/os-vif stable/wallaby: Move mtu update request into ovsdb transaction https://review.opendev.org/c/openstack/os-vif/+/887017 | |
| 18:39:14 | opendevreview | Amit Uniyal proposed openstack/os-vif stable/wallaby: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/886778 | |
| 19:21:01 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test reimage-timeout change https://review.opendev.org/c/openstack/nova/+/887112 | |
| 19:22:25 | dansmith | bauzas: this ^ is the end of the chain to fix that rebuild timeout issue (we think) | |
| 19:24:24 | opendevreview | Merged openstack/nova stable/xena: Reproduce live migration rollback w/o multi port bindings error https://review.opendev.org/c/openstack/nova/+/843336 | |
| 21:48:44 | opendevreview | Merged openstack/nova stable/xena: Fix LM rollback w/o multi port bindings extension https://review.opendev.org/c/openstack/nova/+/843337 | |
| 22:23:50 | opendevreview | melanie witt proposed openstack/nova-specs master: Propose tooling and docs for unified limits https://review.opendev.org/c/openstack/nova-specs/+/887014 | |
| #openstack-nova - 2023-06-28 | |||
| 00:17:59 | NobodyCam | hey hey Nova folks, Off the wall question, should meta-data service(MDS) work in rescue mode. I have been testing rescuing a ironic node and it all seems to work, with the exception that I am unable to reach the MDS via curl.. so I was hoping that someone would know if it should work from rescue mode. The MDS work perfectly for the initially deployed image. | |
| 07:11:18 | opendevreview | Pierre Libeau proposed openstack/nova master: Remove port creation with device_id https://review.opendev.org/c/openstack/nova/+/861172 | |
| 09:22:44 | plibeau1 | sean-k-mooney: hello thx for your help on https://review.opendev.org/c/openstack/nova/+/861172 I have follow your recommendation if you have time to give me your feedback | |
| 09:38:09 | sean-k-mooney | ack i just skimmed it and it looks ok but ill try and find time to review it again later today | |
| 09:38:52 | sean-k-mooney | looks like it passed zuul so this is not breaking anything so thats good | |
| 09:51:47 | opendevreview | John Garbutt proposed openstack/nova master: WIP: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/887151 | |
| 11:20:27 | opendevreview | John Garbutt proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/886980 | |
| 11:24:19 | opendevreview | John Garbutt proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/886980 | |
| 11:26:14 | opendevreview | John Garbutt proposed openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/886989 | |
| 11:26:14 | opendevreview | John Garbutt proposed openstack/nova master: WIP: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/887151 | |
| 13:14:44 | ykarel | sean-k-mooney, hi can you please revisit https://review.opendev.org/c/openstack/nova/+/868419 | |
| 13:34:02 | sean-k-mooney | oh yes i touhgt we had merged that already | |
| 14:00:12 | opendevreview | John Garbutt proposed openstack/nova master: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/887151 | |
| 21:14:00 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test reimage-timeout change https://review.opendev.org/c/openstack/nova/+/887112 | |
| 21:14:23 | dansmith | ugh, looks like we meant to register the reimage timeout in the compute group but ended up with it in DEFAULT | |
| #openstack-nova - 2023-06-29 | |||
| 07:12:11 | opendevreview | Amit Uniyal proposed openstack/os-vif stable/yoga: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/886710 | |
| 07:26:19 | Uggla_ | bauzas, did you had a chance to look at my serie again ? | |
| 07:57:35 | opendevreview | Amit Uniyal proposed openstack/os-vif stable/yoga: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/886710 | |
| 08:22:31 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Bobcat" https://review.opendev.org/c/openstack/nova/+/887255 | |
| 08:23:57 | kashyap | Cc: sean-k-mooney --^ (No rush :)) | |
| 08:27:19 | kashyap | (Maybe I can remove still one more constant. Me looks) | |
| 09:43:59 | opendevreview | Amit Uniyal proposed openstack/os-vif stable/xena: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/886716 | |
| 11:50:04 | opendevreview | Yamato Tanaka proposed openstack/python-novaclient master: Do exact-matching when finding one instance by name https://review.opendev.org/c/openstack/python-novaclient/+/887268 | |
| 13:49:23 | dvo-plv | Hello, All. I'm currently writing functional test, my result should be expected fail. How should I handle this properly? | |
| 13:56:48 | dvo-plv | Should I set just @unittest.expectedFailure, or I need to create some additional note? | |
| 15:32:04 | melwitt | dvo-plv: are you doing the func test as part of a bug fix? if so what we usually do is put the func test first and assert the wrong behavior with a code comment explaining what bug it's about, then stack the fix patch on top and as part of it change the assert in the func test to assert the correct behavior and remove the code comment about the buggy behavior. and if the func test is for a regression, it should go under | |
| 15:32:04 | melwitt | nova/tests/functional/regressions/ | |
| 15:34:02 | dvo-plv | No, this is not a bug. This is a test for new feature | |
| 15:34:14 | dvo-plv | test is based on this Sean's comment https://review.opendev.org/c/openstack/nova/+/876075/14/nova/scheduler/request_filter.py#285 | |