| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-06-05 | |||
| 18:02:08 | bauzas | dansmith: because indeed I wasn't thinking about the other platforms but indeed you're right | |
| 18:02:12 | dansmith | yeah | |
| 18:02:25 | bauzas | +++ definitely, will fix it too and will backport it | |
| 18:02:37 | dansmith | cpufreq is pretty common these days, but if you unload a module or don't have it built into your kernel, we shouldn't fail | |
| 18:03:04 | dansmith | (shouldn't fail to allow offlining I mean) | |
| 18:03:38 | bauzas | indeed | |
| 18:05:03 | dansmith | bauzas: so I didn't look, but I assume the scaling approach already has the privsep helper? | |
| 18:05:09 | dansmith | and it was just the online helper that was missing it? | |
| 18:05:25 | bauzas | dansmith: yeah, we only forgot it for set_offline | |
| 18:05:36 | dansmith | okay cool, just checking | |
| 18:05:41 | bauzas | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/cpu/api.py is the private API | |
| 18:05:53 | bauzas | and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/cpu/core.py is the internal code | |
| 18:06:13 | bauzas | that's where we decorate the callers | |
| 18:06:41 | dansmith | I believe you, just making sure | |
| 18:07:40 | bauzas | dansmith: no worries, was just for explaining you what we do internally since you didn't had time to review the series | |
| 18:07:48 | dansmith | decorators are easy to miss and git rebase/merges sometimes snip them out if they're used in front of all the functions | |
| 18:08:02 | bauzas | https://review.opendev.org/q/topic:bp%252Flibvirt-cpu-state-mgmt | |
| 18:08:13 | bauzas | that's the series if you wanna peak it | |
| 18:08:36 | dansmith | yeah, I found it last week, I had missed it for sure | |
| 18:08:43 | bauzas | and https://review.opendev.org/c/openstack/nova/+/868237/12/nova/virt/libvirt/driver.py is where we offline/online | |
| 18:08:54 | bauzas | the closest I found when we spawn | |
| #openstack-nova - 2023-06-06 | |||
| 07:57:20 | gibi | bauzas, dansmith: nice findings. I'm OK with the privsep fix and you can ping me with the governor check fix when it is available | |
| 08:00:42 | gibi | regarding asserting the use of the decorator during testing we can build a list of filesystem.write(path, data) calls that we know require the privsep decorator and then check in the test that when those calls happen the func has _ENTRYPOINT_ATTR set. | |
| 08:04:14 | gibi | *filesyste.write_sys | |
| 08:09:53 | songwenping | sean-k-mooney:hi, does live migration pass filters if assigned the host? | |
| 08:16:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/873216 | |
| 08:17:30 | gibi | sean-k-mooney: This ^^ was already approved but needed a rebase and a unit test fix due the base changes. Could you check it please? | |
| 08:17:56 | gibi | I did not wait for the author with the rebase and went ahead and fixed up the patch | |
| 08:22:09 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2023.1: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885343 | |
| 08:30:14 | opendevreview | Balazs Gibizer proposed openstack/nova stable/zed: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885344 | |
| 08:33:42 | bauzas | gibi: sorry for the late reply, but thanks | |
| 08:36:19 | opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885345 | |
| 08:45:17 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885347 | |
| 08:46:55 | songwenping | gibi:morning, does live migration pass filters if assigned the host? | |
| 08:47:41 | gibi | songwenping: it depends. See the doc of the host and the force option in https://docs.openstack.org/api-ref/compute/?expanded=live-migrate-server-os-migratelive-action-detail#id131 | |
| 08:53:02 | songwenping | we use rocky version, and nova-conductor donot find new destination. | |
| 08:53:50 | songwenping | and there is a problem, if the vm has affinity, it can be migarated to other host. | |
| 08:57:29 | opendevreview | Balazs Gibizer proposed openstack/nova stable/wallaby: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885348 | |
| 08:57:48 | songwenping | then if we use the same affinity strategy to create vms, these vms scheduled to different hosts. gibi, is this reasonable? | |
| 08:59:00 | gibi | if you use affinity strategy then you cannot move the VM. Execpt if you disable the scheduler via the force flag and old enough microversion. But if you disable the scheduler then the affinity will not be honored. | |
| 08:59:23 | gibi | If you need both affinity and move operations then you should use soft-affinity | |
| 09:08:07 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885349 | |
| 09:09:40 | songwenping | gibi, got it, thanks^^ | |
| 09:57:28 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: make governors to be optional https://review.opendev.org/c/openstack/nova/+/885352 | |
| 10:04:41 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885353 | |
| 10:19:16 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/885355 | |
| 10:22:57 | sean-k-mooney | gibi: its workign on https://github.com/openstack-k8s-operators/nova-operator/pull/400 by the way | |
| 10:23:17 | sean-k-mooney | which ran at 2023-06-05 14:50:20 | |
| 10:23:30 | sean-k-mooney | so it passed yesterday | |
| 10:23:48 | gibi | ack | |
| 10:24:14 | gibi | you oddly switched from downstream slack to upstream irc to write that though :) | |
| 10:24:58 | sean-k-mooney | oh right donwstream is normlaly on the bottom half of my screen and upstream is the top | |
| 10:25:04 | sean-k-mooney | this windows is in the wrong place | |
| 10:25:20 | sean-k-mooney | fixed :) | |
| 10:25:32 | gibi | :) | |
| 11:07:53 | opendevreview | Gorka Eguileor proposed openstack/nova master: Libvirt: remove old discard with virtio log https://review.opendev.org/c/openstack/nova/+/885356 | |
| 11:41:28 | dvo-plv | gibi,bauzas: Hello, Could you please review nova patch: https://review.opendev.org/c/openstack/nova/+/876075 | |
| 11:41:57 | bauzas | dvo-plv: sure, I already promised but unfortunately I needed to work on my presentation for the OpenInfra Summit :( | |
| 11:44:16 | dvo-plv | Sure, thank you no rush, review according to your plan, I just would like to remind in case request was lost | |
| 12:52:27 | bauzas | I'm really sorry folks but I forgot to tell that today is the spec review day | |
| 12:52:29 | bauzas | !!! | |
| 12:52:29 | opendevmeet | bauzas: Error: "!!" is not a valid command. | |
| 14:12:49 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 14:12:50 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 14:23:53 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: make governors to be optional https://review.opendev.org/c/openstack/nova/+/885352 | |
| 14:27:24 | dansmith | bauzas: are you going to update the reno for the first patch? | |
| 14:32:37 | mnederlof | hi, i've created this bp https://blueprints.launchpad.net/nova/+spec/rbd-allow-glance-image-deletion and the code change required, can someone help with the next steps for review? https://review.opendev.org/c/openstack/nova/+/884595 | |
| 14:33:40 | bauzas | dansmith: yeah, I'm just fixing the series | |
| 14:37:19 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: fix the privsep issue when offlining the cpu https://review.opendev.org/c/openstack/nova/+/885293 | |
| 14:37:20 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: make governors to be optional https://review.opendev.org/c/openstack/nova/+/885352 | |
| 14:38:12 | bauzas | dansmith: gibi: just updated the cpu fixes ^ | |
| 14:53:12 | bauzas | elodilles: can you help me ? wanted to propose the train-eol patch but looked at the docs and saw https://docs.openstack.org/project-team-guide/stable-branches.html#end-of-life | |
| 14:53:29 | bauzas | "point #2 : Remove any related zuul jobs that are defined in other repositories and not needed anymore." | |
| 14:53:37 | bauzas | wdym by that ? | |
| 14:54:01 | bauzas | like in tempest ? | |
| 14:59:20 | elodilles | bauzas: any job that nova uses in its .zuul.yaml, but defined outside of nova repository | |
| 14:59:37 | bauzas | I don't see any of them | |
| 15:00:51 | elodilles | for example if there is let's say nova-special-grenade-train defined in, for example, openstack/grenade repository | |
| 15:01:16 | elodilles | bauzas: if there is none, then you're done with that step ;) | |
| 15:01:43 | bauzas | I'll doublecheck with Gerrit | |
| 15:02:12 | bauzas | gibi: btw. I have an appointment around 20 mins after the start of the meeting, can you chair it ? | |
| 15:10:03 | gibi | bauzas: I can try but I'm probably not the best person today as I will be on an flaky connection at that time | |
| 15:10:19 | bauzas | ok, I can ask someone else, I just wonder who | |
| 15:10:23 | bauzas | elodilles: want to lead it ? | |
| 15:15:16 | elodilles | bauzas: i'm not feeling quite well, so i'd rather pass this time :/ | |
| 15:16:33 | bauzas | okok | |
| 15:16:41 | bauzas | so, we'll try to have a quick meeting then | |
| 15:16:52 | elodilles | +1 | |
| 15:18:06 | gibi | bauzas: then I will jump in after you need to leave but I don't promise I will not get disconnected at some point :) | |
| 15:23:36 | dansmith | gibi: #chair me and I can recover it if you drop | |
| 15:26:18 | gibi | ack | |
| 15:38:57 | bauzas | dansmith: cool thanks for the offer | |
| 15:50:10 | bauzas | shit, my appointment just arrived | |
| 15:50:17 | bauzas | gibi: can you please lead it ? | |
| 15:50:32 | bauzas | the agenda is done https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 15:51:41 | gibi | sure | |
| 15:51:45 | gibi | I will do | |
| 16:00:04 | gibi | #startmeeting nova | |
| 16:00:04 | opendevmeet | Meeting started Tue Jun 6 16:00:04 2023 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:04 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |