| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-31 | |||
| 08:55:20 | bauzas | or the other way | |
| 09:02:52 | elodilles | o/ | |
| 09:03:01 | elodilles | what is the question? :) | |
| 09:04:20 | elodilles | yepp, the conflicts that are not valid anymore just confuse reviewers, so best to drop them | |
| 09:09:36 | bauzas | cool, will do | |
| 09:09:38 | bauzas | elodilles: thanks | |
| 09:14:09 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | |
| 09:14:10 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | |
| 09:14:48 | elodilles | np | |
| 09:14:53 | bauzas | elodilles: your help would be appreciated :) | |
| 09:15:16 | elodilles | i need to be AFK, but sure, when i'll be back i'll review it o:) | |
| 09:15:23 | bauzas | elodilles: could you please look at https://review.opendev.org/c/openstack/nova/+/883724 and then https://review.opendev.org/c/openstack/nova/+/884808/ ? | |
| 09:15:42 | bauzas | elodilles: tl;dr: we want to backport a bugfix down to Wallaby | |
| 09:15:53 | bauzas | and we need to backport a dependent change | |
| 09:16:21 | elodilles | ACK, added to my TODO :) | |
| 09:17:03 | bauzas | thanks | |
| 10:52:55 | gibi | bauzas: could you look at the backports of https://review.opendev.org/q/topic:bug%252F1941005 I think stable/wallaby is the next one | |
| 12:12:44 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 12:12:44 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 13:10:09 | bauzas | gibi: I'll try to look at those patches for sure | |
| 13:22:16 | sean-k-mooney | bauzas: gibi can one of ye review https://review.opendev.org/c/openstack/nova/+/873216 | |
| 13:22:58 | bauzas | sean-k-mooney: it seems a legit bug | |
| 13:23:03 | bauzas | I'll review it | |
| 13:23:45 | sean-k-mooney | bug/feature but its a bug that was reported downstream, which was then fixed by our customer and has been waiting for upstream review for a while | |
| 13:24:44 | sean-k-mooney | we did a downstream bug scub yesterday and this was one of the ones that we decied to try and move forward since it was passing ci and bacially ready to go | |
| 13:50:38 | bauzas | sean-k-mooney: I just Review-Prio +1d it | |
| 13:50:52 | sean-k-mooney | thanks | |
| 14:13:29 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 14:13:30 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | |
| 14:13:30 | opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | |
| 14:13:31 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 14:13:31 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| 14:13:32 | opendevreview | Dan Smith proposed openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | |
| 14:13:58 | dansmith | well, rebasing a migration due to a conflict is nicer under alembic, that's for sure | |
| 14:21:55 | sean-k-mooney | i have not looked at the delta too closely but i assuem with alembic ist largely just updating some hashes liek this https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py#26 | |
| 14:23:28 | sean-k-mooney | """Another thing to notice is the down_revision variable. This is how Alembic knows the correct order in which to apply migrations. When we create the next revision, the new file’s down_revision identifier would point to this one:""" | |
| 14:23:28 | sean-k-mooney | """Another thing to notice is the down_revision variable. This is how Alembic knows the correct order in which to apply migrations. When we create the next revision, the new file’s down_revision identifier would point to this one:""" | |
| 14:23:59 | dansmith | this is all I had to do: https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py | |
| 14:24:15 | sean-k-mooney | so i guess if a migration has landed in teh interm you just need to update that but your migration will still refer to the same revision ids in the pater patches | |
| 14:24:34 | sean-k-mooney | ya thats what i ment | |
| 14:24:56 | sean-k-mooney | it makes sens that that just need to be updated to refernce the latest revision | |
| 15:46:38 | opendevreview | Merged openstack/nova stable/zed: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883723 | |
| #openstack-nova - 2023-06-01 | |||
| 07:35:13 | opendevreview | Michel Nederlof proposed openstack/nova master: Add ability to flatten RBD disks upon clone https://review.opendev.org/c/openstack/nova/+/884595 | |
| 07:42:36 | opendevreview | Michel Nederlof proposed openstack/nova master: Add ability to flatten RBD disks upon clone https://review.opendev.org/c/openstack/nova/+/884595 | |
| 09:37:52 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 09:37:53 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 09:37:53 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 09:37:54 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 09:37:54 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 09:37:55 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 09:37:55 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 09:37:56 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 09:37:57 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 09:37:57 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 09:37:59 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 09:37:59 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 09:38:01 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 09:38:01 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 09:38:03 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 09:38:03 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 09:38:05 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 09:38:05 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 09:38:07 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 09:38:07 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 09:38:09 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 09:38:09 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 09:38:11 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 09:38:11 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 09:38:13 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 09:38:13 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 09:38:15 | opendevreview | ribaudr proposed openstack/nova master: Add configuration option share_local_fs https://review.opendev.org/c/openstack/nova/+/884994 | |
| 09:38:15 | opendevreview | ribaudr proposed openstack/nova master: Add hw_share_local_fs extra specs and image property https://review.opendev.org/c/openstack/nova/+/884995 | |
| 09:38:17 | opendevreview | ribaudr proposed openstack/nova master: Add LOCAL storage type https://review.opendev.org/c/openstack/nova/+/884996 | |
| 09:38:17 | opendevreview | ribaudr proposed openstack/nova master: Add share_local_fs scheduler filter https://review.opendev.org/c/openstack/nova/+/884997 | |
| 09:38:19 | opendevreview | ribaudr proposed openstack/nova master: Add new api to retrieve local share (object and db) https://review.opendev.org/c/openstack/nova/+/884998 | |
| 09:38:19 | opendevreview | ribaudr proposed openstack/nova master: Manage local share (driver part) https://review.opendev.org/c/openstack/nova/+/884999 | |
| 09:38:21 | opendevreview | ribaudr proposed openstack/nova master: Manage local share (compute manager part) https://review.opendev.org/c/openstack/nova/+/885000 | |
| 09:38:21 | opendevreview | ribaudr proposed openstack/nova master: Do not mount local share at startup (init_instance) https://review.opendev.org/c/openstack/nova/+/885001 | |
| 09:38:23 | opendevreview | ribaudr proposed openstack/nova master: Do not umount local share if instance id deleted https://review.opendev.org/c/openstack/nova/+/885002 | |
| 09:38:23 | opendevreview | ribaudr proposed openstack/nova master: Support spawn an instance with a local share (driver part) https://review.opendev.org/c/openstack/nova/+/885003 | |
| 09:38:25 | opendevreview | ribaudr proposed openstack/nova master: Support spawn an instance with a local share (compute manager part) https://review.opendev.org/c/openstack/nova/+/885004 | |
| 09:41:02 | Uggla_ | bauzas, ^ should fix what we discussed, I have added what I have done for scaphandre as well on top of the serie. | |
| 09:47:42 | Uggla_ | bauzas, I need to test a couple of things with devstack, then I will try to reorganize the serie to have the API related stuff on the top. | |
| 10:09:09 | opendevreview | Michel Nederlof proposed openstack/nova master: Add ability to flatten RBD disks upon clone https://review.opendev.org/c/openstack/nova/+/884595 | |
| 10:15:53 | bauzas | Uggla_: ack, cooking now | |
| 12:54:08 | Uggla_ | sean-k-mooney[m], can you please remember me the issue with numa and memfd. So far I understand that tweaking numa is not required anymore with As of QEMU 5.0.0 and libvirt 6.9.0. Do I miss something ? | |
| 12:56:07 | sean-k-mooney | i discovered that recently too | |
| 12:56:27 | sean-k-mooney | so your rigt with a new enough qemu memfd does not require numa to be configured | |
| 12:56:42 | sean-k-mooney | so we could start makeing that our default memory backend in nova/libvirt | |
| 12:57:17 | sean-k-mooney | specificaly our default coudl evolve to | |
| 12:57:20 | sean-k-mooney | <memoryBacking> | |
| 12:57:22 | sean-k-mooney | <source type="memfd"/> | |
| 12:57:24 | sean-k-mooney | <access mode="shared"/> | |
| 12:57:26 | sean-k-mooney | </memoryBacking> | |
| 12:57:52 | sean-k-mooney | that will enable virtio fs and vhost-user to start workign automaticlaly without any special addtional configuration | |
| 12:58:38 | sean-k-mooney | Uggla_: however our current min qemu is 4.2.0 or declared next min is 5.2.0 | |
| 12:58:52 | sean-k-mooney | so we need to actuly raise the min version befoer we do that | |
| 12:59:21 | sean-k-mooney | kashyap was ment to be workign on that but i have not seen any patches yet | |
| 13:02:08 | Uggla_ | sean-k-mooney, as a reminder for virtiofs I require a qemu > 5.0.0 and libvirt > 6.2.0. | |
| 13:03:22 | Uggla_ | sean-k-mooney, anyway assuming I find the time to do it, any objection to write a spec for memfd ? (so we could review it at PTG ?) | |