| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-23 | |||
| 16:55:16 | bauzas | is anyone having a thought to share with the team ? | |
| 16:56:47 | bauzas | looks not | |
| 16:56:55 | bauzas | sorry this week I won't save too much of your time | |
| 16:56:59 | bauzas | thanks all | |
| 16:57:03 | bauzas | #endmeeting | |
| 16:57:03 | opendevmeet | Meeting ended Tue May 23 16:57:03 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:57:03 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-23-16.01.html | |
| 16:57:03 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-23-16.01.txt | |
| 16:57:03 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-23-16.01.log.html | |
| 16:58:04 | gibi | thanks | |
| 16:58:20 | elodilles | thanks o/ | |
| 16:59:35 | Uggla_ | thx | |
| #openstack-nova - 2023-05-24 | |||
| 14:59:01 | opendevreview | Merged openstack/nova stable/yoga: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868010 | |
| 17:56:02 | melwitt | dansmith: fyi this is a fix for our subclass signature checker test that detects when volume drivers are not matching the base class https://review.opendev.org/c/openstack/nova/+/883217 I found it wasn't working when I was working on the cve stuff. it would have caught the issue with the wallaby patch | |
| 17:57:24 | dansmith | melwitt: cool | |
| 18:21:52 | sean-k-mooney | melwitt: i didnt know that was a thing | |
| 18:22:30 | sean-k-mooney | i feel like there are proably better ways to detech that if we use mypy | |
| 18:22:34 | sean-k-mooney | to do type checking now | |
| 18:23:24 | sean-k-mooney | with that said im ok with fixing this as is | |
| 18:23:39 | sean-k-mooney | we can likel just do it better with newer tools now | |
| 18:37:00 | melwitt | sean-k-mooney: yeah it was new-ish to me too as I hadn't dug into the volume drivers too much before | |
| 18:37:43 | melwitt | and yeah maybe there's a better way to do it now. the fix was pretty easy tho | |
| 18:40:12 | sean-k-mooney | i havent looked into mypy too much but i think we caoudl annotation the base calses and have it detech if the signirues did not match | |
| 18:40:24 | sean-k-mooney | but that would be a large change anyway | |
| 18:40:54 | sean-k-mooney | espcially since we woudl ahve to enable mypi typeing for the entire file | |
| 18:49:30 | dansmith | please no | |
| 18:51:38 | sean-k-mooney | in the cld classes i think you jsut have to put @overload in the metods so its not that bad | |
| 18:51:46 | sean-k-mooney | but its more work then we need | |
| 18:52:20 | sean-k-mooney | if you declar it an overlaod/override and the signiture does not match it treats it as an error | |
| 18:52:38 | dansmith | do you mean abc? | |
| 18:53:01 | sean-k-mooney | basicaly ya | |
| 18:53:13 | sean-k-mooney | that was how it sued to be done | |
| 18:53:29 | dansmith | yeah, that's the better way, especially for things like this | |
| 18:53:31 | sean-k-mooney | it might still be the way its currently doen | |
| 18:54:01 | sean-k-mooney | i was looking at https://mypy.readthedocs.io/en/stable/class_basics.html#abstract-base-classes-and-multiple-inheritance vs https://mypy.readthedocs.io/en/stable/final_attrs.html#final-methods | |
| 18:54:22 | sean-k-mooney | well https://mypy.readthedocs.io/en/stable/error_code_list.html?highlight=overload#check-calls-to-overloaded-functions-call-overload | |
| 18:56:27 | sean-k-mooney | so there is some checking for overrides in bases https://mypy.readthedocs.io/en/stable/error_code_list.html?highlight=overload#check-validity-of-overrides-override but abstractg base classes is clearer | |
| 18:56:41 | sean-k-mooney | i think the automtaic checking only applies if the types dont match | |
| 18:57:00 | sean-k-mooney | anyway o/ | |
| 19:05:36 | gouthamr | o/ dansmith: do you have logs of a multinode job that ran with changes here: https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/882483 | |
| 19:06:40 | dansmith | gouthamr: meaning other than the ones linked there? | |
| 19:06:50 | dansmith | oh no, right, | |
| 19:06:57 | dansmith | it wasn't running the multinode job | |
| 19:07:47 | dansmith | gouthamr: but no, that was just me trying to sync up that job definition, I didn't get into any actual diagnosis of if the job was working | |
| 19:07:58 | gouthamr | ah thanks | |
| 19:08:40 | gouthamr | saw your comment: "There are errors from one of the nova computes that indicate that it's not getting access to the ceph cluster properly, which means there is more work to do here." | |
| 19:09:08 | gouthamr | so assumed that was on the CI somewhere; ashrodri can enable the base job in the repo with her changes and debug that | |
| 19:09:58 | dansmith | gouthamr: oh, that's probably from the nova test patch, which likely has some logs still because it has a multinode job | |
| 19:10:05 | dansmith | hang on | |
| 19:10:34 | dansmith | gouthamr: https://zuul.opendev.org/t/openstack/build/588de1c62e564a4e93d4e94d1e9a5216 | |
| 19:11:18 | dansmith | yeah so all the migration tests fail which I assume is because the other node can't access the ceph cluster | |
| 19:11:25 | dansmith | (sorry I had purged all this from my cache) | |
| 19:12:34 | dansmith | ceph conf and keyrings are there on the subnode | |
| 19:13:00 | dansmith | but nova can't see it: https://zuul.opendev.org/t/openstack/build/588de1c62e564a4e93d4e94d1e9a5216/log/compute1/logs/screen-n-cpu.txt#8038 | |
| 19:18:10 | gouthamr | dansmith: it looks like we created two ceph clusters there :) | |
| 19:18:29 | gouthamr | with REMOTE_CEPH set to true, we should skip the ceph install on the subnode | |
| 19:18:38 | gouthamr | which we'll try with ashrodri's patch.. | |
| 19:19:32 | dansmith | gouthamr: ack, makes sense | |
| #openstack-nova - 2023-05-25 | |||
| 02:13:04 | gmann | dansmith: can you re-review this, removed glance scope setting also as that is also now enabled in devastack by default https://review.opendev.org/c/openstack/nova/+/883557 | |
| 02:13:32 | gmann | gibi: bauzas: ^^ can either of you check this RBAC old default new job | |
| 04:37:08 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 04:37:09 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 04:37:09 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 04:37:10 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870933 | |
| 04:37:10 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 04:37:11 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 04:37:11 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 04:37:12 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870937 | |
| 04:37:12 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 04:37:13 | opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | |
| 04:37:13 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 04:37:15 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | |
| 04:37:15 | opendevreview | melanie witt proposed openstack/nova master: WIP raw imagebackend support https://review.opendev.org/c/openstack/nova/+/884313 | |
| 05:01:10 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw https://review.opendev.org/c/openstack/nova/+/862416 | |
| 13:40:07 | dansmith | gmann: yep | |
| 14:17:09 | kashyap | dansmith: That CirrOS 0.5.2 is fixed now: https://github.com/cirros-dev/cirros/issues/102 | |
| 14:17:19 | kashyap | They bumped the kernel. | |
| 14:17:33 | sean-k-mooney | finally | |
| 14:17:34 | dansmith | kashyap: hah, we just bumped to 6.0 :) | |
| 14:17:39 | kashyap | LOL | |
| 14:17:52 | dansmith | but yeah, I need to survey for guest kernel crashes since the bump | |
| 14:17:56 | sean-k-mooney | we are on 6.1 no? | |
| 14:18:21 | kashyap | Oh, wait - there are more guest kernel crashes after the bump? | |
| 14:18:21 | sean-k-mooney | i asked them to bump the kernel like 2 years ago to fix some of the kernel issues | |
| 14:18:27 | dansmith | I meant 6.x | |
| 14:19:11 | sean-k-mooney | thats a diffent kernel fix then the one i asked them to bump for before | |
| 14:19:53 | sean-k-mooney | but in anycase we are not using that anymore but it might be useful on stable i guess | |
| 14:20:08 | dansmith | kashyap: no, I'm saying we bumped to cirros 6.x a few days ago and I need to survey to see if the kernel crashes have stopped | |
| 14:20:27 | kashyap | Aaah, like that | |
| 14:20:30 | kashyap | Makes sense, yes. | |
| 14:21:34 | kashyap | sean-k-mooney: Which one did you ask? We asked this update to solve these sort of crashes: https://kashyapc.fedorapeople.org/CirrOS_segfault/guest-boot-console-and-segfault.txt | |
| 14:21:48 | sean-k-mooney | kashyap: it was related to https://github.com/cirros-dev/cirros/issues/69 | |
| 14:23:04 | sean-k-mooney | we worked aroudn it with https://github.com/lyarwood/cirros/commit/c8972ca3dcde2bedc00cbeda0e0ccb8fcbf92883 but chattign to lee i found a fixed kernel bug that had been released in an newer verison | |
| 14:23:18 | kashyap | Oh, this, the IO-APIC one. | |
| 14:23:47 | sean-k-mooney | ya so there was a fix for the apic issue in a later kernel package | |
| 14:23:56 | sean-k-mooney | we worked around it with the kernel parmater | |
| 14:24:09 | sean-k-mooney | but the package never got updated at least not at the time | |
| 14:24:17 | sean-k-mooney | it may have been since | |
| 14:24:43 | kashyap | Ah, nod | |
| 15:35:25 | dansmith | kashyap: from this morning: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f3e/883602/2/gate/nova-ceph-multistore/f3e5585/testr_results.html | |