Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-05-12
13:33:40 bauzas spatel: but have you looked at our upstream docs for hugepages ?
13:34:27 spatel Yes! I am running hugepages on one of my cloud with cpu-pinning with numa scheduling
13:34:48 spatel This is new cloud where thinking to not use pinning but just hugepage
13:59:28 sahid sean-k-mooney: o/ regarding https://review.opendev.org/c/openstack/os-vif/+/881751, based on the bug report you wanted to backport it, right?
14:00:32 bauzas sahid: yes, sean-k-mooney in on PTO but yeah
14:00:33 opendevreview Jay Faulkner proposed openstack/nova-specs master: Re-Propose "Ironic Shards" for Bobcat/2023.2 https://review.opendev.org/c/openstack/nova-specs/+/881643
14:02:01 sahid bauzas: ok, give me a moment I will cherry-pick them, thank you
14:02:46 opendevreview Sahid Orentino Ferdjaoui proposed openstack/os-vif stable/2023.1: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/883015
14:03:33 opendevreview Sahid Orentino Ferdjaoui proposed openstack/os-vif stable/zed: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/883016
14:03:36 JayF bauzas: sean-k-mooney: Updated the Ironic shards spec as requested, thank you!
14:03:55 bauzas JayF: fast-approved
14:04:42 JayF \o/
14:18:02 opendevreview Merged openstack/nova-specs master: Re-Propose "Ironic Shards" for Bobcat/2023.2 https://review.opendev.org/c/openstack/nova-specs/+/881643
14:21:51 opendevreview Sahid Orentino Ferdjaoui proposed openstack/os-vif stable/yoga: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/883071
14:25:17 BobZAnnapolis__ Hey folks, do you know of / have a documentatiuon location where i can find a detailed ERD for the NOVA dbs, the relations / fields defined, hopefully the purpose for each field, limitations, etc, something more than a "describe table" ? tia
#openstack-nova - 2023-05-13
11:47:15 opendevreview Merged openstack/nova stable/zed: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882860
19:58:52 opendevreview Merged openstack/nova stable/zed: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882861
#openstack-nova - 2023-05-15
06:33:16 opendevreview Amit Uniyal proposed openstack/nova master: WIP: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284
07:28:58 dvo-plv gibi, sean-k-mooney, sbauza: Hello. I have update nova code after os-traits release. Coud you please review packed ring support bp: https://review.opendev.org/q/bp/virtio
08:08:29 bauzas sean-k-mooney: could you please give a +2 on https://review.opendev.org/c/openstack/nova/+/882786 so I could prepare both a 2023.1 and Zed releases for both the CVEs ?
08:09:03 bauzas (or any stable core, like gibi) ^
08:23:33 opendevreview Merged openstack/nova stable/2023.1: Bump nova-ceph-multstore timeout https://review.opendev.org/c/openstack/nova/+/882784
09:03:48 zigo Hi! I'm trying to backport https://review.opendev.org/c/openstack/nova/+/882869 to Victoria. So far, it seems working, except, I have a unit test failure:
09:03:48 zigo https://paste.opendev.org/show/br48JgltG6neK70WbkQA/
09:03:48 zigo This is in the new unit test test_cleanup_disconnect_volume()
09:03:48 zigo Does anyone know what I can do?
09:04:13 zigo I really would prefer to keep that unit test if possible ...
09:04:29 zigo melwitt: ^
09:58:52 dvo-plv bauzas: Hello. I have update nova code after os-traits release. Coud you please review packed ring support bp: https://review.opendev.org/q/bp/virtio
11:18:49 opendevreview Amit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757
11:30:52 sean-k-mooney dvo-plv: the code looks ok but your missing test coverage
11:41:10 dvo-plv seean-k-mooney: We would like to implement tests after code approval in the separate bp. Does it possible, or we should to create a test immediately?
11:42:12 sean-k-mooney dvo-plv: no
11:42:23 sean-k-mooney we do not merge untested code in genral
11:42:40 sean-k-mooney so you need to have tests either in the same commmit or a followup commit
11:43:00 sean-k-mooney if its in a followup we will hold the first commit until we are happy with both and then merge them togeter
11:44:33 sean-k-mooney for openstack we treat master as if all commits could be deployed to production.
11:44:58 sean-k-mooney for lareger feature we genreally gate multi commit feature by having the change that enables the feature to be used last in the serise
11:45:37 dvo-plv I think we will implement and update this commit with tests coverage
11:45:49 sean-k-mooney that works
15:31:50 opendevreview Merged openstack/nova stable/yoga: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882863
15:33:45 opendevreview Merged openstack/nova stable/yoga: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882864
17:24:47 dansmith fungi: if we change the wallaby implementation of the cve fix in gerrit (to address the thing raised in the bug), do we have to update errata or not?
17:24:56 dansmith the patch was in the bug, but wallaby should be out of bounds now
17:30:53 fungi technically we don't need to reference it because that branch is no longer under normal maintenance
17:31:27 fungi though i might amend the errata list with it and just not announce that so as to keep the noise level to a minimum
17:32:17 fungi we have a bit of flexibility with branches no longer under normal maintenance since those fixes are merely being included as a convenience and on a best-effort basis
17:32:27 dansmith ack, cool
17:32:50 dansmith I think you said "patches for older branches are appreciated but not required" so I just didn't know how that mapped to "provided as a courtesy and then changed"
17:32:52 dansmith melwitt: ^
17:33:26 fungi it's sort of a grey area
17:33:40 dansmith I'm a walking grey area
17:33:49 fungi we didn't provide any non-nova wallaby patches anyway
17:34:14 fungi everything else stopped at xena (which is also no longer under normal maintenance at this point)
17:35:31 melwitt fungi: I had named the patch nova-2004555-xena_and_wallaby.patch erroneously thinking xena and wallaby were identical but it's really just nova-2004555-xena.patch
17:35:43 fungi makes sense
17:36:21 fungi for the downstream notification (and advisory of course) i split them up
17:36:37 melwitt oh, I see
17:37:33 fungi lots of the patches were "this applies to branches x and y" so i made separate identical branch x and branch y patches, because we don't want consumers to have to sort through a maze of patch name to branch mappings
17:41:07 dansmith melwitt: you're probably going to have to fix the job config on wallaby if you actually want to merge it too
17:41:32 melwitt fungi: that makes sense
17:41:41 dansmith the recent cinder tempest plugin changes for the ceph job have broken it.. I think just disabling the ceph job on wallaby is probably best
17:41:42 melwitt dansmith: good point
17:42:18 melwitt I at least wanted the current ps to be correct if anyone pulls it manually
17:43:13 dansmith yeah
17:43:23 dansmith well, it'll help the ubuntu wallaby patches and the reporter at least
17:47:39 opendevreview melanie witt proposed openstack/nova stable/wallaby: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882869
17:47:40 opendevreview melanie witt proposed openstack/nova stable/wallaby: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882870
18:08:33 dansmith jamespage: you might want to notice this ^ update along with the traffic on https://bugs.launchpad.net/nova/+bug/2004555
18:08:47 dansmith related to the ubuntu packages for that cve
18:54:38 fungi jamespage: also https://review.opendev.org/c/openstack/ossa/+/883202 "Add errata 3 for OSSA-2023-003"
19:28:35 sean-k-mooney i tought the general guidancce was to not track the ubuntu package state in the laucnchpad bug and only use them for the upstream openstack projects
19:29:43 sean-k-mooney i was always toold it was conidered rude to add the disto pacakges to the bug at elast when i was at intel my perception was it caused consution with regards to is this fixed on the upstream branch or downstream branch
19:34:32 melwitt zigo: I looked into the victoria issue, note that I updated the wallaby patch review for something different so please pull the latest one. besides that, I think you can add something like 'mount_device': None here under connection_info https://review.opendev.org/c/openstack/nova/+/882869/2/nova/tests/unit/virt/libvirt/test_driver.py#19646 to pass the test
19:38:03 melwitt the victoria code expects an additional key 'mount_device' key in the block_device_mapping
19:38:19 melwitt *an additional key in
22:53:29 opendevreview Merged openstack/nova stable/xena: CI: fix backport validator for new branch naming https://review.opendev.org/c/openstack/nova/+/882967
#openstack-nova - 2023-05-16
02:21:01 opendevreview melanie witt proposed openstack/nova master: testing: Use inspect.isfunction() to check signatures https://review.opendev.org/c/openstack/nova/+/883217
03:08:30 opendevreview melanie witt proposed openstack/nova master: testing: Use inspect.isfunction() to check signatures https://review.opendev.org/c/openstack/nova/+/883217
07:29:20 elodilles hi nova team! Happy *** Nova Stable Branches Review Day *** to everyone! \o/ o:)
07:56:06 bauzas elodilles: thanks for the reminder :)
08:01:42 jamespage dansmith, fungi: thanks - looking now
08:45:39 bauzas gibi: can you give a swing on that stable review day for https://review.opendev.org/c/openstack/nova/+/882786 ? :)
09:01:31 gibi bauzas: done
09:02:15 gibi on a similar note I need stable review on https://review.opendev.org/q/topic:bug%252F1994526
09:02:47 bauzas gibi: I did it for 2023.1, will look at zed
09:16:51 elodilles gibi: 2023.1 version is on the gate now
09:17:47 elodilles and if you have time for these simple gate fix backports to review: https://review.opendev.org/q/topic:validate-backport-release-id
09:17:50 elodilles o:)
09:19:45 gibi looking
09:21:22 gibi done :)
09:24:12 elodilles thx \o/
09:27:31 opendevreview Amit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757
09:42:24 auniyal_ gibi, elodilles in case you are done with stable reviews, only these 2 stable/2023.1 patches missed: https://review.opendev.org/c/openstack/nova/+/882293 , https://review.opendev.org/c/openstack/nova/+/882913
09:43:39 auniyal_ bauzas, already had +2 in one, and other one is from bauzas
09:44:12 bauzas np
09:50:27 zigo melwitt: I was able to get Nova / Victoria to build correctly with the patch. thanks for your usefull hint !
09:59:14 elodilles zigo: if you could upload the victoria patch then i can review it as well ;)
10:34:05 zigo elodilles: It would need the os-brick patch to be merged first, no?
11:05:39 elodilles zigo: probably yes, but i guess then you have that too

Earlier   Later