| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-04-11 | |||
| 16:35:03 | bauzas | #agreed a blueprint asking to have a weigher using hypervisor_version would be a specless one | |
| 16:35:25 | bauzas | #action sean-k-mooney to ping bauzas once he creates it | |
| 16:35:28 | bauzas | voila | |
| 16:35:41 | bauzas | anything else ? | |
| 16:36:06 | bauzas | if not | |
| 16:36:10 | bauzas | thanks all, | |
| 16:36:13 | bauzas | #endmeeting | |
| 16:36:13 | opendevmeet | Meeting ended Tue Apr 11 16:36:13 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:36:13 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-11-16.00.html | |
| 16:36:13 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-11-16.00.txt | |
| 16:36:13 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-11-16.00.log.html | |
| 16:36:19 | gibi | o/ | |
| 16:36:24 | bauzas | hah, https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/scheduler/filters/image_props_filter.py#L84 | |
| 16:36:52 | bauzas | so, basically we even use the hypervisor version value for an image property :) | |
| 16:37:01 | bauzas | this is even not only internal | |
| 16:37:16 | sean-k-mooney | really? that seams wrong | |
| 16:37:23 | bauzas | sean-k-mooney: look above | |
| 16:37:25 | sean-k-mooney | oh i know what this is for | |
| 16:37:32 | sean-k-mooney | this is for hyperv i think | |
| 16:37:45 | sean-k-mooney | they use v1 and v2 like we use machine types | |
| 16:37:59 | bauzas | maybe, but that works too for libvirt | |
| 16:38:11 | sean-k-mooney | https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/hyperv/hostops.py#L99-L104 | |
| 16:38:21 | sean-k-mooney | i guess no it sused for somethign else | |
| 16:38:40 | sean-k-mooney | i would want this to be a min verion really rather then exact comparison | |
| 16:39:08 | sean-k-mooney | that is not waht it does unfornetly | |
| 16:40:55 | sean-k-mooney | actully return img_prop_predicate.satisfied_by(hyper_ver_str) | |
| 16:41:02 | sean-k-mooney | so that proably is a min version check | |
| 16:41:18 | sean-k-mooney | thats implmented by distutils | |
| 16:41:23 | bauzas | this is | |
| 16:41:25 | bauzas | and https://github.com/openstack/nova/blob/72370a188c0755bc9c864b5a5e4a972077cb8dd6/nova/virt/libvirt/driver.py#L9516 | |
| 16:41:51 | bauzas | if you're an operator, you can create an image requesting for a min libvirt version | |
| 16:41:56 | bauzas | that already exists | |
| 16:42:04 | sean-k-mooney | well that is good to know | |
| 16:42:06 | bauzas | this is bad to me | |
| 16:42:11 | bauzas | but we do support it | |
| 16:42:21 | sean-k-mooney | its bad becasue its leaking backend details | |
| 16:42:25 | bauzas | correct | |
| 16:42:36 | sean-k-mooney | its good if you need to target a version for certen fucntionality | |
| 16:42:46 | sean-k-mooney | it should not be requried if we used traits properly | |
| 16:42:56 | sean-k-mooney | so in the past i can see the usecase | |
| 16:42:59 | bauzas | it was obviously pre-traits | |
| 16:43:04 | sean-k-mooney | ya | |
| 16:43:23 | sean-k-mooney | anyway at least we know the semantic of "it shoudl be sortable" | |
| 16:43:30 | sean-k-mooney | have already been depened on | |
| 16:43:32 | bauzas | yeah, but instead of pinning a specific virt version, we should absract this into abstract versions | |
| 16:43:38 | sean-k-mooney | so that makes the weigher simpler | |
| 16:43:44 | bauzas | semantic versioning I mean | |
| 16:44:06 | sean-k-mooney | ya well to do that we woudl need to change this form an int to string | |
| 16:44:08 | sean-k-mooney | to model that | |
| 16:44:09 | bauzas | but yeah, for your weigher, it just makes the paperwork easy | |
| 16:44:19 | sean-k-mooney | but i dont want to touch that now | |
| 16:44:26 | sean-k-mooney | we can in the future if it makes sense too | |
| 16:44:36 | bauzas | sean-k-mooney: yup, and ideally it should obfuscate the hypervisor specific version | |
| 16:44:45 | sean-k-mooney | i will go do the paperwork and let you knwo when its donw | |
| 16:44:56 | bauzas | cool, I'll approve it once you ping me | |
| 16:45:16 | bauzas | and the weigher seems to me an easy peasy given the existing | |
| 16:45:30 | bauzas | the code change itself should be simple to review :) | |
| 16:46:39 | bauzas | anyway, done for today | |
| 17:06:20 | sean-k-mooney | bauzas: when you have time https://blueprints.launchpad.net/nova/+spec/weigh-host-by-hypervisor-version | |
| 17:07:47 | bauzas | sean-k-mooney: done | |
| 17:08:06 | sean-k-mooney | thanks | |
| 17:49:29 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 17:49:29 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 17:49:30 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 17:49:30 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 17:49:31 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 17:49:31 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 17:49:32 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 17:49:33 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 17:49:33 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 17:49:35 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 17:49:35 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 17:49:37 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 17:49:37 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 17:49:39 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 17:49:39 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 17:49:41 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 17:49:41 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 17:49:43 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 17:49:43 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 17:49:45 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 17:49:45 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 17:49:47 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 17:49:47 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 17:49:49 | opendevreview | ribaudr proposed openstack/nova master: The purpose of this patch is to ensure that, in the event of a compute reboot, shares associated with instances are mounted successfully on the compute host during the service initialization process. https://review.opendev.org/c/openstack/nova/+/880075 | |
| 18:54:40 | dansmith | bauzas: I totally missed this, but apparently we should be working to remove hyperv: https://lists.openstack.org/pipermail/openstack-discuss/2022-November/031044.html | |
| 19:03:20 | sean-k-mooney | oh ya | |
| 19:03:24 | sean-k-mooney | i rememebr seeing that | |
| 19:04:07 | sean-k-mooney | so ya we proably should deprecate it this cycle | |
| 19:04:12 | sean-k-mooney | and remove in C | |
| 19:04:29 | sean-k-mooney | ... or D with the new lifecycle | |
| 19:04:45 | sean-k-mooney | that kind of sucks as it proably should have been deprecated in A | |
| 19:05:02 | gmann | if os-win goes away in this cyle then we might need to just remove it ? | |
| 19:05:13 | sean-k-mooney | yep | |
| 19:05:27 | sean-k-mooney | can we retoactivly declare it deprecated for Antelope | |
| 19:05:37 | sean-k-mooney | assuming that happens | |
| 19:05:42 | gmann | humm | |
| 19:06:48 | sean-k-mooney | either way we shoudl declare it deprecated in bobcat | |
| 19:06:57 | sean-k-mooney | and see if we have issues with os-win | |
| 19:08:53 | bauzas | dansmith : we can send a deprecation signal by Bobcat if you want but continue to say it then in C | |