| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-04-07 | |||
| 15:57:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: show that lower-* jobs has no false positives https://review.opendev.org/c/openstack/nova/+/879888 | |
| 16:18:11 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 16:18:12 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| 19:23:09 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 19:23:09 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | |
| 19:23:10 | opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | |
| 19:23:10 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 19:23:11 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| #openstack-nova - 2023-04-08 | |||
| 03:45:06 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 03:45:07 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 03:45:07 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 03:45:08 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870933 | |
| 03:45:08 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 03:45:09 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 03:45:09 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 03:45:10 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870937 | |
| 03:45:11 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 03:45:11 | opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | |
| 03:45:13 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 03:50:55 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw https://review.opendev.org/c/openstack/nova/+/862416 | |
| #openstack-nova - 2023-04-09 | |||
| 19:35:10 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879405 | |
| #openstack-nova - 2023-04-10 | |||
| 06:37:02 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Add cleanup flag to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 21:10:48 | opendevreview | Merged openstack/nova master: Make scheduler lazy-load the placement client https://review.opendev.org/c/openstack/nova/+/878238 | |
| 22:46:16 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 22:46:17 | opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | |
| 22:46:17 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| #openstack-nova - 2023-04-11 | |||
| 08:07:46 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Re-propose using extend volume completion action for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877233 | |
| 10:05:50 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 12:03:42 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 12:50:54 | gibi | bauzas: sean-k-mooney: dansmith: gmann: here is my take on the limited lower constraint job https://review.opendev.org/q/topic:limited-lower-constraints-jobs it already can catch the issue I want to catch (see the example DNM patches) | |
| 12:50:58 | gibi | https://review.opendev.org/q/topic:limited-lower-constraints-jobs | |
| 12:51:52 | bauzas | gibi: ack, will look | |
| 12:52:29 | sean-k-mooney | gibi: is there a reason you are stating which packages to restrict | |
| 12:52:37 | sean-k-mooney | gibi: instead of everything in requirements.txt | |
| 12:53:15 | gibi | sean-k-mooney: yes, I wanted to limit the scope of the lower constraint jobs as we know that pulling everythin back can be tricky | |
| 12:53:40 | gibi | we can try to pull back all our direct depts | |
| 12:53:42 | sean-k-mooney | ok so now its only testing other nova deliverables | |
| 12:54:03 | sean-k-mooney | honsetly those are the ones i was the least worried about | |
| 12:54:25 | gibi | funnily in Zed we delivered nova with a wrong os-traits dept | |
| 12:54:38 | gibi | and that triggered my thinking about this job | |
| 12:54:52 | gibi | *wrong minimum os-traits dept | |
| 12:55:12 | sean-k-mooney | for which feature | |
| 12:55:20 | gibi | let me dig it out | |
| 12:55:32 | sean-k-mooney | there was one that i expicty didint want to bump it for shice it was optional | |
| 12:55:56 | sean-k-mooney | although that was os-brick i think not os-traits | |
| 12:56:22 | gibi | sean-k-mooney: this was the fix https://review.opendev.org/c/openstack/nova/+/858280 | |
| 12:56:59 | gibi | we released RC2 due to this ^^ | |
| 12:57:23 | gibi | and we only detected that in time because zigo was eager to package the RC1 | |
| 12:57:39 | sean-k-mooney | did it cause failusre when pci in placment was disabeld | |
| 12:57:49 | sean-k-mooney | becaus if it did not we should not have released an rc2 for that | |
| 12:58:30 | sean-k-mooney | in zed we had already stop including lower constraits in the PTI | |
| 12:59:39 | zigo | gibi: And it's out of luck that I found it (ie: because using sbuild + git-buildpackage with the experimental as overlay only, which takes packages from unstable unless there's a strong hint that the experimental version is needed...) | |
| 13:00:00 | sean-k-mooney | i guess given it broke unit tests it could break packagers workflows | |
| 13:00:08 | sean-k-mooney | but high seams a strech to me | |
| 13:01:38 | sean-k-mooney | gibi: https://github.com/openstack/governance/blob/584e06b0c186d4355d1d51f2d6df96e822253bef/resolutions/20220414-drop-lower-constraints.rst happend in zed | |
| 13:02:23 | gibi | sean-k-mooney: and we dropped lower-constraints as a blanket lower constraints job is very hard to do right do to lack of tooling support | |
| 13:02:30 | gibi | hence my take on a limited scope | |
| 13:03:38 | sean-k-mooney | well to me its value was in direct depencies on things like oslo or any other package we directly use | |
| 13:03:58 | gibi | sean-k-mooney: as I said we can try to extend the current proposal to more direct deps | |
| 13:04:22 | gibi | I'm not sure it will be correct if there as cross dependencies between our direct depts | |
| 13:04:29 | sean-k-mooney | well if its not everythign in requiremetns.txt i find it hard to trust that it works | |
| 13:04:29 | gibi | but we can try | |
| 13:04:46 | gibi | I proved it works for os-traits. see the DNM patch on the top | |
| 13:05:05 | sean-k-mooney | yep but what if we start usign a feature in oslo-utils | |
| 13:05:18 | sean-k-mooney | like the imageinfo json output for the vmdk cve | |
| 13:05:57 | sean-k-mooney | to me the real benifit of lower constraits was to ensure we catch issues when backporting | |
| 13:06:00 | gibi | the possible fault we want to catch with the lower constraint is generic for all our direct (or even indirect) depts. I'm not disagreeing there | |
| 13:07:00 | sean-k-mooney | it also has benifit on master to ensure we are intentional when increaseing version and call it out in release notes | |
| 13:07:22 | sean-k-mooney | well if required like swapping to sqlacmey 2.0 | |
| 13:11:39 | gibi | so I would do a blanket lower constraint job if I could. But I know that it is impossible to do that right. So I started from a small set of depts. If you have suggestions what else to add to the set like oslo-utils or sqlachemy. Then we can try. I think blindly add all the direct dept can lead to problems | |
| 13:17:13 | bauzas | gibi: sean-k-mooney: I think we somehow agreed on last weekly meeting that the job should only check the existing packages by pinning their versions | |
| 13:17:58 | gibi | bauzas: "existing packages" <- this is not well defined. | |
| 13:19:21 | bauzas | gibi: I mean, all of the packages from reqs.txt | |
| 13:19:43 | gibi | see above. I think that is bigger than what we can chew. but we can try | |
| 13:20:30 | gibi | as soon as we have cross dependencies between our direct debt the same problem will appert than what we had with the blanket lower constraint job | |
| 13:23:21 | sean-k-mooney | i would almost prefer to take the opisite approch | |
| 13:23:27 | sean-k-mooney | have an exclude list | |
| 13:23:39 | sean-k-mooney | which we filter out | |
| 13:23:53 | sean-k-mooney | so include all the package by default and then exclude ones we have issues with | |
| 13:24:03 | sean-k-mooney | for example cryptography | |
| 13:26:07 | gibi | sean-k-mooney: I have to think about how can we effectively decide what to filter out | |
| 13:27:27 | sean-k-mooney | for me it would be anything that is normally isntalled form the package manager | |
| 13:27:41 | sean-k-mooney | although with tox we might be abel to avoid that | |
| 13:28:21 | sean-k-mooney | i know in devstack cryptography has been problematic in the past due to the fact its normally already installed in teh vm and we cant remove/upgrade it | |
| 13:29:04 | gibi | sean-k-mooney: the problem is that we have no way to force lower constraints transitively with the pip tooling | |
| 13:29:29 | gibi | so as soon as direct dept has cross dependencies we are lost do the the tooling limits | |
| 13:32:21 | sean-k-mooney | pip takes the first constrait for a given package as the constiat too use | |
| 13:32:32 | sean-k-mooney | at least that used to be the behavior | |
| 13:32:40 | sean-k-mooney | i have not looked in a while. | |
| 13:33:18 | sean-k-mooney | but if you include the modifed requirements fiel with -c before uc i think that will make it work for transitive deps | |
| 13:33:46 | sean-k-mooney | of couse if one of our transitive dep increase its min version then we will have to bump ours | |
| 13:34:17 | sean-k-mooney | sorry direct deps | |
| 13:34:36 | sean-k-mooney | it basically gets problematic becasue pip does not support this usecase | |
| 13:38:06 | gibi | yeah | |
| 13:38:24 | gibi | so I don't want to go big and hit the same wall we had before with the lower constraint job | |
| 13:39:02 | sean-k-mooney | i have +2d the relevent patches but i still dont really like this change | |
| 13:39:40 | gibi | this is the smalles, lowest risk change, that can catch the specific issue we had during Zed | |
| 13:40:07 | gibi | I agree that it does not solve every aspect of the generic issue, but I think it is already useful | |
| 13:40:35 | gibi | I cannot promise I can solve the generic issue either | |
| 13:49:53 | opendevreview | Justas Poderys proposed openstack/nova-specs master: Add support for Napatech LinkVirt SmartNICs https://review.opendev.org/c/openstack/nova-specs/+/859290 | |