| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-04-04 | |||
| 17:51:28 | dansmith | yeah, that worked | |
| 17:54:13 | dansmith | the pep8 target worked, but I guess it doesn't use the shared venv so I guess it got rebuilt and the one fast8 uses didn't trigger it or soemthing | |
| 17:59:34 | sean-k-mooney | it could be related to the fact we now dont set useddevelop | |
| 17:59:37 | sean-k-mooney | or what ever | |
| 18:01:20 | dansmith | we still do for all the regular venvs, AFAICT | |
| 18:01:44 | dansmith | I think it's more likely a stale bin/python link in that venv pointing to the old python3.10 on my system or something | |
| 18:01:52 | sean-k-mooney | as in i cant fine the sepcific thing i was likign for | |
| 18:02:02 | sean-k-mooney | it might be related to this https://github.com/openstack/nova/commit/5e5b6751d32aa50dc372c55b5c2044d0dade51f4 | |
| 18:02:13 | sean-k-mooney | but i toug we change how ew used sdigts | |
| 18:02:32 | sean-k-mooney | i tought we did somethign for tox 4 | |
| 18:02:39 | dansmith | yeah, that added isntall_command which was the problem | |
| 18:03:54 | sean-k-mooney | ok ya that was the tox 4 change https://review.opendev.org/c/openstack/nova/+/869545 | |
| 18:04:12 | sean-k-mooney | i tought thact actully bumped the min version to 4 but it did not | |
| 18:04:16 | sean-k-mooney | just made it compatible | |
| 18:55:01 | sean-k-mooney | dansmith: im going to call it a day but this is the youtube link i added to the vdpa spec https://www.youtube.com/watch?v=zyDSUU0TLB4 its not that long but it answered some of my questions | |
| 18:55:22 | dansmith | I saw the link but haven't watched it | |
| 18:55:24 | dansmith | cool | |
| 18:56:21 | sean-k-mooney | i think we are going to want two flags hw_disk_bus=vdpa-blk and then a second flag for if it requires hardware offload | |
| 18:56:48 | sean-k-mooney | if we want to supprot the software and hardware backends eventually | |
| 18:57:20 | dansmith | hmm okay I guess I don't know why we'd need two flags, but I'm sure it's ignorance.. I'll watch, we can chat tomorrow or later | |
| 18:57:55 | sean-k-mooney | well its vdpa-blk in the guest in either caes but ya watch the vid and we can chat about it whenever | |
| 18:57:57 | sean-k-mooney | o/ | |
| 18:58:04 | dansmith | o/ | |
| 19:34:30 | opendevreview | Merged openstack/nova stable/yoga: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874065 | |
| #openstack-nova - 2023-04-05 | |||
| 09:09:49 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866155 | |
| 09:10:41 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866156 | |
| 09:17:09 | bauzas | sean-k-mooney: could you please look at this small PTL doc change ? https://review.opendev.org/c/openstack/nova/+/875730 | |
| 09:46:23 | sean-k-mooney | bauzas: sure ill review it now. for what its worth i never really found the nova wiki useful | |
| 09:46:54 | sean-k-mooney | so i prefer having this in the main schdule | |
| 09:48:07 | sean-k-mooney | i would almost prefer to remove the wiki entirly and move the meeting to etherpad instead but thats a seperate topic | |
| 09:49:24 | sean-k-mooney | * Run the `count-blueprints`__ script daily to gather data for the cycle | |
| 09:49:25 | sean-k-mooney | burndown chart | |
| 09:49:42 | sean-k-mooney | do you really think that has value ? | |
| 09:50:00 | sean-k-mooney | i really dont | |
| 09:54:54 | sean-k-mooney | bauzas: soft -1 i have two questions inline | |
| 09:55:07 | sean-k-mooney | over all the update looks good | |
| 10:17:09 | bauzas | sean-k-mooney: sorry I was afk as I need to taxi my daughter | |
| 10:18:02 | opendevreview | Merged openstack/nova stable/xena: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866155 | |
| 12:22:29 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866156 | |
| 13:40:02 | dansmith | bauzas: gmann: can we enable functional-py311 in our tox? I submitted a patch yesterday I thought was passing functional, because when I ran it locally I got a passing tox run (of unit tests) | |
| 13:40:21 | dansmith | because of the silly tox behavior where it will run any missing testenv | |
| 14:14:09 | bauzas | dansmith: hem, yeah, I guess we can now support py 3.11 by the TC ? | |
| 14:14:36 | dansmith | I don't think we've made that call yet, no, but I don't see why we can't just have our tox not broken for people with 3.11-based dev machines | |
| 14:20:32 | dansmith | bauzas: ^ | |
| 14:21:33 | bauzas | dansmith: because you run tox -efunctional by default ? | |
| 14:22:05 | dansmith | bauzas: no, because if you run tox -efunctional-py311 right now, it will say "huh, there's no such testenv for that, so I'll just run the base one under that name and not say anything" ... which runs unit :) | |
| 14:22:07 | bauzas | sorry, I need to understand the problem | |
| 14:22:15 | dansmith | tox has always done | |
| 14:22:15 | bauzas | dansmith: hah, ok | |
| 14:22:16 | dansmith | that | |
| 14:22:22 | dansmith | tox -enot-a-real-thing will pass | |
| 14:22:48 | bauzas | dansmith: yeah because you pin the python version when calling the target | |
| 14:22:53 | dansmith | so I just want to put up a tox.ini modification to catch 311 as well | |
| 14:23:04 | dansmith | not really related to the python version | |
| 14:23:18 | dansmith | well, it is in the sense that functional-310 won't work | |
| 14:23:20 | bauzas | dansmith: okay, then you already had a patch ? | |
| 14:23:20 | dansmith | maybe that's what you mean | |
| 14:23:27 | dansmith | bauzas: locally, I'll push | |
| 14:24:43 | bauzas | dansmith: okay, then upload it | |
| 14:25:35 | opendevreview | Dan Smith proposed openstack/nova master: Allow running functional-py311 https://review.opendev.org/c/openstack/nova/+/879559 | |
| 14:28:33 | bauzas | dansmith: looks to me we don't need to wait for the TC to be saying we should support a python version, as we merged the same for 3.10 without this https://review.opendev.org/c/openstack/nova/+/839029 | |
| 14:28:51 | dansmith | right, like I said, I don't think that matters :) | |
| 14:28:54 | bauzas | dansmith: so, +1 to your change but you could add a non-voting job if you want | |
| 14:29:01 | dansmith | I was just asking because I was surprised nobody had done it | |
| 14:29:07 | dansmith | bauzas: I don't want a job | |
| 14:29:11 | dansmith | all I want is to be able to run it locally | |
| 14:29:33 | dansmith | without this, it will run unit tests instead of functional if you try | |
| 14:29:33 | bauzas | ack, if this is only for local testing, gtm | |
| 14:29:47 | dansmith | we can add a job when the TC moves us to a 3.11-based distro, this is just for local testing yes | |
| 14:30:35 | bauzas | all cool then | |
| 14:43:38 | opendevreview | Sylvain Bauza proposed openstack/nova master: Update to the PTL guide https://review.opendev.org/c/openstack/nova/+/875730 | |
| 15:28:38 | opendevreview | Dan Smith proposed openstack/nova master: Allow running functional-py311 https://review.opendev.org/c/openstack/nova/+/879559 | |
| 15:28:38 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id column to instances table https://review.opendev.org/c/openstack/nova/+/879499 | |
| 15:28:39 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 15:54:48 | opendevreview | Merged openstack/nova stable/xena: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866156 | |
| 15:55:24 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/821980 | |
| 17:26:09 | gmann | dansmith: bauzas yes, that is what we did in past also to test the py version in advance so that we will make things compatible when it is in testing runtime | |
| 17:27:07 | gmann | dansmith: bauzas: do you know if any distro support it in their official release? we can add unit test job also as non voting in general template | |
| 17:27:23 | dansmith | fedora has it | |
| 17:27:32 | dansmith | I don't think we need to add a job yet, personally | |
| 17:27:56 | dansmith | I just don't want to run functional-py311, see it pass (because it's running unit tests), submit my patch and then see ALL the functionals have failed :P | |
| 17:28:05 | gmann | ok, I was waiting for debian to release it and we can add job that time | |
| 17:28:42 | gmann | true, adding functional tests run also on that is good idea | |
| 17:29:24 | dansmith | gmann: to be clear, I can run 'tox -epy311' and get unit tests on 3.11 as expected, | |
| 17:29:31 | dansmith | but I can't run functionals locally because there is no testenv | |
| 17:29:49 | dansmith | so tox just makes up a fake functional-py311 based on the base testenv (which is unit tests) and then lies to me :) | |
| 17:30:17 | gmann | dansmith: ah yeah due to default tox env https://review.opendev.org/c/openstack/nova/+/879559/2/tox.ini#3 | |
| 17:30:22 | dansmith | right | |
| 17:30:25 | gmann | dansmith: +W on your patch | |
| 17:30:28 | dansmith | thanks | |
| 17:37:29 | sean-k-mooney | i think 3.11 is also alredy in fedora 37 and will be in ubuntu 23.04 | |
| 17:37:41 | sean-k-mooney | so it should be in the cloud archve ocne that releases | |
| 17:38:30 | sean-k-mooney | 3.11.0~rc1 shoudl be in jammy-updates/universe packages already | |
| 17:38:54 | sean-k-mooney | so it wont be long before we have it on 22.04 | |
| 17:41:15 | sean-k-mooney | dansmith: oh while i think of it i appoved the schduler lazy loading patch thanks for the reminder | |
| 17:41:21 | dansmith | thanks | |
| 17:41:37 | sean-k-mooney | are we going to backport that | |
| 17:41:51 | sean-k-mooney | i assume so but not sure how far | |
| 17:41:59 | dansmith | upstream? I wouldn't think so | |
| 17:42:41 | sean-k-mooney | ok i would at least cherry pick it upstream to antelope if we are going to backpot it downstream and see what elodilles thinks | |