| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-03-16 | |||
| 10:56:53 | sean-k-mooney | ok makes sense | |
| 10:57:13 | songwenping | yes, the filter error is mislead. | |
| 10:57:38 | sean-k-mooney | ya you bacially need to look at the set of all filters when debugging it | |
| 10:57:48 | sean-k-mooney | not just the last one that elimiated the final hosts | |
| 10:58:28 | songwenping | yeah the debug info is very useful. | |
| 10:58:55 | sean-k-mooney | some operators run with dbug on all the time for what its worth | |
| 10:59:05 | sean-k-mooney | you might now want it enabeld on all the services | |
| 10:59:14 | sean-k-mooney | but i like having it on for the scheduler at least | |
| 10:59:31 | bauzas | ok gtk | |
| 10:59:52 | sean-k-mooney | there is an argument to be made for moving those specific logs to info level | |
| 11:00:15 | sean-k-mooney | we didnt in the past because it can be a bit noisy but its a trade off | |
| 11:11:11 | Uggla | sean-k-mooney, gibi, bauzas Hi, is the a way to disable a flag set with self.flags(...) ? | |
| 11:15:41 | sean-k-mooney | Uggla: well you can just set it to what you want but if you mean you want to revert it to the unset state then you likely need to do thave via oslo | |
| 11:16:20 | sean-k-mooney | https://docs.openstack.org/oslo.config/latest/reference/locations.html | |
| 11:16:33 | sean-k-mooney | so flags i think is calling set_override | |
| 11:17:05 | sean-k-mooney | https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.ConfigOpts.reset | |
| 11:17:09 | sean-k-mooney | there is a reset funciton | |
| 11:17:25 | sean-k-mooney | so you would do CONF.my_section.my_var.reset() | |
| 11:17:38 | Uggla | sean-k-mooney, cool I'm going to have a look. Thanks | |
| 11:17:39 | sean-k-mooney | that will clear any orverdie ro default value | |
| 11:18:00 | sean-k-mooney | reset()¶ | |
| 11:18:00 | sean-k-mooney | reset()¶ | |
| 11:18:02 | sean-k-mooney | Clear the object state and unset overrides and defaults. | |
| 11:19:06 | sean-k-mooney | Uggla: feel free to wrap that up in a reset_flags helper funciton if you want to use it | |
| 11:20:02 | sean-k-mooney | i have never needed to od this in a test before so before you do are you sure you need this | |
| 11:20:38 | sean-k-mooney | usually i woudl sugges makeign sure the parent of your test class does not do thing you dont need | |
| 11:21:02 | sean-k-mooney | instead of trying to reset teh config state | |
| 11:23:59 | Uggla | sean-k-mooney, I'm not sure I try to have a src node configure with a flag and a dest node without. But it seams that flags are 'global' in functional test. | |
| 11:24:13 | sean-k-mooney | oh you cant do that | |
| 11:24:25 | sean-k-mooney | its a limiation of our test infra | |
| 11:24:47 | sean-k-mooney | there is a way to make it work with context manger which i demonstarted a few years ago but we decided not to do that | |
| 11:25:31 | sean-k-mooney | if your doing this in a functional test you will need to mock it differntly | |
| 11:25:54 | Uggla | sean-k-mooney, the idea is to simulate a live migration from src node with a flag to dst node without this flag | |
| 11:26:17 | sean-k-mooney | yes you cant do that today in our func tests without a lot of hacks | |
| 11:29:27 | Uggla | sean-k-mooney, yes I manage to do what I wanted with mock. But I was wondering if something simpler can be used. | |
| 11:29:47 | Uggla | Is the reset proposed above a potential way to do that ? | |
| 11:30:02 | sean-k-mooney | not really | |
| 11:30:10 | sean-k-mooney | when you reset it it will reset it for both computes | |
| 11:31:58 | Uggla | sean-k-mooney, in my case I think it will be ok, I'll try | |
| 11:32:16 | sean-k-mooney | it likely will be racy | |
| 11:32:35 | sean-k-mooney | basicaly this is something we currently try not to do | |
| 11:32:52 | sean-k-mooney | so if you get ti workign we will have to review it very carefully | |
| 11:38:43 | sean-k-mooney | Uggla: https://stackoverflow.com/questions/33504543/passing-import-context-variables-to-decorators/33507308#33507308 | |
| 11:42:40 | sean-k-mooney | thats not quite what you want but i had an example for this in nova somewhere in gerrit with context manager but i cant find it | |
| 13:02:44 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/864730 | |
| 13:33:42 | opendevreview | Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | |
| 13:33:42 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 13:37:01 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 17:32:15 | opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | |
| 18:12:21 | darkhorse | hi team, i noticed that the periodic tasks defined with @periodic_task decorator at scheduler/manager.py performs tasks on all workers instead of running once at defined spacing. is that a bug or a designed behavior? | |
| 18:12:30 | darkhorse | hi team, i noticed that the periodic tasks defined with @periodic_task decorator at scheduler/manager.py performs tasks on all workers instead of running once at defined spacing. is that a bug or a designed behavior? | |
| 18:24:13 | dansmith | darkhorse: which periodic are you looking at? but yes, it's *expected* and the periodic should use some locking to prevent it from running simultaneously if need-be | |
| 18:26:45 | darkhorse | dansmith: thank you for clarification. i have added a custom periodic task that should run every minute. will you point me to an example code that uses locking? | |
| 18:27:05 | dansmith | darkhorse: oslo lockutils :) | |
| 18:27:26 | dansmith | with external=true so it uses a lock file, which all the others will see | |
| 18:27:38 | dansmith | if not external, then it'd just be per-process, which wouldn't help | |
| 18:29:43 | darkhorse | ok thank you! | |
| #openstack-nova - 2023-03-17 | |||
| 09:32:35 | opendevreview | René Ribaud proposed openstack/nova master: Reproducers for bug 1869804 https://review.opendev.org/c/openstack/nova/+/877772 | |
| 09:32:36 | opendevreview | René Ribaud proposed openstack/nova master: Fix for bug 1869804. https://review.opendev.org/c/openstack/nova/+/877773 | |
| 16:23:41 | opendevreview | René Ribaud proposed openstack/nova master: Reproducers for bug 1869804 https://review.opendev.org/c/openstack/nova/+/877772 | |
| 16:23:41 | opendevreview | René Ribaud proposed openstack/nova master: Fix for bug 1869804. https://review.opendev.org/c/openstack/nova/+/877773 | |
| #openstack-nova - 2023-03-18 | |||
| 05:04:23 | opendevreview | Merged openstack/nova stable/wallaby: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871416 | |
| 07:26:59 | opendevreview | Merged openstack/nova stable/victoria: Retry attachment delete API call for 504 Gateway Timeout https://review.opendev.org/c/openstack/nova/+/866087 | |
| 08:37:49 | opendevreview | Vasyl Saienko proposed openstack/placement master: Do not use coalesce for consumers.uuid https://review.opendev.org/c/openstack/placement/+/877852 | |
| #openstack-nova - 2023-03-20 | |||
| 10:09:39 | dvo-plv | sean-k-mooney: Hello, Are you here ? | |
| 10:31:15 | opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | |
| 12:01:56 | sean-k-mooney | stephenfin: speaking of the sdk i proposed this revert https://review.opendev.org/c/openstack/python-openstackclient/+/877017 mainly for getting some discussion at the ptg | |
| 12:02:27 | stephenfin | sean-k-mooney: I thought I replied to that. Evidently not. | |
| 12:03:56 | stephenfin | I raised the concerns when it merged but we decided to get it in while we still had students working on it. That's relatively easy to fix without removing SDK support, thankfully. Just needs someone to do it | |
| 12:17:17 | sean-k-mooney | ya i dont think we need to drop the sdk integration but i think we shoudl restore to only showing filed that are non empty by default unless you pass --long | |
| 12:17:41 | sean-k-mooney | i wanted to discuss about the double naming | |
| 12:17:50 | sean-k-mooney | i.e. do we want to keep the api names | |
| 12:18:01 | sean-k-mooney | or the translated names used by sdk | |
| 12:18:47 | sean-k-mooney | again im kind of ok with --long haveing both potentionally | |
| 12:19:00 | sean-k-mooney | i just dont think we should have the duplicate names by default | |
| 12:19:27 | sean-k-mooney | ideally i think the switch to sdk should not have changed the output | |
| 12:19:52 | sean-k-mooney | but that could have been done in a later release | |
| 12:30:07 | dvo-plv | Hello, Sean. I would like to notify that we had fixed yout comments in this blueprint: https://review.opendev.org/c/openstack/nova-specs/+/868377 | |
| 12:32:05 | sean-k-mooney | thanks | |
| 12:32:23 | dvo-plv | Also I have a question about comment 166 in this blueprint https://docs.openstack.org/neutron/latest/admin/config-ovs-offload.html | |
| 12:33:49 | sean-k-mooney | which comment? | |
| 12:34:02 | sean-k-mooney | can you link to it | |
| 12:36:06 | sean-k-mooney | dvo-plv: id you mean this comment https://review.opendev.org/c/openstack/nova-specs/+/859290/8/specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst#166 | |
| 12:36:36 | dvo-plv | How it will be better to solve comment 166. As you can remember, we have OVS fork and a little bit another nic initialization process. So does we should add all this specific changes to the document what was mentined in the comment, or it will be better to described new feature and add that this particulat feature supported by Napatech nic and link on the Napatech website with all steps how to configure that like it done by M | |
| 12:36:54 | dvo-plv | exactly | |
| 12:44:24 | sean-k-mooney | well the curent document describe the steps need for mellonox nics | |
| 12:44:57 | sean-k-mooney | i would hope that you woudl not actully need to add much info that is vendor specific | |
| 12:45:32 | sean-k-mooney | but you can refernece external sites in the docs provided its not pay-walled | |
| 12:46:31 | sean-k-mooney | you menthioned that this woudl also work with vanilla ovs-dpdk | |
| 12:58:15 | dvo-plv | Okay, So we will add some information about dpdk representors port and how it configure in the OpenStack with virtio-forwarder vnic type. All vendor specific info will be in the Napatech resources, it is free. | |
| 14:38:50 | dvo-plv | sean-k-mooney: I also have a question about PTG meeting. I found https://etherpad.opendev.org/p/nova-bobcat-ptg and https://etherpad.opendev.org/p/neutron-bobcat-ptg agenda files. Should I add spec file discussion to the nova agenda ? | |
| 15:02:03 | sean-k-mooney | dvo-plv: add it to the neutro cross proejct section in the nova doc | |
| 15:02:18 | sean-k-mooney | here https://etherpad.opendev.org/p/nova-bobcat-ptg#L59 | |
| 15:02:20 | sean-k-mooney | dvo-plv: | |
| 15:09:16 | opendevreview | René Ribaud proposed openstack/nova master: Reproducers for bug 1869804 https://review.opendev.org/c/openstack/nova/+/877772 | |
| 15:09:17 | opendevreview | René Ribaud proposed openstack/nova master: Fix for bug 1869804. https://review.opendev.org/c/openstack/nova/+/877773 | |
| 15:10:28 | dvo-plv | I added, thanks | |
| 15:13:46 | dvo-plv | Do I need to be presented on all meetings from Mon to the Fri, or there will be agenda per day ? | |
| 18:08:30 | sean-k-mooney | dvo-plv: there will be an adgenda per day and we will ping people on irc when we get to there topic | |
| 18:08:46 | sean-k-mooney | there will be a 1 hour slot for nova/neutorn topics | |