| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-03-13 | |||
| 15:24:23 | dansmith | wtf, I just fetched and had to create it myself | |
| 15:25:16 | dansmith | hrm, okay | |
| 15:25:23 | dansmith | must'n'tve worked or something | |
| 15:25:59 | sean-k-mooney | i assume your working on the set service_id in compute node table spec | |
| 15:26:10 | dansmith | yeah ^ | |
| 15:26:20 | sean-k-mooney | cool | |
| 15:31:16 | dansmith | I'm realizing maybe I should have tried harder to get this second phase into 2023.1 because of the SLURP rules, but oh well | |
| 15:37:47 | tobias-urdin | sean-k-mooney: if you have some time over this week can you check the mdev naming fixes proposed to stable branches, starting with zed https://review.opendev.org/c/openstack/nova/+/866152 and the parent patch and cherry-picks w/ parents, ty! | |
| 16:01:20 | bauzas | tobias-urdin: I think I said +2 for stable/zed, right? | |
| 16:01:39 | bauzas | correct, so we need one stable core ^ | |
| 16:01:56 | tobias-urdin | bauzas: yes! just need more, then moving on the the cherry-picks to older releases | |
| 16:10:21 | bauzas | ++ | |
| 16:12:53 | opendevreview | Dan Smith proposed openstack/nova-specs master: Add compute-object-ids spec for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877291 | |
| 18:04:21 | opendevreview | Merged openstack/nova master: Unbind port when offloading a shelved instance https://review.opendev.org/c/openstack/nova/+/853682 | |
| 18:31:03 | gmann | elodilles: fixed your comment, please check https://review.opendev.org/q/I4e3e5732411639054baaa9211a29e2e2c8210ac0+status:open | |
| 18:39:44 | elodilles | gmann: looking | |
| 18:42:17 | gmann | thanks | |
| 18:53:34 | elodilles | looks good, thanks! | |
| 19:09:48 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing 2023.1|2 unit tests job template https://review.opendev.org/c/openstack/nova/+/877320 | |
| 19:10:13 | opendevreview | Ghanshyam proposed openstack/nova stable/2023.1: DNM: testing 2023.1|2 unit tests job template https://review.opendev.org/c/openstack/nova/+/877262 | |
| 19:10:26 | opendevreview | Ghanshyam proposed openstack/nova stable/zed: DNM: testing 2023.1|2 unit tests job template https://review.opendev.org/c/openstack/nova/+/877263 | |
| 19:10:52 | gibi | Uggla: what am I missing. I try to test your manial series I have an active nfs share in manila. I have a stopped VM in nova. When I associate the share with the VM the compute tries to mount the share but it seems it stuck. https://paste.opendev.org/show/bFyX8c5xjnPQdPk9YEiK/ I also tried to manually mount on the host but that also stucks | |
| 19:15:44 | gibi | Uggla: btw after the API time outs the share remains in "inactive" state in nova side so I think nova thinks that the mount was successfully but it probably isn't: https://paste.opendev.org/show/bQlQVJaLOF1fhfuQR6ND/ | |
| 19:17:42 | gibi | Uggla: then when I start the VM with openstack server start it happily starts up an uses the empty directory as the share where the nfs share should have been mounted | |
| 19:18:27 | gibi | so it looks everything is OK but in the other hand the VM now has write access to a hypervisor directory without size limites | |
| 19:22:29 | gibi | Uggla: I can also confirm my suspicion that if an active VM with an active share is being deleted then we leak the active share_mapping in the DB and therefore probably leaking the mount on the hypervisor too https://paste.opendev.org/show/bs44BjHHcFkICNNlqw9R/ | |
| 19:22:45 | gibi | I cannot confirm the latter as I cannot mount the share in the first place | |
| #openstack-nova - 2023-03-14 | |||
| 05:18:09 | opendevreview | Amit Uniyal proposed openstack/nova stable/wallaby: fup: Print message logging uncaught nova-manage exceptions https://review.opendev.org/c/openstack/nova/+/877334 | |
| 08:45:14 | Uggla | gibi, Hi I agree that currently nothing prevent leaking the share if you delete the VM. | |
| 08:47:56 | bauzas | Uggla: you tested it ? | |
| 08:48:00 | bauzas | that was my question | |
| 08:48:04 | Uggla | yes | |
| 08:49:27 | bauzas | ok, so | |
| 08:49:32 | bauzas | https://review.opendev.org/c/openstack/nova/+/831193/24/nova/db/main/models.py#677 | |
| 08:50:01 | bauzas | that means the FK would be not relationed | |
| 08:51:31 | Uggla | gibi, I'm surprised regarding the mount error not tracked, any idea about what is causing the issue. Firewalling maybe ? | |
| 08:53:08 | gibi | Uggla: what manila config you used for testing? I tried the default that is DHSS=True + GenericDriver | |
| 08:55:17 | Uggla | gibi, DHSS=false LVM driver | |
| 08:55:48 | gibi | Uggla: is there a reason why GenericDriver + DHSS=true would not work? | |
| 08:55:56 | gibi | (I'm restacking with LVM DSSF=false now) | |
| 08:56:05 | gibi | *DHSS | |
| 08:57:01 | Uggla | gibi, to be honest I have not tested with DHSS=false thinking that in our context that was not necessary. So I don't know. :( | |
| 08:58:20 | bauzas | so, IMHO, we should delete the share mapping in the instance delete call | |
| 08:58:35 | bauzas | as we can't use the delete cascade SQL support | |
| 08:58:49 | Uggla | bauzas, yep and add the semaphore to avoid any race. | |
| 08:59:09 | bauzas | + in init_instance(), recreating the share like I said | |
| 08:59:30 | bauzas | and maybe a periodic for making sure we don't leak any shares | |
| 09:00:31 | bauzas | Uggla: can you look at what happens to the foreign key ? | |
| 09:01:59 | Uggla | bauzas, yes I'll try to simulate it again. | |
| 09:03:45 | bauzas | cool | |
| 10:57:49 | opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor https://review.opendev.org/c/openstack/nova/+/867077 | |
| 13:35:39 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix duplicate cell creation with same name https://review.opendev.org/c/openstack/nova/+/876940 | |
| 14:17:15 | bauzas | gibi: sean-k-mooney: other cores, we need this https://review.opendev.org/c/openstack/nova-specs/+/876887 to be merged quick soon please | |
| 14:17:22 | bauzas | quite* soon | |
| 14:21:16 | sean-k-mooney | ah the redirects sure ill look now | |
| 14:21:38 | gibi | good for me | |
| 14:22:02 | sean-k-mooney | same looks fine | |
| 14:22:13 | sean-k-mooney | im happy the script worked with the new name format | |
| 14:30:49 | opendevreview | Merged openstack/nova-specs master: Move Antelope implemented specs https://review.opendev.org/c/openstack/nova-specs/+/876887 | |
| 14:36:02 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if base image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| 14:38:37 | bauzas | thanks folks | |
| 15:17:22 | gibi | bauzas: I'm happy that you are only asking me to review these realtively easy patches as otherwise I would have to say no :) | |
| 16:00:06 | bauzas | #startmeeting nova | |
| 16:00:06 | opendevmeet | Meeting started Tue Mar 14 16:00:06 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:06 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:06 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:12 | bauzas | howdy folks | |
| 16:00:18 | dansmith | o/ | |
| 16:00:21 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:04 | bauzas | ok, let's start, people can join meanwhile | |
| 16:01:10 | gibi | o/ | |
| 16:01:10 | bauzas | #topic Bugs (stuck/critical) | |
| 16:01:15 | bauzas | #info No Critical bug | |
| 16:01:19 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 16 new untriaged bugs (+2 since the last meeting) | |
| 16:01:26 | elodilles | o/ | |
| 16:01:30 | auniyal | o/ | |
| 16:02:02 | bauzas | elodilles: I saw you did a bit of triage | |
| 16:02:07 | elodilles | yepp | |
| 16:02:08 | bauzas | I also looked at the new bugs todayt | |
| 16:02:16 | elodilles | thanks! | |
| 16:02:21 | bauzas | (to see whether we were regressing) | |
| 16:02:31 | bauzas | elodilles: nothing you want to discuss ? | |
| 16:02:43 | auniyal | bauzas, regarding this - https://bugs.launchpad.net/nova/+bug/2011567 | |
| 16:02:52 | auniyal | The message right now is, "fill this in after the PTG", shall we update it to something else. | |
| 16:02:57 | gmann | o/ | |
| 16:03:21 | bauzas | auniyal: as I said as a comment, we don't have cycle priorities | |
| 16:03:40 | bauzas | so, either we delete the Bobcat file, or meh | |
| 16:04:07 | sean-k-mooney | we have kept it for other release | |
| 16:04:17 | sean-k-mooney | its been blank for years at this point | |
| 16:04:18 | bauzas | yup, that's what I wrote | |
| 16:04:33 | bauzas | we can provide some upstream priorities if we want | |
| 16:04:40 | auniyal | okay, the msg seems like we missed to update after PTG | |
| 16:04:47 | bauzas | but, if we don't have anyone, should we delete the file ? | |
| 16:05:03 | sean-k-mooney | im ok either way | |
| 16:05:10 | bauzas | we could discuss this in the PTG if we want | |
| 16:05:14 | sean-k-mooney | sure | |
| 16:05:18 | bauzas | kk | |
| 16:05:18 | auniyal | ack | |
| 16:05:21 | bauzas | let's do this then | |
| 16:05:42 | bauzas | auniyal: I also closed your other bug report https://bugs.launchpad.net/nova/+bug/2011564 | |