| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-09 | |||
| 03:30:13 | opendevreview | Yusuke Okada proposed openstack/nova master: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/873216 | |
| 06:05:34 | opendevreview | Nobuhiro MIKI proposed openstack/nova master: libvirt: Add 'COMPUTE_ADDRESS_SPACE_*' traits support https://review.opendev.org/c/openstack/nova/+/873221 | |
| 09:14:09 | Uggla | bauzas, gibi o/ | |
| 09:16:39 | Uggla | bauzas, gibi looking at the https://review.opendev.org/c/openstack/nova/+/839401/22 are we all agree to remove the ShareMappingLibvirt* although that is not following the spec and might be more difficult if we want to create a dedicated module (os-share) later ? | |
| 09:17:55 | Uggla | bauzas, gibi, of course doing that will simplify the code but I will have to review lot of stuff. | |
| 09:39:51 | bauzas | Uggla: I agree with you | |
| 09:40:58 | gibi | ...loading context | |
| 09:44:42 | gibi | For me the content of ShareMappingLibvirt is OK, it is just placed to a too public place. | |
| 09:45:48 | gibi | i.e. I'm OK to use inheritance to model that a ShareMapping my need to be mounted by a libvirt or by other virt driver | |
| 09:48:18 | Uggla | gibi, hum I think what bauzas and john expect is the removal of convert and inheritance and move that in the driver itself. | |
| 09:48:44 | gibi | sure tha is also an option | |
| 09:49:21 | Uggla | gibi, if not in the object where do you put the act code ? | |
| 09:50:30 | gibi | the libvirt specific classes can be placed to nova.virt.libvirt afaik. But as you said bauzas and johnthetubaguy might want not to have them as ovos even if they are moved under nova.virt.libvirt | |
| 09:51:13 | gibi | so to expedite things I think it would be easier to simply remove the driver specific ovo | |
| 09:51:34 | gibi | and create functions in the driver that takes a generic ShareMapping and do the driver specific bits with it | |
| 09:52:20 | gibi | I guess that what bauzas and johnthetubaguy suggests | |
| 09:54:23 | Uggla | gibi, yes sounds like it is ok for you to go in this way as well ? | |
| 09:54:46 | gibi | yeah, OK with me | |
| 09:56:10 | Uggla | ok so I'll change the code in this way. | |
| 09:57:54 | bauzas | gibi: tbc, I w | |
| 09:58:10 | bauzas | I don't want to have a ovo inheritance for this object | |
| 09:58:18 | bauzas | Uggla: ^ | |
| 09:58:46 | bauzas | since this object is not about providing fields or persisting them | |
| 09:58:53 | bauzas | by RPC calls | |
| 09:59:15 | bauzas | but yeah, we can have a specific python object for it in libvirt if Uggla wants | |
| 09:59:28 | Uggla | bauzas, yep I will keep only the ShareMapping / ShareMappingList objects | |
| 10:00:36 | Uggla | bauzas, not sure it is worth creating an object in the libvirt part, I'll see. | |
| 10:05:37 | gibi | bauzas: we have examples where we use ovo not just to persist data. We even have examples to driver specific data in ovo https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py | |
| 10:06:19 | gibi | or driver specific ovo | |
| 10:09:27 | bauzas | gibi: sure, but those objects are used for being passing between services | |
| 10:10:07 | bauzas | and those are only for fields | |
| 10:10:31 | Uggla | sounds like https://miro.medium.com/v2/resize:fit:720/format:webp/1*LzKppsHIMabQhnCCdpdQXg.jpeg :) | |
| 10:10:40 | bauzas | gibi: while the previous ShareMappingLibvirt objects were directly calling libvirt | |
| 10:14:54 | gibi | bauzas: I never really got why we are not coupling data and the methods using that data together into the ovos. That is one of the main reason classes exists to couple data and code acting on that data together :) | |
| 10:15:26 | gibi | but I rest my case. It is a theorethical discussion | |
| 10:15:51 | bauzas | gibi: well I remember when dansmith created those objects | |
| 10:16:13 | bauzas | gibi: and I'm pretty sure I can find you some links explaining how this works | |
| 10:16:26 | bauzas | I mean, not how, but why | |
| 10:16:46 | bauzas | (sorry, not explaining you're bad, just about the situation) | |
| 10:17:06 | bauzas | we could have specific libvirt objects like you said | |
| 10:17:24 | bauzas | but those objects would only have values | |
| 10:18:16 | gibi | and that is the point I disagree with out object model ^^ | |
| 10:18:47 | gibi | but as I said I rest my case. I don't want to change how nova looks at this point in its lifecycle | |
| 10:22:14 | ralonsoh | hi folks, do you know when we can set 'device_owner': 'compute:FAIL' for a port? Where is this 'compute:FAIL' coming from? | |
| 10:24:43 | gibi | the FAIL part is interesting | |
| 10:25:07 | ralonsoh | yeah, I've never seen that | |
| 10:25:23 | gibi | as it should be 'compute:%s' % instance.availability_zone | |
| 10:25:47 | ralonsoh | ahhh, that could make sense | |
| 10:25:49 | gibi | so I'm wondering if a) it is manually set by the user b) the availability_zone name is set to fAIL | |
| 10:27:08 | ralonsoh | I'll check that, thanks! | |
| 11:14:19 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: DNM: CI test https://review.opendev.org/c/openstack/nova/+/873242 | |
| 11:15:18 | sean-k-mooney | ralonsoh: its the name of an AZ | |
| 11:15:35 | sean-k-mooney | ah gibi answered | |
| 11:22:18 | sean-k-mooney | gmann: do you think we can get the policy change for nova merged this cycle. specfically the service role support | |
| 11:22:43 | sean-k-mooney | the new defaults were just waiting on placmenemtn correct | |
| 11:29:44 | ralonsoh | sean-k-mooney, yeah, I found the code thanks! | |
| 12:11:58 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/ussuri: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/833437 | |
| 12:13:20 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/train: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/833438 | |
| 12:44:02 | elodilles | bauzas gibi : os-traits release patch has merged | |
| 12:44:10 | gibi | elodilles: thanks | |
| 12:44:23 | bauzas | all cool | |
| 13:20:23 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 13:20:23 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 13:20:24 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 13:20:24 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870933 | |
| 13:20:25 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 13:20:25 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 13:20:26 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 13:20:27 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870937 | |
| 13:20:27 | opendevreview | melanie witt proposed openstack/nova master: Add reset_encryption_fields() and save_all() to BlockDeviceMappingList https://review.opendev.org/c/openstack/nova/+/870938 | |
| 13:20:29 | opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | |
| 13:20:29 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 13:35:36 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: interfaces for managing state and governor https://review.opendev.org/c/openstack/nova/+/868236 | |
| 13:35:36 | opendevreview | Sylvain Bauza proposed openstack/nova master: libvirt: let CPUs be power managed https://review.opendev.org/c/openstack/nova/+/821228 | |
| 13:35:38 | opendevreview | Sylvain Bauza proposed openstack/nova master: Enable cpus when an instance is spawning https://review.opendev.org/c/openstack/nova/+/868237 | |
| 13:36:02 | bauzas | gibi: sean-k-mooney: updated the series ^ | |
| 13:36:07 | bauzas | will provide a fup for docs | |
| 14:36:08 | opendevreview | Merged openstack/nova stable/yoga: Accept both 1 and Y as AMD SEV KVM kernel param value https://review.opendev.org/c/openstack/nova/+/843819 | |
| 15:30:24 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: [stable-only] Remove broken sdk job from wallaby https://review.opendev.org/c/openstack/nova/+/873295 | |
| 15:57:59 | kashyap | bauzas: Maybe it's just best to quickly rename the function here - https://review.opendev.org/c/openstack/nova/+/821228 | |
| 15:58:36 | kashyap | bauzas: (Instead of a follow-up). Something like get_cpu_status() or get_cpu_power_status() -- as either of these names include both offline and online | |
| 16:23:00 | bauzas | what is the fuck this new CI issue ? TypeError: retry_bad_request() missing 1 required positional argument: 'fn' | |
| 16:23:01 | bauzas | https://6b96a36d22f450141095-9e4eb9f05513870f0e5456f29474f6b2.ssl.cf5.rackcdn.com/868236/5/check/nova-ceph-multistore/6011df8/testr_results.html | |
| 16:23:18 | bauzas | dansmith: ^ I'm pretty done with all those glance image issues | |
| 16:23:54 | dansmith | oh crap | |
| 16:24:02 | dansmith | that might be broken in the patch I just did | |
| 16:24:18 | dansmith | which might mean it did't actually get run in the tempest gate | |
| 16:24:20 | dansmith | eesh | |
| 16:24:56 | dansmith | crap yeah | |
| 16:25:06 | dansmith | so that's breaking anyone that runs that job 100% right now :( | |
| 16:25:40 | bauzas | then no worries, everyone can make mistakes | |
| 16:26:11 | dansmith | I was sure I checked, | |
| 16:26:20 | bauzas | including me, having a long list of bugs I created | |
| 16:26:20 | dansmith | but I have about a thousand open unit test report tabs right now :9 | |
| 16:26:23 | dansmith | :( | |
| 16:27:11 | dansmith | need a DNM nova patch against the fix I guess | |
| 16:28:33 | jungleboyj | dansmith: You around? | |
| 16:29:31 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test tempest fix https://review.opendev.org/c/openstack/nova/+/873302 | |
| 16:29:37 | dansmith | bauzas: ^ | |
| 16:29:48 | dansmith | jungleboyj: yes, are you here to hassle me about breaking the ceph job? | |