| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-24 | |||
| 16:50:10 | zigo | Rocky, I haven't started working on it yet... | |
| 16:50:12 | sean-k-mooney | based on the gerrit included in output | |
| 16:50:57 | zigo | sean-k-mooney: Correct. (but not really a pb for me...) | |
| 16:51:43 | sean-k-mooney | anywya lets loop back to this after the meeting | |
| 16:52:06 | sean-k-mooney | if we need it for train then we can backport it to train in oslo | |
| 16:52:13 | sean-k-mooney | but there are plenty of branches to get through first | |
| 16:52:16 | bauzas | is it me or there was a typo in the oslo.utils patch ? https://review.opendev.org/c/openstack/oslo.utils/+/706880/4/oslo_utils/imageutils.py#88 | |
| 16:52:50 | sean-k-mooney | not that i see | |
| 16:52:53 | bauzas | appened ? | |
| 16:53:28 | sean-k-mooney | its a list so i think that valid | |
| 16:53:44 | bauzas | I know I'm not a python expert, but I didn't know that a list object was having an 'appened' method | |
| 16:53:48 | sean-k-mooney | https://docs.python.org/3/tutorial/datastructures.html#more-on-lists | |
| 16:53:49 | bauzas | append, eyes | |
| 16:53:59 | sean-k-mooney | """Add an item to the end of the list. Equivalent to a[len(a):] = [x].""" | |
| 16:54:08 | bauzas | append, yes | |
| 16:54:14 | bauzas | appened, doesn't exist | |
| 16:54:22 | sean-k-mooney | oh | |
| 16:54:46 | bauzas | which tends me thinking this patch is nice but unsufficient | |
| 16:55:06 | sean-k-mooney | ya thats wrong i think but i shoudl not try and spot typos :) | |
| 16:55:19 | sean-k-mooney | that presumably was fixed | |
| 16:55:27 | bauzas | correct, probably in a fup | |
| 16:55:39 | zigo | Well, in this specific case, the code is executed in the format == 'json' path, so it *is* enough ... (but still wrong in that other case) | |
| 16:55:45 | bauzas | so it would require the fup to be dragged down too | |
| 16:56:15 | sean-k-mooney | aparenlty not https://github.com/openstack/oslo.utils/blob/stable/ussuri/oslo_utils/imageutils.py#L89 | |
| 16:56:19 | bauzas | zigo: correct, the bug is only on the string definition | |
| 16:56:25 | zigo | Well, stable/zed has the typo ... :/ | |
| 16:56:28 | bauzas | when you str() | |
| 16:56:34 | bauzas | or you print | |
| 16:56:48 | bauzas | so, technically, you don't need the fix | |
| 16:56:51 | sean-k-mooney | https://github.com/openstack/oslo.utils/commit/d49d5944824f15d00e04e1b9c7f8c3b03b440c95 | |
| 16:57:01 | sean-k-mooney | it was fixed 2 months ago | |
| 16:57:02 | bauzas | anyway, the meeting is close to the end | |
| 16:57:15 | bauzas | how to wrap up on this ? | |
| 16:57:31 | dansmith | I suggest #endmeeting | |
| 16:57:35 | sean-k-mooney | +1 | |
| 16:57:38 | elodilles | :) | |
| 16:57:49 | bauzas | then | |
| 16:57:54 | bauzas | thanks all | |
| 16:57:58 | bauzas | #endmeeting | |
| 16:57:58 | opendevmeet | Meeting ended Tue Jan 24 16:57:58 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:57:58 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-24-16.00.html | |
| 16:57:58 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-24-16.00.txt | |
| 16:57:58 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-24-16.00.log.html | |
| 16:58:07 | bauzas | wasn't that quick, unfortunately | |
| 17:00:31 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 17:00:31 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 17:00:32 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 17:00:33 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 17:00:34 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 17:00:34 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 17:00:35 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 17:00:35 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 17:00:36 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 17:00:36 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 17:00:37 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 17:00:38 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 17:00:38 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 17:00:40 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 17:00:40 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 17:00:42 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 17:00:42 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 17:00:44 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 17:00:44 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 17:00:46 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 17:00:46 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 17:00:48 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 17:00:48 | opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.XX https://review.opendev.org/c/openstack/nova/+/852088 | |
| 17:00:50 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 17:21:49 | priteau | dansmith: Hello. Is there a reason for no backport of https://review.opendev.org/c/openstack/nova/+/871622 to wallaby yet? It seems to backport cleanly with the resolution done in xena. | |
| 17:22:18 | dansmith | priteau: yes, because wallaby is EOL | |
| 17:22:55 | dansmith | well, EM | |
| 17:23:23 | priteau | But you will still propose a patch for it or not at all? | |
| 17:23:41 | dansmith | priteau: you go ahead :) | |
| 17:23:49 | priteau | OK | |
| 17:24:35 | priteau | The backports don't have the "cherry picked from commit" line by the way | |
| 17:24:48 | priteau | (maybe because it wasn't a cherry pick at all) | |
| 17:25:08 | opendevreview | Pierre Riteau proposed openstack/nova stable/wallaby: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871557 | |
| 17:26:17 | priteau | Hum, maybe it is new Gerrit behavior? | |
| 17:30:49 | dansmith | priteau: because they were all pre-canned ahead of time yeah | |
| 17:31:04 | gibi | priteau: I think the cherry picked from line is comfing from git cherry-pick -x | |
| 17:31:56 | priteau | No, I know what's happening. Gerrit only adds it when you cherry-pick a *merged* change. | |
| 17:32:17 | priteau | I cherry-picked from stable/xena to get the conflict resolution, this hasn't merged yet. | |
| 17:33:17 | gibi | priteau: true. if you want to add it then you can by doing the cherry-pick with git and using -x | |
| 17:34:19 | opendevreview | Pierre Riteau proposed openstack/nova stable/wallaby: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871557 | |
| 17:34:37 | priteau | Yes, I've done this many times. Here we go. | |
| 18:21:51 | gibi | Uggla: I re-reviewd the first half of the manial series mostly OK with it buth johnthetubaguy had some valid questions there so I left -1 to have the visibility | |
| 18:21:58 | gibi | I will continue tomorrow | |
| 18:22:09 | gibi | Uggla: do you have a set of functional tests added to the series? | |
| #openstack-nova - 2023-01-25 | |||
| 01:51:23 | opendevreview | Merged openstack/nova master: Check VMDK create-type against an allowed list https://review.opendev.org/c/openstack/nova/+/871612 | |
| 02:20:55 | gmann | gibi: sean-k-mooney: please review the placement RBAC change, https://review.opendev.org/c/openstack/placement/+/865618 | |
| 02:22:06 | gmann | I am sure it is in your list, just wanted to get review/merge this soon in case any thing we need to update/test we can do before m-3 | |
| 02:34:50 | sean-k-mooney[m] | gmann: i have one question in line regarding listing traits | |
| 02:35:54 | sean-k-mooney[m] | so im +1 but if we dont want to change listing traits im +2 on the change i think | |
| 02:36:00 | sean-k-mooney[m] | illl check back in my morning | |
| 02:36:46 | gmann | sean-k-mooney[m]: thanks. will check and reply | |
| 05:18:15 | gmann | sean-k-mooney[m]: replied https://review.opendev.org/c/openstack/placement/+/865618/2/placement/policies/trait.py#41 | |
| 08:27:15 | Uggla | gibi, hi I will have a look at the comments left by john. Strangely I did not noticed them before. (OO) | |
| 08:28:50 | Uggla | gibi, regarding functional test yes in the latest patches there are some of them. Or do you think about tempest tests ? | |
| 08:34:59 | gibi | Uggla: no, not tempest. But then I will see them as I progress with the review today... | |
| 08:48:34 | zigo | Hi there! | |