| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-20 | |||
| 12:51:20 | kashyap | gibi: Ahh, I still have to fix 3-4 unit tests; just noticed. :( | |
| 12:51:35 | gibi | kashyap: no worries, ping me and I can re-review | |
| 12:51:46 | kashyap | Thanks | |
| 13:22:07 | opendevreview | Merged openstack/nova master: Split ignored_tags in stats.py https://review.opendev.org/c/openstack/nova/+/867978 | |
| 13:25:22 | opendevreview | Rajesh Tailor proposed openstack/nova master: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/861738 | |
| 13:33:43 | opendevreview | Elod Illes proposed openstack/nova stable/xena: nova-live-migration tests not needed for Ironic https://review.opendev.org/c/openstack/nova/+/855469 | |
| 14:18:18 | bauzas | artom: verifying now | |
| 14:20:23 | bauzas | artom: sending to the gate | |
| 14:22:33 | artom | Cheers! | |
| 15:15:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out a mixin class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 15:16:36 | kashyap | (It's failing as a result of my: https://review.opendev.org/c/openstack/nova/+/870794) | |
| 15:18:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Show candidate combinatorial explosion by dev number https://review.opendev.org/c/openstack/nova/+/855885 | |
| 15:28:11 | gibi | kashyap: noted the issue in https://review.opendev.org/c/openstack/nova/+/870794/7#message-a9e217530aaca46763329444a8776bc1eb1948d8 | |
| 15:29:08 | kashyap | gibi: Duuh, I thought I was careful w/ the spaces and still messed | |
| 15:29:46 | kashyap | Thanks for the eagle eyes, /me goes to fix... | |
| 15:35:34 | opendevreview | Andre Aranha proposed openstack/nova stable/yoga: Test setting the nova job to centos-9-stream https://review.opendev.org/c/openstack/nova/+/860087 | |
| 15:36:07 | opendevreview | Andre Aranha proposed openstack/nova stable/yoga: Test setting the nova job to centos-9-stream https://review.opendev.org/c/openstack/nova/+/860087 | |
| 15:38:10 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/870794 | |
| 15:38:10 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 15:43:21 | kashyap | Hmm, one more UT to debug (unrelated to the formatting issue). | |
| 15:57:58 | opendevreview | Dan Smith proposed openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | |
| 15:57:58 | opendevreview | Dan Smith proposed openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | |
| 15:57:59 | opendevreview | Dan Smith proposed openstack/nova master: Add get_available_node_uuids() to virt driver https://review.opendev.org/c/openstack/nova/+/863917 | |
| 15:57:59 | opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 15:58:00 | opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 15:58:00 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 16:07:18 | opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 16:07:18 | opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 16:07:19 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 16:18:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out a mixin class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 16:44:21 | opendevreview | David Hill proposed openstack/nova master: Change maximum value of pcie-ports to 64 https://review.opendev.org/c/openstack/nova/+/871305 | |
| 16:47:42 | gibi | bauzas: fyi, all the mandatory pieces of bp/pci-device-tracking-in-placement has been landed. So the bp can be set completed in A. | |
| 16:48:21 | gibi | there are two open patches https://review.opendev.org/q/topic:bp/pci-device-tracking-in-placement+status:open one is a small refactor that might or might not land. The other is just a demonstrator that we have a "limitation" | |
| 16:51:52 | sean-k-mooney | congrats | |
| 16:58:15 | gibi | It would have been impossible without sean-k-mooney's and stephenfin's help. thank you! | |
| 17:12:00 | opendevreview | David Hill proposed openstack/nova master: Change maximum value of pcie-ports to 64 https://review.opendev.org/c/openstack/nova/+/871305 | |
| 17:35:03 | opendevreview | David Hill proposed openstack/nova master: Change maximum value of pcie-ports to 32 https://review.opendev.org/c/openstack/nova/+/871305 | |
| #openstack-nova - 2023-01-21 | |||
| 00:22:09 | opendevreview | melanie witt proposed openstack/nova master: [WIP] add initial healthcheck support https://review.opendev.org/c/openstack/nova/+/825015 | |
| 00:22:09 | opendevreview | melanie witt proposed openstack/nova master: [WIP] add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 00:22:10 | opendevreview | melanie witt proposed openstack/nova master: [WIP] add healthcheck tracker to nova context https://review.opendev.org/c/openstack/nova/+/829468 | |
| 00:22:10 | opendevreview | melanie witt proposed openstack/nova master: [WIP] add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 00:22:11 | opendevreview | melanie witt proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 05:39:22 | opendevreview | Merged openstack/nova master: Microversion 2.94: FQDN in hostname https://review.opendev.org/c/openstack/nova/+/869812 | |
| 15:57:35 | jpic | hi all, any idea why this VM won't boot anymore after being resized from 32 to 64 vCPU? It seems to complain about memory but the hypervisor seems to have way enough, boot logs: https://dpaste.org/b5Cis | |
| #openstack-nova - 2023-01-23 | |||
| 05:12:59 | opendevreview | Amit Uniyal proposed openstack/nova stable/zed: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871413 | |
| 05:14:37 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871414 | |
| 05:15:43 | opendevreview | Amit Uniyal proposed openstack/nova stable/xena: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871415 | |
| 05:16:41 | opendevreview | Amit Uniyal proposed openstack/nova stable/wallaby: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871416 | |
| 05:17:58 | opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871417 | |
| 05:19:41 | opendevreview | Amit Uniyal proposed openstack/nova stable/ussuri: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871419 | |
| 06:09:36 | opendevreview | Amit Uniyal proposed openstack/nova stable/train: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871444 | |
| 06:26:41 | opendevreview | Amit Uniyal proposed openstack/nova stable/train: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871444 | |
| 07:52:13 | opendevreview | Rajesh Tailor proposed openstack/nova master: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/861738 | |
| 09:47:50 | opendevreview | Rajesh Tailor proposed openstack/nova master: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/861738 | |
| 10:00:28 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 10:00:28 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 10:07:58 | bauzas | gibi: so, wants me to move https://blueprints.launchpad.net/nova/+spec/pci-device-tracking-in-placement to Implemented so , | |
| 10:08:00 | bauzas | ? | |
| 10:08:50 | gibi | bauzas: yes please | |
| 10:08:54 | bauzas | ack | |
| 11:06:54 | opendevreview | Rajesh Tailor proposed openstack/nova master: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/861738 | |
| 12:35:39 | opendevreview | Rajesh Tailor proposed openstack/nova stable/zed: Correct config help message related options https://review.opendev.org/c/openstack/nova/+/871247 | |
| 12:44:53 | kashyap | gibi: If you have time, appreciate a look at this failure: https://zuul.opendev.org/t/openstack/build/42cccae5e7b64091a9a63ed0f808c980. (I thought mocking _register_all_undefined_instance_details should suffice; but fails differently after that: https://paste.opendev.org/show/bNMZwe9Sh4vT5V9gA95t/) | |
| 12:59:08 | gibi | kashyap: you set up mocked_compare to return 2 but the code around self._host.compare_cpu in driver.py expect an libvirtError exception when failure happens | |
| 13:00:31 | kashyap | gibi: You're talking about this test in the above paste-bin, yeah? - test__check_cpu_compatibility_advance_model | |
| 13:00:42 | gibi | yepp | |
| 13:00:52 | gibi | with the extra mock form the paste applied | |
| 13:01:32 | kashyap | Hmm | |
| 13:02:04 | kashyap | gibi: The extra mock is the first step here, at least right | |
| 13:02:19 | gibi | kashyap: yepp, I think so | |
| 13:02:42 | gibi | what you mocked would call into the db and that is not allowed in that unit test hence the need for the mock | |
| 13:03:12 | kashyap | Right; I see. | |
| 13:04:15 | kashyap | gibi: Unless I'm being dense, the test is trying to raise an exception there, isn't it - line-12. | |
| 13:04:21 | kashyap | (In the pastebin) | |
| 13:04:54 | gibi | kashyap: nope, that point the test *expects* an exception is being raied by calling drvr.init_host | |
| 13:06:09 | kashyap | gibi: Hmm, how would you suggest to fix this? I'm a bit out of brain cells here | |
| 13:09:57 | kashyap | I didn't paste the last line of test traceback, but probably you saw it in Zuul: it's the "impl.MismatchError ... <bound method [...] returned None>" | |
| 13:10:47 | gibi | so looking at https://github.com/openstack/nova/blob/d8b4b7bebdc0f55353cd99f372044b9e30315a6d/nova/virt/libvirt/driver.py#L9978-L9993 | |
| 13:11:23 | gibi | you need to return a negative integer from mock_compare to trigger a failure case OR you have to raise libvirtError from mock_compare | |
| 13:12:00 | gibi | I'm not sure what the real libvirt behavior is, raise or return negative | |
| 13:12:08 | gibi | but the code linked above handles both | |
| 13:12:20 | kashyap | Aaah, the "if ret <=0" bit | |
| 13:15:38 | gibi | one more thing | |
| 13:15:46 | gibi | you mock nova.virt.libvirt.host.libvirt.Connection.compareCPU | |
| 13:16:10 | gibi | but I'm not sure that the actuall call reaches there in the unit test | |
| 13:16:20 | kashyap | Hmm | |
| 13:16:51 | gibi | I think in that unit test the call reaches nova.tests.fixtures.libvirt.Connection.compareCPU | |
| 13:16:55 | gibi | instead | |
| 13:17:05 | kashyap | (Aside: returning negative integer didn't help; I tried - "mocked_compare.side_effect = -1") | |
| 13:18:14 | kashyap | gibi: Hmm, it's odd that it is reaching the fixture in this case, rather than the host.libvirt | |
| 13:18:22 | gibi | let me check... | |
| 13:18:54 | kashyap | (Another test is failing the same way, actually. If you want to pull the patch in: https://review.opendev.org/c/openstack/nova/+/870794/) | |
| 13:23:19 | gibi | hm, there is a bug in the code. We removed the first check and kept the second but actually the second check runs on each cpu_model_extra_flags flag one by one. If no flags defined there then no check runs at all | |
| 13:23:32 | gibi | the latter happens in the unit test | |
| 13:24:34 | kashyap | gibi: Hmm, I sure tried adding extra_flags to this test. Maybe I mixed up, lemme try adding one in the test | |
| 13:25:24 | kashyap | gibi: You mean "bug in the code" or bug in the unit test code -- to be modified to reflect the new reality | |
| 13:25:44 | kashyap | gibi: Sure enough, adding this line succeeds the test: | |
| 13:25:45 | kashyap | + cpu_model_extra_flags = ["-aes"], | |
| 13:25:52 | gibi | it is more like a question. Do we want to run the check if on extra flags are configured? | |
| 13:26:54 | kashyap | gibi: Yeah, we do want to check to run (_compare_cpu) when the extra_flags are configured -- is that what you ask? | |