| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-12 | |||
| 13:21:53 | sean-k-mooney | you seam to have change very little and its surpising that that is sufficent to emulate the new behavior | |
| 13:21:58 | sean-k-mooney | of the new api | |
| 13:22:35 | kashyap | sean-k-mooney: Exactly, I didn't change much of the fixture, as it is indeed a "drop-in" replacement and I don't think we should implement all the internal mechanics of libvirt | |
| 13:23:06 | kashyap | sean-k-mooney: Oh, we can also keep the vendor check there too. I don't think that'll affect it either | |
| 13:23:24 | sean-k-mooney | well then its identical to the ohter one :) | |
| 13:23:34 | sean-k-mooney | so we can just have one function call the other or alias thme | |
| 13:23:47 | kashyap | Yes :) | |
| 13:23:57 | kashyap | How do I alias? | |
| 13:24:01 | sean-k-mooney | have you any concenrs withthe delta in behavior of the fixture/real code | |
| 13:24:18 | sean-k-mooney | compareHypervisorCPU = compareCPU | |
| 13:24:49 | kashyap | I don't have any concerns. I'm just waiting for a real-life test to come back | |
| 13:25:16 | kashyap | Thanks for looking! | |
| 13:29:31 | sean-k-mooney | actually the alais wont work in this case | |
| 13:29:40 | sean-k-mooney | kashyap: the fucntion signiture is differnt | |
| 13:30:00 | kashyap | sean-k-mooney: Err, oh, right. Indeed | |
| 13:30:01 | sean-k-mooney | but you can jsut havc compareHypervisorCPU call compareCPU in the fixutre | |
| 13:30:37 | sean-k-mooney | assuming the vendor bit does not matter | |
| 13:30:56 | kashyap | Yep, it does not matter. I'll do the call and run the tests | |
| 13:49:06 | kashyap | sean-k-mooney: Good you raised the fixture point, I caught a few more buggy unit tests :) | |
| 13:51:29 | kashyap | Hmm, I fixed all but 2 of 'em seem a bit tricky; /me digs | |
| 14:09:11 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 14:20:23 | tobias-urdin | sean-k-mooney: weird question, if one implements a scheduler host filter the RequestSpec.image.properties is a ImageProps class, does that get populated for BFV instances? i.e would it read cached properties of image props for that volume and populate ImageProps or read existing image props for image volume spawned from an populate ImageProps? | |
| 14:20:56 | tobias-urdin | I'm guessing that is cached since it exists in RequestSpec from when it was spawned | |
| 14:29:12 | sean-k-mooney | tobias-urdin: yes its gets populated for BFV instances if the volume was created from a glance image it will have the image properties stored in the volume metadata and we also copy them into the nova databasein two locaionts | |
| 14:29:29 | sean-k-mooney | the request spec and teh instance_system_metadata in teh cell db | |
| 14:31:22 | sean-k-mooney | tobias-urdin: the request spec copy is used for schdulign to avoid needing to get the info out of the cell db | |
| 14:31:24 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L64 | |
| 14:32:21 | sean-k-mooney | the image filed is an nova imagemeta object which has the image properies embded in it https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L75 | |
| 14:35:55 | tobias-urdin | sean-k-mooney: thanks that good then it was like I expected :) as always, thanks for the detailed answer! | |
| 14:45:58 | opendevreview | Sofia Enriquez proposed openstack/nova master: WIP: Implement encryption on backingStore https://review.opendev.org/c/openstack/nova/+/870012 | |
| 14:50:40 | opendevreview | Sofia Enriquez proposed openstack/nova master: WIP: Implement encryption on backingStore https://review.opendev.org/c/openstack/nova/+/870012 | |
| 15:11:09 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 15:12:12 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 15:24:07 | bauzas | shall I propose chatgpt for nova-core ? https://twitter.com/sylvainbauza/status/1613556643945672704 | |
| 15:24:24 | kashyap | bauzas: :D | |
| 15:24:31 | kashyap | bauzas: Please ask it to also fix my unit tests! | |
| 15:24:54 | kashyap | (Or even better, just I submit a blueprint to it, write the rest of the code + docs + tests :P) | |
| 15:24:59 | bauzas | kashyap: its trained data dates from 2021 | |
| 15:25:22 | bauzas | kashyap: but you can ask it why your test is failing, I'm sure it will find you the bug | |
| 15:26:12 | sean-k-mooney | how do you know im not chatgpt in disguise | |
| 15:27:01 | sean-k-mooney | oh chatgpt can spell | |
| 15:27:17 | sean-k-mooney | that a problem if i want to use it to automate my job in secret | |
| 15:27:34 | sean-k-mooney | i should ask it if can respond in seanspeak | |
| 15:27:50 | dansmith | hah | |
| 15:41:13 | kashyap | sean-k-mooney: LOL | |
| 15:41:26 | kashyap | sean-k-mooney: I'd totally believe if you're SeanGPT5 | |
| 15:41:27 | kashyap | ! | |
| 15:45:41 | tobias-urdin | hehe | |
| 15:47:28 | bauzas | sean-k-mooney: hahaha | |
| 15:49:12 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 15:49:54 | bauzas | sean-k-mooney: well, chatgpt sometimes says some wrong answers, but eventually it finds the right one | |
| 15:51:11 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 15:57:38 | noonedeadpunk | hey folks! I was trying to find a way to get `failed_builds` counter through API but I'm not sure I udnerstand what provides ComputeNode object there. As it's not hypervisor, hosts are deperecated... | |
| 15:58:46 | noonedeadpunk | it looks a bit like internal scheduler thing to me at this point... | |
| 15:59:16 | noonedeadpunk | I mean specifically this thing https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/host_manager.py#L261-L262 | |
| 16:01:24 | noonedeadpunk | What I'm trying to do is monitor this counter to see when node falls out from scheduling and fix the issue/restart nova-compute to return it back | |
| 16:11:38 | noonedeadpunk | I do see it's in cell database but still no idea how to fetch with api :( | |
| 16:12:10 | noonedeadpunk | (in compute_nodes table) | |
| 17:07:25 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 17:10:07 | kashyap | gibi: --^ Fixed your nits. Thanks for your continued reviews. | |
| 17:52:18 | gmann | dansmith: did you get chance to review RBAC flag switch change https://review.opendev.org/c/openstack/nova/+/866218 | |
| 17:52:34 | dansmith | gmann: I haven't since your update yet sorry | |
| 17:53:39 | gmann | dansmith: ok, please check its depends-on also when you have time https://review.opendev.org/c/openstack/placement/+/869525 https://review.opendev.org/c/openstack/devstack/+/869781 | |
| 18:10:38 | melwitt | sean-k-mooney: I'm +2 on the ironic vnc spec after my questions answered, if you want to send it https://review.opendev.org/c/openstack/nova-specs/+/863773 | |
| 18:13:01 | sean-k-mooney | melwitt: i can i was more or less holding off for you to get your questions answered without interferring | |
| 18:13:24 | sean-k-mooney | i know the responce form the previous iteration but i was away i was filling in context that was not in the spec | |
| 18:13:29 | melwitt | sean-k-mooney: I know. wanted to let you know I'm good so you can go ahead | |
| 18:13:40 | sean-k-mooney | so wanted ot let you get happy with the spec content without that bias | |
| 18:13:59 | melwitt | I appreciate that :) | |
| 18:14:53 | melwitt | I knew you were +2 already but I didn't feel comfortable +2ing until I understood it better | |
| 18:17:30 | sean-k-mooney | hehe well i was almost -2 intilaly when it was storign password. with the pivot to addign the ironic vnc proxy that removed most of my concners and this just became a ironic dirver change to add partiy for an exisitn api | |
| 18:18:04 | sean-k-mooney | the double proxying is a little odd but i see use in the ironic vnc proxy for standalone ironic too | |
| 18:19:39 | melwitt | I was also pretty much -2 with the initial proposal. so I saw that was removed which was good but didn't quite understand where the second proxy fit into the flow | |
| 18:20:49 | melwitt | *saw that password storage was removed | |
| 18:20:58 | sean-k-mooney | ya so the current vnc proxy really just wraps the vnc tcp session provided by qemu in a web socket | |
| 18:21:30 | sean-k-mooney | in the ironic case its more or less the same it will take the tcp session form the ironic proxy and convert it to a websocket for horizon | |
| 18:22:44 | melwitt | yeah, I think it makes sense now but at first I was confused | |
| 18:26:28 | opendevreview | Merged openstack/nova-specs master: new spec: support of vnc console for ironic https://review.opendev.org/c/openstack/nova-specs/+/863773 | |
| 18:40:57 | gmann | sean-k-mooney: gibi: I know you might have this in your list but just a review reminder for placement RBAC change https://review.opendev.org/c/openstack/placement/+/865618 | |
| 18:41:31 | sean-k-mooney | it is on it but i can try and give it more priority :) | |
| 18:41:59 | sean-k-mooney | is this a depency for the nova patch to merge or was that something else | |
| 18:50:50 | opendevreview | Merged openstack/nova master: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/849131 | |
| 18:52:02 | gmann | sean-k-mooney: that was something else. there is no deps. | |
| 18:52:24 | sean-k-mooney | ok that was changing the jobs to enable srbac right | |
| 18:52:37 | sean-k-mooney | we needed to do that for placment then nova | |
| 18:52:37 | gmann | sean-k-mooney: yes | |
| 18:53:00 | sean-k-mooney | ok and this is adding the service role | |
| 18:53:07 | sean-k-mooney | and the other changes for the srbac role | |
| 18:53:13 | sean-k-mooney | ok ill take a look shortly | |
| 18:53:25 | gmann | sean-k-mooney: for placement it was a change in fixture which is needed for nova to enable new defaults, this one https://review.opendev.org/c/openstack/placement/+/869525 | |
| 18:53:29 | gmann | sean-k-mooney: thanks | |
| 18:56:14 | sean-k-mooney | ill look at that after so | |
| 19:24:59 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 19:25:37 | opendevreview | Tobias Urdin proposed openstack/nova master: Use new get_rpc_client API from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 21:20:59 | opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 21:20:59 | opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 21:21:00 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 23:08:05 | opendevreview | Merged openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| #openstack-nova - 2023-01-13 | |||
| 02:58:43 | opendevreview | Merged openstack/nova-specs master: Add maxphysaddr support for Libvirt https://review.opendev.org/c/openstack/nova-specs/+/861033 | |
| 06:24:46 | opendevreview | Merged openstack/placement master: Avoid rbac defaults conflict in functional tests https://review.opendev.org/c/openstack/placement/+/869525 | |