| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-09 | |||
| 17:31:47 | opendevreview | Balazs Gibizer proposed openstack/nova stable/victoria: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/869584 | |
| 17:34:05 | sean-k-mooney | bauzas: can you take a look at https://review.opendev.org/c/openstack/nova-specs/+/865432 again | |
| 17:34:47 | sean-k-mooney | melwitt: gibi: and if one of ye has time https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 17:35:11 | sean-k-mooney | the cinder spec is appvoed for ^ if i recall | |
| 17:35:35 | sean-k-mooney | https://review.opendev.org/c/openstack/cinder-specs/+/866718 | |
| 17:38:05 | melwitt | sean-k-mooney: I've been meaning to get back to that one 😓 | |
| 17:38:05 | melwitt | sean-k-mooney: I've been meaning to get back to that one 😓 | |
| 17:38:33 | opendevreview | Dan Smith proposed openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | |
| 17:38:34 | opendevreview | Dan Smith proposed openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | |
| 17:38:34 | opendevreview | Dan Smith proposed openstack/nova master: Add get_available_node_uuids() to virt driver https://review.opendev.org/c/openstack/nova/+/863917 | |
| 17:38:35 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 17:38:35 | opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 17:38:36 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 17:43:09 | dansmith | melwitt: sean-k-mooney ^ | |
| 17:43:20 | dansmith | I was able to make it all work without removing that test after all it seems | |
| 17:43:50 | sean-k-mooney | cool is ignore WIP status is that more or less feature complete at this point | |
| 17:44:02 | sean-k-mooney | *so ignoring.. | |
| 17:44:05 | dansmith | the two WIP ones just need more tests | |
| 17:44:11 | sean-k-mooney | ack | |
| 17:44:51 | melwitt | ack also | |
| 17:44:52 | sean-k-mooney | but in terms fo the spec i assume that series now covers most of the work itmes or all of it? | |
| 17:45:06 | dansmith | re: that test, I had one thing in the fake driver that was being done earlier in the set than needed, which meant I was triggering the undelete early in the stack before we had the code to handle it | |
| 17:45:14 | dansmith | sean-k-mooney: yeah | |
| 17:47:45 | sean-k-mooney | "lambda: None" ... ok i guess that one way to noop | |
| 17:48:37 | sean-k-mooney | i guess fixtures.MockPatch need a callback functions to work | |
| 17:48:43 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/869585 | |
| 17:48:44 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/869586 | |
| 17:57:42 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check in _check_cpu_compatiblity() https://review.opendev.org/c/openstack/nova/+/869587 | |
| 18:01:39 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check in _check_cpu_compatibility() https://review.opendev.org/c/openstack/nova/+/869587 | |
| 18:06:01 | gmann | gibi: thanks. +2, leaving approval to stephenfin in case anything else missing | |
| 18:08:42 | opendevreview | Ghanshyam Mann proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | |
| 18:09:14 | opendevreview | Ghanshyam Mann proposed openstack/placement master: Avoid rbac defaults conflict in functional tests https://review.opendev.org/c/openstack/placement/+/869525 | |
| 18:39:58 | sean-k-mooney | dansmith: nothing major so far just weighed in on the open() discussion https://review.opendev.org/c/openstack/nova/+/863915 i looked into why your useage is actully safe but this change between python 2 and 3 | |
| 18:52:05 | dansmith | sean-k-mooney: yeah I do this all the time to avoid extra indents for no reason.. I'm pretty surprised it's even controversial | |
| 18:52:28 | sean-k-mooney | its not really just never seen this done before | |
| 18:52:54 | sean-k-mooney | but again im pretty sure that was because it was not safe on python 2 but we dont need to supprot that anymore | |
| 18:52:55 | dansmith | also it hasn't changed, python 2.7 works the same way | |
| 18:53:19 | dansmith | I just re-confirmed to convince myself as I still have a system with 2.7 on it | |
| 18:53:20 | sean-k-mooney | well python2 gave you back the file like object but i tough you had to close that | |
| 18:53:38 | dansmith | no, when the last reference goes away it closes | |
| 18:53:40 | sean-k-mooney | ok then this is just the inertia of tutorials | |
| 18:53:46 | sean-k-mooney | ack | |
| 18:54:49 | opendevreview | Ghanshyam Mann proposed openstack/python-novaclient stable/yoga: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869597 | |
| 18:55:21 | dansmith | it's of course not critical to that patch and I could change it, there's just no reason :) | |
| 18:55:33 | opendevreview | Ghanshyam Mann proposed openstack/python-novaclient stable/xena: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869598 | |
| 18:55:50 | sean-k-mooney | ya im not going to block on it if gibi is fine with the explanation | |
| 18:56:13 | sean-k-mooney | ill keep reviewing the rest in the interim once i do downstream bug triage assignmet | |
| 18:56:47 | sean-k-mooney | dansmith: its just the first time i had seen it so i assumed the same as gibi | |
| 20:43:16 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 20:46:00 | opendevreview | Ghanshyam Mann proposed openstack/python-novaclient stable/xena: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869598 | |
| 21:15:41 | sean-k-mooney | dansmith: if you have time to cast your eyes over teh user-data update spec https://review.opendev.org/c/openstack/nova-specs/+/863884 that would be ideal | |
| 21:18:51 | opendevreview | Merged openstack/os-vif master: Make tox.ini tox 4.0.0 compatible https://review.opendev.org/c/openstack/os-vif/+/868420 | |
| 22:07:06 | gmann | bauzas: gibi: this is to pin tox<4 for python-novaclient https://review.opendev.org/q/I442568a5f5900e593feb2b5527109e0aa79e5aa7+status:open | |
| 22:08:39 | gmann | bauzas: dansmith : nova rbac default switch is ready https://review.opendev.org/c/openstack/nova/+/866218 which need placement test fixture change too https://review.opendev.org/c/openstack/placement/+/869525/3 | |
| 22:16:18 | dansmith | sean-k-mooney: yep thanks | |
| 22:16:22 | dansmith | gmann: will have to be tomorrow | |
| 22:16:33 | gmann | dansmith: sure, thanks | |
| #openstack-nova - 2023-01-10 | |||
| 09:10:23 | gibi | sean-k-mooney dansmith: I'm +2 on stable uuid first patch but hold +A to get an ack on my analysis of fd closing behavior and to read the rest of the series | |
| 09:12:01 | gibi | in sort, in cpython we are fine in pypy we are less fine, and in general zen of python says "Explicit is better than implicit." | |
| 09:17:39 | sahid | o/ | |
| 09:36:19 | gibi | stephenfin: if you are around could you +A https://review.opendev.org/c/openstack/nova/+/869545 ? | |
| 09:36:55 | gibi | and https://review.opendev.org/c/openstack/placement/+/868418 | |
| 09:59:34 | opendevreview | Justas Poderys proposed openstack/nova-specs master: Add support for Napatech LinkVirt SmartNICs https://review.opendev.org/c/openstack/nova-specs/+/859290 | |
| 10:09:47 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check in _check_cpu_compatibility() https://review.opendev.org/c/openstack/nova/+/869587 | |
| 10:13:37 | kashyap | gibi: If you get a few spare minutes, please have a gander at the above. Please also read the commit message to load up on context (this is what takes the most time) | |
| 10:27:25 | opendevreview | Merged openstack/os-vif master: Update gate jobs as per the 2023.1 cycle testing runtime https://review.opendev.org/c/openstack/os-vif/+/861468 | |
| 10:38:31 | bauzas | Uggla: can you please provide a new revision for https://review.opendev.org/c/openstack/nova-specs/+/861881 quickly today ? | |
| 10:39:01 | bauzas | 1/ change the directory to use instance UUID instead of name | |
| 10:39:23 | bauzas | 2/ tell that you'll add a doc explaining live-mig won't work | |
| 10:39:28 | bauzas | and then I can +2 it | |
| 10:47:13 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/869673 | |
| 10:47:14 | opendevreview | Balazs Gibizer proposed openstack/nova stable/train: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/869674 | |
| 10:52:51 | Uggla | bauzas, looking at it | |
| 11:32:32 | sean-k-mooney | bauzas: traits never enable features so we need an image proprly or flavor extra spec | |
| 11:32:40 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/861881/7/specs/2023.1/approved/virtiofs_scaphandre.rst#127 | |
| 11:49:52 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Process all nodes when host aggregate changes https://review.opendev.org/c/openstack/nova/+/869687 | |
| 12:03:37 | sean-k-mooney | gibi: the pypy behavior was exactly what i was concerend about | |
| 12:06:29 | gibi | I haven't checked jython and ironpython but I guess they also inherit the gc from the runtime env for java and .net so they are not ref count based | |
| 12:06:49 | sean-k-mooney | yep that is proably | |
| 12:07:09 | sean-k-mooney | althogh as i said im my reply to your comment | |
| 12:07:19 | sean-k-mooney | outside the clients we officaly only support cpython | |
| 12:07:46 | sean-k-mooney | but im not against enabling other interperts for core nova we just dont supprot that officaly or test it | |
| 12:09:12 | sean-k-mooney | i mostly cargo cult the "with open ..." pattern because that is waht i learned to do year ago and the implict understandign that when used as a context manager the file like object retruned by open would close the underlying stream/socket/filedescriptor | |
| 12:10:11 | sean-k-mooney | with statements dont actully form scopes so the closign is delayed until the exit of the function in either case | |
| 12:10:49 | sean-k-mooney | well without the with i gues it when the gc runs ranter then the exit of the fuction scope | |
| 12:12:24 | kashyap | gibi: sean-k-mooney: The functional test failures here seem unrelated to my patch: https://review.opendev.org/c/openstack/nova/+/869587 | |
| 12:12:40 | kashyap | Am I reading it right? Example failure from py38 job: https://zuul.opendev.org/t/openstack/build/21785a8539e34c65aad0038a6cae0cde | |
| 12:13:07 | kashyap | "failed with could not find python interpreter matching any of the specs functional-py38" | |
| 12:13:08 | sean-k-mooney | this is the gate blocker we discussed at the start of the tech call yesterday | |
| 12:13:18 | sean-k-mooney | so not related to your patch | |
| 12:13:25 | kashyap | Ah, I missed it. | |
| 12:13:27 | sean-k-mooney | its related to tox 4 | |
| 12:24:25 | kashyap | sean-k-mooney: Thanks! (My keyboard got locked accidentally, and had to reboot) | |
| 12:25:04 | kashyap | I guess it's related to this patch from gibi -- https://review.opendev.org/c/openstack/placement/+/868418 ("Make tox.ini tox 4.0.0 compatible") | |
| 12:26:44 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix huge-page doc https://review.opendev.org/c/openstack/nova/+/869689 | |
| 12:28:27 | gibi | kashyap: yes | |
| 12:28:50 | sean-k-mooney | kashyap: well tehre is a nova version of that too | |
| 12:28:57 | sean-k-mooney | i think from gmann ? | |
| 12:29:28 | gibi | https://review.opendev.org/c/openstack/nova/+/869545 this is the nova one | |
| 12:29:48 | gibi | sean-k-mooney: I think the with statement itself make sure that after the with block the fd is closed. it might not free up any memory but it closed the file descriptor | |