Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-01-08
20:10:39 opendevreview Ghanshyam Mann proposed openstack/placement master: Avoid rbac defaults conflict in functional tests https://review.opendev.org/c/openstack/placement/+/869525
20:15:05 opendevreview Ghanshyam Mann proposed openstack/python-novaclient stable/zed: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869527
20:17:30 gmann seems we are hitting missing interpreter again? https://zuul.opendev.org/t/openstack/build/3dbb7278e8b94e77aa25d207286bfcba/log/job-output.txt
20:17:35 gmann stephenfin: ^^
20:36:23 gmann seeing this in placement master patches also
#openstack-nova - 2023-01-09
03:54:29 opendevreview David Sedgmen proposed openstack/nova master: Nova: Add workaround to mask mpx on compareCPU() https://review.opendev.org/c/openstack/nova/+/869536
08:55:34 gibi gmann, stephenfin: it is strange I see the periodic passed during the weekend but now I also see failing jobs with missing interpreter: here is a fresh one https://1729c20500306078d1cb-f18cd0734c7002742f0baf633d0573f2.ssl.cf2.rackcdn.com/854615/11/check/nova-tox-functional-py310/548baa7/job-output.txt
09:05:10 gibi it seems that nova functional jobs are hit but unit test jobs arent
09:06:51 songwenping_ passwd
09:19:27 gibi both job using tox 4.2.6 which supposed to contain the fix of missing interpreters
09:20:35 bauzas gibi: sorry, this vgpu downstream reproducer vamps me
09:21:09 bauzas gibi: can you please explain me the current status for tox4 issues ?
09:21:48 gibi bauzas: o/\
09:22:31 gibi bauzas: so https://github.com/tox-dev/tox/pull/2828 supposed to fix the missing interpreter error that hit both unit and functional test jobs
09:22:41 gibi bauzas: it merged and released during the weekend in 4.2.5
09:22:49 bauzas kk
09:22:56 gibi bauzas: this morning I rechecked one of my patch
09:23:06 gibi bauzas: the unit test jobs passed there with tox 4.2.6
09:23:19 gibi bauzas: but the functional ones are still failing with the missing interpreter error
09:23:35 bauzas gibi: are you sure you're not pinned by a previous tox version ?
09:23:37 gibi this is the recheck run I watch https://zuul.opendev.org/t/openstack/status#854615
09:25:31 gibi I'm pretty sure both jobs run with 4.2.6 but feel free to double check the logs
09:26:21 sahid 220185
09:27:18 bauzas 2023-01-09 08:51:17.905173 | ubuntu-jammy | Downloading https://mirror.bhs1.ovh.opendev.org/pypifiles/packages/6a/fd/8e1f5e6f251120f643e7e2773d9451b7669e6dfdd3c09fc6d9185b423fc9/tox-4.2.6-py3-none-any.whl (145 kB)
09:27:23 bauzas gibi: indeed ^
09:29:56 gibi I think I can reproduce it locally in a container with tox 4.2.6
09:32:39 gibi maybe it does not understand our generative tox env definition any more `[testenv:functional{,-py38,-py39,-py310}]`
09:33:56 bauzas hmmm
09:34:22 gibi no
09:34:30 gibi simplifying that to `[testenv:functional-py310]` still doesnt work
09:34:59 bauzas can you just remove the python version suffix ?
09:35:15 bauzas with tox, it could autocreate the right dirs IIRC
09:42:34 gibi__ my home internet went down
09:43:07 gibi__ I'm not sure what I was able to send last time
09:43:28 gibi__ so simplifying the tox target to functional-py310 does not help
09:43:49 bauzas gibi__: can you create just a tox target without the python version ?
09:44:31 bauzas I guess you have py39 default
09:44:39 gibi__ let me see
09:46:41 gibi__ hm, if I change the functional-py310 to functionalpy310 then it seems to work
09:47:38 gibi__ the problem is that it then ignores the py310 part of the target and runs with whathever python3 interpreter I have
09:47:48 gibi__ so functionalpy39 runs with the same python3.10 I have installed
09:49:53 sahid o/ any chance to get some reviews on https://review.opendev.org/c/openstack/nova/+/858383 ?
09:50:18 sahid perhpas gibi__ when you have a moment :D ^
09:51:04 gibi__ bauzas: so I do believe that the generative env feature is broken somehwo
09:51:07 gibi__ stephenfin: ^^
09:51:26 bauzas gibi__: yeah, that's my guess
09:51:35 gibi__ sahid: ack, I'm not sure when I will have that moment, sorry
09:51:48 bauzas gibi__: tox can't guess which python interpreter to use
09:52:10 bauzas that said, it looks a large regression
09:53:17 bauzas gibi__: ^
09:57:03 opendevreview Balazs Gibizer proposed openstack/nova master: Define basepython for functional targets https://review.opendev.org/c/openstack/nova/+/869545
09:57:17 gibi__ bauzas: ^^ this seems to work locally
09:58:54 bauzas theorically, this shouldn't be needed
09:59:00 bauzas https://tox.wiki/en/4.2.6/config.html#base_python
09:59:58 gibi__ yeah, it worked before
10:00:01 bauzas unfortunately the tox4 docs isn't that explaining how to autogenerate venvs with py versioning like tox3 docs do https://tox.wiki/en/3.4.0/config.html#generating-environments-conditional-settings
10:00:32 gibi__ I will open an issue for tox maybe the devs knows more
10:01:04 bauzas "tox provides a number of default factors corresponding to Python interpreter versions. The conditional setting above will lead to either python3.6 or python2.7 used as base python, e.g. python3.6 is selected if current environment contains py36 factor."
10:01:27 bauzas so I guess the default factors no longer work
10:09:59 gibi__ after some more trials it is more like basepython = python3 and -py310 factor creates a conflict but we have ignore_basepython_conflict to supress that and that lead to no interpreter found
10:20:43 gibi__ bauzas, gmann, stephenfin: opened https://github.com/tox-dev/tox/issues/2838
10:21:23 bauzas gibi__: we could remove basepython IMHO
10:23:55 gibi__ we could if we assume no env will have python2.7 as a default interpreter installed
10:37:46 stephenfin yeah, be can/should drop basepython at this point
10:37:49 stephenfin *we
10:39:41 stephenfin gibi: replied on the tox bug also
10:40:18 gibi__ stephenfin: I tried in tox 3.28 and I did not need ingnore_base_python_conflict to make it work
10:40:44 gibi__ stephenfin: you can simply remova that from nova's tox.ini and it work in tox 3.28 for me locally
10:42:42 gibi__ stephenfin: anyhow so you suggest to just remove basepython = python3 and assume people's machine has python3 by default
10:43:03 gibi__ (which could be a fair assumption having python2.7 in EOL)
10:43:32 stephenfin I think that's a reasonable workaround, yes
10:44:30 gibi__ OK, I will change https://review.opendev.org/c/openstack/nova/+/869545 to drop basepython instead of defining it for each generative env
10:45:15 gibi__ and then I can also try to drop ignore_basepython_conflict
10:45:44 stephenfin oh, you can do the two in one go. ignore_basepython_conflict is only needed if `basepython` is defined (which it won't be here)
10:46:01 gibi__ OK
10:50:28 sean-k-mooney bauzas: yes you can use tox -e py3|functional
10:50:42 sean-k-mooney those will use your defalt python
10:51:20 sean-k-mooney we only set basepython to cater for python2 vs python3
10:51:26 sean-k-mooney so yes we can drop it now
10:53:47 opendevreview Balazs Gibizer proposed openstack/nova master: Remove basepython def from tox.ini https://review.opendev.org/c/openstack/nova/+/869545
10:53:54 gibi__ stephenfin, bauzas: ^^
10:54:04 sean-k-mooney gibi__: so regarding https://review.opendev.org/c/openstack/os-vif/+/869500 that now works but we need to squash it into your patch
10:54:23 sean-k-mooney or in your patch you can disable the functional jobs and we can re enable it in this one
10:54:29 sean-k-mooney gibi__: any prefernce
10:56:36 gibi__ I need to update that tox patch to remove basepython and ignore_basepython_conflict, I can do a squash at the same time
10:57:00 darkhorse artom: If you remember our discussion on unshelving pci instance, I tried to boot from image that is related to the unshelved instance but failed. I don't see an image created when I shelve an instance. I tried openstack images list and also checked in the glace>images table but nothing is created when I shelve an instance.
10:57:41 gibi__ sean-k-mooney: but I need to have lunch first
10:59:13 sean-k-mooney gibi__: cool works for me enjoy your lunch
11:00:43 gibi__ thanks
11:31:40 opendevreview Balazs Gibizer proposed openstack/os-vif master: Make tox.ini tox 4.0.0 compatible https://review.opendev.org/c/openstack/os-vif/+/868420
11:31:51 gibi__ sean-k-mooney: ^^ fix with the squash
11:40:56 sean-k-mooney gibi__: thanks +2 although ignoring 2 +2s thing for a sec given i wrote part of this i want someone else to +w anyway
11:42:51 opendevreview sean mooney proposed openstack/os-vif master: Update gate jobs as per the 2023.1 cycle testing runtime https://review.opendev.org/c/openstack/os-vif/+/861468
11:51:35 gibi__ stephenfin: if you have a sec then here https://review.opendev.org/c/openstack/placement/+/868418 I think we have some disagreements
11:56:32 sean-k-mooney gibi__: the convention we had for the deps is generally to inherit and extend
11:57:00 sean-k-mooney like this
11:57:01 sean-k-mooney deps =
11:57:03 sean-k-mooney {[testenv]deps}
11:57:05 sean-k-mooney -r{toxinidir}/doc/requirements.txt
11:57:16 sean-k-mooney i think that is what stephen was sugessing but not sure

Earlier   Later