| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-12-06 | |||
| 16:22:46 | bauzas | moving on then, and profit. | |
| 16:22:49 | elodilles | ++ | |
| 16:22:52 | elodilles | :) | |
| 16:22:52 | bauzas | #topic Open discussion | |
| 16:23:04 | Kirill_ | can someone review this: https://review.opendev.org/c/openstack/nova-specs/+/863773 . sean-k-mooney already reviewed and and set +1, need more reviews for setting +2, right? | |
| 16:23:07 | bauzas | I had a question but I don't see a quorum | |
| 16:23:24 | bauzas | Kirill_: nod, lemme see | |
| 16:23:41 | Kirill_ | thanks | |
| 16:23:41 | bauzas | ah that one | |
| 16:23:50 | bauzas | sure, I'll do some review | |
| 16:23:56 | sahid_ | o/ then, i have one regarding review priority | |
| 16:24:14 | bauzas | sahid_: sure, shoot | |
| 16:24:40 | sahid_ | thanks | |
| 16:24:51 | sahid_ | it's just to know, we have this that had the bit Review-Priority | |
| 16:24:52 | sahid_ | https://review.opendev.org/c/openstack/nova-specs/+/857838 | |
| 16:25:09 | sahid_ | I'm wondering whtehr the impl can I have also that bit, or if it's a different process? | |
| 16:25:12 | sahid_ | :-) | |
| 16:25:27 | bauzas | sahid_: surely, you can ask for it :) | |
| 16:25:42 | bauzas | sahid_: ping us tomorrow and we'll see | |
| 16:25:53 | bauzas | looks there are not a lot of people around atm | |
| 16:26:08 | sahid_ | yeah... no worries, will see that tomorrow | |
| 16:26:10 | sahid_ | thanks a lot | |
| 16:27:02 | bauzas | np | |
| 16:27:36 | bauzas | so let's end this meeting for now, I'll ask about which meetings to skip during the xmas period next week | |
| 16:27:55 | bauzas | anyone having anything to raise before we say it's a wrap ? | |
| 16:28:34 | bauzas | looks not, | |
| 16:28:39 | bauzas | thanks all | |
| 16:28:43 | opendevmeet | Meeting ended Tue Dec 6 16:28:43 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:28:43 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-12-06-16.01.txt | |
| 16:28:43 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-12-06-16.01.log.html | |
| 16:28:43 | bauzas | #endmeeting | |
| 16:28:43 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-12-06-16.01.html | |
| 16:29:23 | elodilles | thanks bauzas o/ | |
| 16:29:51 | sean-k-mooney | kgube: we generally do not like tracking changes to nova in other projects specs | |
| 16:29:51 | elodilles | that sounds fun :D | |
| 16:30:31 | sean-k-mooney | kgube: if you are chaing the sematics or the extend voluem external event even if that does not change the content passed to the api we shoudl still have a spec to dicuss that | |
| 16:30:47 | kgube | sean-k-mooney, alright! | |
| 16:30:57 | sean-k-mooney | Kirill_: i wanted gmann or other to confirm my reasoning on https://review.opendev.org/c/openstack/nova-specs/+/863773/10/specs/wallaby/approved/nova-vnc-support-for-ironic.rst#134 | |
| 16:32:03 | sean-k-mooney | Kirill_: i.e. that we do not need a microversion for this change and there is no other upgrade impact for the reasons is stated in the commnet | |
| 16:35:11 | gmann | sean-k-mooney: I kept it open but somehow got distracted. It is in my list. | |
| 16:35:57 | Kirill_ | per my understanding, we don't need any miniversions cause if nova does not support my changes the result will be the same as now, if ironic does not support - again we will catch error - vnc is unsupported. i'll try such scenarios tomorrow. | |
| 16:36:54 | sean-k-mooney | Kirill_: ya so part of what im wondering is changing form a 400 to a 200 ok | |
| 16:37:15 | sean-k-mooney | and i think it is because if it was a libvirt instance then a 200 would have been valid | |
| 16:37:31 | sean-k-mooney | or possible for the same api request | |
| 16:37:46 | sean-k-mooney | so to me there is no need for a microverion | |
| 16:38:55 | Kirill_ | ++ | |
| 20:22:51 | opendevreview | Merged openstack/nova stable/wallaby: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/841483 | |
| 20:22:57 | opendevreview | Merged openstack/nova stable/wallaby: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/841760 | |
| 20:48:58 | opendevreview | Merged openstack/nova stable/wallaby: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/841736 | |
| #openstack-nova - 2022-12-07 | |||
| 01:09:58 | opendevreview | melanie witt proposed openstack/nova stable/train: Fix the wrong exception used to retry detach API calls https://review.opendev.org/c/openstack/nova/+/866090 | |
| 01:09:59 | opendevreview | melanie witt proposed openstack/nova stable/train: Retry attachment delete API call for 504 Gateway Timeout https://review.opendev.org/c/openstack/nova/+/866091 | |
| 04:57:37 | opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: add sftp driver https://review.opendev.org/c/openstack/nova/+/866672 | |
| 07:24:12 | opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: add sftp driver https://review.opendev.org/c/openstack/nova/+/866672 | |
| 10:24:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support multiple config file with mod_wsgi https://review.opendev.org/c/openstack/nova/+/864014 | |
| 10:24:39 | gibi | bauzas: ^^ that is an easy fix | |
| 10:24:58 | bauzas | gibi: ack, looking | |
| 10:26:03 | gibi | stephenfin: a friendly poke about the pci in placement series. If you have time, review would be appreciated. bottom is: https://review.opendev.org/c/openstack/nova/+/852771 | |
| 10:50:11 | sahid_ | gibi: o/ i will review it as well if you don't mind :-) | |
| 10:51:05 | gibi | sahid_: go for it! and thank you :) | |
| 10:51:33 | gibi | sahid_: please note that we landed the inventory reporting and allocation healing in zed, the patches open now is for the scheduling support | |
| 10:51:56 | gibi | sahid_: and also this is only covering PCI devices requested via the pci alias in the flavor. The neutron SRIOV support is planned for later | |
| 10:56:34 | sahid_ | ack thank you for the heads-up I noticed that on the first path some of them get landed during zed | |
| 11:33:14 | sean-k-mooney | sahid_: the feature has basiclaly been code compelte for a while it just hit m3 so got pushed to A | |
| 11:34:21 | sean-k-mooney | sahid_: our orginal goal was to try and land this all by m1 but time going away form us so we are trying to make an effort to finaly get this merged before people start disaparing for PTO | |
| 11:36:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support multiple config file with mod_wsgi https://review.opendev.org/c/openstack/nova/+/864014 | |
| 11:49:13 | sahid_ | sean-k-mooney: ack i understand your point i guess | |
| 11:56:44 | sahid_ | guys I have a question regarding the usage of NOTE(name) do we really think that we should continue using it? I mean most of the time such note a just comment, no actions are required. Where I see that makes sense is for TODO/FIXME | |
| 11:58:58 | sean-k-mooney | yes i dislike having bare NOTE/FIXME without the name | |
| 11:59:17 | sean-k-mooney | it has come up before that we coudl drop the (name) portion | |
| 11:59:21 | sean-k-mooney | and some project have | |
| 11:59:38 | sean-k-mooney | we have a hacking check that enforces it to keep nova consitent | |
| 11:59:42 | sahid_ | I would drop the whole NOTE thingm with name or not | |
| 12:00:04 | sean-k-mooney | and just use bare comments | |
| 12:00:09 | sahid_ | yes | |
| 12:00:34 | sean-k-mooney | we could but because we cant eaially use git blame on some of our files | |
| 12:00:47 | sahid_ | instead of for TODO(name) or FIXME(name), which make sense has there is an action behind it | |
| 12:00:50 | sean-k-mooney | i kind of like having the name so i know who to ask about the note | |
| 12:01:10 | sean-k-mooney | sahid_: well the name is not ment to represent who is going to work on it | |
| 12:01:18 | sahid_ | yes i would have use git blame, but if we can't I understand | |
| 12:01:18 | sean-k-mooney | for TODO() and FIXME() | |
| 12:01:39 | sean-k-mooney | so the libvirt driver and compute manager often time out on github | |
| 12:02:06 | sean-k-mooney | so while i coudl do blame locally it does not work well for github/gitia | |
| 12:06:45 | sahid_ | BTW gibi, very impressive work | |
| 12:09:05 | gibi | sahid_: thanks, it was fun to get through it. I learned many things about our PCI codepath during that | |
| 12:09:32 | sahid_ | I imagine :-) | |
| 12:13:57 | sean-k-mooney | gibi: im sure you now have the scares on your soul to prove it too :P | |
| 12:14:17 | sean-k-mooney | gibi: with that said its both better and worse then it appears at first glance | |
| 12:14:48 | sean-k-mooney | once you wrap your head aroudn teh design its elegant in a way in how the virt driver bits are entirly abstracted | |
| 12:15:10 | sean-k-mooney | but there is a lot of other questionable choices that you ahve rectifed along the way | |
| 13:22:06 | gibi | sean-k-mooney: I agree with you I think the overal desing is OK, it just has a step learning curve | |
| 13:36:47 | sean-k-mooney | its proably comperable to emac/vims | |
| 13:36:56 | sean-k-mooney | which is not something to strive for | |
| 15:40:47 | sahid | o/ bauzas do you think we could discuss whehter the impl can get the Priority-Review bit as the spec received it? https://review.opendev.org/c/openstack/nova-specs/+/857838 | |
| 16:29:11 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Use extend volume migration https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 16:30:09 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Use extend volume completion action https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 16:47:09 | gibi | bauzas: zuul is happy now on https://review.opendev.org/c/openstack/nova/+/864014 | |
| 16:47:49 | bauzas | gibi: sent to the gate | |
| 16:47:54 | gibi | bauzas: thansk!~ | |
| 16:47:58 | gibi | thanks even :) | |
| 16:48:55 | kgube_ | sean-k-mooney, I rewrote the spec to reflect the current proposal in Cinder: https://review.opendev.org/c/openstack/nova-specs/+/855490 | |