| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-11-17 | |||
| 11:14:12 | sean-k-mooney | yes so i was about to approve the old patch and then soft -1 the second one askign for the workaround option if that works for you. | |
| 11:14:33 | sean-k-mooney | the only thing i was wonderign about for the first patch is shoudl it have a release note | |
| 11:14:44 | sean-k-mooney | although its only apartial fix | |
| 11:14:51 | sean-k-mooney | the second patch should have one | |
| 11:15:01 | johnthetubaguy | yeah, second patch needs one for sure | |
| 11:15:37 | johnthetubaguy | the first one might be worth advertising via a release note I guess, it is handy | |
| 11:16:24 | johnthetubaguy | but merging is better for me, obviously :) | |
| 11:16:41 | sean-k-mooney | shall i hold +2w for you to add one or just go for it | |
| 11:16:46 | sean-k-mooney | i think its fine as is | |
| 11:17:03 | johnthetubaguy | yeah, lets get that first one in, I will add some workaround stuff in the second one | |
| 11:17:05 | sean-k-mooney | i like to have releas notes for close-bug | |
| 11:17:18 | sean-k-mooney | i treat them as optional for paritals or related | |
| 11:17:22 | johnthetubaguy | ah, fair enough | |
| 11:17:45 | sean-k-mooney | cool first one is on its way | |
| 11:17:52 | sean-k-mooney | ill comment on the second | |
| 11:18:43 | johnthetubaguy | sweet, thank you | |
| 11:19:19 | sean-k-mooney | i owe you a review of the ironic spec too, i didnt get to it on the review day so once im done with this ill take a look at that next | |
| 11:24:55 | johnthetubaguy | Ah, that would be great, thank you. I am sure it needs some refinement. I have half a plan to do some POC work on that soon, but these other bugs keep distracting me. | |
| 11:31:38 | sean-k-mooney | your looking at a thrid bug related to pci claims too right. did you pick that up form mark? | |
| 11:32:22 | sean-k-mooney | ya its https://review.opendev.org/q/topic:bug%252F1860555 | |
| 11:32:54 | johnthetubaguy | sort of yes, trying to restack that on top of the functional test | |
| 11:33:21 | johnthetubaguy | I need to decide which of these we backport in various downstreams | |
| 11:34:53 | sean-k-mooney | i havent looked at it in a while but i tought it would be backportable upstream | |
| 11:35:47 | sean-k-mooney | in case that helps. | |
| 11:36:04 | johnthetubaguy | yeah, I agree, I think it should be | |
| 11:36:29 | johnthetubaguy | I am not totally sure about the claims stuff, and how critical that is, its very possible we leak PCI devices without that fix up | |
| 11:37:54 | sean-k-mooney | leak is not quite right | |
| 11:38:08 | sean-k-mooney | we can end up claiming more then we request | |
| 11:38:17 | sean-k-mooney | they will all get freed when the vm is deleted | |
| 11:38:19 | sean-k-mooney | but not before | |
| 11:38:25 | sean-k-mooney | without it | |
| 11:38:39 | johnthetubaguy | yeah, without that object refresh, that is certainly true | |
| 11:39:06 | sean-k-mooney | we have seen this persiste even after the vm is shelved in downstream bug reports | |
| 11:39:07 | johnthetubaguy | the functional test probably needs more checks on the PCI claims I guess | |
| 11:39:26 | sean-k-mooney | not nessisalry because fo the rescdule there were issue with resize in the past that had a similar effect | |
| 11:39:26 | johnthetubaguy | ah, good to know, certainly believeable | |
| 11:40:01 | johnthetubaguy | ah, interesting | |
| 11:40:28 | sean-k-mooney | i have not look i added RP+1 to get it on my list i proably wont get to it this week but ill try and see if i can take a look again on monday | |
| 11:41:35 | johnthetubaguy | thank you | |
| 11:43:14 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Add API for assisted volume extend https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 12:21:25 | sean-k-mooney | elodilles: im plannign to fix a trivial docs issuw with one of our config options but i want to also test this in ci https://bugs.launchpad.net/nova/+bug/1996094 | |
| 12:22:07 | sean-k-mooney | i chatted to bauzas about this a bit downstream and we wer eunsure how you and other stabel cores would feel about when it comes to backporting | |
| 12:22:30 | sean-k-mooney | elodilles: is it ok to do both in one patch or woudl you prefer we did not backport the ci change | |
| 12:22:56 | sean-k-mooney | i woudl prefer to backport both and if we are backportign both i would prefer to have it be in one patch | |
| 12:23:45 | sean-k-mooney | my curent plan is to set heal_instance_info_cache_interval=0 in nova-next | |
| 12:36:54 | opendevreview | John Garbutt proposed openstack/nova master: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/864773 | |
| 12:39:29 | johnthetubaguy | gibi sean-k-mooney I have added a release note and the workaround config, slightly more intrusive, but not by much I guess. | |
| 12:40:37 | sean-k-mooney | ack most of the way though the spec not much feeback so far beyond what is already there | |
| 12:40:59 | sean-k-mooney | just got to the nova manage command | |
| 12:48:47 | bauzas | sean-k-mooney: elodilles: yup, I just wondered if we were ok for backporting a .zuul file :) | |
| 12:49:57 | sean-k-mooney | im pretty sure i have dont that before | |
| 12:50:11 | sean-k-mooney | backported a job change we defintly did it to fix the train gate | |
| 13:01:19 | elodilles | sean-k-mooney bauzas : as far as i remember, traditionally, doc change backports were not accepted, but i think it is OK to backport them. about the CI I'm a bit hesitant, though. but it depends on the change, i would say | |
| 13:01:25 | gibi | johnthetubaguy: left reply in the pci re-schedule bugfix | |
| 13:01:47 | gibi | johnthetubaguy: that single instance.refresh() feels strange to me | |
| 13:01:58 | sean-k-mooney | elodilles: it littrally is disablelng a perodic task | |
| 13:02:36 | sean-k-mooney | elodilles: we perodicaly heal the network info cache but that in practic should not be required as neutron tells us when something chagnes | |
| 13:02:46 | sean-k-mooney | elodilles: so the ci change is setting one config value to 0 | |
| 13:03:04 | johnthetubaguy | gibi: agreed, its crazy that fixes so much, drops all the transient changes before a save, roughly. I want more of that claims stuff in the functional test I think | |
| 13:03:04 | sean-k-mooney | in one job nova-next | |
| 13:03:25 | elodilles | sean-k-mooney: so it won't be a new CI job, but a config value change in 1(?) job as I understand then | |
| 13:03:46 | sean-k-mooney | yes just one addtionall config override in the nova-next job | |
| 13:03:52 | gibi | johnthetubaguy: if the PciDevice.instance_uuid field is already update to point to this instance then simply resetting the instance with instance.refresh() cannot be enough | |
| 13:03:58 | sean-k-mooney | to set the existing config option to 0 instead of the defautl 60 | |
| 13:04:02 | elodilles | sean-k-mooney: and you state that it won't introduce any instability o:) | |
| 13:04:24 | sean-k-mooney | well thats why we want to have it runing in ci | |
| 13:04:29 | sean-k-mooney | but i dont belive it will | |
| 13:04:53 | elodilles | maby let's see it first in master banch then :) | |
| 13:05:01 | elodilles | * maybe | |
| 13:05:25 | sean-k-mooney | ok so two patches one for docs change to corect the help text adn seperate one for zuul | |
| 13:05:30 | sean-k-mooney | i can do that | |
| 13:05:43 | elodilles | sean-k-mooney: yep, that sounds good | |
| 13:09:45 | sean-k-mooney | cool ill do that then thanks | |
| 13:36:16 | opendevreview | Amit Uniyal proposed openstack/nova stable/train: functional: Change order of two classes https://review.opendev.org/c/openstack/nova/+/864672 | |
| 13:36:17 | opendevreview | Amit Uniyal proposed openstack/nova stable/train: functional: Rework '_delete_server' https://review.opendev.org/c/openstack/nova/+/864721 | |
| 13:36:18 | opendevreview | Amit Uniyal proposed openstack/nova stable/train: functional: Unify '_build_minimal_create_server_request' implementations https://review.opendev.org/c/openstack/nova/+/864713 | |
| 13:36:19 | opendevreview | Amit Uniyal proposed openstack/nova stable/train: Extend NeutronFixture to allow live migration with ports https://review.opendev.org/c/openstack/nova/+/864900 | |
| 14:04:49 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support https://review.opendev.org/c/openstack/nova/+/859577 | |
| 14:09:39 | opendevreview | Danylo Vodopianov proposed openstack/os-vif master: MTU support for DPDK port added https://review.opendev.org/c/openstack/os-vif/+/859574 | |
| 14:11:34 | opendevreview | John Garbutt proposed openstack/nova master: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/864773 | |
| 14:16:26 | opendevreview | Merged openstack/nova stable/ussuri: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/862603 | |
| 14:36:52 | opendevreview | Merged openstack/nova stable/ussuri: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/862604 | |
| 14:37:09 | opendevreview | Merged openstack/nova master: DOC update remote console access https://review.opendev.org/c/openstack/nova/+/860687 | |
| 14:47:24 | johnthetubaguy | gibi: I don't think the PCI device objects are getting saved in time, I am trying to prove that in the functional test at the moment | |
| 15:11:05 | opendevreview | Merged openstack/nova master: Replace "db archive" with "db archive_deleted_raws" https://review.opendev.org/c/openstack/nova/+/847963 | |
| 15:15:58 | opendevreview | sean mooney proposed openstack/nova stable/yoga: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/855022 | |
| 15:15:59 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/855023 | |
| 15:16:00 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking https://review.opendev.org/c/openstack/nova/+/855024 | |
| 15:16:01 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/855025 | |
| 15:16:02 | opendevreview | sean mooney proposed openstack/nova stable/yoga: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/855026 | |
| 15:16:04 | opendevreview | sean mooney proposed openstack/nova stable/yoga: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/855035 | |
| 15:16:30 | sean-k-mooney | gibi: finally got around to fixing the commit messge on the double mocking pathc. i also rebased to the tip of stable yoga | |
| 15:16:59 | sean-k-mooney | im goint to try backporting that to xena and wallaby now | |
| 15:20:45 | gibi | sean-k-mooney: I'm +2 on https://review.opendev.org/q/topic:bug%252F1970467 | |
| 15:28:49 | sean-k-mooney | ok including https://review.opendev.org/c/openstack/nova/+/829974 fixes it and that applies cleanly | |
| 16:24:34 | opendevreview | John Garbutt proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 16:24:35 | opendevreview | John Garbutt proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 16:30:32 | opendevreview | John Garbutt proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 16:34:48 | johnthetubaguy | gibi: I double checked with mgoddard, it turns out he found either patch will fix the issue, we just get to pick which one to merge. The functional tests seem to suggest mark is totally correct, i.e. either patch will fix it. I prefer the instance.refresh() one myself. | |
| 16:58:41 | gibi | johnthetubaguy: I'm wondering when we add the pci dev to the instance.pci_devices list. If we do that during the claim, then claim.abort should be the one to clean that up | |