| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-10-04 | |||
| 16:51:27 | bauzas | anything else to mention ? | |
| 16:51:29 | sean-k-mooney[m] | i would be in favor of eloing stien and older but ya ptg | |
| 16:51:47 | bauzas | perfect place for this kind of discussion | |
| 16:52:28 | bauzas | in particular given not a lot of people care about stein and older (in terms of branch maintainance) | |
| 16:52:38 | elodilles | :) | |
| 16:52:39 | bauzas | anyway, moving on | |
| 16:52:52 | elodilles | (meanwhile i've added the topic to the PTG etherpad) | |
| 16:52:52 | bauzas | #topic Open discussion | |
| 16:53:00 | bauzas | elodilles: great, thanks | |
| 16:53:05 | elodilles | ++ | |
| 16:53:18 | bauzas | there is nothing to discuss in the open discussion section | |
| 16:53:27 | bauzas | anyone having anything they'd like to say ? | |
| 16:53:48 | bauzas | as a reminder, specless blueprints can be asked here :) | |
| 16:54:11 | bauzas | looks not, | |
| 16:54:20 | bauzas | I return you 6 mins of your time | |
| 16:54:24 | bauzas | thanks alll | |
| 16:54:27 | bauzas | all* even | |
| 16:54:30 | bauzas | #endmeeting | |
| 16:54:30 | opendevmeet | Meeting ended Tue Oct 4 16:54:30 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:54:30 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-10-04-16.00.html | |
| 16:54:30 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-10-04-16.00.txt | |
| 16:54:30 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-10-04-16.00.log.html | |
| 16:54:36 | elodilles | thanks bauzas o/ | |
| 16:54:43 | Uggla | o/ | |
| 16:56:12 | gibi | o/ | |
| 16:56:35 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 16:56:36 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 16:56:36 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 16:56:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 16:56:38 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 16:56:38 | opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 16:56:39 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 16:56:44 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 16:56:44 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 16:56:45 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 16:56:45 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 16:56:46 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 16:56:46 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 16:56:47 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 16:56:48 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 16:56:48 | opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.94 https://review.opendev.org/c/openstack/nova/+/852088 | |
| 16:56:50 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 16:56:50 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 16:56:52 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 16:56:52 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 16:56:54 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 16:56:54 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 16:56:56 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 18:41:32 | opendevreview | Merged openstack/os-vif stable/xena: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/841771 | |
| 18:59:57 | opendevreview | Merged openstack/os-vif stable/xena: only register tables used by os-vif https://review.opendev.org/c/openstack/os-vif/+/841772 | |
| #openstack-nova - 2022-10-05 | |||
| 04:58:20 | opendevreview | Merged openstack/nova master: Remove the periodic Centos 8 job https://review.opendev.org/c/openstack/nova/+/858272 | |
| 08:13:44 | opendevreview | ribaudr proposed openstack/nova master: Default Nova persistent objects without soft delete. https://review.opendev.org/c/openstack/nova/+/854355 | |
| 08:22:20 | Uggla | stephenfin, if you have some time can you have a look at https://review.opendev.org/c/openstack/openstacksdk/+/853949 | |
| 08:55:39 | Uggla | gibi, bauzas , Hi so if you can have a look at https://review.opendev.org/c/openstack/nova/+/854355. | |
| 08:56:11 | bauzas | Uggla: I'll try, a bit busy today due to some late stuff | |
| 08:57:03 | Uggla | gibi, if you are motivated, then you can continue the review of manila/virtiofs all patches are under this new topic bp/manila_shares_attachments_v2 | |
| 08:58:02 | Uggla | bauzas, I know, there is no hurry. | |
| 08:58:08 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 08:58:08 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 09:37:22 | bauzas | Uggla: so, I'll look at your patch, but I'll also like to have dansmith to dent it https://review.opendev.org/c/openstack/nova/+/854355 | |
| 09:46:14 | gibi | Uggla: yes. I would like to keep reviewing the manila work. It is a bit hard for me to balance my time at the moment. So I would like to ask you to be peristent asking for review :) I won't be offended if you keep pinging me all the time with the manial stuff :) | |
| 10:05:48 | gibi | dansmith: if you have time when you are up we need your ovo experties here https://review.opendev.org/c/openstack/nova/+/854355/3..4#message-90730ecb520b41d974a8d64c7f7cd0bb0f56356c | |
| 10:06:10 | gibi | Uggla: ^^ I see the problem but I don't see the imediate solution | |
| 10:06:22 | gibi | and I don't like duplicating created_at | |
| 10:07:07 | gibi | It might turn out that what I want is not possible with ovo | |
| 10:12:40 | sean-k-mooney | i feel like what you want should be possible | |
| 10:12:47 | sean-k-mooney | but i have not looked at the review properly | |
| 10:13:06 | sean-k-mooney | i might pull it locally quickly and play with it for a bit and see if we can drop those fields | |
| 11:33:04 | opendevreview | Stephen Finucane proposed openstack/nova master: conf: Add '[database] enable_soft_delete' flag https://review.opendev.org/c/openstack/nova/+/860401 | |
| 11:34:01 | stephenfin | I've been thinking about that for years 👆 Maybe it belongs in oslo.db but the idea is what's relevant. Would welcome input (particularly melwitt) | |
| 11:51:10 | sean-k-mooney | stephenfin: you were not in some of our interal team calls but we were discussign coudl we move to remvoing shaddow tables | |
| 11:51:59 | sean-k-mooney | soft delete i dont have a probalem with honestly | |
| 11:52:04 | sean-k-mooney | i dont like shadown tables | |
| 11:52:28 | sean-k-mooney | my only concern with the conf approch is it change api behavior | |
| 11:52:45 | sean-k-mooney | specificly for soft deleteing instance as we can use the restore api action to undelete them | |
| 11:53:20 | sean-k-mooney | there is no api impact to remvoe shadow tables however since once we have archive the rows there is no going back | |
| 11:53:28 | sean-k-mooney | so that seam less in vasive to me | |
| 11:54:29 | sean-k-mooney | stephenfin: but yes removing softdelete is someting to consider. we could for example use the soft delete timout as the config option instead | |
| 11:54:39 | sean-k-mooney | so if its not enable dthen just delete thing fully | |
| 11:55:08 | sean-k-mooney | if we had already disabeld shadow tabels or remvoe them i think we could do that | |
| 11:55:16 | stephenfin | sean-k-mooney: Aren't those different things? | |
| 11:55:32 | sean-k-mooney | there are 3 things | |
| 11:55:33 | stephenfin | soft-deleting an instance vs soft-deleteable tables | |
| 11:56:03 | sean-k-mooney | soft deleteing an instnace marks the row as deelte but does not actully delete it until the soft delete timeout expires | |
| 11:56:12 | stephenfin | I don't think it does | |
| 11:56:50 | sean-k-mooney | i woudl have to check but as far as im aware it at least updates teh state so that it nolonger shows up in insntace list | |
| 11:56:58 | sean-k-mooney | unless you add --deleted | |
| 11:57:18 | sean-k-mooney | if it truely is independed and not marking it as delete in the db | |
| 11:57:32 | stephenfin | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3363-L3377 | |
| 11:57:44 | sean-k-mooney | then yes the 3 things (shadown tabels, soft deletable instance and soft deletable rows) would be independent | |
| 11:58:12 | stephenfin | it seems to be setting power_state, vm_state and task_state fields. It's not setting 'deleted' or 'deleted_at' | |
| 11:58:14 | sean-k-mooney | ok so its via a vm state | |
| 11:58:21 | stephenfin | yup | |
| 11:58:28 | stephenfin | which this doesn't touch | |
| 11:58:32 | sean-k-mooney | ok then ya no api impact so | |
| 11:58:44 | sean-k-mooney | add it as a ptg topic | |
| 11:59:53 | sean-k-mooney | so long term i like to remvoe nova-manage acive_delete_rows and make pruge act like purge in other project | |
| 12:00:12 | sean-k-mooney | in other projects purge it deletes the soft deleted rows | |
| 12:00:43 | sean-k-mooney | but if we can also remvoe those (optionally or eventually permently) i woudl be happy to do that too | |
| 12:01:36 | sean-k-mooney | stephenfin: i think i have mentioned this to you before but i woudl prefer if we mvoed to recommendign peole use https://github.com/ovh/osarchiver/ | |