| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-09-22 | |||
| 14:09:17 | sean-k-mooney | so im fine with droping python | |
| 14:09:23 | sean-k-mooney | becuase you knwo bindep needs it | |
| 14:09:44 | sean-k-mooney | so if you dont know why we have it i can remove it but i think its to ensure we have all the python version we need | |
| 14:10:45 | sean-k-mooney | i.e. i think the tox job does not preinstall the python versoin for the current job | |
| 14:11:01 | sean-k-mooney | and bindep is isntalling all of them so when tox runs the required version is there | |
| 14:11:07 | sean-k-mooney | does that make sesne | |
| 14:12:21 | sean-k-mooney | actully no | |
| 14:12:23 | sean-k-mooney | https://packages.ubuntu.com/focal/python3-all | |
| 14:12:32 | sean-k-mooney | so its just pulling the default python looking at the deps | |
| 14:12:44 | sean-k-mooney | althoguh that might be wrong | |
| 14:12:49 | sean-k-mooney | package depending on all supported Python 3 runtime versions | |
| 14:13:03 | sean-k-mooney | so that appears to by why we are using it | |
| 14:19:13 | bauzas | sean-k-mooney: I'm done with my meeting but I need to go taxidading | |
| 14:19:30 | bauzas | I'll look at your patches when I'm back | |
| 14:40:38 | zigo | My 1st Zed VM is up and pings ... :P | |
| 14:41:18 | sean-k-mooney | :) | |
| 14:49:57 | gmann | sean-k-mooney: I thought it was merged. gibi stephenfin please check this https://review.opendev.org/c/openstack/placement/+/845074 | |
| 14:50:20 | gmann | or bauzas ^^ | |
| 14:55:44 | stephenfin | gmann: We were just talking about that. https://review.opendev.org/c/openstack/placement/+/858927 does the same but for RHEL/Fedora also | |
| 14:55:54 | stephenfin | Is this blocking the gate? | |
| 14:56:36 | gmann | i think py310 job is failing whihc is voting now | |
| 14:57:24 | frickler | it is blocking https://review.opendev.org/c/openstack/placement/+/857901 which should be merged before anything else in master | |
| 14:58:02 | stephenfin | gmann: Are you core on placement? Want to look over this? https://review.opendev.org/c/openstack/placement/+/858927 | |
| 14:58:32 | stephenfin | I +W'd it to unblock the gate but it's always good to have another pair of eyes | |
| 14:58:45 | gmann | sure | |
| 14:59:27 | gmann | done | |
| 14:59:34 | opendevreview | Stephen Finucane proposed openstack/placement master: Switch to 2023.1 Python3 unit tests and generic template name https://review.opendev.org/c/openstack/placement/+/857901 | |
| 14:59:45 | stephenfin | ty | |
| 15:00:06 | stephenfin | rebased that and +W so they should merge together (CC: Frickler) | |
| 15:17:46 | bauzas | sean-k-mooney: gmann: stephenfin: fwiw, +Wd https://review.opendev.org/c/openstack/placement/+/858927 | |
| 15:18:25 | bauzas | tbc, we don't need to backport it to Zed, right? | |
| 15:18:29 | bauzas | this is just for Antelope | |
| 15:18:58 | gmann | bauzas: yes. only for Antelope | |
| 15:19:13 | bauzas | yeah, just verified https://governance.openstack.org/tc/reference/runtimes/zed.html | |
| 15:19:19 | bauzas | 20.04 | |
| 15:19:22 | bauzas | we're all good | |
| 16:00:20 | melwitt | sean-k-mooney: I wanted to get your thoughts on this bug fix, do you think this is an ok thing to do or any problems with it? I was unsure about whether it's proper to use qemu-img info to determine the disk format of a volume https://review.opendev.org/c/openstack/nova/+/858836 | |
| 16:02:03 | sean-k-mooney | is this related ot luks | |
| 16:02:27 | melwitt | sean-k-mooney: no, it's just nfs | |
| 16:02:28 | sean-k-mooney | oh no its differnt | |
| 16:02:45 | sean-k-mooney | ya i tough i swa an nfs related patch for something like this | |
| 16:02:52 | sean-k-mooney | oh i rememebr the bug | |
| 16:03:08 | sean-k-mooney | so snapshots on nfs have to be qcow right | |
| 16:03:23 | melwitt | right | |
| 16:03:33 | sean-k-mooney | like the os-assisted-snapshost api say it must be that | |
| 16:03:36 | sean-k-mooney | ok | |
| 16:03:42 | melwitt | yes it does | |
| 16:04:11 | sean-k-mooney | so when i was looking at the snapshot code i think i say we shoudl usjt update it to be qcow | |
| 16:04:19 | melwitt | but on our side we store the volume attachment connection_info and the format captured there represents the format of the volume (which is raw) not the snapshot (which is qcow2) | |
| 16:04:58 | sean-k-mooney | ya | |
| 16:05:03 | melwitt | yeah, the thing is how to "remember" that when the instance is rebooted for example | |
| 16:05:50 | sean-k-mooney | let me see if i can find the code i was suggesting changing but basicaly i was suggestin updating the format on the image | |
| 16:06:07 | sean-k-mooney | what your dowing sound valid | |
| 16:06:13 | sean-k-mooney | just not sure if its requried | |
| 16:06:18 | melwitt | oh, hm | |
| 16:07:54 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2932-L2958 | |
| 16:08:00 | sean-k-mooney | i tought we could fix that in that code | |
| 16:09:04 | melwitt | ok, I will look at that. thanks for the pointer | |
| 16:10:16 | sean-k-mooney | honestly i think when we create teh snapshot the connection info should get updated to qcow | |
| 16:11:11 | melwitt | sean-k-mooney: I tried that first https://review.opendev.org/c/openstack/cinder/+/857528 and it's run into problems | |
| 16:11:32 | melwitt | if you have any thoughts on that one as well | |
| 16:12:06 | sean-k-mooney | well the backend driver should be reprotign it as qcow no? | |
| 16:12:14 | melwitt | because unless the connection_info gets updated in cinder, we will overwrite it when we do refresh connection_info | |
| 16:12:23 | sean-k-mooney | like its a bug for them to be returnign raw after the snapshot is created | |
| 16:12:33 | melwitt | cinder only keeps the volume format, not the snapshot format | |
| 16:12:46 | melwitt | that's the only thing it knows how to return | |
| 16:13:10 | sean-k-mooney | right so the volume format should be updated once we snapshot right | |
| 16:13:19 | sean-k-mooney | because it has now changed | |
| 16:13:30 | melwitt | yeah, so I tried that and it broke volume extend | |
| 16:13:35 | sean-k-mooney | fun | |
| 16:13:53 | melwitt | because the resize needs to change the size of the raw backing file iiuc | |
| 16:14:05 | sean-k-mooney | so we could work around this in nova but i think we shoudl also bring this up with cinder in the ptg | |
| 16:14:13 | melwitt | so if we stored qcow2, that blows up when it tries to resize raw by specifying qcow2 | |
| 16:14:22 | sean-k-mooney | well extend is not supported with nfs | |
| 16:14:28 | sean-k-mooney | so that shoudl not be a problem | |
| 16:14:29 | melwitt | it is | |
| 16:14:31 | sean-k-mooney | its not | |
| 16:14:42 | sean-k-mooney | we have a spec and open bug for it | |
| 16:14:46 | melwitt | it's in the nfs job, that's how I know it failed :P | |
| 16:14:56 | sean-k-mooney | well its not supported | |
| 16:15:06 | melwitt | ? | |
| 16:15:11 | sean-k-mooney | https://bugs.launchpad.net/cinder/+bug/1870367 | |
| 16:15:52 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 16:16:03 | sean-k-mooney | that is the spec to add extend support in A | |
| 16:16:54 | melwitt | huh. | |
| 16:17:03 | melwitt | I wonder what/how it's running the tests on nfs and passing currently | |
| 16:17:23 | sean-k-mooney | it can work but i think its racy | |
| 16:17:31 | melwitt | ugh, ok. | |
| 16:17:35 | sean-k-mooney | basicaly they tought they fixed it | |
| 16:17:46 | sean-k-mooney | but the external event is async | |
| 16:17:56 | sean-k-mooney | so there is no way for cidner ot know if it works or not | |
| 16:18:25 | sean-k-mooney | there is also https://bugs.launchpad.net/cinder/+bug/1978294 | |
| 16:19:51 | melwitt | yeah.. I have seen that but I didn't remember it when I saw the extend test fail | |
| 16:21:03 | melwitt | I'll add something to the ptg agenda about this | |
| 16:22:06 | melwitt | bc even if we skipped the extend tests for nfs, changing the actual volume format in the metadata to qcow2 afaik isn't correct because it's the snapshot that is qcow2 and the volume itself is still raw. so we're still stuck | |
| 16:33:09 | stephenfin | melwitt: Random question. It appears the '<class>' argument to 'nova quota-class-show <class>' doesn't do anything. Is that expected? | |
| 16:34:14 | sean-k-mooney | melwitt: see the way this works with nfs that is not reallly true | |
| 16:34:22 | melwitt | stephenfin: I don't think that's expected. are you running like 'nova quota-class-show default'? | |
| 16:34:52 | sean-k-mooney | when we create the snapshot the snapshot point to the orginal file and the vm is now runnign form the qcow that is created on top right | |
| 16:35:02 | gibi | gmann, stephenfin: sorry I focused elsewhere. I see stephenfin approved it now | |