| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-31 | |||
| 09:21:30 | stephenfin | okay | |
| 09:21:41 | sean-k-mooney[m] | thats everything except the schduler part | |
| 09:21:43 | gibi | also in the light of the recent shadow RPC discussion I feel that storing data in InstancePCIRequest.extra_info is also shadowy in my series | |
| 09:22:07 | gibi | sean-k-mooney[m]: yepp, that already gives visibility of the PCI resource inventories in placement which is good to have | |
| 09:22:29 | sean-k-mooney[m] | it would have been nice to have the split pools by PF change | |
| 09:22:42 | gibi | we could land that, that is not effected by the bug | |
| 09:23:02 | sean-k-mooney[m] | that would be nice since it gives preference to PFs without VFs when you ask for a PF | |
| 09:23:03 | gibi | it does not do any externally visible change\ | |
| 09:23:22 | gibi | I'm not sure it is a real preference or just an ordering change | |
| 09:23:29 | gibi | I have to look if we sort the pool | |
| 09:23:52 | sean-k-mooney[m] | i always tought the way we allocated was more or less deterministic | |
| 09:24:23 | sean-k-mooney[m] | at least it has been stable enough for use to use in the functional tests without intermient failures | |
| 09:24:31 | gibi | it is stable | |
| 09:24:44 | gibi | but it might be not stable do to sorting | |
| 09:24:55 | gibi | but due to simple iteration order of devices / pools | |
| 09:25:03 | sean-k-mooney[m] | ack | |
| 09:25:20 | bauzas | sean-k-mooney: so I've read https://review.opendev.org/c/openstack/nova/+/816157/15 | |
| 09:25:23 | sean-k-mooney[m] | so i guess we can look at that again and confirm if it is of benifit | |
| 09:25:34 | bauzas | sean-k-mooney: can you request for the patch split and the other microversion ? | |
| 09:25:37 | gibi | sean-k-mooney[m]: yes, I will look at the ordering | |
| 09:25:51 | bauzas | I can leave some comments but I'm way behind | |
| 09:25:54 | gibi | I have to drop for an hour now for an early lunch but I will be back after | |
| 09:26:15 | sean-k-mooney[m] | bauzas: sure | |
| 09:26:21 | bauzas | thanks | |
| 09:26:40 | bauzas | I'll review quickly the bfv rebuild series | |
| 09:26:56 | bauzas | both you and gibi gave +2s but I'll do my glance quickly | |
| 09:27:14 | bauzas | and I'll tell whoami-rajat to respin the API patch with 2.93 | |
| 09:27:21 | gibi | bauzas: you could look at the viommu one too | |
| 09:27:43 | bauzas | gibi: yup, on my list | |
| 09:32:01 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/816157/15#message-f9bcfb9f6d0115f20223c4cd1e91d5c5428798d7 | |
| 09:32:06 | sean-k-mooney[m] | done ^ | |
| 09:32:51 | sean-k-mooney[m] | whoami-rajat: dansmith do you have time to update the BFV serise to use 2.93 and rebase to master | |
| 09:32:52 | bauzas | thanks | |
| 09:33:16 | sean-k-mooney[m] | its too early for them but they should see it when they get online | |
| 09:36:38 | sean-k-mooney[m] | gibi i think you are right by the way. there is no preference its just the fact we create the pool with just the PF before we create the pool with the VF in those tests i think so its just down to pciadress/pool ordering i think. | |
| 09:37:32 | sean-k-mooney[m] | we could add a prefernce but that is out of scope of the spec so dont worry about it | |
| 09:45:24 | sean-k-mooney[m] | ... its a annoying i think i see how to fix configdrive | |
| 09:45:57 | sean-k-mooney[m] | for RBD we do infact import the local config drive into ceph and it will creatly delete and recreate it if required | |
| 09:46:40 | sean-k-mooney[m] | if i use a tempory path to to generate teh new config drive and implemnente import file for the other backends then that should fix it | |
| 09:47:13 | sean-k-mooney[m] | for flat/qcow that jsut an atomic move to the normal localtion via privesep to workaround the permission issue | |
| 09:47:29 | sean-k-mooney[m] | for lvm its not much harder to do but its a little more work | |
| 09:48:25 | sean-k-mooney[m] | so im still going to try and do that so that they have a refernce patch for how to fix it | |
| 10:03:27 | bauzas | sean-k-mooney: gibi: fwiw https://review.opendev.org/c/openstack/nova/+/820368/comment/bd35c4c9_0ad9dd3d/ I'm asking to update https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_rebuild in the API patch | |
| 10:11:27 | sean-k-mooney[m] | bauzas: gibi ok i have a working version of the config drive part | |
| 10:11:48 | sean-k-mooney[m] | i can push it for review and then work on tests to see what people think | |
| 10:14:46 | bauzas | ok | |
| 10:14:58 | bauzas | I need to bail out for lunch but I'll be back later | |
| 10:26:49 | opendevreview | sean mooney proposed openstack/nova master: support configdrive rebuilding https://review.opendev.org/c/openstack/nova/+/855351 | |
| 10:44:13 | whoami-rajat | sean-k-mooney[m], ack, on it | |
| 11:35:33 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 11:35:34 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 11:35:34 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 11:37:40 | whoami-rajat | sean-k-mooney[m], bauzas gibi dansmith ^^ rebased to 2.93 | |
| 11:37:59 | bauzas | ++ | |
| 11:38:11 | whoami-rajat | once this merges, i will change novaclient, openstackclient, tempest changes as well | |
| 11:39:44 | whoami-rajat | bauzas, I wasn't sure what your ask was regarding the support matrix change, can you check if this is the change you intended ? https://review.opendev.org/c/openstack/nova/+/830883/29..30/doc/source/user/support-matrix.ini | |
| 11:39:53 | whoami-rajat | https://review.opendev.org/c/openstack/nova/+/830883/30/doc/source/user/support-matrix.ini | |
| 11:45:54 | bauzas | whoami-rajat: well, the status should be 'complete' for the libvirt drivers, right? | |
| 11:48:12 | whoami-rajat | bauzas, yeah, there were too many, so wasn't sure, will update for all libvirt drivers | |
| 11:49:13 | bauzas | whoami-rajat: say 'unknown' for the ones you don't know | |
| 11:49:36 | bauzas | like ppc64, s390x and lxc | |
| 11:49:59 | whoami-rajat | to be honest, I'm not sure about different architectures | |
| 11:50:01 | whoami-rajat | ack will do | |
| 11:52:17 | gibi | I guess on those architecture where the libvirt virt driver supports boot from volume there the rebuild will work too. at least I don't remember any arch dependent code in the rebuild patches | |
| 11:53:05 | sean-k-mooney | the arch shoudl not matter | |
| 11:53:16 | sean-k-mooney | the virt types might | |
| 11:53:25 | sean-k-mooney | as i expect this to work for qemu and kvm | |
| 11:55:09 | sean-k-mooney | we could list them as unknon but i stongly suspect it will work on arrch64 at the very least or as gibi suggested anywhere wehre boot form volume is supported | |
| 11:57:19 | sean-k-mooney | whoami-rajat: we support attach and detach volume on all teh kvm and qemu combindations | |
| 11:58:18 | sean-k-mooney | do you have any reason to belive that it would not work or would depend on the architecure | |
| 11:59:14 | gibi | we dont have a row in the matrix about boot from volume support | |
| 11:59:38 | sean-k-mooney | ya i noticed that | |
| 11:59:52 | sean-k-mooney | this could be adressed in a followup patch yes | |
| 11:59:58 | gibi | yes | |
| 12:00:05 | gibi | the whole matrix thing is just doc | |
| 12:00:12 | gibi | that can be done even after FF | |
| 12:00:16 | gibi | before RC1 | |
| 12:00:25 | gibi | or as a doc bugfix later | |
| 12:00:52 | whoami-rajat | sean-k-mooney, i don't think so, if BFV works then this should work too as we're doing some attach detach operations and on cinder side we're doing dd to copy image data to volume | |
| 12:01:06 | whoami-rajat | more or less same as what we do in BFV | |
| 12:01:26 | sean-k-mooney | ack thats what i tought woudl be the case | |
| 12:01:43 | whoami-rajat | so should i just mark all kvm qemu drivers as supported? | |
| 12:01:46 | sean-k-mooney | i think we could mark them complete unless we get a bug report saying it does not work | |
| 12:02:05 | sean-k-mooney | thats what i would do but bauzas might perfer unknonw | |
| 12:02:05 | whoami-rajat | ack, will update that | |
| 12:02:46 | bauzas | I'm not opiniateds | |
| 12:03:12 | bauzas | and I thought, given whoami-rajat was about to update his API change, it was OK to ask for this for the API chbange | |
| 12:03:18 | bauzas | and not by a FUP | |
| 12:03:39 | sean-k-mooney | either is fine | |
| 12:03:52 | gibi | I'm OK with the patch as is if we go with a FUP, or I can reapply my +2 if it is respined | |
| 12:03:53 | sean-k-mooney | i was waitign for zuul to report before revieing after the microversion change | |
| 12:05:19 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 12:05:34 | whoami-rajat | does this look good? ^ | |
| 12:06:08 | sean-k-mooney | yes i think so | |
| 12:06:51 | bauzas | +2d | |
| 12:07:07 | sean-k-mooney | libvirt-lxc wont work since attach/detach volumes is missing but thats a nit | |
| 12:07:23 | sean-k-mooney | unknonw is fine | |
| 12:09:18 | gibi | we need a +2+A on the first patch then the series will land | |
| 12:09:49 | sean-k-mooney | doing that now | |
| 12:09:52 | sean-k-mooney | was just revieing it | |