| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-30 | |||
| 20:04:38 | sean-k-mooney[m] | that we dont regenerate today | |
| 20:05:06 | dansmith | gibi: well my first thought was not a flag, but pass the user data to the reboot call, and let it update it | |
| 20:05:14 | dansmith | gibi: that would be much better all around | |
| 20:05:21 | dansmith | I need to look at the potential size limit though | |
| 20:05:29 | sean-k-mooney[m] | like if you attch a volume/interface or update server metadata that wont get updated in the config drive today | |
| 20:05:31 | gibi | ahh yeah, it is a blob | |
| 20:05:34 | dansmith | if you can pass a MiB that would be bad... | |
| 20:06:11 | sean-k-mooney[m] | its 64k i think | |
| 20:06:36 | dansmith | sean-k-mooney[m]: is it? | |
| 20:06:52 | sean-k-mooney[m] | its large yes | |
| 20:06:57 | dansmith | we might want to make that bigger though at some point, so expecting to put that into an rpc message might be a bad idea long-term | |
| 20:07:44 | melwitt | it was a bit of a coincidence :) I saw sean's comment on the userdata review come in email and they said "I talked to dan" but I didn't see any talking to dan in the channel. that's when I realized my client was messed up | |
| 20:07:56 | dansmith | aha | |
| 20:08:26 | gibi | I need to drop for the night. I'm fine pulling user_data out of the release while we design it better. I just whish we can somehow avoid in the future push contributors into a desgin dead end and then pulling the rug out at FF. | |
| 20:08:51 | dansmith | I know the feeling because I was arguing that we not do that for bfv rebuild either | |
| 20:09:01 | gibi | yeah | |
| 20:09:04 | dansmith | and I noted in my comment that (a) I know the implication and (b) I'm willing to scramble on the work | |
| 20:09:09 | melwitt | so I disconnected and reconnected the network and I saw yalls comments rolling in. but when I sent messages there was no acknowledgement, so I checked the irc logs and my messages weren't there. so I had to escalate to a full quit/start of my client. and now it's working 🙄 | |
| 20:09:29 | gibi | I can look at the patch / comments tomorrow morning. But now I drop. See you tomorrow | |
| 20:09:39 | dansmith | alright | |
| 20:09:45 | gibi | o/ | |
| 20:09:56 | dansmith | sean-k-mooney[m]: how about this: | |
| 20:10:28 | dansmith | sean-k-mooney[m]: how about we let this land as it is because theoretically the trait should catch it, and we convert to an RPC interface after BFV set and before the release | |
| 20:10:36 | dansmith | that won't be a behavioral change since it *should* be catching it now | |
| 20:10:58 | dansmith | if someone is deploying on master within a two week window they could have some sysmeta cruft, but highly unlikely | |
| 20:11:31 | sean-k-mooney[m] | ack we can likely get that working by the end of the week | |
| 20:11:43 | sean-k-mooney[m] | as part of the follow up patch once bfv is landed | |
| 20:11:46 | dansmith | it's mostly what I just wrote, but 6.2 | |
| 20:11:56 | sean-k-mooney[m] | yep | |
| 20:12:09 | dansmith | but I also think that this is missing a lot of testing it should have | |
| 20:12:23 | sean-k-mooney[m] | looking at it again you are right | |
| 20:12:26 | dansmith | has anyone other than the author tried this on a real devstack? with configdrive? | |
| 20:12:50 | sean-k-mooney[m] | no i was going to see if i could do that tonight but i might just do that torrow at this point | |
| 20:12:57 | dansmith | also, in my defense, gibi *did* ask me to review this :) | |
| 20:13:30 | dansmith | and I *did* try to punt to melwitt | |
| 20:13:46 | dansmith | and melwitt *did* sabotage her irc client so she "didn't see that" | |
| 20:13:52 | sean-k-mooney[m] | i was going to see if i could create a tempest test for this althogh im not sure how to force the vm too boot on the un upgraded node for grenade | |
| 20:14:12 | dansmith | yeah you can't really, so you have to boot two and hit both I think | |
| 20:14:29 | dansmith | but at least it would non-deterministically fail | |
| 20:14:32 | sean-k-mooney[m] | oh with the anti affintiy filter | |
| 20:15:09 | dansmith | melwitt: are you caught up yet, enough to grok that ^ plan? | |
| 20:16:12 | melwitt | dansmith: yeah I think so | |
| 20:16:30 | dansmith | and what say ye? | |
| 20:17:21 | melwitt | the plan sounds like a good compromise | |
| 20:18:44 | sean-k-mooney[m] | we can likely sync with the autour tomrrow but i can set this up and test it tomorrow in anycase and perhaps look at more testing | |
| 20:19:08 | sean-k-mooney[m] | so see if we can harden this and unblock bfv | |
| 20:20:05 | dansmith | I just un-1'd it with a writeup | |
| 20:20:24 | dansmith | sean-k-mooney[m]: are you saying that because you want to test it before it merges, given it has no real testing now? | |
| 20:20:33 | dansmith | or because you expect some change to this again? | |
| 20:21:10 | sean-k-mooney[m] | they were going to work on a followup patch to adress some nits | |
| 20:21:24 | sean-k-mooney[m] | and i want to test it and figure out what else they should add tests for in that | |
| 20:21:46 | dansmith | okay but we told them to do those as a follow-up right? | |
| 20:21:56 | sean-k-mooney[m] | yep | |
| 20:22:35 | dansmith | okay, well, tomorrow our runway is even shorter | |
| 20:22:40 | dansmith | so hopefully you can do that in the morning :) | |
| 20:23:06 | melwitt | sean-k-mooney[m]: something I was confused on was whether the admin password (if there is one) would be preserved across a configdrive recreate. it seemed like yes? based on userdata update during rebuild impl, but I couldn't find definitively how that works | |
| 20:23:20 | dansmith | I guess I thought you all were more confident in this with all the +2s it had | |
| 20:24:16 | sean-k-mooney[m] | i was priortising it more then i would otherwise becuase of the bfv series on top | |
| 20:25:37 | dansmith | yeah the ordering was unfortunate | |
| 20:26:05 | sean-k-mooney[m] | i should have reviewed it more closly sorry. thanks for reviewing though even if the timing is not idea its better to get this right | |
| 20:27:24 | dansmith | yep, so maybe if you test in the morning and +W it we can get the others in the queue and I'll start on the proper RPC stuff based on my pastebin above when I'm around | |
| 21:23:35 | opendevreview | Rajat Dhasmana proposed openstack/python-novaclient master: Add support to rebuild boot volume https://review.opendev.org/c/openstack/python-novaclient/+/827163 | |
| 21:31:59 | opendevreview | Rajat Dhasmana proposed openstack/python-novaclient master: Add support to rebuild boot volume 2.94 https://review.opendev.org/c/openstack/python-novaclient/+/827163 | |
| 21:33:02 | whoami-rajat | ^ rebased on top of 2.93 to avoid conflicts later | |
| 21:34:47 | whoami-rajat | sean-k-mooney[m], jfyi, you've a -2 on client patch of 2.93 https://review.opendev.org/c/openstack/python-novaclient/+/816158 | |
| 21:41:37 | sean-k-mooney[m] | oh i didnt clear that after you spun | |
| 21:41:50 | sean-k-mooney[m] | i proably wont review that tonight but ill drop the -2 sorry about that | |
| 21:43:01 | sean-k-mooney[m] | oh thats the user data one | |
| 21:44:25 | whoami-rajat | yep, you already dropped the -2 from mine some time back but without the user data one, my change can't get in :) | |
| 21:48:05 | sean-k-mooney[m] | i ment to do that when the spec was approved | |
| 21:50:12 | sean-k-mooney[m] | there is no reason your bfv sereise would not work with the lvm driver right | |
| 21:50:53 | sean-k-mooney[m] | i have a devstack deploying to test the user_data update but forgot to enable ceph | |
| 21:51:16 | sean-k-mooney[m] | but i can pull in your changes after and test them if i get time after | |
| 23:14:34 | sean-k-mooney[m] | dansmith: https://termbin.com/6502 | |
| 23:15:27 | sean-k-mooney[m] | ill try ubuntu 20.04 in the morning but on c9s the regenreation fails | |
| 23:15:33 | dansmith | ugh | |
| 23:15:47 | dansmith | I was not expecting that kind of failure | |
| 23:16:01 | dansmith | seems if we get to the mkisofs part we should be as good as otherwise | |
| 23:16:12 | sean-k-mooney[m] | not when we are just calling an exsiting funciton | |
| 23:16:27 | dansmith | so the configdrive was created properly on instance boot but failed on regenerate? | |
| 23:17:17 | sean-k-mooney[m] | ya it might be because of the format | |
| 23:17:28 | sean-k-mooney[m] | this might be trying to update the iso | |
| 23:18:11 | dansmith | oh you mean code that works if the iso doesn't exist but fails if it already does? | |
| 23:18:13 | sean-k-mooney[m] | when we use vfat that is allow but for iso it need to delete and recreate the file | |
| 23:18:21 | dansmith | right | |
| 23:18:39 | dansmith | I guess I expected it to overwrite, but maybe that's why permission denied, because qemu owns it now? | |
| 23:18:39 | sean-k-mooney[m] | ya the previous iff unly ran that code if the file did not exist | |
| 23:18:43 | dansmith | yeah | |
| 23:18:51 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/816157/15/nova/virt/libvirt/driver.py#4950 | |
| 23:19:01 | dansmith | man, if this really doesn't work (with isofs) and nobody tested until now ... :P | |
| 23:19:17 | sean-k-mooney[m] | the reboot continues | |
| 23:19:25 | sean-k-mooney[m] | the error is logged and ignored | |
| 23:19:41 | sean-k-mooney[m] | so if you dont actuly look at the logs it looks like it worked form the api | |
| 23:19:58 | dansmith | yeah, but I hope that's not why it went unnoticed | |
| 23:20:11 | dansmith | this is also why a tempest test would be good... | |
| 23:20:46 | dansmith | early in the bfv rebuild, we were doing the same.. quietly not doing the rebuild, and I wrote a test that touches a file, then does the rebuild, and asserts that it's gone.. and that pointed out that we weren't actually doing it | |
| 23:22:40 | sean-k-mooney[m] | lookign at the vfat path i think i twould repoen the file and reformat it https://github.com/openstack/nova/blob/master/nova/virt/configdrive.py#L100 | |
| 23:23:32 | sean-k-mooney[m] | although im kind fo surrpised its failing like this for iso | |
| 23:23:32 | sean-k-mooney[m] | the upper fucntion https://github.com/openstack/nova/blob/master/nova/virt/configdrive.py#L137 | |
| 23:23:54 | dansmith | I gotta run in a minute | |