| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-30 | |||
| 10:30:25 | sean-k-mooney | kgube: what is the thing you have been working on by the way | |
| 10:38:47 | kgube | sean-k-mooney: support for extending attached file-based volumes (such as NFS volumes) | |
| 10:39:05 | sean-k-mooney | oh that shoudl already exists | |
| 10:39:23 | sean-k-mooney | provided the cinder volume supprots it | |
| 10:39:40 | sean-k-mooney | i rememebr that case being speical but i belive it should work | |
| 10:40:10 | sean-k-mooney | ah yes https://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_online_extend_support | |
| 10:40:24 | sean-k-mooney | Generic NFS Reference Driver (NFS): missing | |
| 10:41:04 | sean-k-mooney | but some vendor nfs drivers supprot it | |
| 10:41:06 | sean-k-mooney | Veritas Cluster NFS Driver (NFS): complete | |
| 10:41:12 | sean-k-mooney | NetApp Data ONTAP Driver (iSCSI, NFS, FC): complete | |
| 10:41:27 | sean-k-mooney | kgube: so that is likely a cidner feature rahter then a nova one | |
| 10:41:33 | kgube | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1978294 | |
| 10:43:16 | sean-k-mooney | hum | |
| 10:43:35 | sean-k-mooney | im not sure if we really want nova to have logic to resize these volumes on behalf of the backend | |
| 10:43:50 | sean-k-mooney | i guess we can review your proposal | |
| 10:44:04 | sean-k-mooney | but i would proably push this towards os-brick | |
| 10:44:12 | kgube | the logic is already there, though | |
| 10:44:21 | sean-k-mooney | or require the backend driver to do it not nova | |
| 10:44:45 | kgube | its just exposed as an external server event only | |
| 10:44:55 | sean-k-mooney | changing the external events api to be synconous is likely not somethign we can do | |
| 10:45:22 | kgube | The problem is that QEMU has to perform the resize | |
| 10:45:35 | sean-k-mooney | qemu or qemu image | |
| 10:45:46 | sean-k-mooney | *qemu-img | |
| 10:46:21 | kgube | qemu holds a lock on the attached file, which qemu-img respects | |
| 10:46:38 | kgube | so it refuses to resize | |
| 10:46:41 | sean-k-mooney | right but you can call qemu-img with force-share | |
| 10:47:05 | sean-k-mooney | my understandign is that is what the nfs driver normally did to reseize the device | |
| 10:47:10 | sean-k-mooney | is that not the case | |
| 10:47:22 | kgube | that does not work for modifying the image, afaik | |
| 10:48:39 | kgube | and the qemu-img docu explicitely warns against modifying attached volumes | |
| 10:49:58 | sean-k-mooney | i see | |
| 10:50:04 | sean-k-mooney | then rather then a new server action | |
| 10:50:29 | sean-k-mooney | i think you should modle the new api on the existing /os-assed-volume-shapshots api | |
| 10:50:31 | sean-k-mooney | https://docs.openstack.org/api-ref/compute/#create-assisted-volume-snapshots | |
| 10:51:40 | sean-k-mooney | actully https://docs.openstack.org/api-ref/compute/#assisted-volume-snapshots-os-assisted-volume-snapshots is slight better link | |
| 10:52:19 | sean-k-mooney | you could add a /os-assisted-volume-extend api for this usecase | |
| 10:52:57 | sean-k-mooney | that can be blocking or nonblocking as its a new api for this exact usecase | |
| 10:53:43 | sean-k-mooney | its not really a server action like the other instance actions hence new top level api | |
| 10:54:41 | kgube | ok, yeah, I guess that makes sense | |
| 10:56:24 | kgube | so Cinder does not need to care which instance the volume is attached to | |
| 10:58:43 | sean-k-mooney | well im not actully sure why we dont include the instance uuid it woudl make our life simpler | |
| 10:59:06 | sean-k-mooney | so i would proably include it in teh request as its simpelr for use to then make the rpc to the compute node work | |
| 11:00:05 | sean-k-mooney | im not actully user that /os-assisted-volume-snapshots works properly for multi_attach volumes for example | |
| 11:00:26 | sean-k-mooney | although i suspect that is not supproted via nfs backends | |
| 11:02:08 | sean-k-mooney | so i would proably make the body somethign like (instance_uuid, volume_uuid, new_size) and perhapsp include the attachment_uuid if that is useful but proably not required | |
| 11:02:43 | kgube | hm, NetApp ONTAP seems to support multiattach | |
| 11:02:50 | sean-k-mooney | with that we can internally lookup the instance.host and make an rpc to the compute to do the reisze | |
| 11:02:59 | sean-k-mooney | kgube: i think that is likely only with iscsi | |
| 11:03:16 | sean-k-mooney | you could make it work i guess with nfs | |
| 11:03:35 | sean-k-mooney | but that will be much much harder to supprot extend with | |
| 11:03:44 | sean-k-mooney | as we have muliple QEMU processes using it | |
| 11:03:51 | kgube | yeah | |
| 11:04:12 | kgube | I think this will only work if the file is read-only | |
| 11:04:14 | sean-k-mooney | for iscis the volume resize is going ot happen on the netapp san | |
| 11:04:25 | kgube | but then we canT resize it anyway | |
| 11:04:54 | kgube | or, qemu won't rather | |
| 11:07:14 | sean-k-mooney | yep thats an edge case which prably should be called out and validated on the cinder sied | |
| 11:07:54 | sean-k-mooney | e.g. prevent multi attach volumes on nfs form either beign created or rezised while attached depending on what is more approcriate | |
| 11:11:12 | kgube | yeah, that is something cinder will have to do | |
| 11:19:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Follow up for the PCI in placement series https://review.opendev.org/c/openstack/nova/+/855185 | |
| 11:19:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Doc follow up for PCI in placement https://review.opendev.org/c/openstack/nova/+/855186 | |
| 12:23:56 | bauzas | reminder : nova meeting will happen today at 1600UTC here in this channel | |
| 12:24:10 | bauzas | gibi: sean-k-mooney: I can run the meeting back | |
| 12:29:25 | gibi | bauzas: you can have the meeting back :) | |
| 12:29:56 | bauzas | not sure if I should say \o/ or /.o\ | |
| 12:30:40 | Uggla | Hi bauzas, I hope you enjoy your vacation. | |
| 12:30:47 | bauzas | I did | |
| 12:31:10 | Uggla | Just to let you know that unfortunately I could not attend today's meeting. :( | |
| 12:31:17 | bauzas | np | |
| 12:31:23 | kashyap | Uggla: s/enjoy/enjoyed/? I thought he's going to have another vacation :-P | |
| 12:31:36 | kashyap | (Which is also fine, if he's up for it.) | |
| 12:31:49 | Uggla | *enjoyed thx kashyap | |
| 12:31:53 | bauzas | haha, can't wait for someone saying I'm on "perpetual PTO" | |
| 12:32:35 | bauzas | you know what was fun ? I was in a camp site for two weeks | |
| 12:32:45 | bauzas | first week, the site was telling in French | |
| 12:33:01 | bauzas | eventually, last week, we got like 70% of people that were German | |
| 12:33:30 | bauzas | as it was the last children vacations week in France, while some German lander still have 3 weeks | |
| 12:33:48 | bauzas | so, the campsite folks were telling in German | |
| 12:34:04 | bauzas | *in Corsica | |
| 12:34:43 | Uggla | I hope you had no pb with the storm in Corsica ? | |
| 12:36:25 | bauzas | none | |
| 12:36:37 | bauzas | I was on the East | |
| 12:38:06 | bauzas | when the storm arrived around Ajaccio, we just got a small storm, like just winding and a few raining for 10 mins | |
| 12:39:27 | bauzas | but the campsite asked us on the afternoon to make sure we could quickly move to a gym if needed on the next evening as a new storm was arriving | |
| 12:39:34 | bauzas | eventually, we didn't move | |
| 12:45:25 | Uggla | bauzas, good to know. I saw some impressive storm videos and thought about you hoping you were safe. | |
| 12:45:41 | bauzas | thanks | |
| 12:45:50 | bauzas | indeed this was impressive | |
| 12:45:58 | Uggla | clearly | |
| 12:46:15 | bauzas | I visited some small village in the mountains on the day the storm arrived | |
| 12:46:27 | bauzas | and yeah, they got problems with just the wind | |
| 12:46:31 | bauzas | 200km/h | |
| 12:46:45 | bauzas | fortunately, the mountain protected us | |
| 12:54:44 | kashyap | Yikes! | |
| 13:38:53 | ricolin | sean-k-mooney gibi stephenfin hey, can you give another review on https://review.opendev.org/c/openstack/nova/+/830646/ thanks | |
| 13:40:55 | sean-k-mooney | sure have you started reworking https://review.opendev.org/c/openstack/nova/+/844507/ | |
| 13:41:04 | sean-k-mooney | we likely will want ot merge both togehter | |
| 13:41:41 | sean-k-mooney | they proably shoudl be in the other order too | |
| 13:55:18 | stephenfin | ricolin: sure | |
| 14:05:12 | dansmith | whoami-rajat: are you working on gibi's comments? if not, I'll do it | |