| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-29 | |||
| 09:31:59 | sean-k-mooney | that version of it | |
| 09:32:09 | sean-k-mooney | the patch has been around for a few years | |
| 09:32:17 | sean-k-mooney | the orginal one is form 2018 | |
| 09:32:36 | sean-k-mooney | correct 2013 https://lkml.org/lkml/2013/5/30/513 | |
| 09:33:09 | sean-k-mooney | i honeestly dont know why this has not landed other then alex is busy with other things | |
| 09:33:17 | sean-k-mooney | it would be really really useful for vms | |
| 09:35:29 | songwenping | thanks, i will try to merge the patch. | |
| 09:36:03 | gibi | sean-k-mooney: I've reviewed the user_data and the rebuild bfv patches. I will go and dig into the func test part ofthe bfv patch now. | |
| 09:36:56 | gibi | sean-k-mooney, stephenfin: if you have cycles then the next 11 PCI patch is ready to land ;) | |
| 09:39:09 | opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/854979 | |
| 09:39:10 | opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/854980 | |
| 09:57:39 | admin1 | hi .. i am getting this error: nova-compute Connection to libvirt failed: authentication failed: authentication failed: libvirt.libvirtError: authentication failed: authentication failed and the compute node is unable to register itself .. i am using kolla-ansible yoga .. | |
| 10:14:08 | sean-k-mooney | they changed how they connect | |
| 10:14:29 | sean-k-mooney | that is really a question for the kolla channel since nova was not involved in this change | |
| 10:14:50 | sean-k-mooney | admin1: they enabled more authentication by default | |
| 10:15:42 | sean-k-mooney | admin1: you can tempoarly disable ths use of sasl authentication https://github.com/openstack/kolla-ansible/blob/master/doc/source/reference/compute/libvirt-guide.rst#sasl-authentication | |
| 10:17:01 | sean-k-mooney | noonedeadpunk: was i chating to you about ^ in the past | |
| 10:17:09 | sean-k-mooney | triging to rememebr who hit that before | |
| 10:18:47 | sean-k-mooney | noonedeadpunk: porably wrong user name then | |
| 10:19:13 | sean-k-mooney | im trying to think who works at blizzard | |
| 10:19:37 | opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/854979 | |
| 10:19:40 | noonedeadpunk | we never did sasl in osa, we use tls certs auth between computes for migrations | |
| 10:19:40 | sean-k-mooney | its been a month or two | |
| 10:19:43 | admin1 | maybe spatel :) | |
| 10:19:59 | sean-k-mooney | noonedeadpunk: tls is more secure for sure | |
| 10:20:00 | noonedeadpunk | afaik he's not from blizzard ) | |
| 10:20:13 | sean-k-mooney | spatel is not no | |
| 10:20:14 | admin1 | yeah | |
| 10:20:39 | sean-k-mooney | i could proably gerp my logs but admin1 that is likely your issue | |
| 10:20:42 | noonedeadpunk | btw talking about auth, it's sad that for offline migrations you still have to ensure SSH connection between computes :( | |
| 10:20:59 | sean-k-mooney | offline you mean cold | |
| 10:21:06 | noonedeadpunk | yeah, sorry, cold | |
| 10:21:26 | sean-k-mooney | ya for the disk copy and more importantly if you are using cpeh/bfv for the file system check | |
| 10:21:30 | noonedeadpunk | as for live migrations libvirt is jsut leveraged | |
| 10:21:34 | sean-k-mooney | that could be remvoed | |
| 10:22:47 | noonedeadpunk | can it? hm, I can recall I still had to ensure ssh even for ceph | |
| 10:22:53 | sean-k-mooney | but it need some changes to how we check for shared filesystem | |
| 10:23:38 | sean-k-mooney | we could replcase the ssh requirement with doign the check via an rpc | |
| 10:23:54 | sean-k-mooney | right now we ssh to the dest and toch a file | |
| 10:23:58 | noonedeadpunk | ah, ok, now I got what you meant | |
| 10:24:00 | sean-k-mooney | then check on the source if we can see it | |
| 10:24:08 | sean-k-mooney | but we could do that via an rpc | |
| 10:24:29 | noonedeadpunk | yeah, I thought the same, but ENOTIME as usual | |
| 10:25:42 | sean-k-mooney | for live migration we actully have the rpcs in place we woudl just do it avia the existing pre-migration rpcs | |
| 10:26:07 | sean-k-mooney | i dont know if we can do the same for cold migratoin today as i dont know if we have rpcs to the dest at the right times that we can extend | |
| 10:38:12 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 10:38:13 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 10:38:13 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 10:38:14 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 10:38:14 | opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 10:38:15 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 10:38:15 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 10:38:16 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 10:38:17 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 10:38:18 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_on_error notification https://review.opendev.org/c/openstack/nova/+/852084 | |
| 10:38:18 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_off_error notification https://review.opendev.org/c/openstack/nova/+/852278 | |
| 10:38:20 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 10:38:20 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 10:38:22 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 10:38:22 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 10:38:24 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 10:38:24 | opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.93 https://review.opendev.org/c/openstack/nova/+/852088 | |
| 10:53:27 | opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/854979 | |
| 10:53:28 | opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/854980 | |
| 10:54:53 | sean-k-mooney | gibi: did you fiture out why you could not do request_id=uuidutils.generate_uuid(dashed=True) | |
| 10:54:56 | sean-k-mooney | by the way | |
| 10:55:17 | sean-k-mooney | oh nevermind | |
| 10:55:20 | sean-k-mooney | yes we did | |
| 10:55:20 | gibi | yes I did and I already forgot it :) | |
| 10:55:36 | sean-k-mooney | i was the util function | |
| 10:55:42 | sean-k-mooney | you moved it to the object | |
| 10:56:41 | gibi | ahh yes | |
| 10:56:42 | gibi | true | |
| 10:56:55 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/853835/9 | |
| 10:57:09 | sean-k-mooney | i was just clenaing up the nova repo i had the DNM change checked out in | |
| 10:57:33 | sean-k-mooney | im going to start backporting the first vdpa patch | |
| 10:57:47 | sean-k-mooney | although i think i need to backport one of your patches first | |
| 10:58:09 | sean-k-mooney | the compute manger restart patch | |
| 10:59:20 | gibi | yeah on the libvirt tests fixture we overlap a bit | |
| 10:59:25 | gibi | hopefully not much | |
| 10:59:37 | sean-k-mooney | well im just using it for one test | |
| 10:59:41 | sean-k-mooney | the evacuate test | |
| 10:59:51 | sean-k-mooney | so i just need to backport it and then rebase on top | |
| 11:00:11 | sean-k-mooney | ah found it https://review.opendev.org/c/openstack/nova/+/850510 | |
| 11:00:44 | sean-k-mooney | ok so im going to try backporting that and then ill cherry pick my patch | |
| 11:05:03 | gibi | now I'm done with the func test part of the rebuild bfv as well. I found nothing serious so I think we can land the series this week | |
| 11:05:21 | gibi | next up is the manila series... | |
| 11:05:47 | gibi | but I need to get food first | |
| 11:05:50 | sean-k-mooney | has the userdata patch been updated | |
| 11:06:24 | sean-k-mooney | if that is not updated today we should change the order or perhaps one of us can adress the nits | |
| 11:06:51 | gibi | sean-k-mooney: it was updated during the weekend | |
| 11:07:12 | sean-k-mooney | ah ok ill review that when im done with this then | |
| 11:07:13 | gibi | there is some failing unit tests but the overal logic now looks good to me | |
| 11:11:28 | sean-k-mooney | api sample tests or generic unit tests | |
| 11:20:43 | sean-k-mooney | oh ... this might also need some of the double mockign seriese | |
| 11:32:58 | sean-k-mooney | :) | |
| 11:33:09 | stephenfin | sean-k-mooney: gibi: continuing it here, I think they need a PTL to ack the patch against openstack/release | |
| 11:33:11 | sean-k-mooney | stephenfin: are there any others i should look at or jsut nova client | |
| 11:33:22 | sean-k-mooney | stephenfin: no they dont | |
| 11:33:36 | stephenfin | I'd ask elodilles directly but he's on PTO | |