| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-25 | |||
| 16:57:24 | gibi | sean-k-mooney: re multi create: I think it works with PCI in placement. I had to fix how we generate the Selection objects as they were not aware of the fact the the scheduler already allocated some resources in placement. | |
| 16:58:12 | gibi | the re-used the same allocation request | |
| 16:58:22 | gibi | *the selection generation | |
| 16:59:35 | gibi | anyhow I think it works now | |
| 16:59:45 | gibi | so I'm happy :) | |
| 17:21:32 | sean-k-mooney | ok thats good news | |
| 17:23:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 17:23:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | |
| 17:43:59 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 17:44:00 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 17:44:00 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 17:44:01 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 17:44:01 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 17:44:02 | opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 17:44:02 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 17:44:03 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 17:44:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 17:44:04 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 17:44:06 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_on_error notification https://review.opendev.org/c/openstack/nova/+/852084 | |
| 17:44:06 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_off_error notification https://review.opendev.org/c/openstack/nova/+/852278 | |
| 17:44:08 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 17:44:08 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 17:44:10 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 17:44:10 | opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.93 https://review.opendev.org/c/openstack/nova/+/852088 | |
| 18:06:30 | opendevreview | Merged openstack/nova master: Trigger reschedule if PCI consumption fail on compute https://review.opendev.org/c/openstack/nova/+/853611 | |
| 22:33:24 | opendevreview | Merged openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 22:54:04 | opendevreview | Merged openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| #openstack-nova - 2022-08-26 | |||
| 04:42:59 | opendevreview | Merged openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 04:46:37 | opendevreview | Merged openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 04:51:14 | opendevreview | Merged openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 04:58:45 | opendevreview | Merged openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 04:58:52 | opendevreview | Merged openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 04:59:43 | opendevreview | Merged openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 05:01:39 | opendevreview | Merged openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 05:30:10 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | |
| 06:54:43 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | |
| 06:59:19 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | |
| 07:02:30 | gibi | good morning | |
| 07:02:56 | gibi | wow all the approved PCI patch merged. the gate is in a pretty good shape then | |
| 07:39:42 | Uggla | good morning | |
| 11:45:31 | sean-k-mooney1 | gibi: by the way you know how cursed the gate is going to be for the rest of the cycle ya | |
| 12:14:36 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | |
| 12:14:37 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 12:14:45 | gibi | I'm hopefule about the gate :) | |
| 12:15:43 | sean-k-mooney | i reviewed the bfv reuild patches today | |
| 12:16:08 | sean-k-mooney | the last 2 are mostly ok but the last one needs docs for the api change | |
| 12:16:22 | sean-k-mooney | the first needs some changes | |
| 12:16:37 | sean-k-mooney | is it intentional that we did not implemtne this for ironic? | |
| 12:16:41 | gibi | I reviewed a buncs of manila today | |
| 12:16:48 | gibi | bunch | |
| 12:17:28 | sean-k-mooney | which do you think makes sense for me to look at next manilla or encypted storage | |
| 12:17:37 | sean-k-mooney | i was going to look that encypted | |
| 12:21:12 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 12:21:12 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 12:21:13 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 12:21:13 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 12:21:14 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 12:21:14 | opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 12:21:15 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 12:21:16 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 12:21:16 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 12:21:18 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 12:21:18 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_on_error notification https://review.opendev.org/c/openstack/nova/+/852084 | |
| 12:21:20 | opendevreview | ribaudr proposed openstack/nova master: Add instance.power_off_error notification https://review.opendev.org/c/openstack/nova/+/852278 | |
| 12:21:20 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 12:21:22 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 12:21:22 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 12:21:24 | opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.93 https://review.opendev.org/c/openstack/nova/+/852088 | |
| 12:21:31 | gibi | sean-k-mooney: encrypted | |
| 12:21:57 | gibi | sean-k-mooney: I can check the bfv after I finish with the manila api patach | |
| 12:22:00 | sean-k-mooney | i kicked the first 4 that are remaining into the queue | |
| 12:22:02 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/826752 | |
| 12:22:19 | sean-k-mooney | is where melwitt is adding the encyption options which she has set -w on | |
| 12:22:33 | sean-k-mooney | ill review some of the later patches but that will need ot be updated | |
| 12:26:08 | gibi | sean-k-mooney: how do you feel about this https://review.opendev.org/c/openstack/nova/+/836830/10/nova/api/openstack/compute/server_shares.py#54 ? | |
| 12:26:27 | gibi | sean-k-mooney: nova-api tries to resolve the compute hostname to ip address | |
| 12:26:53 | sean-k-mooney | that sound incorrect | |
| 12:27:01 | gibi | yeah it feels strange | |
| 12:27:43 | sean-k-mooney | for one there might be multipel interfaces and the compute host might connect to the starge backend via a differnt interface the we use for our inter service managment trafffic | |
| 12:28:09 | sean-k-mooney | the api also may not be able to resolve the compute ip in an iolsated networkign config | |
| 12:28:31 | gibi | yes, also this socket call only works for ipv4 | |
| 12:28:49 | sean-k-mooney | yep so we shoudl not do this in the api and im not sure if we should do it in the comptue | |
| 12:29:06 | gibi | unfortunately manila only takes IP as per https://docs.openstack.org/api-ref/shared-file-system/?expanded=grant-access-detail#grant-access | |
| 12:29:07 | sean-k-mooney | what is this bieing used for | |
| 12:29:18 | gibi | it is to allow mounting the share to the compute | |
| 12:29:19 | sean-k-mooney | well we dont have to use that grant type | |
| 12:29:30 | sean-k-mooney | i was hoping to move to the cert one | |
| 12:29:50 | gibi | ahh I see | |
| 12:30:23 | sean-k-mooney | i think generating a tls cert for each share attachmetn woudl be the better approch longterm | |
| 12:31:58 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 12:32:01 | sean-k-mooney | so for now i guess if we are using ip we shoudl do this in the compute | |
| 12:32:03 | sean-k-mooney | not the api | |
| 12:32:17 | sean-k-mooney | although we might need a new config option | |
| 12:32:28 | sean-k-mooney | a share_access_network_ip | |
| 12:32:43 | sean-k-mooney | which we can default based on a lookup using the hypervioer_hostname | |
| 12:33:03 | sean-k-mooney | but for those that have need to have a seperate network for this they can overried it | |
| 12:33:12 | sean-k-mooney | like we do for the live migratieon inbound adress | |
| 12:33:22 | sean-k-mooney | gibi: Uggla ^ what do you think | |
| 12:33:25 | gibi | so define one IP per compute for manila shares | |
| 12:33:43 | gibi | that make sense | |