| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-24 | |||
| 11:05:59 | gibi | this is the delta https://review.opendev.org/c/openstack/nova/+/846435/19/doc/source/admin/pci-passthrough.rst#370 | |
| 11:06:34 | gibi | I probably need to mention the extra case in the doc about reconf | |
| 11:07:04 | gibi | ohh I did https://review.opendev.org/c/openstack/nova/+/852397/5/doc/source/admin/pci-passthrough.rst#407 | |
| 12:15:01 | gmann | gibi: dansmith_ : re on RBAC, I am +2 on dansmith_ patch https://review.opendev.org/c/openstack/nova/+/848021/2 | |
| 12:15:31 | gmann | but little confused with the error in my patch, https://review.opendev.org/c/openstack/nova/+/849209/4 | |
| 12:20:47 | opendevreview | Merged openstack/nova master: Add source dev parsing for vdpa interfaces https://review.opendev.org/c/openstack/nova/+/841016 | |
| 12:20:54 | opendevreview | Merged openstack/nova master: Fix suspend for non hostdev sriov ports https://review.opendev.org/c/openstack/nova/+/841017 | |
| 12:21:33 | sean-k-mooney | yay | |
| 12:22:00 | sean-k-mooney | stephenfin: when you have time could you review the last vdpa patch https://review.opendev.org/c/openstack/nova/+/853704/7 | |
| 13:06:17 | Uggla | sean-k-mooney, gibi is https://review.opendev.org/c/openstack/nova/+/854355 ok for you. Or you absolutely don't want to change NovaPersistentObject ? I think it is clearer in the way, but I don't mind changing if you think it is better. | |
| 13:06:39 | gibi | gmann: left a note about the test failure in https://review.opendev.org/c/openstack/nova/+/849209/4 | |
| 13:09:59 | gmann | gibi: that is what I am not getting why it is failing as there is no reference of PROJECT_ADMIN. locally all test passing | |
| 13:11:15 | gmann | PS3 passed successfully which was rebased with no change in that patch | |
| 13:12:18 | opendevreview | Ghanshyam proposed openstack/nova master: Remove system scope from all APIs https://review.opendev.org/c/openstack/nova/+/848021 | |
| 13:12:27 | opendevreview | Ghanshyam proposed openstack/nova master: Keep legacy admin behaviour in new RBAC https://review.opendev.org/c/openstack/nova/+/849209 | |
| 13:12:36 | gmann | rebasing on master, let's see | |
| 13:15:04 | gibi | Uggla: I made some notes in https://review.opendev.org/c/openstack/nova/+/854355 . I can accept the direction you are proposing. | |
| 13:16:23 | Uggla | gibi, thx I'm gonna look at the comments. | |
| 13:16:42 | gibi | gmann: that feels like some weird rebase issue then in zuul | |
| 13:17:09 | gmann | gibi: yeah seems so. it should pass now, let's see | |
| 13:17:33 | gibi | yeah we will see | |
| 13:47:49 | sean-k-mooney | Uggla: i have not done a full review but that is proably workable providere there is not api or db impact | |
| 13:48:32 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 13:48:33 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 13:48:33 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 13:50:27 | Uggla | sean-k-mooney, yep I just want the minimal change. Mostly to avoid next contributors "confusion" creating new objects. | |
| 14:58:21 | auniyal__ | Hi All | |
| 14:58:26 | auniyal__ | please review these | |
| 14:58:31 | auniyal__ | https://review.opendev.org/c/openstack/nova/+/852171 | |
| 14:59:23 | auniyal__ | https://review.opendev.org/c/openstack/nova/+/853811 | |
| 14:59:35 | auniyal__ | https://review.opendev.org/c/openstack/nova/+/853812 | |
| 16:33:29 | opendevreview | Ghanshyam proposed openstack/nova master: Keep legacy admin behaviour in new RBAC https://review.opendev.org/c/openstack/nova/+/849209 | |
| 16:35:21 | gibi | sean-k-mooney: am I correct that in nova there is no implemented preference between consuming a PF (for a direct-phyiscal port) that has VFs over consuming a PF that has no VFs? | |
| 16:38:06 | gibi | there is a single func test that assumes that we consume the PF without the VFs instead of the PF with VFs. But I think it was a simple coincidence that nova actually consumed that | |
| 16:39:04 | gibi | with the pools splitted the order of the pools changed and that test fails now. | |
| 16:39:29 | gibi | I will try to trick nova to change the order back... | |
| 16:47:59 | gmann | gibi: 849209 should pass now, actually unshelve_to_host policy merged in between and RBAC patches were not rebases to master. after rebasing to master the unshelve_to_host new policy shows up in gerrit display which needs to be corrected in RBAC changes. | |
| 16:48:07 | gmann | gibi: I fixed that and it in gate now | |
| 16:49:25 | gibi | gmann: ahh, true, that explains it. I always forget that zuul rebases a patch even in the check queue | |
| 16:49:55 | gmann | yeah | |
| 17:20:05 | gmann | gibi: dansmith: unit/functional test pass (means things are ok now) on RBAC patch, please review https://review.opendev.org/c/openstack/nova/+/849209 | |
| 17:20:23 | gmann | thanks sean-k-mooney for review, will check your query/feedback tomorrow | |
| 17:23:14 | gibi | dansmith: if you can look at ^^ that would be awesome as you probably have the context. Otherwise I can try to look at it tomorrow morning with fresh brain | |
| 17:23:43 | dansmith | gibi: I'm on my way to an appointment now.. so maybe later | |
| 17:23:53 | gibi | dansmith: ack | |
| 17:40:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 17:40:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize https://review.opendev.org/c/openstack/nova/+/852396 | |
| 17:40:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | |
| 17:40:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 17:40:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Generate request_id for Flavor based InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/853835 | |
| 17:40:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Create RequestGroups from InstancePCIRequests https://review.opendev.org/c/openstack/nova/+/852771 | |
| 17:40:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 17:40:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 17:40:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 17:40:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 17:40:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 17:40:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 17:40:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support move operations with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 17:40:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | |
| 17:40:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |
| 18:05:46 | sean-k-mooney | gmann: non of it needs to be adressed in those patches | |
| 18:06:10 | sean-k-mooney | gmann: just pointed out odd default we had like requiring admin to force shelve offload | |
| 18:06:32 | sean-k-mooney | those are just things we proably should fix next cycle. | |
| 18:06:55 | sean-k-mooney | gibi: correct | |
| 18:07:04 | sean-k-mooney | gibi: there is no prefernce but adding one woudl make sense | |
| 18:07:13 | sean-k-mooney | gibi: and could be done in a weigher now | |
| 18:07:19 | sean-k-mooney | if we have provider summeries | |
| 18:07:27 | sean-k-mooney | in addtion to the allcoation candiates | |
| 18:08:15 | sean-k-mooney | actuly that woont be allowed if tracked in placment | |
| 18:13:30 | sean-k-mooney | so ignore that | |
| 18:13:30 | sean-k-mooney | it woudl have been nice in the on placment world to prefer PFs without vfs but now we will only allow it to be listed either as a pf or the vfs | |
| 18:13:30 | sean-k-mooney | o/ talk to ye tomorrow | |
| 21:10:49 | opendevreview | Merged openstack/nova master: Remove system scope from all APIs https://review.opendev.org/c/openstack/nova/+/848021 | |
| 21:22:54 | opendevreview | Merged openstack/nova master: Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/853704 | |
| 23:37:48 | opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | |
| #openstack-nova - 2022-08-25 | |||
| 03:26:06 | opendevreview | wangjiaqi proposed openstack/os-vif master: remove unicode from code https://review.opendev.org/c/openstack/os-vif/+/854486 | |
| 03:31:50 | opendevreview | Ke Niu proposed openstack/os-vif master: remove unicode prefix from code https://review.opendev.org/c/openstack/os-vif/+/854488 | |
| 03:32:32 | opendevreview | Ke Niu proposed openstack/os-vif master: remove unicode prefix from code https://review.opendev.org/c/openstack/os-vif/+/854488 | |
| 05:18:16 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 05:18:17 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | |
| 05:44:54 | gmann | sean-k-mooney: ack | |
| 07:16:19 | gibi | good morning | |
| 07:25:33 | auniyal__ | Hi sean-k-mooney, gibi | |
| 07:25:43 | auniyal__ | can you please review these | |
| 07:25:45 | auniyal__ | https://review.opendev.org/c/openstack/nova/+/852171 | |
| 07:25:55 | auniyal__ | https://review.opendev.org/c/openstack/nova/+/853811 | |
| 07:26:04 | auniyal__ | https://review.opendev.org/c/openstack/nova/+/853812 | |
| 07:58:14 | gibi | auniyal__: sorry, I have to take these later due to the looming featur freeze deadline | |
| 07:58:52 | gibi | sean-k-mooney: I have to rebase the PCI series as I have a merge conflict in the middle. I will do this quickly but if you in the middle of the review then let me know to hold it | |
| 08:07:33 | auniyal__ | gibi, these 2 are already reviewed, need to backport - https://review.opendev.org/c/openstack/nova/+/853811, https://review.opendev.org/c/openstack/nova/+/853812 | |
| 08:08:07 | gibi | auniyal__: ack, I will try, but no promises :) | |
| 08:08:23 | auniyal__ | okay | |
| 08:09:54 | gibi | brace for impact | |
| 08:10:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1986838 https://review.opendev.org/c/openstack/nova/+/853516 | |
| 08:10:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Trigger reschedule if PCI consumption fail on compute https://review.opendev.org/c/openstack/nova/+/853611 | |
| 08:10:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 08:10:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 08:10:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 08:10:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 08:10:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |