| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-19 | |||
| 12:17:35 | sean-k-mooney | so the idea was +1 can be set by anyone and they will review | |
| 12:17:51 | sean-k-mooney | an that is an indication that cores can use to perhaps also review it | |
| 12:18:07 | sean-k-mooney | and +2 is a commitmnet form the core reivew to review this | |
| 12:18:41 | gibi | I think +1 is not well defined for cores | |
| 12:18:57 | gibi | so sean-k-mooney you are free to use to for a "maybe" | |
| 12:19:16 | sean-k-mooney | sylvain wanted to use +1 as a way for non cores to singal to cores that something might be ready for review too | |
| 12:19:20 | sean-k-mooney | the text in my orgially patch was +1 is core review requested and +2 is core review approved but that was also problematic | |
| 12:19:44 | gibi | I think +1 for non-cores is the same as +2 for cores | |
| 12:19:50 | gibi | both is a promise | |
| 12:19:54 | sean-k-mooney | yep | |
| 12:20:03 | gibi | that I, who set it, will review the patch | |
| 12:20:14 | sean-k-mooney | im using +1 as im going to review this but not nessiarly ping other to review it | |
| 12:20:35 | sean-k-mooney | vs +2 ill review it and when im going to give my +2 ill ping others to review it too | |
| 12:20:59 | gibi | that is OK to me | |
| 12:21:03 | sean-k-mooney | i.e. i not only commit to reviewing but i also care about this not waiting for every | |
| 12:21:33 | sean-k-mooney | kindo fo like feature-liason lite | |
| 12:21:38 | gibi | stephenfin: I needed the small step in the PCI work for myself too to see what is missing :) The inventory part is self contained mostly in the new translator. The scheduling part will be less easy to read (once I write it :D) | |
| 12:21:53 | gibi | sean-k-mooney: that make sense | |
| 12:24:17 | stephenfin | gibi: I got as far as https://review.opendev.org/c/openstack/nova/+/851358 +2 on everything I think | |
| 12:24:53 | gibi | stephenfin: thank you, have a good one | |
| 12:27:39 | sean-k-mooney | my plan for there rest of the day is finish the vdpa seriese, review the pci serise and if melwitt has updated the encyption series review that. my plan for next week assuming vdpa is done is 100% upstream review so please ping as needed | |
| 12:29:20 | gibi | sean-k-mooney: ack. I will do another vdpa round today if needed | |
| 12:30:31 | gibi | stephenfin: thanks for noticing the TODO in https://review.opendev.org/c/openstack/nova/+/851358 I forgot it. Actually the patches above that are also ready until https://review.opendev.org/c/openstack/nova/+/850468 | |
| 12:31:05 | opendevreview | Amit Uniyal proposed openstack/nova stable/wallaby: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/853811 | |
| 12:31:06 | opendevreview | Amit Uniyal proposed openstack/nova stable/wallaby: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/853812 | |
| 12:31:06 | gibi | but it is more than fair to stop there now | |
| 12:32:58 | stephenfin | ack, I'll keep going with it this afternoon so. If you could cobble together a follow-up I can finish that | |
| 12:38:58 | gibi | stephenfin: I will hold off with the follow up until sean-k-mooney reviews it | |
| 12:42:10 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check for VM snapshot fail while quiesce https://review.opendev.org/c/openstack/nova/+/852171 | |
| 13:38:37 | opendevreview | Merged openstack/nova master: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853265 | |
| 14:54:50 | JayF | Good morning; thanks for the reviews I've already been getting. I do have a couple of other PRs open in Gerrit I'd appreciate reviews on that are ready to go: https://review.opendev.org/c/openstack/nova/+/853529 and https://review.opendev.org/c/openstack/nova/+/853540 - thanks in advance. | |
| 14:58:12 | opendevreview | Merged openstack/nova stable/wallaby: Ignore plug_vifs on the ironic driver https://review.opendev.org/c/openstack/nova/+/821349 | |
| 14:59:21 | opendevreview | Jay Faulkner proposed openstack/nova stable/ussuri: Ignore plug_vifs on the ironic driver https://review.opendev.org/c/openstack/nova/+/821351 | |
| 14:59:58 | JayF | I need to re-learn my alphabet, apparently. Rebased the wrong one lol | |
| 15:00:03 | opendevreview | Jay Faulkner proposed openstack/nova stable/victoria: Ignore plug_vifs on the ironic driver https://review.opendev.org/c/openstack/nova/+/821350 | |
| 15:34:33 | opendevreview | Merged openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | |
| 15:40:23 | gibi | 2022-08-19 17:35:22,086 DEBUG [nova.pci.stats] Dropped 1 device(s) as they are on the wrong NUMA node(s) | |
| 15:40:26 | gibi | 2022-08-19 17:35:22,086 DEBUG [nova.pci.stats] Dropped 1 device(s) that are not part of the placement allocation | |
| 15:40:29 | gibi | 2022-08-19 17:35:22,086 DEBUG [nova.pci.stats] Not enough PCI devices left to satisfy request | |
| 15:40:47 | gibi | ... and the NUMATopologyFilter now works with placement allocation candidates \o/ | |
| 15:40:53 | sean-k-mooney | nice | |
| 15:41:36 | gibi | there are some raw edges but the general idea seems to work | |
| 15:42:07 | gibi | now I have like 10 WIP commits locally to clean up :D | |
| 15:42:10 | sean-k-mooney | ack im sure we can flesh that out via review and or cleanups | |
| 16:23:38 | opendevreview | Merged openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | |
| 17:50:00 | opendevreview | melanie witt proposed openstack/nova master: Follow up changes for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/853254 | |
| 18:23:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: why I cannot set request_id on InstancePCIRequiest https://review.opendev.org/c/openstack/nova/+/853835 | |
| 18:24:26 | gibi | sean-k-mooney: if you are still around ^^ I totally don't get this | |
| 18:30:54 | sean-k-mooney | i dont think you want to set request_id you want to set requester_id | |
| 18:31:31 | sean-k-mooney | ill take a look quickly but we set this in teh neutorn module somewhere i think | |
| 18:33:12 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance_pci_requests.py#L43-L44 | |
| 18:33:22 | sean-k-mooney | but actully it depens on what you want to track ther | |
| 18:33:47 | sean-k-mooney | are you tryign to add the placment request group or resouce provider there | |
| 18:33:55 | gibi | I need a unique id | |
| 18:34:07 | sean-k-mooney | well the request_id should be unique | |
| 18:34:22 | gibi | for neutron based InstancePCIRequests we generate a uuid for request_id | |
| 18:34:31 | gibi | I try to do the same for the flavor based requests | |
| 18:34:41 | sean-k-mooney | yes and we set requester_id to the neutorn port uuid | |
| 18:34:48 | sean-k-mooney | ah ok | |
| 18:35:04 | sean-k-mooney | am that should be posible | |
| 18:35:53 | sean-k-mooney | what error do you get | |
| 18:35:54 | gibi | https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2390 | |
| 18:36:19 | gibi | the test fails as the domain has no PCI device | |
| 18:36:33 | sean-k-mooney | i would guess this is a bug in our fixture | |
| 18:36:48 | gibi | https://paste.opendev.org/show/bK1kbEypC2EUHXtL2ruT/ | |
| 18:36:53 | sean-k-mooney | let me grab that patch and run it locally | |
| 18:37:30 | gibi | anyhow my brain is toasted and my wife just arrived so I have to log off. don't think too much about this issue it is late friday anyhow | |
| 18:37:44 | gibi | see you all on Monday | |
| 18:37:49 | sean-k-mooney | ok | |
| 18:37:54 | sean-k-mooney | im going to call it a day too | |
| 18:38:06 | gibi | have a nice weekend | |
| 18:38:36 | sean-k-mooney | you too ill try and look at this on monday after i rebase the vdpa patches | |
| 18:58:22 | opendevreview | Dan Smith proposed openstack/nova-specs master: WIP: Robustify Compute Node Hostnames https://review.opendev.org/c/openstack/nova-specs/+/853837 | |
| 18:58:36 | dansmith | sean-k-mooney: artom: ^ | |
| 18:59:08 | dansmith | that's a big chunk of work, which we may never do, but I thought it was probably good to document some of the things we could/should do to make this better | |
| 18:59:23 | dansmith | either to point to and say "see, too big, never going to happen" or the opposite | |
| 18:59:49 | dansmith | I've been thinking about the first work item for a long time and I think we should probably do that for safety even if we don't do any of the rest of it | |
| 19:02:33 | artom | That's kind of in the same vein as https://bugzilla.redhat.com/show_bug.cgi?id=1965419, which came up before when another customer renamed their hosts | |
| 19:02:44 | artom | Now that I think about it, it may have been that exact same KCS | |
| 19:02:51 | artom | Because it was a 10 -> 13 FFU | |
| 19:02:58 | artom | Sorry, leaking downstream here | |
| 19:04:21 | sean-k-mooney | i mean we were broken in 16.1 requirenign neutron ot add a new config option | |
| 19:04:23 | sean-k-mooney | https://bugzilla.redhat.com/show_bug.cgi?id=1900500 | |
| 19:04:51 | sean-k-mooney | resource_provider_default_hypervisor | |
| 19:06:27 | sean-k-mooney | https://github.com/openstack/neutron/commit/577217c52d677ba35ca78b87c06302d506f66ff9 and https://github.com/openstack/neutron/commit/ddf0fef28b7095724c8ba27f3275d0dad2252251 | |
| 19:06:45 | sean-k-mooney | were added to neutorn to work aorund changes in ooo | |
| 19:30:15 | opendevreview | Dan Smith proposed openstack/nova-specs master: WIP: Robustify Compute Node Hostnames https://review.opendev.org/c/openstack/nova-specs/+/853837 | |
| #openstack-nova - 2022-08-20 | |||
| 06:18:38 | opendevreview | Takashi Natsume proposed openstack/nova master: Add missing descriptions in HACKING.rst https://review.opendev.org/c/openstack/nova/+/853054 | |
| 06:18:59 | opendevreview | Takashi Natsume proposed openstack/nova master: doc: Update a PTL guide https://review.opendev.org/c/openstack/nova/+/852275 | |
| 06:35:52 | opendevreview | Merged openstack/nova stable/train: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/c/openstack/nova/+/751367 | |
| 09:06:23 | opendevreview | Merged openstack/nova master: doc: Update a PTL guide https://review.opendev.org/c/openstack/nova/+/852275 | |
| 15:37:55 | opendevreview | Merged openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | |
| 21:21:04 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 21:21:05 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 21:21:05 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| #openstack-nova - 2022-08-21 | |||
| 06:06:07 | opendevreview | Takashi Natsume proposed openstack/nova master: Fix a deprecation warning about threading.Thread https://review.opendev.org/c/openstack/nova/+/853869 | |
| #openstack-nova - 2022-08-22 | |||
| 03:10:32 | opendevreview | zhangqing proposed openstack/nova stable/train: remove redundant statement in SecurityGroupDefaultRulesController https://review.opendev.org/c/openstack/nova/+/853901 | |
| 03:11:24 | opendevreview | zhangqing proposed openstack/nova stable/train: remove redundant statement https://review.opendev.org/c/openstack/nova/+/853901 | |
| 07:29:58 | Uggla | Hello o/ | |
| 07:37:57 | gibi | Uggla: welcome back | |