| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-17 | |||
| 17:23:57 | sean-k-mooney | is incase the host is eliminated by another filter | |
| 17:24:18 | sean-k-mooney | we want to make sure the host state object has the correct data | |
| 17:24:40 | sean-k-mooney | but we can do that by doing a deep copy of the pci stats in the filter | |
| 17:25:02 | sean-k-mooney | there are other ways around that too | |
| 17:25:21 | sean-k-mooney | this comes back to correct behavior for muticreate/server groups | |
| 17:25:57 | sean-k-mooney | i would proably try just calling consume and see if that breaks any of our tests | |
| 17:26:10 | sean-k-mooney | then we might eb able to remove the call to apply | |
| 17:26:13 | sean-k-mooney | in the host manager | |
| 17:26:16 | gibi | yepp | |
| 17:26:20 | gibi | that make sense | |
| 17:40:11 | spatel | can i set hard limit in nova to create number of vm instance? | |
| 18:15:00 | JayF | So, trying to figure out why gate jobs keep failing on my change. They are seemingly random, and I noticed something strange in zuul status: https://home.jvf.cc/~jay/gated-after-master-change.png | |
| 18:15:18 | JayF | 826523,5 is a change landing into master AFAICT | |
| 18:15:28 | JayF | but is in the same merge queue as my change to stable/yoga (800873,2) | |
| 18:16:05 | JayF | s/yoga/victoria/ | |
| 18:17:33 | sean-k-mooney | they might be intermiten failure yes | |
| 18:17:52 | JayF | Well, I'm just saying I'm surprised that stable/ patches and master patches are gate-queued together | |
| 18:18:11 | sean-k-mooney | oh they should not be unless its tempest | |
| 18:18:23 | JayF | that's what my png ^^^ shows | |
| 18:18:34 | JayF | is that it seems to have done exactly that | |
| 18:18:52 | sean-k-mooney | do you have the link to the backprot | |
| 18:18:55 | JayF | oooh, or do the separate lines indicate "nope, this is in a separate queue" | |
| 18:19:06 | JayF | https://review.opendev.org/c/openstack/nova/+/800873 same as yesterday | |
| 18:19:09 | JayF | trying to get it to actually land | |
| 18:19:23 | sean-k-mooney | the seperate lines are seperate sets of patches that are in flight | |
| 18:19:37 | sean-k-mooney | so those cidner changes are sperate form the nova one | |
| 18:19:54 | JayF | got it, this is just me learning for the first time after looking at this UI for an embarassingly long time | |
| 18:19:59 | JayF | that the lines on the left have meaning | |
| 18:20:02 | JayF | lol | |
| 18:20:05 | JayF | thank you for the clarity :D | |
| 18:20:30 | sean-k-mooney | there is somethign wrong here | |
| 18:20:50 | sean-k-mooney | well hum im not sure | |
| 18:20:58 | sean-k-mooney | 800873,2 is a master patch | |
| 18:21:10 | sean-k-mooney | but i dont think it depends on the 826523,5 | |
| 18:21:18 | JayF | https://review.opendev.org/c/openstack/nova/+/800873 that's not true | |
| 18:21:20 | sean-k-mooney | i think the patch it was specultivly merged with has already merged | |
| 18:21:37 | JayF | this says repo | branch: openstack/nova | stable/victoria | |
| 18:21:48 | sean-k-mooney | on that yes | |
| 18:21:53 | sean-k-mooney | but not on https://review.opendev.org/c/openstack/nova/+/826523/ | |
| 18:21:58 | JayF | that is 800873,2 | |
| 18:22:06 | sean-k-mooney | that is the second nova patch with the x | |
| 18:22:28 | sean-k-mooney | so the integrate queue currently has 3 sets of changes in flight i think | |
| 18:22:43 | sean-k-mooney | 826523,5 which is your one that depends on nothing | |
| 18:22:59 | sean-k-mooney | 800873,2 that depend on a change that has laready merged | |
| 18:23:11 | sean-k-mooney | and then the swich/cinder ones | |
| 18:23:16 | sean-k-mooney | which are a third set | |
| 18:23:23 | JayF | yeah; I think I misread the queue docs | |
| 18:23:36 | JayF | the behavior seems sane to me now that I understand what the UI was tryin' to tell me | |
| 18:24:03 | sean-k-mooney | the ui is not super clear | |
| 18:24:42 | sean-k-mooney | on the pluse side the backport is still green | |
| 18:24:58 | sean-k-mooney | so hopefully it will have mergedin the next half hour or so | |
| 18:25:01 | JayF | no, the backport is the one that is X I thought | |
| 18:25:20 | sean-k-mooney | oh you are right | |
| 18:25:29 | JayF | yeah nova-live-migration failed again :| | |
| 18:25:30 | sean-k-mooney | failed on nova live migration | |
| 18:25:57 | sean-k-mooney | ah | |
| 18:26:00 | JayF | I wish I could tell Zuul "trust me, Ironic driver can't break this" :| | |
| 18:26:02 | sean-k-mooney | test_live_block_migration_with_attached_volume | |
| 18:26:15 | sean-k-mooney | well actullly this came up in the past | |
| 18:26:29 | sean-k-mooney | we could skip the live migration job if its an ironic only change | |
| 18:26:55 | JayF | I mean, that seems sane-ish to me, but maybe a lot of effort for a branch where this is likely literally one of the only ironic driver things to hit | |
| 18:27:09 | sean-k-mooney | we can add nova/virt/ironic and nova/tests/unit/virt/ironic | |
| 18:27:13 | sean-k-mooney | to the irrelevent files list | |
| 18:27:35 | sean-k-mooney | well im sure you woudl not mind having it on master and it shoudl be simple to backport | |
| 18:27:39 | JayF | you want to tell me where that change goes? If so I'll post it, and you can keep your +2 :D | |
| 18:28:01 | JayF | I took just long enough of a break from OpenStack to not really grok the new zuul configs very well | |
| 18:28:06 | sean-k-mooney | https://github.com/openstack/nova/blob/master/.zuul.yaml#L92-L106 | |
| 18:28:24 | JayF | incoming | |
| 18:29:04 | sean-k-mooney | unfortuetly that is used as the defintio of nova-base-irrelevant-files | |
| 18:29:18 | sean-k-mooney | that is sginifed by the & | |
| 18:29:32 | sean-k-mooney | so you will need to copy tha tsection to https://github.com/openstack/nova/blob/master/.zuul.yaml#L131 | |
| 18:29:43 | sean-k-mooney | then in the current one for the migration update it it | |
| 18:29:48 | JayF | got it | |
| 18:29:55 | JayF | yaml anchors are awesome and terrible :D | |
| 18:30:33 | sean-k-mooney | ok im going to go figure out dinner ill check back in a while but feel free to add me to the review and/or ping me here | |
| 18:30:58 | sean-k-mooney | in the mean time youcan likelly just recheck once the gate change fails | |
| 18:31:30 | sean-k-mooney | with a message plaease :) "recheck ironic does not support live migration" or similar | |
| 18:32:11 | sean-k-mooney | we have an issue with volume detach intermitently failing and i think that is what you are hitting | |
| 18:32:59 | opendevreview | Jay Faulkner proposed openstack/nova master: nova-live-migration tests not needed for Ironic https://review.opendev.org/c/openstack/nova/+/853529 | |
| 18:33:12 | JayF | sean-k-mooney: ^ | |
| 18:33:23 | JayF | Thanks sean :) | |
| 18:34:25 | sean-k-mooney | ok that looks ok i think | |
| 18:34:43 | sean-k-mooney | test only changes and releasenote only change are already skipped | |
| 18:34:50 | sean-k-mooney | so just the ironic virt driver | |
| 18:34:52 | JayF | That's why I didn't add the tests line, yep | |
| 18:35:13 | JayF | I know how the stanzas for zuul config work, I just can't ever find the #@%$# configs anymore lol | |
| 18:36:10 | sean-k-mooney | you can technially go form teh zuul ui to the job definition mostly at least to the repo where there defiend | |
| 18:36:26 | sean-k-mooney | i normally fall back on https://codesearch.opendev.org/ if i cant find it quickly | |
| 18:36:45 | sean-k-mooney | anyway chat to you tomorrow o/ | |
| 20:27:19 | opendevreview | Merged openstack/nova stable/victoria: [ironic] Minimize window for a resource provider to be lost https://review.opendev.org/c/openstack/nova/+/800873 | |
| 20:27:42 | JayF | \o/ | |
| 20:30:32 | opendevreview | Jay Faulkner proposed openstack/nova stable/ussuri: [ironic] Minimize window for a resource provider to be lost https://review.opendev.org/c/openstack/nova/+/853540 | |
| 21:19:03 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 21:19:04 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 21:19:04 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 21:20:39 | ricolin | gibi: was asking about the necessary of raise exception for locked memory, but I guess the right behavior should be raise it. just update the patch accordingly. thanks for your review, please help to review again. ^^^ | |
| 22:04:15 | opendevreview | Jay Faulkner proposed openstack/nova stable/train: [ironic] Minimize window for a resource provider to be lost https://review.opendev.org/c/openstack/nova/+/853546 | |
| 22:05:56 | JayF | Train is as far back as you all go, right? | |
| 22:23:36 | sean-k-mooney[m] | i think we still might have older branches but i think we have gate issues beyond train | |
| 22:24:18 | sean-k-mooney[m] | we still have stable queens branches | |