| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-04 | |||
| 11:36:58 | sean-k-mooney[m] | that is done seperatly | |
| 11:39:23 | gibi | I agree that we should not use the sysfs and user the libvirt driver instead | |
| 11:39:47 | gibi | right now I cannot precisely answer why we look up the type during the whitelist parsing | |
| 11:39:54 | sean-k-mooney[m] | well rather the objects returned by the virt driver genericlly | |
| 11:40:06 | gibi | but I have many theorethical issues with that code | |
| 11:40:36 | gibi | +1 on an abstraction over the libvirt virt driver | |
| 11:40:38 | sean-k-mooney[m] | its proably used to supprot the feature where if we whitelist the pf addres with vf product id | |
| 11:40:41 | sean-k-mooney[m] | we allow the VFs | |
| 11:40:51 | gibi | that could be one reason yes | |
| 11:40:56 | sean-k-mooney[m] | well you should not be calling the driver | |
| 11:41:08 | gibi | it is a very convoluted code | |
| 11:41:10 | sean-k-mooney[m] | the whitelist is used to fileter the objects returned by the driver | |
| 11:41:24 | sean-k-mooney[m] | by objects i mean the dicts | |
| 11:41:37 | sean-k-mooney[m] | so the dict already has the type set | |
| 11:41:54 | sean-k-mooney[m] | so we shoudl just be able to look at the type in the dict | |
| 11:43:17 | gibi | yes, that would be nice | |
| 11:43:57 | gibi | it could be a natural continuation of the https://review.opendev.org/q/topic:pci-device-spec-cleanup series | |
| 11:44:24 | sean-k-mooney[m] | yes | |
| 11:44:38 | sean-k-mooney[m] | escpically since the sysfs way only works on linux anyway | |
| 11:44:57 | sean-k-mooney[m] | it does ont work for other virt drivers where as the dict approch would | |
| 11:45:01 | gibi | yes, I also want to remove the sysfs deps from the code | |
| 11:45:21 | sean-k-mooney[m] | we cant remove all of them unforcunetly | |
| 11:45:29 | gibi | true, so limit them :) | |
| 11:45:37 | sean-k-mooney[m] | since we cant trust libvirt because of its caching in some cases | |
| 11:46:05 | gibi | yeah I saw what you and bauzas_away found about the mdev cache in libvirt | |
| 11:46:11 | sean-k-mooney[m] | the sysfs part might be able to move to a libvirt dirver util file or somehting | |
| 11:46:23 | sean-k-mooney[m] | well its not just that | |
| 11:46:39 | gibi | yepp, currently even the nova/network/neutron code is depend on sysfs too | |
| 11:46:40 | sean-k-mooney[m] | i fixed a similar caching issue where libvirt would miss mac adress changes | |
| 11:49:04 | gibi | probably in general if we change something via sysfs and not via libvirt then libvirt will have a stale cache | |
| 11:49:23 | gibi | which is sort of understandable | |
| 11:49:28 | kashyap | Yeah | |
| 11:50:08 | gibi | wondering if neutron also manipulate the host via sysfs or ethtool | |
| 11:50:20 | gibi | as there they have no libvirt interface at all | |
| 11:50:45 | sean-k-mooney[m] | in general if we could disable the caching in libvirt entirly i think we would | |
| 11:51:12 | sean-k-mooney[m] | i have serriously considered if we would be better not using libvirt for device tracking a few times | |
| 11:51:52 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/739131 | |
| 11:52:02 | sean-k-mooney[m] | that was the change i was thinkin of | |
| 11:52:05 | gibi | yeah, or creating a way to force libvirt to refresh the cache | |
| 11:52:36 | sean-k-mooney[m] | bind mount it to /dev/null on. disk ? | |
| 11:53:13 | gibi | is it an on disk cache? | |
| 11:53:19 | gibi | I assumed it is just in memory | |
| 11:53:28 | sean-k-mooney[m] | i think both | |
| 11:53:46 | sean-k-mooney[m] | its in memory in the vritnodedevd container | |
| 11:54:02 | sean-k-mooney[m] | but i think it also caches some info on disk | |
| 11:54:16 | sean-k-mooney[m] | i wonder can you just not use that container/deamon | |
| 11:54:19 | sean-k-mooney[m] | and run without it | |
| 11:54:26 | sean-k-mooney[m] | i should ask danpb | |
| 11:55:07 | sean-k-mooney[m] | i assume that wont actully work | |
| 11:55:21 | sean-k-mooney[m] | that deamon is more then just a cache | |
| 11:57:47 | gibi | I assume so | |
| 11:59:52 | sean-k-mooney[m] | what we really. want i think is to add a flag to https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices to force it to probe | |
| 12:00:28 | gibi | yepp, that would help | |
| 12:00:36 | gibi | we would just alway set that flag | |
| 12:06:46 | opendevreview | Rajesh Tailor proposed openstack/nova master: Transport context to all threads https://review.opendev.org/c/openstack/nova/+/827467 | |
| 12:16:41 | gibi | sean-k-mooney[m]: when you have 2 minutes, could you look at this please? https://review.opendev.org/c/openstack/nova/+/845922 I got hit by it recently | |
| 12:17:10 | sean-k-mooney[m] | sure im just working on a doc for a meeting tomrrow | |
| 12:17:40 | sean-k-mooney[m] | hum im not familar with this bug but sure sound strait forward | |
| 12:18:08 | gibi | it happens on slow nodes | |
| 12:19:24 | sean-k-mooney[m] | 1.23 :) | |
| 12:19:43 | sean-k-mooney[m] | i would have also accepted a 42, 420 or 69 | |
| 12:20:17 | sean-k-mooney[m] | have you ever looked at our ping message in the rpc client. that one is my favorite | |
| 12:22:36 | gibi | lol, now I looked :D | |
| 12:30:14 | sean-k-mooney[m] | oh its the conductor ping not base api https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/conductor/api.py#L67 | |
| 12:30:52 | sean-k-mooney[m] | but ya that makes me happy whenever i see it | |
| 12:33:38 | gibi | :) | |
| 13:00:20 | gibi | ...brace for impact | |
| 13:00:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 13:00:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 13:00:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 13:00:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 13:00:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 13:00:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 13:00:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 13:00:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 13:00:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 13:00:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 13:00:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 13:00:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 13:00:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 13:00:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 13:00:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 13:00:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 13:00:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 13:01:17 | gibi | this should resolve all the mocking issues from ^^ | |
| 13:06:37 | Uggla | gibi, notify_about_instance_usage is a "legacy call" to notification and should not be used anymore ? | |
| 13:07:19 | gibi | Uggla: if you add a new notification for attaching a share then yes you should not use the legacy one | |
| 13:08:37 | Uggla | ok | |
| 13:11:20 | gibi | we even have a test case that would prevent you to introduce a new legacy notification :) | |
| 13:32:29 | opendevreview | Bence Romsics proposed openstack/nova master: Add limitation to docs about bug 1983570 https://review.opendev.org/c/openstack/nova/+/852168 | |
| 13:45:03 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check for VM snapshot fail while quiesce https://review.opendev.org/c/openstack/nova/+/852171 | |
| 13:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 13:56:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626 | |
| 13:56:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 13:56:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 13:56:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 13:56:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types https://review.opendev.org/c/openstack/nova/+/845765 | |
| 13:57:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname https://review.opendev.org/c/openstack/nova/+/845775 | |
| 13:57:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class https://review.opendev.org/c/openstack/nova/+/845780 | |
| 13:57:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class https://review.opendev.org/c/openstack/nova/+/845781 | |