Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-08-02
13:51:26 gibi It was added there on purpose as far as I see
13:51:51 artom Yeah, it was so that we roll back the stuff claimed on the destination
13:51:54 dansmith it's something in driver.destroy() that looks to see if there's a migration context, and does more/less stuff during destroy as a result right?
13:52:19 artom Actually, maybe not, ignore me until I look at the code again
13:52:53 dansmith as noted, I think that was probably the first bad move
13:53:06 dansmith the "temporarily mutate instance so I don't have to change code elsewhere"
13:53:23 dansmith ended up having a side-effect that we didn't expect, so more flags to prevent side effects is just compounding the problem :)
13:55:00 gibi dansmith: I agree with general idea not to add more flags. So lets see if we can figure out how to untangle what we have
13:55:07 dansmith ++
13:58:12 gibi dansmith: if we are already at the problem the follow up patch https://review.opendev.org/c/openstack/nova/+/850746/3 show another occurence of the save under mutated migration context codepath.
13:58:21 gibi we call driver.rebuild https://review.opendev.org/c/openstack/nova/+/850746/3 under a mutated context
13:58:24 kashyap gibi: Hey, is there some "openstack server show" command to see the machine type configured on the compute node? Or 'grep'ing the nova.conf / `sudo virsh dumpxml $instance` the only way?
13:58:59 dansmith gibi: I have to jump on a call, might have a few minutes after before the next one at the top of the next hour
13:59:01 gibi and ironic virt driver saves the instance https://review.opendev.org/c/openstack/nova/+/850746/3
13:59:01 bauzas kashyap: you would need to be an admin at least if so
13:59:09 gibi dansmith: ack
13:59:15 gibi dansmith: no worries
13:59:19 kashyap bauzas: Right, let's say admin. Is there an admin Nova command?
13:59:31 bauzas this is a conf opt
13:59:43 bauzas so this shouldn't be an API extension
14:00:21 bauzas in general, we don't want to provide an API for knowing about some config option
14:00:56 kashyap bauzas: Right; fair enough
14:01:49 kashyap bauzas: Note, this is also a metadata and extra_spec property as well
14:01:57 kashyap "this" == guest machine type
14:03:47 kashyap bauzas: So if a user configures a Glance image with that image meta property, they should be able to see
14:05:38 kashyap bauzas: So, `openstack image show` should show it if a user sets it
14:06:33 gibi dansmith: so if you have a minute at some point I summarized my second question here https://review.opendev.org/c/openstack/nova/+/850746/3/nova/compute/manager.py#3797
14:06:52 opendevreview Elod Illes proposed openstack/nova stable/train: DNM: test preinstall of python3-yaml https://review.opendev.org/c/openstack/nova/+/851861
14:08:53 gibi kashyap: while I understand the need to see what machine type an instance uses, I don't think we have a single place we persist it for the insance. I guess we rely on the fact that we can always regenerate the machine type from the flavor + image + compute config.
14:09:28 kashyap gibi: Great answer; that's exactly what I'm writing for a (downstream) docs question
14:09:48 kashyap It is set via 3 places as you indicate - per-compute host config; flavor extra spec; or an image metada prop
14:09:53 kashyap s/metada/metadata/
14:16:55 kashyap gibi: Oh, wait - do we actually support this hw:machine_type" via flavor extra_spec?
14:21:38 gibi kashyap: I dont see machine_type in https://docs.openstack.org/nova/latest/configuration/extra-specs.html
14:21:55 kashyap gibi: Yeah, me neither: so only two ways - compute config; or image meta
14:22:52 kashyap gibi: For image, a tenant user should be able to see it via `openstack image show`, right?
14:23:05 gibi I think so
14:25:18 gibi kashyap: one thing i see is that nova stores the image meta in instance.system_metadata['image_hw_machine_type'] so that even if the image is changed later the instance has its machine type persisted
14:25:59 kashyap Yeah, we do store it in system_metadata (Lee did that work)
14:26:07 gibi also if an admin want to query the machine_type of an instance then it can be done via nova-manage
14:26:08 kashyap https://docs.openstack.org/nova/latest/admin/hw-machine-type.html
14:26:29 gibi ack, that is the one
14:26:30 kashyap gibi: What about the tenant user? (Perhaps via `openstack image show`?
14:27:10 gibi openstack image show only valid the the image properties are not changed after the instance is booted (I'm not sure the image meta could change)
14:27:27 bauzas oh the q35 saga
14:27:31 bauzas forgot about it
14:27:41 bauzas hence the nova-manage command
14:27:59 bauzas actually, 4 given I reply
14:28:02 kashyap gibi: Oh, right: "nova-manage image_property show $instance_uuid $property"
14:28:28 kashyap --^ The above is for tenant too, right?
14:29:18 kashyap So, it'd be: `nova-manage image_property show $instance_uuid hw_machine_type`
14:31:16 gibi the tenant does not have access to nova-manage
14:31:23 gibi that is an admin tool
14:31:26 gibi afaik
14:31:33 kashyap Yes, you're right
14:39:59 opendevreview Stanislav Dmitriev proposed openstack/nova master: Add support for sync writes with block migration https://review.opendev.org/c/openstack/nova/+/851892
14:43:32 opendevreview Merged openstack/placement master: doc: Comment out language option https://review.opendev.org/c/openstack/placement/+/844855
15:00:35 opendevreview Balazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination https://review.opendev.org/c/openstack/nova/+/851832
15:00:35 opendevreview Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746
15:01:05 gibi artom, dansmith: when the other direction ^^. I don't find anything that breaks when I remove the mutation from rollback_live_migration_at_destination so I did so
15:01:13 gibi s/when/went/
15:12:43 elodilles bauzas: are you updating the meeting page right now, or is it OK if i edit it?
15:13:02 bauzas elodilles: I'm piling a lot of stuff, please do it by now and then I'll do it
15:13:33 elodilles bauzas: ack, one sec
15:15:40 elodilles bauzas: done (i tried to be quick :))
15:25:45 opendevreview Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746
15:35:41 bauzas reminder : nova meeting in 25 mins here
15:37:50 gibi stephenfin: if you have time, this makes py310 happy with unittest.mock https://review.opendev.org/c/openstack/nova/+/851445/
15:47:55 opendevreview Merged openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651
15:54:44 Uggla gibi, maybe dumb question but how do you properly set in instance in "failure" ?
15:57:51 Uggla instance.vm_state = vm_states.ERROR and instance.save() ?
15:59:01 gibi it depends on where and when the ERROR condition happened
15:59:14 Uggla I especially wonder about the error msg.
15:59:15 gibi you might need to report error on an instance event
16:00:04 bauzas #startmeeting nova
16:00:04 opendevmeet Meeting started Tue Aug 2 16:00:04 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:04 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:04 opendevmeet The meeting name has been set to 'nova'
16:00:12 bauzas hi folks
16:00:18 Uggla o/
16:00:39 gibi o/
16:01:45 bauzas ok, let's start so people will join
16:01:53 ratailor o/
16:01:55 elodilles o/
16:02:02 bauzas #topic Bugs (stuck/critical)
16:02:09 bauzas #info No Critical bug
16:02:16 bauzas #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 11 new untriaged bugs (+1 since the last meeting)
16:02:24 bauzas #link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement
16:02:35 bauzas I had a small time for looking at the bugs
16:02:54 bauzas but I provided an etherpad https://etherpad.opendev.org/p/nova-bug-triage-20220726
16:03:15 bauzas I only triaged two, as at least 3 other bugs need to be looked more
16:03:33 bauzas that's it
16:03:41 opendevreview Merged openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory https://review.opendev.org/c/openstack/python-novaclient/+/851231
16:03:55 bauzas any bug to discuss ?
16:04:46 bauzas btw. I had fun with https://bugs.launchpad.net/nova/+bug/1983263
16:05:19 bauzas looks we only accept Ussuri computes for Ussuri :p
16:05:43 bauzas could be a FFU issue :)
16:06:36 bauzas just sayin' :)
16:06:47 bauzas anyway, moving on
16:07:01 bauzas #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster

Earlier   Later