| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-01 | |||
| 09:30:35 | whoami-rajat | ack, thanks | |
| 09:42:26 | bauzas | done | |
| 09:47:22 | elodilles | bauzas sean-k-mooney fyi, the long waited pike-eol patch for nova: https://review.opendev.org/c/openstack/releases/+/851571 :) | |
| 09:48:55 | bauzas | elodilles: done | |
| 09:49:36 | elodilles | bauzas: thx \o/ | |
| 10:58:06 | opendevreview | Pierre Riteau proposed openstack/nova stable/ussuri: Allow Train compute hosts to register with Ussuri https://review.opendev.org/c/openstack/nova/+/851732 | |
| 11:24:17 | opendevreview | Pierre Riteau proposed openstack/nova stable/ussuri: Allow Train compute hosts to register with Ussuri https://review.opendev.org/c/openstack/nova/+/851732 | |
| 14:14:38 | kashyap | gibi: bauzas: elodilles: Can any of you please put this backport through? - https://review.opendev.org/c/openstack/nova/+/845045 (libvirt: Add a workaround to skip compareCPU() on destination) | |
| 14:14:43 | kashyap | (Or anyone else) | |
| 14:14:55 | kashyap | gibi: You already reviewed it in the past, and helped w/ the UT :) | |
| 14:17:37 | gibi | I did my part :) | |
| 14:17:44 | gibi | now you need a second core | |
| 14:21:15 | kashyap | Thank you! :) | |
| 14:36:52 | elodilles | damn, too, many reviewers :) | |
| 14:37:03 | elodilles | double approved :S | |
| 14:39:11 | bauzas | damn shit. | |
| 14:39:12 | bauzas | https://stackoverflow.com/questions/893333/multiple-variables-in-a-with-statement | |
| 14:39:38 | bauzas | context : https://review.opendev.org/c/openstack/python-openstackclient/+/851244/3/openstackclient/tests/functional/compute/v2/test_keypair.py#140 | |
| 14:42:33 | gibi | bauzas: yepp that is a fairly recent syntax | |
| 14:43:16 | bauzas | wasn't told by pep8 locally | |
| 14:43:20 | bauzas | osc-- | |
| 14:47:26 | bauzas | last time I used nested withs, I was using contextlib stdlib | |
| 14:47:30 | bauzas | and it was working great | |
| 14:47:53 | bauzas | py27, I still love you <3 | |
| 14:48:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | |
| 14:48:53 | gibi | stephenfin, sean-k-mooney, efried: ^^ that is the fix for the double mocking in py310, now I going to rebase the whole mock series as we landed things on master that needs care... | |
| 14:50:32 | efried | <3 | |
| 15:03:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/c/openstack/nova/+/714676 | |
| 15:03:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | |
| 15:03:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/c/openstack/nova/+/708768 | |
| 15:03:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove the PowerVM driver https://review.opendev.org/c/openstack/nova/+/850346 | |
| 15:12:42 | bauzas | gibi: do you think I should provide a new revision for https://review.opendev.org/c/openstack/nova/+/838976 ? | |
| 15:12:57 | bauzas | I'll be off by tomorrow EOB | |
| 15:47:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/c/openstack/nova/+/714676 | |
| 15:47:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | |
| 15:47:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/c/openstack/nova/+/708768 | |
| 15:47:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove the PowerVM driver https://review.opendev.org/c/openstack/nova/+/850346 | |
| 16:53:06 | opendevreview | Merged openstack/nova stable/yoga: libvirt: Add a workaround to skip compareCPU() on destination https://review.opendev.org/c/openstack/nova/+/845045 | |
| 19:07:44 | opendevreview | Merged openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/c/openstack/nova/+/714676 | |
| #openstack-nova - 2022-08-02 | |||
| 03:00:10 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 03:00:10 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | |
| 03:00:11 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 03:00:11 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 03:00:12 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | |
| 03:00:12 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 04:19:35 | opendevreview | Amit Uniyal proposed openstack/nova master: Updated Suspend definition in server concepts doc https://review.opendev.org/c/openstack/nova/+/851511 | |
| 04:31:31 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 05:07:49 | opendevreview | Tony Breeds proposed openstack/placement master: disable traits count check to allow os-traits 2.8.0 https://review.opendev.org/c/openstack/placement/+/851792 | |
| 05:07:50 | opendevreview | Tony Breeds proposed openstack/placement master: Update placement for os-traits 2.8.0 release https://review.opendev.org/c/openstack/placement/+/851793 | |
| 05:27:50 | tonyb | Can someone take a look at: https://review.opendev.org/c/openstack/requirements/+/849986 The patch is trying to use the latest openstacksdk but it fails "nova.tests.unit.scheduler.client.test_report.SafeConnectedTestCase.test_missing_endpoint" I suspect that's because openstacksdk reworked the proxy/cache code [ https://review.opendev.org/c/openstack/openstacksdk/+/837802 ] and I'm guessing that it caches 404 (or similar) | |
| 05:27:50 | tonyb | so the second all returns directly from the cache. | |
| 07:29:12 | gibi | good morning | |
| 07:30:25 | Uggla | gibi, good morning | |
| 07:44:35 | bauzas | good morning | |
| 07:53:01 | opendevreview | Tony Breeds proposed openstack/placement master: disable traits count check to allow os-traits 2.8.0 https://review.opendev.org/c/openstack/placement/+/851792 | |
| 07:53:02 | opendevreview | Tony Breeds proposed openstack/placement master: Update placement for os-traits 2.8.0 release https://review.opendev.org/c/openstack/placement/+/851793 | |
| 08:15:55 | opendevreview | Radosław Piliszek proposed openstack/nova master: [docs] Fix mention of custom scheduling after Wallaby https://review.opendev.org/c/openstack/nova/+/851807 | |
| 08:15:55 | opendevreview | Radosław Piliszek proposed openstack/nova master: [docs] Fix mention of custom scheduling after Wallaby https://review.opendev.org/c/openstack/nova/+/851807 | |
| 08:29:16 | bauzas | gibi: around ? | |
| 08:29:27 | gibi | bauzas: yes | |
| 08:29:44 | bauzas | gibi: I wanted to discuss your excellent point on https://review.opendev.org/c/openstack/nova/+/838976/3/nova/virt/libvirt/utils.py#597 | |
| 08:30:25 | bauzas | fixing it isn't trivial as it either needs to change the callers or to longer use this method | |
| 08:31:03 | bauzas | but I checked which callers are using this method, and this is only for the reshape method and for the recreating method (when you reboot) | |
| 08:33:21 | bauzas | [sbauza@sbauza nova]$ git grep '\.mdev_uuid2name(' | |
| 08:33:21 | bauzas | nova/tests/functional/libvirt/test_reshape.py: utils.mdev_uuid2name(mdev_uuid)) | |
| 08:33:21 | bauzas | nova/tests/functional/libvirt/test_vgpu.py: mdev_name = libvirt_utils.mdev_uuid2name(uuid) | |
| 08:33:21 | bauzas | nova/tests/functional/libvirt/test_vgpu.py: mdev_name = libvirt_utils.mdev_uuid2name(mdev) | |
| 08:33:21 | bauzas | nova/tests/functional/libvirt/test_vgpu.py: libvirt_utils.mdev_uuid2name(mdevs[0])) | |
| 08:33:22 | bauzas | nova/tests/functional/regressions/test_bug_1951656.py: mdev_name = libvirt_utils.mdev_uuid2name(uuid) | |
| 08:33:23 | bauzas | nova/virt/libvirt/driver.py: dev_name = libvirt_utils.mdev_uuid2name(mdev_uuid) | |
| 08:33:24 | bauzas | nova/virt/libvirt/driver.py: dev_name = libvirt_utils.mdev_uuid2name(mdev_uuid) | |
| 08:35:18 | bauzas | so FWIW, I think we could provide a follow-up patch for it, instead of trying to modify all of the above in the same change | |
| 08:36:33 | gibi | I'm not sure what you imply. Is this not a bug right now to use non suffixed mdev_name with libvirt 7.7+? | |
| 08:40:50 | bauzas | gibi: we already have a bug for recreate() | |
| 08:41:24 | bauzas | so this won't change | |
| 08:41:54 | gibi | OK, so you say, that we use the wrong mdev_name in two cases 1) reshape, but there we only use it internally to nova so libvirt wont see it 2) in recreate but recreate is broken for other reasons as well | |
| 08:42:01 | gibi | Do I understand it correctly? | |
| 08:42:24 | bauzas | 1) for reshapes, we no longer do them | |
| 08:42:39 | gibi | except FFU | |
| 08:42:40 | bauzas | unless someone wants to reshape from Queens to Rocky | |
| 08:42:46 | gibi | ack | |
| 08:43:08 | bauzas | for 2), you got it | |
| 08:44:03 | bauzas | actually, we could fix https://bugs.launchpad.net/nova/+bug/1900800 once we provide the FUP | |
| 08:44:05 | gibi | so 1) can be an issue if someone FFUs from Queens to Train | |
| 08:44:26 | bauzas | 1) only if they run Train with libvirt 7.7 | |
| 08:44:36 | gibi | yepp | |
| 08:45:05 | gibi | I agree this is low probabability | |
| 08:45:32 | bauzas | and I'm not saying we shouldn't modify uuid2name | |
| 08:45:41 | bauzas | just saying this couldn't be in the same change | |
| 08:45:51 | bauzas | but by a FUP | |
| 08:45:55 | gibi | OK, lets have a fup | |
| 08:51:31 | sean-k-mooney | bauzas your on pto for the next two weeks yes? from tomorrow? | |
| 08:51:46 | bauzas | sean-k-mooney: from tonight until Aug 29 | |
| 08:52:26 | sean-k-mooney | bauzas: did you start trying to port the mdev lib to work around the other issues we have with libvirt | |
| 08:52:38 | sean-k-mooney | if not that is ok | |
| 08:53:14 | bauzas | sean-k-mooney: you mean about using sysfs instead of libvirt for getting the mdevs ? | |
| 08:53:17 | bauzas | no if so | |
| 08:53:24 | sean-k-mooney | ya | |
| 08:53:26 | sean-k-mooney | ok | |
| 08:59:27 | opendevreview | Sylvain Bauza proposed openstack/nova master: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/838976 | |