| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-28 | |||
| 11:04:34 | bauzas | like "I can manage myself" | |
| 11:05:03 | sean-k-mooney | this is kind of like sheep | |
| 11:05:17 | sean-k-mooney | 1 sheep 2 sheep | |
| 11:05:27 | bauzas | damn english folks | |
| 11:05:29 | sean-k-mooney | either works but i think plural is more correct | |
| 11:05:46 | sean-k-mooney | well ok | |
| 11:05:49 | sean-k-mooney | no your right | |
| 11:05:51 | sean-k-mooney | singulaer | |
| 11:05:58 | sean-k-mooney | sicne we have 1 RP per PF | |
| 11:06:09 | sean-k-mooney | i was thinking about the VF inventories | |
| 11:06:12 | gibi | we have 1 PR per multiple VFs | |
| 11:06:13 | gibi | :) | |
| 11:06:21 | gibi | RP | |
| 11:06:23 | sean-k-mooney | ya so this is correct as is | |
| 11:06:27 | gibi | OK | |
| 11:06:43 | bauzas | yeah | |
| 11:06:49 | bauzas | I wasn't discussing about SRIOV | |
| 11:06:59 | bauzas | this is for a PCI ID | |
| 11:07:01 | gibi | btw, bauzas, this trait was not mentioned in the spec so I added a comment to the merged spec now and I will push a follow up on the spec to sync it with the implementation reality | |
| 11:07:03 | bauzas | hence singular | |
| 11:07:20 | sean-k-mooney | gibi: we can update the spec later | |
| 11:07:25 | gibi | yeah I | |
| 11:07:29 | sean-k-mooney | based on the final merged implemeantion | |
| 11:07:30 | gibi | I'm planning to do so | |
| 11:07:32 | bauzas | gibi: ok, so I wasn't lazy then :D | |
| 11:07:39 | bauzas | :ô | |
| 11:07:39 | bauzas | :ô | |
| 11:07:40 | bauzas | :p | |
| 11:07:42 | gibi | I'm collecting the comments there to know what to update | |
| 11:07:51 | sean-k-mooney | we also move the logic to the compute manager | |
| 11:07:55 | gibi | sean-k-mooney: yepp | |
| 11:08:11 | sean-k-mooney | i dont know if we eplxitly said tiwoudl be in the driver before but its good to document | |
| 11:08:32 | bauzas | gibi: I'll try to look at your series before tuesday eob | |
| 11:09:06 | bauzas | oh wait | |
| 11:09:09 | gibi | bauzas: when you look try to focus on the high level direction and architecture please | |
| 11:09:18 | bauzas | gibi: https://github.com/openstack/os-traits/tree/master/os_traits/hw | |
| 11:09:34 | gibi | we discussed with sean-k-mooney that this is not a hw trait | |
| 11:09:37 | bauzas | could be hw | |
| 11:09:40 | gibi | but more like a capability trait | |
| 11:09:43 | gibi | of the compute service | |
| 11:09:50 | bauzas | meh ok | |
| 11:12:52 | opendevreview | Merged openstack/os-traits master: Add COMPUTE_MANAGED_PCI_DEVICE trait https://review.opendev.org/c/openstack/os-traits/+/850538 | |
| 11:12:59 | gibi | bauzas, sean-k-mooney: thanks! | |
| 11:13:35 | gibi | I'm going to push a os-traits release | |
| 11:15:39 | sean-k-mooney | lets wait a sec | |
| 11:15:40 | bauzas | damn | |
| 11:15:41 | bauzas | | nova | 11 | 22 | 50.0 | | |
| 11:15:47 | bauzas | 50% of blind rechecks | |
| 11:15:49 | bauzas | man ! | |
| 11:15:56 | sean-k-mooney | it would be nice to do https://review.opendev.org/c/openstack/os-traits/+/844336 too | |
| 11:16:38 | bauzas | don't people read our meeting ? :)= | |
| 11:16:40 | sean-k-mooney | ricolin: ^ coudl you respin that quickly and remvoe the none | |
| 11:17:23 | sean-k-mooney | well | |
| 11:17:31 | sean-k-mooney | ricolin: we could leave it i guess | |
| 11:17:45 | sean-k-mooney | ah actully no | |
| 11:18:08 | sean-k-mooney | vioummu=non shouuld not force libvirt | |
| 11:18:32 | sean-k-mooney | so we should remove the trait and not request a trait if you set the exptra spec to none | |
| 11:19:00 | sean-k-mooney | gibi: bauzas alernitivly i could adress my own nit in that patch and ye could review | |
| 11:19:09 | gibi | sean-k-mooney: go for it | |
| 11:19:13 | gibi | I can respin the releasenotes | |
| 11:19:22 | gibi | s/releasenotes/release/ | |
| 11:21:26 | opendevreview | sean mooney proposed openstack/os-traits master: Add traits for vIOMMU https://review.opendev.org/c/openstack/os-traits/+/844336 | |
| 11:22:30 | sean-k-mooney | oh the depends on is wrong | |
| 11:22:49 | opendevreview | sean mooney proposed openstack/os-traits master: Add traits for vIOMMU https://review.opendev.org/c/openstack/os-traits/+/844336 | |
| 11:23:54 | sean-k-mooney | ok ^ should be good to review | |
| 11:27:34 | gibi | done +2 | |
| 12:19:21 | gibi | stephenfin, sean-k-mooney: so far I fixed the duplicated mocking in libvirt.test_driver and all of them was either an unnecessary second mocking or can be fixed easily. So I think while it is manual work it can be done. I will try to fix them today and push a patch | |
| 12:19:49 | sean-k-mooney | sound promising | |
| 12:21:11 | gibi | I think it is worth to fix as there was really stupid mistakes caught by this. like mocking the same thing twice in two consecutive decorator and applying assert on the second mock :) | |
| 12:43:08 | opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | |
| 12:48:43 | bauzas | ok, will rebase my novaclient change on top of ^ | |
| 12:50:06 | opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | |
| 12:52:01 | Uggla | bauzas, hoping you will not have too many conflicts. | |
| 12:52:17 | bauzas | Uggla: nope, just one I guess | |
| 12:52:23 | bauzas | for the microversion number | |
| 13:01:28 | opendevreview | Sylvain Bauza proposed openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory https://review.opendev.org/c/openstack/python-novaclient/+/851231 | |
| 13:01:41 | bauzas | Uggla: actually, no merge conflict I got \o/ | |
| 13:01:45 | bauzas | just a simple rebase | |
| 13:01:56 | Uggla | bauzas, \o/ | |
| 13:07:10 | opendevreview | Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | |
| 13:33:54 | stephenfin | gibi: nice work :) | |
| 14:12:47 | gibi | TIL: if there are both side_effect and return_value is defined on a mock then return_value is ignored | |
| 14:14:50 | gibi | bauzas: when you are around, could you hit https://review.opendev.org/c/openstack/os-traits/+/844336 ? | |
| 14:15:04 | bauzas | I am and I can | |
| 14:15:21 | gibi | thank you | |
| 14:15:32 | gibi | I will update the os-trait release patch once that lands | |
| 14:15:58 | bauzas | done | |
| 14:17:31 | gibi | awesome thanks | |
| 14:26:56 | opendevreview | Merged openstack/os-traits master: Add traits for vIOMMU https://review.opendev.org/c/openstack/os-traits/+/844336 | |
| 14:30:31 | gibi | sean-k-mooney, bauzas: I've updated the os-traits release patch https://review.opendev.org/c/openstack/releases/+/851390 | |
| 14:33:18 | efried | :* | |
| 14:33:30 | gibi | o/ | |
| 14:34:27 | gibi | efried: how is life? | |
| 14:35:38 | efried | Living the dream. Working on https://github.com/openshift/hive/ mostly. Enjoy it a lot. | |
| 14:35:38 | efried | What's new with y'all? | |
| 14:38:12 | gibi | good to hear that | |
| 14:39:25 | gibi | I got involved writing k8s operators to deploy OpenStack so I will look at hive at some point to learn some tricks :) | |
| 14:40:05 | gibi | while also trying to make PCI tracking in Placement happen | |
| 14:44:18 | efried | Not gonna claim hive is the examplar of k8s operators, but it has some pretty cool stuff going on. | |
| 14:44:18 | efried | In theory hive will deploy OpenStack -- though I've never tried it myself. | |