| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-26 | |||
| 17:21:13 | sean-k-mooney | yep | |
| 17:21:13 | stephenfin | bauzas: I'd rather deal with merge conflicts now than when the gate is hammered before FF | |
| 17:21:20 | stephenfin | personally | |
| 17:21:24 | sean-k-mooney | same | |
| 17:21:35 | bauzas | then, looks like you have your two cores | |
| 17:21:41 | bauzas | :) | |
| 17:22:30 | stephenfin | Wow, I proposed this in March 24 2020. 3 days before lockdown #1 (in Ireland, anyway) | |
| 17:22:40 | stephenfin | Oh, the innocence of pre-COVID times :) | |
| 17:22:53 | sean-k-mooney | heh | |
| 17:23:14 | sean-k-mooney | i set Review-Priority +2 so ill review this today | |
| 17:23:29 | sean-k-mooney | bauzas: melwitt do we want to continue talking about ephemeral | |
| 17:23:31 | gibi | you can ping me tomorrow to review it | |
| 17:23:59 | stephenfin | gibi: will do (y) | |
| 17:24:23 | stephenfin | bauzas: They had it coming | |
| 17:24:28 | melwitt | stephenfin: ok, I'll help review if gibi or sean-k-mooney end up not being able to for some reason | |
| 17:26:48 | bauzas | stephenfin: I don't see a hacking rule preventing us to import the mock lib | |
| 17:27:13 | stephenfin | bauzas: it's here. I just need to rebase it https://review.opendev.org/c/openstack/nova/+/708768 | |
| 17:27:13 | bauzas | stephenfin: so I guess you ask reviewers to make sure we don't pull that lib again ? | |
| 17:27:22 | stephenfin | I can do that now | |
| 17:27:40 | bauzas | stephenfin: ok, gtk | |
| 17:27:41 | sean-k-mooney | ack was just going to say seperate patch please | |
| 17:29:14 | gibi | I need to disappeare. see you tomorrow | |
| 17:29:20 | sean-k-mooney | gibi: o/ | |
| 17:29:48 | sean-k-mooney | bauzas: back to ephmeral if you look at https://github.com/openstack/python-openstackclient/commit/4da4b96296c6b6d4351ebd47e32d5049a88211f1#diff-6759a29d0fccaa3a8d26137549b909fa3b3925b71d5318f30fe9fe7021f8558eR1227 you will see how osc construts the bdms | |
| 17:30:03 | sean-k-mooney | for swap and ephemeral | |
| 17:30:14 | sean-k-mooney | if you pass --swap or --epmeral to the server create | |
| 17:30:51 | bauzas | I'm just wondering whether we'll be able to merge things :D | |
| 17:31:25 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851034 | |
| 17:31:56 | sean-k-mooney | bauzas: this is perhaps better https://github.com/openstack/python-openstackclient/blob/4da4b96296c6b6d4351ebd47e32d5049a88211f1/openstackclient/tests/unit/compute/v2/test_server.py#L2734-L2785= | |
| 17:31:57 | bauzas | sean-k-mooney: about the ephemeral encryption name, I can try to propose something | |
| 17:32:39 | sean-k-mooney | sure | |
| 17:32:44 | bauzas | "local BDM encryption" | |
| 17:32:54 | sean-k-mooney | maybe | |
| 17:32:59 | sean-k-mooney | they might not alwasy be type local | |
| 17:33:03 | dansmith | that's the proposed title of the feature/spec? | |
| 17:33:22 | bauzas | dansmith: I said earlier, I'm terrible at naming | |
| 17:33:28 | bauzas | I'm just quite giving up | |
| 17:33:57 | dansmith | I think the problem is, things were named, and then we implemented lots of features that blurred all the lines we had, which makes not only the existing names less than ideal, but also makes it hard to accurately describe what we're talking about | |
| 17:34:07 | dansmith | which pretty much means there's hardly any point in a rename of anything, IMHO | |
| 17:34:11 | bauzas | this feature is about to encrypt BDMs which are local | |
| 17:34:23 | bauzas | hence the countername | |
| 17:34:28 | dansmith | "non-volume data disks" is probably the most accurate, but I mean, good lord :) | |
| 17:34:30 | sean-k-mooney | bauzas: it also works for ceph volumes allocated by nova | |
| 17:34:34 | sean-k-mooney | so local is not really right | |
| 17:34:35 | dansmith | bauzas: not always local :) | |
| 17:34:45 | sean-k-mooney | its about encypting non cinder sotrage | |
| 17:35:05 | melwitt | swap isn't included so "non-volume data disks" doesn't even work :P | |
| 17:35:11 | sean-k-mooney | although personally i woudl have perfered if it also work for bfv | |
| 17:35:26 | sean-k-mooney | melwitt: very true | |
| 17:35:49 | dansmith | melwitt: but swap isn't encrypted right? that's why I put "data" in there :) | |
| 17:36:14 | sean-k-mooney | dansmith: what would the flavor extra specs be for that | |
| 17:36:27 | melwitt | ephemeral_and_root_disk_encryption 😂 | |
| 17:36:37 | dansmith | nvdd_encryption=FML | |
| 17:36:40 | melwitt | dansmith: oh, I see. yeah swap is not encrypted | |
| 17:36:50 | melwitt | I didn't get the "data" emphasis | |
| 17:36:53 | sean-k-mooney | honestly i prefer that name to what we have | |
| 17:37:35 | sean-k-mooney | too bad we cant just call it nova_disk_encryption | |
| 17:37:43 | sean-k-mooney | i.e. encyuption for stuff nova owns | |
| 17:38:22 | dansmith | non-volume is the key I think, but it's not very nice to say/write | |
| 17:38:48 | sean-k-mooney | ya | |
| 17:39:03 | sean-k-mooney | flavor_disk_encryption? | |
| 17:39:07 | sean-k-mooney | but no | |
| 17:39:10 | sean-k-mooney | that break for bfv | |
| 17:39:24 | sean-k-mooney | well sort of | |
| 17:39:41 | melwitt | and swap | |
| 17:39:51 | dansmith | the argument here is about the naming of the extra spec? | |
| 17:39:53 | sean-k-mooney | ya swap i would honestly just add | |
| 17:39:59 | dansmith | I mean to be honest, this feels like a *massive* waste of time | |
| 17:40:04 | sean-k-mooney | dansmith: yes extra spec and image property | |
| 17:40:23 | dansmith | how about nova_disk_encryption <- excludes cinder, and if you're worried about swap, then add swap to it and move on | |
| 17:40:39 | sean-k-mooney | i would be happy with ^ | |
| 17:41:05 | bauzas | wfm | |
| 17:41:06 | sean-k-mooney | i just was not sure if we are ment to use the project name in things like this | |
| 17:41:28 | bauzas | let's just write a very good config option doc | |
| 17:41:46 | dansmith | nova_ on this case makes it clear we're talking about the things nova owns | |
| 17:41:52 | sean-k-mooney | sure and by config option doc you mean flavor validator doc | |
| 17:41:52 | dansmith | compute_ would work too I guess, but I think it's less clear | |
| 17:42:28 | sean-k-mooney | ack ya nova_ i liek more but i would be happy with compute_ | |
| 17:42:40 | sean-k-mooney | so either i think are ok | |
| 17:42:53 | dansmith | nova_ and promise to never ever discuss this again? :) | |
| 17:43:16 | bauzas | or say it 5 times in front of a mirror ? | |
| 17:43:24 | sean-k-mooney | :) | |
| 17:43:38 | sean-k-mooney | melwitt: are you ok with that? | |
| 17:45:06 | melwitt | I guess. I'm focused on making sure everyone's happy with the name. I checked https://docs.openstack.org/glance/latest/admin/useful-image-properties.html and don't find any other project names there so that feels a bit weird, but ¯\_(ツ)_/¯ | |
| 17:45:45 | bauzas | virt_disk_encryption ? | |
| 17:45:57 | dansmith | intrinsic_disk_encryption, managed_disk_encryption | |
| 17:46:00 | bauzas | damn, I stepped into the ... | |
| 17:46:15 | dansmith | virt_ is not specific enough I think, because cinder disks aren't real disks | |
| 17:46:30 | dansmith | non_volume_disk_encryption.. uglier, but no project name and more accurate | |
| 17:46:42 | dansmith | OR | |
| 17:46:52 | bauzas | oh, I was poorly refering to the fact we defer the disk creation to the underlying virt driver | |
| 17:46:55 | dansmith | we explain that "ephemeral disks" are "everything but volume disks" and then we're back to the start! | |
| 17:47:08 | melwitt | 😂 ahhhhhh | |
| 17:47:29 | sean-k-mooney | ya i still fine ephmeral kind of insulting to refer to novas storage but thats just me | |
| 17:47:30 | bauzas | (18:57:19) bauzas: yeah, if we need to write some doc explaining "ephemeral" == "this new thing" this is bad | |
| 17:47:30 | bauzas | (18:56:47) bauzas: if we pick something else, this has to be better understandable about what it is | |
| 17:47:30 | bauzas | (18:57:39) bauzas: hence the challenge | |
| 17:48:19 | dansmith | sean-k-mooney: you're fine or you "find" ? | |
| 17:48:35 | bauzas | cores, would appreciate a quick +2 on os-vif blocking https://review.opendev.org/c/openstack/nova/+/850998/2 | |
| 17:48:35 | sean-k-mooney | we have had customer go to great lents to do terible things because they found the term ephemeral unackceptable | |