Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-07-25
14:58:34 bauzas bug 1940425 I mean
15:07:50 bauzas gibi: wdyt we could do for https://bugs.launchpad.net/nova/+bug/1940425
15:07:57 bauzas we already wait for 60secs
15:08:04 bauzas ?
15:08:28 gibi bauzas: would make sense pinging neutron folks
15:10:00 bauzas failure rate is so high that we can't merge things by now
15:33:48 bauzas mmm, so melwitt had a thought on https://github.com/openstack/tempest/blob/97be23ea6402649652991983f3f2b85873eba4d8/tempest/api/compute/admin/test_live_migration.py#L285 maybr not required for all neutron backends
15:36:32 bauzas slaweq: around ?
15:44:49 melwitt ^ it was sean-k-mooney's thought that I repeated :) sean's the one who knows tons of stuff about nova <--> neutron
15:45:56 bauzas if I'm not getting it wrong, nova isn't only impacted
15:46:06 bauzas this is also hitting cinder
15:59:55 sean-k-mooney melwitt: so the basis of this is that for ovn we only plug one port into ovs. and the trunking is implemented as openflow rules on that port
16:00:08 sean-k-mooney for ml2/ovs and ml2/linux bridge
16:00:19 sean-k-mooney we careate a ovs or linux bridge per trunkport
16:00:53 sean-k-mooney in the ovs case each sub port is create as a patch port pair between the br-int and br-trunk###
16:01:14 sean-k-mooney and the br-int side of the patch port is tagged with the neutron port uuid
16:01:26 sean-k-mooney so ml2/ovs reports the status fo the port as up/active
16:01:35 sean-k-mooney once it finishes wiring them up
16:02:08 sean-k-mooney for ml2/ovn i have no idea if it bothers to report the subports as up since they dont exist on the dataplane level
16:02:11 bauzas sean-k-mooney: except the ovn-hybrid-plug job, this is also failing on nova-next
16:02:20 melwitt I think my brain just exploded from reading that
16:02:43 bauzas ovs-hybrid-plug, my bad
16:03:00 bauzas we also have the grenade-multinode which hits such bug
16:03:05 sean-k-mooney bauzas: ack so its failing regardesll of how its implemneted
16:03:08 gibi the interesting part that it is not 100% failure in nova-next, so in some case neutron does bring up the subport
16:03:17 bauzas yup
16:03:21 sean-k-mooney it could be a timing thing
16:03:23 bauzas this looks a transient issue
16:03:32 bauzas we already wait for 60s
16:03:33 gibi but 60sec is a lot
16:03:33 sean-k-mooney neutron is not ment to send network vif pulgged for the parent
16:03:39 sean-k-mooney untill all the subports are setup
16:03:46 sean-k-mooney maybe it does nto take that into account
16:04:00 sean-k-mooney and sends it only once the parent is set up
16:04:06 sean-k-mooney meaning we might be racing
16:04:16 gibi yeah that make sense
16:04:25 sean-k-mooney nova only has one port attached to the vm so we only care about the parent
16:04:28 gibi that will depend on how was tempest querying the state
16:05:01 sean-k-mooney i dont think the parent shoudl really be active if the subports are not active
16:05:03 melwitt this is the tempest test https://github.com/openstack/tempest/blob/97be23ea6402649652991983f3f2b85873eba4d8/tempest/api/compute/admin/test_live_migration.py#L285
16:05:16 sean-k-mooney but honestly that is proably an impmentation detail that noone should depend on
16:05:26 sean-k-mooney i dont think this was defiended in teh specs
16:05:59 sean-k-mooney so the test might just be asserting stuff that is not required/guarenteed by the api
16:07:28 sean-k-mooney im pretty sure this was the relevent spec https://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html
16:10:00 sean-k-mooney gibi: melwitt so ya reading that quickly the status of the subport is not defeined in relation to port binding
16:10:18 dansmith sean-k-mooney: on the event, it should send the event once the thing the port represents can pass traffic, right? so subport or not, we shouldn't get the alert until the traffic will flow
16:10:32 dansmith else we're wiring up to something we can't expect to get dhcp or other critical traffic through
16:10:36 sean-k-mooney correct
16:10:47 dansmith calling the trunk up because one side is active isn't good enough
16:11:00 sean-k-mooney we should not get the network-vif-plugged for the trunk parent untill everything is configured to allow all taffic to flow
16:11:26 dansmith right, so depending on the backend implementation that may come depending on what wiring needs to happen
16:11:30 sean-k-mooney but they may not have implemented that depened status check
16:11:47 opendevreview Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625
16:11:48 opendevreview Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626
16:11:48 opendevreview Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491
16:11:49 opendevreview Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565
16:11:49 opendevreview Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628
16:11:50 opendevreview Balazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types https://review.opendev.org/c/openstack/nova/+/845765
16:11:50 dansmith right but that would be a neutron issue
16:11:50 opendevreview Balazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname https://review.opendev.org/c/openstack/nova/+/845775
16:11:51 opendevreview Balazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class https://review.opendev.org/c/openstack/nova/+/845780
16:11:51 opendevreview Balazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class https://review.opendev.org/c/openstack/nova/+/845781
16:11:58 sean-k-mooney dansmith: yes it would
16:12:23 dansmith ack, just confirming ;)
16:12:31 sean-k-mooney so your suggesting that marking it confirmed for nova on the bug is wrong and we should likely change it
16:13:15 dansmith I dunno about that I just want to be clear that nova shouldn't be trying to interpret vif-plugged differently for trunks
16:13:23 sean-k-mooney bauzas: gibi by the way with the escalation and everything that happened in the last few days i have not been doing upstream bug triage this week sorry
16:13:34 gibi sean-k-mooney: no worries
16:13:38 sean-k-mooney dansmith: agreeed
16:13:48 bauzas sean-k-mooney: no worries at all, again, bug triage is just down any prio
16:13:57 sean-k-mooney dansmith: nova should jsut care about thte one port that is attached to the vm (the trunk)
16:14:03 sean-k-mooney the rest is up to neutron to care about
16:14:07 dansmith yes
16:14:23 sean-k-mooney dansmith: if tempest should check this at all is proably TBD
16:14:27 gibi maybe the tempest test verify the system from neutron perspective hence the assert on the subport too
16:14:57 dansmith sean-k-mooney: also true
16:15:06 sean-k-mooney gibi: yes but in that casae it is indicating that neutron is not correctly seting up the trunk
16:15:11 gibi yes
16:15:14 gibi I agree
16:15:44 sean-k-mooney i would suggest seting the nova part to incomplete for now
16:15:55 sean-k-mooney as its not clear that nova shoudl be doing anything it is not already doing
16:20:19 gibi works for me
16:20:32 gibi later we can set it to invalid if turn out only neutron needs a fix
16:24:12 opendevreview Billy Olsen proposed openstack/nova master: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/838976
19:30:40 opendevreview Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886
#openstack-nova - 2022-07-26
05:31:15 auniyal logs from nova/db/main/api should come in devstack@n-cond-cell1, super-cond or cpu ?
05:41:22 auniyal it should come under devstack@n-super-cond, but exceptions are not coming
07:48:43 bauzas good morning Nova
07:49:05 gibi o/
07:55:30 bauzas I just sent an email
07:55:44 bauzas tl;dr: HOLD YOUR RECHECKS
08:07:39 gibi I see a nice buzz around the issue in the bug report
08:08:48 bauzas like I said in -neutron, I'm looking at gerrit now based on mlavalle's comment
08:09:52 gibi I did that already and commented on the bug, but feel free to double check
08:17:36 opendevreview Sylvain Bauza proposed openstack/nova master: DNM: Avoid os-vif 3.0.0 https://review.opendev.org/c/openstack/nova/+/850998
08:17:39 bauzas gibi: ^
08:18:23 gibi bauzas: thanks
08:53:04 sean-k-mooney[m] why?
08:53:41 sean-k-mooney[m] what change in os-vif do you think is related
08:55:13 sean-k-mooney[m] the trunk bridge patch?

Earlier   Later