| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-22 | |||
| 11:37:22 | sean-k-mooney | just thinking that might be good to be able to backport seperatly | |
| 11:37:27 | sean-k-mooney | although not required | |
| 11:58:46 | gibi | sean-k-mooney: sure I can, but I guess we will backport the reproducer and the eventual fix anyhow | |
| 11:59:14 | sean-k-mooney | yep its not that important | |
| 11:59:37 | sean-k-mooney | just one of the reaosn i have used the freestanding approch in the past is to not include cast_as_call | |
| 12:00:03 | sean-k-mooney | i.e. if you just use the mixins that is not added unless you do it yourslef in teh func test | |
| 12:00:19 | gibi | sean-k-mooney: true | |
| 12:00:39 | gibi | I'm not sure how easy it would be to move the libvirt functional tests away from the _IntegratedBase | |
| 12:01:07 | sean-k-mooney | i would move it to https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/integrated_helpers.py#L23= first | |
| 12:02:11 | sean-k-mooney | but as stephen notes https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L1231-L1233= | |
| 12:02:24 | sean-k-mooney | but if we were to remove one or the ohter i would remove _IntegratedTestBase | |
| 12:03:07 | sean-k-mooney | crap meeting | |
| 13:07:35 | gibi | I think this shows that even if we want light test case bases we eventually end up with heavy bases | |
| 13:08:02 | gibi | so I would not fight much against the heavy bases | |
| 13:58:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: api: Drop generating a keypair and add special chars to naming https://review.opendev.org/c/openstack/nova/+/849133 | |
| 13:59:03 | bauzas | gibi: sean-k-mooney: updated my 2.92 patch based on gibi's comments | |
| 13:59:09 | bauzas | just a few cleanups | |
| 14:57:25 | gibi | bauzas: +2 | |
| 14:57:34 | bauzas | ta | |
| 14:57:43 | bauzas | I'm reviewing Uggla's API change ;) | |
| 14:58:41 | gibi | I feel we will land two API change in a short while :) | |
| 15:18:47 | opendevreview | Alexey Stupnikov proposed openstack/nova master: [trivial] Simplify dict get call by removing unused default https://review.opendev.org/c/openstack/nova/+/850450 | |
| 15:29:47 | Uggla | bauzas, thx, I hope you will like it. | |
| 15:41:02 | bauzas | gibi: looks like we have a problem with test_live_migration_with_trunk | |
| 15:41:17 | bauzas | in tempest.api.compute.admin.test_live_migration.LiveMigrationTest | |
| 15:50:16 | bauzas | Uggla: +Wd so happy weekend :) | |
| 15:53:24 | Uggla | bauzas, I wish you a happy (probably hot) WE as well. | |
| 15:53:50 | bauzas | it's my daughter's birthday today so yes :) | |
| 15:53:55 | bauzas | 12yo | |
| 15:54:03 | bauzas | f***, I'm getting old | |
| 15:54:27 | bauzas | likewise OpenStack | |
| 15:54:38 | bauzas | both were born on mid-July 2010 | |
| 15:55:48 | bauzas | anyway, done for the week, see you all on Monday | |
| 22:55:08 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| #openstack-nova - 2022-07-23 | |||
| 13:59:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: conf: Add four new '[libvirt] live_migration_*' options https://review.opendev.org/c/openstack/nova/+/456571 | |
| 14:02:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: conf: Add four new '[libvirt] live_migration_*' options https://review.opendev.org/c/openstack/nova/+/456571 | |
| 14:41:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: conf: Add four new '[libvirt] live_migration_*' options https://review.opendev.org/c/openstack/nova/+/456571 | |
| 15:10:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: conf: Add four new '[libvirt] live_migration_*' options https://review.opendev.org/c/openstack/nova/+/456571 | |
| #openstack-nova - 2022-07-25 | |||
| 08:20:21 | bauzas | morning folks | |
| 08:43:28 | opendevreview | Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | |
| 09:06:07 | opendevreview | Amit Uniyal proposed openstack/nova master: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/849104 | |
| 09:06:08 | opendevreview | Amit Uniyal proposed openstack/nova master: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/848886 | |
| 11:31:54 | auniyal_ | how should we write zuul recheck cmd | |
| 11:32:18 | auniyal_ | so I want to run zuul, recheck for 4 jobs | |
| 11:47:08 | sean-k-mooney | auniyal_: you cant and that by design | |
| 11:47:27 | sean-k-mooney | auniyal_: we don not allow indivigual jobs to be rechecked seperatly | |
| 11:48:26 | auniyal_ | okay, so have to run all jobs, by giving recheck only ? | |
| 11:50:31 | sean-k-mooney | correct. you can tirgger third party ci seperately | |
| 11:50:46 | auniyal_ | thanks sean-k-mooney | |
| 11:50:50 | sean-k-mooney | but first party ci will run all jobs together | |
| 11:54:07 | auniyal_ | earlier I saw somewhere, that we should not run all jobs if only 1 or 2 job fails and can only run by single jobs using recheck |
|
| 12:08:40 | sean-k-mooney | the confirution is per pipeline and we expeictly do not allow that in openstack | |
| 12:09:04 | sean-k-mooney | zuul may support that but we do not allow that in openstack under the green check policy | |
| 12:09:23 | sean-k-mooney | all jobs on the check run must use the same revison fo the code | |
| 12:09:33 | sean-k-mooney | if you recheck indivicual jobs that woudl not be the case | |
| 12:31:01 | bauzas | folks, we have a problem with tempest.api.compute.admin.test_live_migration.LiveMigrationTest.test_live_migration_with_trunk | |
| 12:35:12 | bauzas | https://opensearch.logs.openstack.org/_dashboards/app/discover?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30h,to:now))&_a=(columns:!(_source),filters:!(),index:'94869730-aea8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:test_live_migration_with_trunk),sort:!()) | |
| 12:35:54 | bauzas | looks like it's https://bugs.launchpad.net/nova/+bug/1940425 | |
| 12:35:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 12:35:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 12:36:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 12:36:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 12:36:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 12:36:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 12:36:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 12:36:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 12:36:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 12:36:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 12:36:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 12:36:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 12:36:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 12:36:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 12:36:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 12:38:34 | gibi | bauzas: I see 10 hits in the last 7 day: https://paste.opendev.org/show/b8BF5WsTcwJojALnC5J0/ so it is become a bit more frequent than when I reported that bug | |
| 12:38:48 | bauzas | I found 226 hits from the last 7 days | |
| 12:42:07 | gibi | I don't really know how to parse the opensearch query. did you just queried for 'test_live_migration_with_trunk' ? that is all the runs of the test case including when the test passed, isn'tit? | |
| 12:42:46 | gibi | also this 'from:now-30h,to:now' does not seem to be 7 days | |
| 12:43:57 | gibi | I filtered for the nova-next job runs, so my number can be smaller than the global number for sure | |
| 12:47:51 | gibi | bauzas: that is probably closer to the 7 days query of all jobs https://opensearch.logs.openstack.org/_dashboards/app/discover?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-7d,to:now))&_a=(columns:!(_source),filters:!(),index:'94869730-aea8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:%22test_live_migration.py%22),sort:!()) | |
| 12:48:21 | gibi | I queryd for "test_live_migration.py" do that filters out passing test cases (the test case name is printed ther but not the file) | |
| 12:48:21 | bauzas | gibi: yeah, I just checked for the testname | |
| 12:48:34 | bauzas | as the testname is only provided with a FAILURE | |
| 12:48:39 | gibi | nope | |
| 12:48:53 | gibi | this is a passing test with testname {1} tempest.api.compute.admin.test_live_migration.LiveAutoBlockMigrationV225Test.test_live_migration_with_trunk [30.171614s] ... ok\ | |
| 12:49:09 | bauzas | see the buildrate | |
| 12:49:14 | bauzas | it's 100% | |
| 12:49:59 | bauzas | but agreed, I could query it better | |
| 12:51:10 | gibi | does opensearch filters out SUCCESS runs automatically? | |
| 12:51:23 | gibi | or why the passing runs not appear? | |
| 12:51:44 | gibi | the string "test_live_migration_with_trunk" is in the job-output.txt for passing runs too | |
| 12:51:58 | gibi | so something magic happens in opensearch to filter those | |
| 12:53:24 | bauzas | dunno, just testing this new tool | |
| 12:53:38 | gibi | I don't like magic :D | |
| 12:54:10 | bauzas | well, at least the failure rate seems high and not related to one specific job | |
| 12:56:26 | gibi | yeah I don't think it is related to nova-next at all, I just needed a way to limit my query | |
| 12:57:09 | gibi | my tool don't do a full search on all job results as that would require to download all the job results and logs locally | |
| 12:57:13 | gibi | and that is not feasible | |
| 12:58:33 | gibi | I've just run a widened search on all the nova devstack based jobs, it is 16 hits in 7 days for me and it is hitting nova-next and nova-grenade-multinode in nova | |
| 13:05:12 | bauzas | ovs-hybrid-plug job too | |
| 13:17:50 | gibi | bauzas: good point. I missed that job in my config | |